Repository navigation
docs: define bidirectionality design intent - #6047
nynexman4464 merged 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
/approve-spec e406a84 |
cixzhang
left a comment
There was a problem hiding this comment.
Thanks for consolidating the shared bidirectionality design intent. Approved at exact head e406a8402eb4b94e719b3ccea91bb4038c23f3c2.
|
AI review status for this pull request.
|
e406a84 to
732d227
Compare
732d227 to
940b751
Compare
940b751 to
74cc14a
Compare
74cc14a to
bf30bdf
Compare
bf30bdf to
432c62c
Compare
432c62c to
817674e
Compare
817674e to
fc4b038
Compare
fc4b038 to
981e81f
Compare
|
/approve-spec 981e81f |
PR Analysis Report📚 Storybook Preview🧪 Sandbox PreviewNo new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Visual Regression38 of 474 shot(s) changed. A change here is a question, not a failure: check whether the after is the
and 18 more. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
Stack
Intent
Clarify the existing semantic distinction between directional artwork and raw caller-supplied glyph geometry.
Authority
The record is promoted to
authority: currentwithapproved_by: nynexman4464andapproved_at: 2026-10-15, with a DEC-1 entry recording that DR1–DR14 are the shared bidirectional relationships. The exact-head/approve-speccommand on this pull request records that decision for the final head. It is promoted after the two architecture records it links. Open questions OQ1, OQ3, and OQ4 stay undecided.Existing authority searched
design:bidirectionality; reuse docs: define bidirectionality design intent #6047, retaining its DR1–DR14 rather than creating a parallel i18n/RTL design spec.architecture:knowledge-contractsINV20 and its claim-scoped global overlay own cross-cutting routing; other knowledge claims own claim scope and human approval; AST-020 owns target size; the style-authoring architecture explicitly delegates bidirectionality; docs: define RTL audit evidence policy #6046 owns audit evidence and docs(core): define the internationalization contract #6048 owns provider/DOM direction behavior.rtlStyles,useDirection, the RTL audit and curated targets, physical-property lint, and the SVGIcon raw-registry story.Authority and ownership
Keep
design:bidirectionalityas the canonical design owner, withnynexman4464first andcixzhang/rubyycheungretained. Internationalization architecture owns the provider/DOM direction boundary; RTL audit architecture owns applicability and evidence. No repository membership change is included.Cross-cutting component contract
Selected DRs now route globally by visual, styling, layout, navigation, interaction, layering, scrolling, responsive, runtime, and accessibility triggers. A visual change receives artwork meaning/exceptions rather than every keyboard or audit clause; a layer change receives the logical trigger relationship. Interaction, navigation, and scrolling carry the semantic-exception rule alongside their directional outcomes, so current LTR behavior or convenience cannot authorize a physical-direction exemption. No backlink is required merely to receive matched current globals.
Component/module/family records still own which artwork is a cue versus data, leading/trailing parts, local actions/states, sizes, and evidence. They link specific DRs when recording a local relationship or exception, without repeating a universal RTL checklist. The shared rules are not copied into a new component-facing record; existing owners already cover this fact boundary.
The routes do not imply every glyph mirrors and do not settle the remaining open questions. No schema, runtime, or changelog change is included.
Clarification
DR5 explicitly states that a reference sample preserves left/right glyph geometry when it is data. The same glyph used as previous, next, or progression artwork still follows DR4 and must receive exactly one directional treatment. A raw-registry example makes the distinction concrete without declaring all SVG icons exempt from RTL behavior.
The record delegates target-size numbers and exceptions to AST-020 and component/composition owners. It does not claim that alignment proves size or add a universal pixel minimum.
Validation
Knowledge validation, repository guardrails, formatting, and
git diff --checkpass. The global-route checks verify selective artwork/layer/interaction claims; all 121 knowledge tests pass on current main, and all four records validate as current at this head. The stack preserves the architecture-before-design dependency order. No runtime, product visual, or API change is included here.Writing rubric results
R1 narration: replaced the shipped-direction migration story with the scope of DR1–DR14 and their separate evidence owners. Promotion removed draft-readiness wording rather than narrating the approval.
R2 research: no experiment, scorecard, or external survey is standing content.
R3 evidence: no historical PR stands in for the directional meaning of an example.
R4 rejected alternatives: none.
R5 change references: removed the direction-foundation and target-centering PR references from the decision section.
R6 open questions: minimum target-size ownership is delegated rather than an approval blocker; unresolved physical-exception vocabulary, mixed-content fixtures, and direction-change animation questions remain visible.