Repository navigation
test(Tokenizer): the row-action warning test asks for the sheet with presentation - #9847
imdreamrunner wants to merge 1 commit into
Conversation
…presentation
The test added with the render-time row-action check passed
`experimental={{presentation: 'bottom-sheet'}}`, which the removal of
Tokenizer's experimental spelling took away while both changes were open,
so main fails typecheck (TS2769). It now passes `presentation="bottom-sheet"`,
the only spelling.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
|
AI review status for this pull request.
|
![astracat-bot[bot]](https://avatars.githubusercontent.com/in/4796231?s=60&v=4){kind=small}
There was a problem hiding this comment.
Requesting changes to the description only; the code change is correct.
Moving the StrictMode row-action test to presentation="bottom-sheet" makes Core's typecheck and that test pass again.
Blocking
- The description says
mainfails "the Node test shards" because of this line, but their only failure onmainis theresolution-compat.test.mjssnapshot foruseLightbox, which this change leaves failing, while the shard it does fix is atest-uileg; please reword Maintainer impact and Testing to nametypecheck,buildandtest-ui, and say thetest-nodesnapshot failure is separate.
[Automated review]
There was a problem hiding this comment.
No blocking findings: the one-line test change is correct and the description matches CI.
Passing presentation="bottom-sheet" lets typecheck and build pass again, and the StrictMode row-action test reaches the sheet once more: it fails on main and passes here. The separate test-node snapshot failure in resolution-compat.test.mjs is left alone, as the description says; it mismatches the usePressPin row as well as useLightbox, so its fix should cover both.
[Automated review]
PR Analysis Report🔎 Preview ·
|
| Component | Size | LoC | Visual · A11y · RTL |
|---|---|---|---|
| Tokenizer · Storybook | 70.3 kB (0) · 17.1 kB CSS (0) | 2,114 (0) | — · ✓ · ✓ |
Package size: no published package changed; no new dependencies.
API changes: none in this pull request
Committed API report behind this build: core 2 rows; run pnpm api:report.
Touched components checked; add ci:run-visual, ci:run-a11y or ci:run-rtl to run the full suites.
Current run: CI concluded failure; parts of this report may be missing.
Generated by PR Enrichment workflow | View full report
…ved experimental prop #9808 added the test with experimental.presentation; #9836 removed that prop. Each was green alone; together main typecheck fails (TS2769). Same change as #9847, folded in here so one pull request turns main green. Co-authored-by: Xinzi Zhou <2252473+imdreamrunner@users.noreply.github.com>
…tion, and the recorded module resolutions follow core (#9851) * test(cli): the recorded module resolutions follow useLightbox's doc and drop the deleted usePressPin #9752 gave useLightbox its own doc; #9756 deleted the internal Layer/usePressPin.ts. Each was green alone because PR checks skip this fixture test; main test-node fails on both lines. * test(Tokenizer): the sheet-row test passes presentation, not the removed experimental prop #9808 added the test with experimental.presentation; #9836 removed that prop. Each was green alone; together main typecheck fails (TS2769). Same change as #9847, folded in here so one pull request turns main green. Co-authored-by: Xinzi Zhou <2252473+imdreamrunner@users.noreply.github.com>
|
Closing: #9851 landed the same one-line test change together with the resolution fixture update, so |
Maintainer impact
mainfailstypecheck,buildand atest-uileg for every pull request:packages/core/src/Tokenizer/TokenizerBottomSheet.test.tsx(1814,11): error TS2769: No overload matches this call.A separate
test-nodefailure onmain(theresolution-compat.test.mjssnapshot foruseLightbox) has a different cause, and this change leaves it as it is.Intended invariant
maintype-checks. Tokenizer's only presentation spelling is the stablepresentationprop;experimental.presentationis removed.Change
The row-action warning test (added with the render-time row-action check, #9808) passed
experimental={{presentation: 'bottom-sheet'}}. The removal of Tokenizer's experimental spelling (#9836) was open at the same time and based before it, so each passed on its own and the combination fails. The test now passespresentation="bottom-sheet". One line, test only.Evidence
typecheckonmainreports TS2769 at the line above, which also failsbuild, and the StrictMode row-action test fails in itstest-uileg.experimental={{presentationremains underpackages/core/srcor the Tokenizer and PowerSearch stories;typecheck,buildandtest-uion this pull request.Scope
Testing
CI
typecheck,buildandtest-uion this pull request. Thetest-nodeuseLightboxsnapshot failure is separate and not addressed here.