Skip to content

Add nvidia-alchemi agent (NVIDIA ALCHEMI Toolkit) 1.1.2 - #212

Open
Andre Assis (anogassis) wants to merge 7 commits into
microsoft:mainfrom
anogassis:add-nvidia-alchemi-agent
Open

Andre Assis (anogassis) wants to merge 7 commits into
microsoft:mainfrom
anogassis:add-nvidia-alchemi-agent

Conversation

@anogassis

Copy link
Copy Markdown

Summary

Adds the nvidia-alchemi agent: a prompt agent with one GPU tool built on the NVIDIA ALCHEMI Toolkit for batched atomistic simulation. It evaluates single-point energies and forces, relaxes geometries (FIRE/FIRE2) and runs molecular dynamics (NVE, NVT, NPT, NPH) with MACE and AIMNet2 potentials, which can be combined with Lennard-Jones, DFT-D3 dispersion and Ewald/PME electrostatics. It also supports fused multi-stage pipelines, inflight batching for screening, Zarr trajectories, MLIP fine-tuning and multi-GPU runs. The tool image builds from the public nvidia/cuda:13.0.1-devel-ubuntu24.04 base (pinned by digest) with exact package pins, and downloads the MACE and AIMNet2 checkpoints at build time with SHA-256 verification, so jobs run offline.

Type of change

  • New agent (under agents/<name>/)
  • Update to an existing agent
  • New starter kit (under starter-kits/<name>/)
  • Update to an existing starter kit
  • Schema change (docs/schemas/**)
  • Workflow / script change (.github/**)
  • Documentation only
  • Other (describe below)

Related issue / tracking

n/a

Schema impact

  • No schema changes
  • Schema changes are backward compatible
  • Schema changes are breaking — add the breaking-change label and link the rollout plan below

Validation checklist

  • Documentation (README.md, schemas) is updated to match the change.
  • No hand-edits to .auto-registry/** (it is generated post-merge).
  • No OS / editor artefacts committed (.DS_Store, .env, *.swp, .idea/, .vs/, etc.).
  • If model-weight files are added, they are Git-LFS tracked, ≤5 GB each, and in an allowed format. (No weights are committed; checkpoints are downloaded and hash-verified at image build time.)
  • No secrets, customer data, or internal-only URLs are committed.
  • All Markdown links resolve.

Reviewer notes (optional)

  • Changes are confined to agents/nvidia-alchemi/ (23 files).
  • Ran locally on Linux before opening: .github/scripts/validate_pr.py passes with no findings, and .github/tests/test_schema_security.py passes (37 tests).
  • spellcheck_prose.py reports two advisory SPELL-001 warnings, both false positives: "Lond" is in the citation Proc. R. Soc. Lond. A (THIRD_PARTY_NOTICES.md), and "COO" is the coordinate-format neighbor list listed for MACE in the potentials table in agent.yaml.
  • Tool tests in tools/nvidia-alchemi/tests/ (32 tests) need the built image and a GPU, so they are not run by CI. They pass inside the image, and release 1.1.2 was also validated end to end on one NVIDIA H100 NVL: the smoke suite, offline single-point checks of all three bundled models, and a 100-step MACE NVT run with an independent kinetic-energy check. Multi-GPU execution and full training are documented capabilities but are outside that validation (see the README's "Verification status").
  • Third-party licenses are listed in THIRD_PARTY_NOTICES.md and copied into the image under /app/licenses/.

@github-actions github-actions Bot added 1p-contribution Authored by Microsoft (party='1p' in metadata) contains-code PR includes source-code changes contains-dockerfile PR adds, modifies, renames, or removes a Dockerfile pr-validation-passed The pr-review workflow's validator passed. Other status checks report separately. labels Oct 6, 2026
@anogassis

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree company="Microsoft"

@anogassis
Andre Assis (anogassis) marked this pull request as ready for review October 21, 2026 14:49
@anogassis
Andre Assis (anogassis) requested a review from a team as a code owner October 21, 2026 14:49
Security
- Bump GitPython 3.1.62, hydra-core 1.3.7, multidict 6.9.1 and urllib3 2.8.0
  to clear published advisories flagged by dependency review.
- Verify checkpoint size and SHA-256 before deserializing; runtime model
  aliases resolve only to hash-verified checkpoints baked into the image.
- Make cached checkpoints read-only and reserve logs.out from artifact
  replacement.

Behavior
- Require CUDA by default; CPU runs only when explicitly requested for tests.
- Propagate trajectory-sink and distributed-run failures instead of
  swallowing them.
- Fix indentation in the embedded script template.
- Mark training, multi-GPU, periodic MACE and broader cuEquivariance use as
  experimental in catalog descriptions.

Tests
- Add 11 regression tests (43 total), including hash-before-load checks for
  the checkpoint downloader.

Validation
- 43/43 tests on CPU during image build and on one H100 NVL, no skips.
- MACE small-0b/medium-0b2 and AIMNet2 inference, MACE relaxation and
  100-step NVT revalidated on H100 with independent numerical checks.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
nvidia-alchemi: hardening fixes and H100 revalidation for microsoft#212
@github-actions github-actions Bot added 1p-contribution Authored by Microsoft (party='1p' in metadata) contains-code PR includes source-code changes contains-dockerfile PR adds, modifies, renames, or removes a Dockerfile pr-validation-passed The pr-review workflow's validator passed. Other status checks report separately. and removed 1p-contribution Authored by Microsoft (party='1p' in metadata) pr-validation-passed The pr-review workflow's validator passed. Other status checks report separately. contains-dockerfile PR adds, modifies, renames, or removes a Dockerfile contains-code PR includes source-code changes labels Oct 23, 2026
- Bump certifi to 2026.10.19 (GHSA-6q48-6c7w-9gw2, critical), which
  dependency review flagged after the previous fixes merged.
- Let the checkpoint downloader tests locate /app/build themselves, so
  `python /app/release_smoke.py` runs unchanged in the deployed image.
  Image-build tests now run with the runtime PYTHONPATH to catch this.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
yousefi-msft
yousefi-msft previously approved these changes Oct 26, 2026

@yousefi-msft yousefi-msft left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

faranm-stack and others added 3 commits October 27, 2026 18:10
Dependency Review fails on high or critical advisories. These were reviewed
after the previous update and affect the pinned versions:

- Pillow 12.3.0 -> 13.0.0 (28 high/critical, including 5 critical)
- GitPython 3.1.62 -> 3.2.1 (5 high)
- aiohttp 3.14.3 -> 3.14.4 (3 high)
- filelock 3.32.3 -> 4.2.1 (1 high)
- hydra-core 1.3.7 -> 1.3.8 (1 high)
- setuptools 84.0.0 -> 84.1.0 (1 low)

No pinned package declares a conflict with these versions, and none of them
has a known advisory.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
aiohttp 3.14.4 requires yarl>=1.25.1; the image build's pip check rejected
yarl 1.24.5. An offline pip-check of all 198 pins finds no other violations,
and yarl 1.25.1 has no known advisories.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
nvidia-alchemi: fix dependency advisories and release smoke import path
@github-actions

Copy link
Copy Markdown

Starter Kit Impact: Validation Error

Source validation run for commit 4060f26ea8b23cc26745892975a740b999b63241.

Missing, invalid, or contradictory local removal result. A prepared trusted base is required.

Override decision: Not evaluated.

Option A: Update the affected starter kits: replace required references with valid agents, archive/delete the kit, or remove the required flag.

Option B (non-fork PRs only): A maintainer with write, maintain, or admin permission may apply starter-kit-impact-approved and rerun the check. Fork PRs must use Option A.

For setup or validation errors, inspect the source run logs and rerun after fixing the error.
Starter-kit guidance

This comment is diagnostic only. The removal check remains authoritative; review and approval requirements are unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1p-contribution Authored by Microsoft (party='1p' in metadata) contains-code PR includes source-code changes contains-dockerfile PR adds, modifies, renames, or removes a Dockerfile pr-validation-passed The pr-review workflow's validator passed. Other status checks report separately.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants