Repository navigation
quest(quic): record the BBR release steps and media check - #4193
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
moq-dev/noq#10 prepares 1.4.0 of the fork. The quest now lists the parent, upstream status, the ordered steps the maintainer runs to tag, publish, and pin, and the netem media check with its 1.3.0 versus 1.4.0 results from a local [patch] build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
MERGE Positive improvement: yes. This turns a vague “publish and pin” quest into a concrete maintainer runbook: ordered release steps, trusted-publisher caveat for Worth the complexity: yes, and the cost is low. One markdown file, no code or lockfile churn. Recording local Different approach: putting the release checklist only in moq-dev/noq#10 would lose the MoQ-side pin and media gate that this quest owns. Waiting to document until crates are live would just delay the same content. No better split stands out. Recommendation: merge as-is. After moq-dev/noq#10 lands and This is an automated review, not the maintainer's decision |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 877bfe28b7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| moq-bench --connect http://localhost:4443 --connect-websocket-enabled=false \ | ||
| --fanout media --connections 3 --startup 1s --duration 60s --report 5s \ | ||
| --fps 30 --frame-size 20000 --group-size 29 --output stats.jsonl | ||
| kill %1' |
There was a problem hiding this comment.
Preserve the benchmark failure through cleanup
If moq-bench exits nonzero, for example because the required media delivery fails, this shell still runs kill %1; a successful kill then becomes bash -c's exit status, so unshare reports success and the release check can pass despite a failed benchmark. Capture and return the benchmark status after cleanup, or use a cleanup trap that preserves it.
AGENTS.md reference: AGENTS.md:L17-L17
Useful? React with 👍 / 👎.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b304466ab6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| moq-bench --connect http://localhost:4443 --connect-websocket-enabled=false \ | ||
| --fanout media --connections 3 --startup 1s --duration 60s --report 5s \ | ||
| --fps 30 --frame-size 20000 --group-size 29 --output stats.jsonl |
There was a problem hiding this comment.
Gate the release on corrected media performance
When a BBR regression still delivers some media, as the documented 1.3.0 results do, this command exits successfully because Stats::ensure_delivery only requires groups_recv > 0; stats.jsonl is written but never checked against the 1.3.1 throughput or latency expectations. Consequently the required release gate can pass with the known-bad behavior even after the benchmark exit status is preserved. Add an explicit assertion on the recorded delivery and latency results.
AGENTS.md reference: AGENTS.md:L18-L18
Useful? React with 👍 / 👎.
| unshare -rn bash -c ' | ||
| ip link set lo up | ||
| tc qdisc add dev lo root netem delay 20ms loss 2% rate 40mbit | ||
| moq-relay relay.toml & # bind 127.0.0.1:4443, tls.generate, public auth, no iroh |
There was a problem hiding this comment.
Provide the relay configuration used by the check
In a fresh checkout run from the repository root, moq-relay relay.toml cannot start because that file is neither created by the snippet nor present at this path. A repo-wide search finds files with that name only under packaging/moq-relay and test/wasm, and neither is the configuration described by the inline comment. Point to a checked-in suitable config or create the exact config in the snippet so the release check is reproducible.
Useful? React with 👍 / 👎.
Point the relay at test/interop/interop.toml, keep moq-bench's exit status across the cleanup kill, and reject the 1.3.0 delivery shape on the 40 Mbps path. Co-authored-by: Grok 4.7 <noreply@x.ai>
|
Landing the BBR release runbook on the quic quest line. It records the 1.3.1 publish steps and the netem media results. The media-check snippet now fails closed:
The 16 Mbps row stays a table comparison. 1.3.0 already delivers most of the bytes there and the latency ranges overlap, so those cutoffs would not separate the two builds. (Written by Grok 4.7) |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 064851e8fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| unshare -rn bash -c ' | ||
| ip link set lo up | ||
| tc qdisc add dev lo root netem delay 20ms loss 2% rate 40mbit | ||
| moq-relay test/interop/interop.toml & |
There was a problem hiding this comment.
Run the checkout's release binaries explicitly
In a fresh checkout using the repository-required Nix development shell, neither moq-relay nor moq-bench is on PATH, and the preceding clippy and nextest commands do not create release executables. The documented release gate therefore stops here, or can accidentally test an unrelated globally installed version instead of the newly locked crates. Add an explicit release build and invoke target/release/moq-relay and target/release/moq-bench. (Written by GPT-5.6 Sol)
AGENTS.md reference: AGENTS.md:L82-L83
Useful? React with 👍 / 👎.
Updates the BBR release quest with the exact steps the maintainer runs to publish and pin the fork, and the media-shaped check the quest requires. The quest stays open until the release ships and the pin lands. Nothing here publishes.
Changes
moq-noq-proto,moq-noq-udp,moq-noq, andweb-transport-moq, with the parent (1a26a8b0), carried set, and upstream status inCHANGELOG-MOQ.md.v1.3.1, then change the requirements here from"1.3"to"1.3.1"and runcargo update -p moq-noq-proto -p moq-noq-udp -p moq-noq -p web-transport-moq.[patch.crates-io]build.The pin change isn't committed, because
"1.3.1"can't resolve until the crates exist, so--lockedwould fail. It raises the floor for the fork crates MoQ names directly, so downstream consumers of the nextmoq-tokioandmoq-uringreleases get the fixed BBR:Validation against the local fork build
--all-features(cargo tree -d).-D warnings, default features: moq-tokio, moq-uring, moq-relay, moq-native, moq-bench, moq-cli. With--all-features: moq-tokio, moq-uring, moq-relay.--no-default-featurescheck, andjust rs tokio-features. All pass.--all-features: moq-tokio and moq-relay 658/658. moq-uring: every test passed in some run, but io_uring worker setup hitENOMEMon this shared host, on different tests each run, before any QUIC code ran.Public API and wire impact
None here. After the pin: the fork's
Controllergains additive, space-aware callbacks. MoQ doesn't implement or callController, so it doesn't change. No wire change.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code