Skip to content

chore: release 1.3.1 with the BBR correctness fixes - #10

Merged
kixelated merged 2 commits into
mainfrom
release/1.4.0
Sep 25, 2026
Merged

kixelated merged 2 commits into
mainfrom
release/1.4.0

Conversation

@kixelated

@kixelated kixelated commented Sep 25, 2026 •

Copy link
Copy Markdown

Prepares 1.3.1 of moq-noq-proto, moq-noq-udp, moq-noq, and web-transport-moq, carrying the seven BBR correctness fixes (#3 to #9). Merging does not publish; pushing the v1.3.1 tag does, through moq-release.

Changes

  • Workspace version 1.3.0 to 1.3.1, and the internal version = pins with it, so moq-noq and web-transport-moq require the fixed moq-noq-proto.
  • CHANGELOG-MOQ.md: per release, the parent commit and each carried change with its upstream status. It is a separate file so the weekly upstream sync never conflicts with upstream's CHANGELOG.md. The README links it.
  • The branch is still named release/1.4.0 so this PR keeps its number; the version is 1.3.1. cargo publish --workspace --locked --dry-run passes at 1.3.1.
  • The moq-release header comment now lists web-transport-moq, which cargo publish --workspace already publishes.

Parent and carried set

API Changes

Additive. The maintainer chose a patch release: nothing breaks, and MoQ's "1.3" requirement picks it up without a pin change. cargo semver-checks check-release --baseline-version 1.3.0 passes for all four crates (196 checks, no breaking change).

  • congestion::{PacketId, Space}.
  • Controller::{on_packet_space_sent, on_packet_space_acked, on_packet_space_lost, on_congestion_event_space}, each defaulting to the number-only callback it replaces. The number-only callbacks are deprecated.
  • Controller::on_congestion_event is no longer required.
  • Controller::on_app_limited(in_flight).

Testing

  • The moq-ci steps on main (36cf8663), locally with Rust 1.98.1: fmt, clippy -Dwarnings, doc all pass. cargo test --workspace --locked --no-fail-fast: 520 passed, 0 failed, 4 ignored.
  • moq-noq tests::stream_stopped failed once while a large release build shared the machine, then passed 20 of 20 times alone. Its client has a 100ms timeout, and the endpoint runs the default Cubic controller, so the BBR series is not on its path. It's a pre-existing timing flake.
  • MoQ built against this branch through a local [patch.crates-io]. The pin change, consumer builds, and the netem media check are in quest(quic): record the BBR release steps and media check moq#4193. On a 2% loss path, the patched build delivered 69 MB against 23-26 MB for 1.3.0.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Bumps the shared workspace version and the internal pins, so moq-noq and
web-transport-moq require the fixed moq-noq-proto. CHANGELOG-MOQ.md names the
parent and every carried change with its upstream status, in its own file so
upstream syncs never conflict with CHANGELOG.md.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T22:14:07.108778Z 1093d74 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: a7bed6cc-2ddc-4833-85d6-6f553165a208

📥 Commits

Reviewing files that changed from the base of the PR and between faaeb74 and 1093d74.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • CHANGELOG-MOQ.md
  • Cargo.toml
  • noq/Cargo.toml
  • web-transport-moq/Cargo.toml
🚧 Files skipped from review as they are similar to previous changes (1)
  • CHANGELOG-MOQ.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The workspace and related dependency requirements change to version 1.3.1. The changelog adds fork release notes for versions 1.3.0 and 1.3.1, and the README links to it. The release workflow description now includes web-transport-moq among the crates published for a v* tag.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 1093d

The release versions and lockfile are aligned, and a matching tag publishes the workspace crates. No merge-blocking release issue was identified.

Architecture Summary

Architecture risk: 🔵 Low · up to 1093d

The change affects 5 systems.

Changed systems: Cargo.toml, CHANGELOG-MOQ.md, noq, README.md, web-transport-moq

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — Cargo.toml (service) was modified; 1 changed file maps to changed impact.
  • observed — CHANGELOG-MOQ.md (service) was modified; 1 changed file maps to changed impact.
  • observed — noq (service) was modified; 1 changed file maps to changed impact.
  • observed — README.md (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in README.md: The README now links to CHANGELOG-MOQ.md as the list of each release’s parent and carried changes.
  • observed — Modified behavior in CHANGELOG-MOQ.md: Adds fork-specific release notes for versions 1.3.1 and 1.3.0, documenting BBR changes, congestion-controller API additions and defaults, upstream tracking, and package releases.
  • observed — Modified behavior in Cargo.toml: The workspace package version changes from 1.3.0 to 1.3.1.
  • observed — Modified behavior in noq/Cargo.toml: Changed the declared versions of moq-noq-proto and moq-noq-udp from 1.4.0 to 1.3.1; their paths and feature settings are unchanged.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the 1.3.1 release and its main BBR correctness fixes.
Description check ✅ Passed The description provides a detailed summary, change list, API changes, parent and carried commits, release behavior, and test results. It omits the template's exact Description heading, Notes & open q…
✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

kixelated added a commit to moq-dev/moq that referenced this pull request Sep 25, 2026
moq-dev/noq#10 prepares 1.4.0 of the fork. The quest now lists the parent,
upstream status, the ordered steps the maintainer runs to tag, publish, and
pin, and the netem media check with its 1.3.0 versus 1.4.0 results from a
local [patch] build.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title chore: release 1.4.0 with the BBR correctness fixes chore: release 1.3.1 with the BBR correctness fixes Sep 25, 2026
@kixelated
kixelated merged commit ff9d2ab into main Sep 25, 2026
2 checks passed
kixelated added a commit to moq-dev/moq that referenced this pull request Sep 25, 2026
noq 1.3.1 shipped the seven BBR fixes (moq-dev/noq#10, tag v1.3.1), and
#4206 pins MoQ to it on main. Delete the quest and every reference, and
drop the Required entries it gated.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated added a commit to moq-dev/moq that referenced this pull request Sep 26, 2026
noq 1.3.1 shipped the seven BBR fixes (moq-dev/noq#10, tag v1.3.1), and
#4206 pins MoQ to it on main. Delete the quest and every reference, and
drop the Required entries it gated.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant