Repository navigation
chore: release 1.3.1 with the BBR correctness fixes - #10
Conversation
Bumps the shared workspace version and the internal pins, so moq-noq and web-transport-moq require the fixed moq-noq-proto. CHANGELOG-MOQ.md names the parent and every carried change with its upstream status, in its own file so upstream syncs never conflict with CHANGELOG.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe workspace and related dependency requirements change to version 1.3.1. The changelog adds fork release notes for versions 1.3.0 and 1.3.1, and the README links to it. The release workflow description now includes Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The release versions and lockfile are aligned, and a matching tag publishes the workspace crates. No merge-blocking release issue was identified. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 5 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
moq-dev/noq#10 prepares 1.4.0 of the fork. The quest now lists the parent, upstream status, the ordered steps the maintainer runs to tag, publish, and pin, and the netem media check with its 1.3.0 versus 1.4.0 results from a local [patch] build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
noq 1.3.1 shipped the seven BBR fixes (moq-dev/noq#10, tag v1.3.1), and #4206 pins MoQ to it on main. Delete the quest and every reference, and drop the Required entries it gated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
noq 1.3.1 shipped the seven BBR fixes (moq-dev/noq#10, tag v1.3.1), and #4206 pins MoQ to it on main. Delete the quest and every reference, and drop the Required entries it gated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Prepares 1.3.1 of
moq-noq-proto,moq-noq-udp,moq-noq, andweb-transport-moq, carrying the seven BBR correctness fixes (#3 to #9). Merging does not publish; pushing thev1.3.1tag does, throughmoq-release.Changes
version =pins with it, somoq-noqandweb-transport-moqrequire the fixedmoq-noq-proto.CHANGELOG-MOQ.md: per release, the parent commit and each carried change with its upstream status. It is a separate file so the weekly upstream sync never conflicts with upstream'sCHANGELOG.md. The README links it.release/1.4.0so this PR keeps its number; the version is 1.3.1.cargo publish --workspace --locked --dry-runpasses at 1.3.1.moq-releaseheader comment now listsweb-transport-moq, whichcargo publish --workspacealready publishes.Parent and carried set
1a26a8b0, unchanged since 1.3.0. Upstream main is two commits ahead (92361d22bumps rustls in the lockfile for RUSTSEC-2026-0285 and raises aws-lc-sys minimums;89ed00c3adds sent packet and byte stats). Neither affects the published libraries' fixes, so this release does not wait on a sync. MoQ's own lockfile already has rustls 0.23.45.git log --no-merges upstream/main..main, 38 commits: the packaging (chore!: publish as moq-noq, moq-noq-proto, and moq-noq-udp #1, feat: add web-transport-moq, the WebTransport adapter over the fork #2) and the BBR series (fix(proto): identify BBR packets by space and number #3 to fix(proto): keep BBR's undo snapshot for the whole recovery episode #9).PacketIdcallbacks and go upstream together once the shape settles.API Changes
Additive. The maintainer chose a patch release: nothing breaks, and MoQ's
"1.3"requirement picks it up without a pin change.cargo semver-checks check-release --baseline-version 1.3.0passes for all four crates (196 checks, no breaking change).congestion::{PacketId, Space}.Controller::{on_packet_space_sent, on_packet_space_acked, on_packet_space_lost, on_congestion_event_space}, each defaulting to the number-only callback it replaces. The number-only callbacks are deprecated.Controller::on_congestion_eventis no longer required.Controller::on_app_limited(in_flight).Testing
moq-cisteps onmain(36cf8663), locally with Rust 1.98.1: fmt, clippy-Dwarnings, doc all pass.cargo test --workspace --locked --no-fail-fast: 520 passed, 0 failed, 4 ignored.moq-noqtests::stream_stoppedfailed once while a large release build shared the machine, then passed 20 of 20 times alone. Its client has a 100ms timeout, and the endpoint runs the default Cubic controller, so the BBR series is not on its path. It's a pre-existing timing flake.[patch.crates-io]. The pin change, consumer builds, and the netem media check are in quest(quic): record the BBR release steps and media check moq#4193. On a 2% loss path, the patched build delivered 69 MB against 23-26 MB for 1.3.0.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code