Skip to content

fix(watch): honor fixed playback delay on release - #6217

Merged
kixelated merged 2 commits into
releasefrom
quest/m0/release-fixed-delay
Oct 22, 2026
Merged

kixelated merged 2 commits into
releasefrom
quest/m0/release-fixed-delay

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

On release, a viewer selecting 100 ms also waits for the rendition's catalog delay and jitter. Growing publisher estimates can move that viewer tens of seconds behind. This implements the release backport quest.

Approach

Use a numeric configured delay directly, including zero. Keep auto and instant behavior unchanged. Update the audio replay harness to wait for the corrected target. This ports the settled behavior from moq-dev/moq#4162 without its watch API rework.

Impact

  • Consumer: the existing <moq-watch> player on moq.dev, after the next release deploy. Fixed selections remain exact even when catalog estimates grow.
  • Public API and wire: no signature, type, or wire-format changes. No package version bumps.

Validation

  • Reproduced the regression before the fix: a fixed 0 ms delay resolved to 234 ms.
  • Mocked clock and microtask regression covers fixed 0/100/250 ms, an estimate growing to 42 s, playhead stability, max age, configuration changes, and unregistering.
  • nix develop --command just check origin/release passed, including all 256 watch tests.
  • Both strict CI halves passed with MOQ_STRICT=1: just ci check origin/release and just ci test origin/release.
  • Live Chrome playback held fixed 100 ms and 250 ms while the audio catalog advertised 117 ms jitter; auto still resolved to 140 ms.

Alternatives

The broader main-branch watch rework would break the published API and is intentionally excluded from this behavior-only backport.

Follow-ups

The separate publisher stall estimate quest addresses why catalog terms grow. The release quest exists only on main, so its bookkeeping remains there until this backport lands.

(Written by GPT-6)

kixelated and others added 2 commits October 21, 2026 15:40
Co-Authored-By: GPT-6 <noreply@openai.com>
Keep a numeric delay independent of rendition catalog delay and jitter, while preserving auto and instant behavior. Update replay target expectations and cover fixed playhead and max-age behavior with mocked time.

Co-Authored-By: GPT-6 <noreply@openai.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Completed the release-only behavior backport at 3b3e669. Numeric selections now stay exact; auto and instant retain their behavior. Reproduced the old failure, added mocked-clock coverage, and passed scoped checks plus both strict CI halves. Live Chrome playback also held fixed 100/250 ms with 117 ms advertised catalog jitter.

No outstanding implementation or API decisions. Recommendation: proceed through /quest-ready and the normal release review/merge workflow. This background task leaves the PR draft and does not merge or enqueue it. No new follow-up quest is needed; the existing publisher stall estimate quest remains separate. Main's release-backport quest bookkeeping can be removed after this PR lands.

(Written by GPT-6)

@kixelated
kixelated marked this pull request as ready for review October 22, 2026 06:00
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T15:55:27.354450Z 3b3e669 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

@codex review

(Written by Claude Opus 5.5)

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 3b3e669153

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant