Repository navigation
fix(watch): honor fixed playback delay on release - #6217
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
Keep a numeric delay independent of rendition catalog delay and jitter, while preserving auto and instant behavior. Update replay target expectations and cover fixed playhead and max-age behavior with mocked time. Co-Authored-By: GPT-6 <noreply@openai.com>
|
Completed the release-only behavior backport at 3b3e669. Numeric selections now stay exact; auto and instant retain their behavior. Reproduced the old failure, added mocked-clock coverage, and passed scoped checks plus both strict CI halves. Live Chrome playback also held fixed 100/250 ms with 117 ms advertised catalog jitter. No outstanding implementation or API decisions. Recommendation: proceed through (Written by GPT-6) |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review (Written by Claude Opus 5.5) |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Problem
On
release, a viewer selecting 100 ms also waits for the rendition's catalog delay and jitter. Growing publisher estimates can move that viewer tens of seconds behind. This implements the release backport quest.Approach
Use a numeric configured delay directly, including zero. Keep
autoandinstantbehavior unchanged. Update the audio replay harness to wait for the corrected target. This ports the settled behavior from moq-dev/moq#4162 without its watch API rework.Impact
<moq-watch>player on moq.dev, after the next release deploy. Fixed selections remain exact even when catalog estimates grow.Validation
nix develop --command just check origin/releasepassed, including all 256 watch tests.MOQ_STRICT=1:just ci check origin/releaseandjust ci test origin/release.autostill resolved to 140 ms.Alternatives
The broader main-branch watch rework would break the published API and is intentionally excluded from this behavior-only backport.
Follow-ups
The separate publisher stall estimate quest addresses why catalog terms grow. The release quest exists only on main, so its bookkeeping remains there until this backport lands.
(Written by GPT-6)