Skip to content

fix(test): preserve valid wire compatibility measurements - #7061

Merged
moq-bot[bot] merged 1 commit into
mainfrom
quest/m0/interop-green/wire-compat-remeasure
Oct 30, 2026
Merged

moq-bot[bot] merged 1 commit into
mainfrom
quest/m0/interop-green/wire-compat-remeasure

Conversation

@kixelated

@kixelated kixelated commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The accepted lite-07-wip exception in test/interop/compat/planned-breaks.json named old releases (moq-cli 0.14.8, moq-relay 0.17.8, @moq/net 0.4.5), so stale() refused every scheduled just test wire-compat run. Refreshing the pins was blocked because stable Rust media cells failed the Opus tone-phase check.

Approach

  • Select current Group.Producer.finish() or released close() once, when the test client sets up. Both complete cleanly. An unknown shape fails before connecting.
  • Preserve demuxed PTS with FFmpeg -copyts. By default FFmpeg shifts the negative Opus priming to zero, which moves the kept samples late. The tone/timestamp checker is unchanged.
  • Exempt a released CLI publisher from the phase check (INTEROP_PUB_LIVE=1, set by compat.sh when the publisher is the released binary). The released CLI's fMP4 import calls .live(), which restamps media on a clock anchored at arrival, so its tone never starts at timestamp zero. The browser publisher is already exempt for the same reason. Frequency, level, and contiguity checks still apply. Released readers keep the phase check.
  • Stop before rewriting accepted exception pins when a stable cell fails.
  • Re-pin lite-07-wip to the releases resolved on 2026-10-30, with a dated reason, after moq-cli 0.14.10 shipped the Opus edit-list backport (moq-dev/moq#7273, released by moq-dev/moq#7302).
  • Delete the finished quest quest/m0/interop-green/wire-compat-remeasure.md and its link in the epic README.

Impact

  • Public API: none. The API adaptation stays inside the cross-version driver.
  • Wire: none. The planned break's scope is unchanged; only its release pins and reason move.

Results (2026-10-30)

Resolved releases: moq-cli 0.14.10 (installed from crates.io), moq-relay 0.17.10, @moq/net 0.4.7.

  • quest gate just test wire-compat --remeasure (26 min): 89 session cells ran and 32 were skipped. 16 of 17 lite-07-wip cells still fail (media-rust, media-js-native-node, js-publish, and FETCH, across every relay and publisher pairing), so it re-pinned. The lite-07-wip FETCH capability cell passes. Every stable lite-01 through lite-06 cell passes (9/9/9/9/17/19), including the released-reader Opus phase cells that failed at +321us on 0.14.9. Token and catalog/container pass for all four sources. The framing errors match the reason: protocol violation, invalid value, long buffer.
  • quest gate just test wire-compat (the scheduled check): exit 0. 72 cells ran and 49 were skipped, the 17 lite-07-wip cells as the planned break. Token, session, catalog, and container lanes passed.

Earlier investigation (2026-10-29, moq-cli 0.14.9): a released reader of a current publisher failed at a stable +321us because the released exporter dropped the Opus edit list. A released publisher failed at a varying offset from .live() restamping, now exempted. 0.14.10 fixes the reader side.

Validation

  • quest check --base origin/main: 666 documents ok.
  • quest gate just ci: every module passes except test js, where two @moq/hang tests fail in src/util/libav.test.ts (AAC fallback decode and f32-planar deinterleave). This branch's js/, nix, and lockfile tree is identical to origin/main 9a0e152 (git diff --stat origin/main HEAD -- js/ flake.nix flake.lock nix/ package.json bun.lock is empty), so the failure is not this PR's. No open PR covers it; see Follow-ups.

Decisions (settled 2026-10-29)

  1. Released-reader cells: backport moq-dev/moq#7118 to release and publish a patch moq-cli, then rerun the full remeasurement. Done: moq-dev/moq#7273, published as moq-cli 0.14.10 via moq-dev/moq#7302.
  2. Released-publisher exemption (INTEROP_PUB_LIVE): kept as implemented.

Review

Codex (quest review), gpt-6.1-sol, medium effort, head 8b5661b against origin/main 9a0e152: no findings.

Follow-ups

  • @moq/hang's libav polyfill tests (the fallback decodes AAC without a native AudioDecoder, the polyfill deinterleaves every channel to f32-planar) fail locally on main's JS tree with a fresh nix build .#moq-libav. Worth a quest to check whether CI reproduces it.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

@kixelated kixelated changed the title Remeasure the planned wire break docs(quest): record wire-compat measurement blocker Oct 28, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

Current published head: 2862b6625a. This head has no completed Codex review or earlier request and is more than 30 minutes old.

(Written by GPT-6)

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T10:41:12.565500Z 8b5661b Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 2862b6625a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 17 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 90f532e9-1a50-48e0-afeb-f603b2052d3f
Commits

Reviewing files that changed from the base of the PR and between 9a0e152 and 8b5661b.

Files selected for processing: 6
  • quest/m0/interop-green/README.md
  • quest/m0/interop-green/wire-compat-remeasure.md
  • test/interop/compat.sh
  • test/interop/compat/client.ts
  • test/interop/compat/planned-breaks.json
  • test/interop/interop.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 8b5661b.

No actionable bugs found. The narrow compatibility adapter preserves the group receiver when invoking finish/close, and preserving demuxed PTS avoids shifting the samples judged against timestamps. The settled released-publisher phase exemption remains directional: a current publisher feeding a released reader still gets phase validation. Unexpected stable/control failures now stop before accepted exception pins are rewritten, which is the right fail-closed direction.

Verification limits: static review of the changed harness, matrix/remeasure logic, completion API and timestamp-checking path, plus an independent source review. No compatibility matrix, FFmpeg decode or released-package execution performed. The reported passing cells and release remeasurement are author-provided results, not independently reproduced here.

(Written by OpenAI)

@kixelated

Copy link
Copy Markdown
Collaborator Author

Landing: moq-cli 0.14.10 shipped the Opus edit-list backport, so the full just test wire-compat --remeasure now passes every stable lite-01 through lite-06 cell and still fails the 16 lite-07-wip cells. This re-pins lite-07-wip to moq-cli 0.14.10, moq-relay 0.17.10, and @moq/net 0.4.7 with a dated reason, and the scheduled just test wire-compat passes. Deletes the finished quest. Local Codex and online OpenAI/CodeRabbit reviews found nothing on 8b5661b.

(Written by Claude Opus 5.5)

This branch had an error being deployed

1 failed and 1 inactive deployments
github-pages — 9387174a Deployed Oct 30, 2026 by kixelated via Benchmark site #105
cache-write — 9387174a Deployed Oct 30, 2026 by kixelated via platform / macOS #105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant