Repository navigation
chore: release - #411
chore: release#411
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 0403154
P1: Give the changed facade package an unpublished version. rs/web-transport/Cargo.toml:24 changes the WASM requirement to ^0.9.0, while line 8 still declares web-transport 0.13.2. The registry confirms that #404 published 0.13.2 at 04:28:57 UTC with ^0.8.1. Published crate contents are immutable, and that requirement excludes 0.9.0, so merging this manifest cannot deliver the new dependency to facade consumers. Restore the existing dependency if the extra WASM release is unnecessary, or select a new facade version and assess its exposed WASM types before publishing. This is a recurrence of the earlier #404 finding in this newly generated PR.
Direction: reconcile the release baseline before merging. Comparing with web-transport-wasm-v0.8.1 shows no new WASM implementation changes, yet the new 0.9.0 changelog repeats historical features/breaking changes. The PR also duplicates the 0.13.1 Quinn and 0.13.2 facade release headings. Regenerating after #404's publication finishes is simpler than carrying these repeated release entries forward.
Verification: inspected the complete five-file diff, surrounding facade/manifests, release-tag comparison, registry records, and publishing workflow. Exact-head CI and the prior publication workflow were still running when checked. I did not run builds, tests, or a publication dry run.
0403154 to
dd0d92d
Compare
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: dd0d92d
No new actionable correctness findings. The earlier P1 at 0403154 is addressed: rs/web-transport/Cargo.toml:8,21–24 now bumps the facade to 0.13.3 and matches Quinn 0.13.2 / WASM 0.8.2. The regenerated release entries no longer repeat the previous Quinn/facade release versions. Direction is sound: patch releases package merged #416's API-compatible datagram fix, with matching Iroh 0.8.2 and Noq 0.4.2 manifests/changelogs.
Verification: inspected the complete ten-file release diff, all five manifests, changelog context, upstream #416 and comparison with web-transport-wasm-v0.8.1. Exact-head CI passed both just check and just test (run 37537815306). No local tests, registry availability checks, or publication dry run performed. WASM has no implementation changes since that tag; its bump is release metadata rather than a new runtime fix.
🤖 New release
web-transport-quinn: 0.13.1 -> 0.13.2 (✓ API compatible changes)web-transport-wasm: 0.8.1 -> 0.8.2web-transport-iroh: 0.8.1 -> 0.8.2 (✓ API compatible changes)web-transport-noq: 0.4.1 -> 0.4.2 (✓ API compatible changes)web-transport: 0.13.2 -> 0.13.3Changelog
web-transport-quinnweb-transport-wasmweb-transport-irohweb-transport-noqweb-transportThis PR was generated with release-plz.