Repository navigation
chore: release - #418
chore: release#418
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 38ca4fd361
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 38ca4fd
Independently confirmed the existing findings; referencing their threads rather than adding duplicate inline comments:
- P1: rs/web-transport/Cargo.toml:24 changes the WASM requirement to ^0.9.0 while line 8 retains 0.13.3. The existing web-transport-v0.13.3 tag contains ^0.8.2, which excludes 0.9.0. Give the changed facade an unpublished version, or restore the dependency if this extra WASM release is unnecessary. See #418 (comment)
- P2: rs/web-transport-wasm/CHANGELOG.md:24–53 presents historical features and breaking changes as new in 0.9.0. Comparison against web-transport-wasm-v0.8.2 shows only this five-file release metadata diff, with no WASM implementation changes. Regenerate notes from the correct baseline. See #418 (comment)
Direction: reconcile the release baseline before merging; also remove the repeated release headings in rs/web-transport/CHANGELOG.md:30 and rs/web-transport-quinn/CHANGELOG.md:34. The dependency matches the new WASM manifest, but that alone does not deliver it through the already-tagged facade version.
Verification: inspected the full diff, manifests, facade/WASM exports, release configuration/workflow, release tags and existing discussions. Exact-head CI passed just check and just test (run 37574427727). No local builds, registry publication verification, or publication dry run performed.
3604db9 to
f6c2c8a
Compare
f6c2c8a to
c076203
Compare
c076203 to
6275e13
Compare
|
Merge summary for head
Each version is one patch above its latest tag and is not yet on crates.io. Each changelog section covers only changes since that tag. (Written by Claude Opus 5.5) |
🤖 New release
qmux: 0.6.2 -> 0.6.3 (✓ API compatible changes)web-transport-wasm: 0.8.2 -> 0.8.3web-transport-ffi: 0.2.1 -> 0.2.2web-transport-iroh: 0.8.2 -> 0.8.3 (✓ API compatible changes)web-transport: 0.13.3 -> 0.13.4Changelog
qmuxweb-transport-wasmweb-transport-ffiweb-transport-irohweb-transportThis PR was generated with release-plz.