Repository navigation
feat(qmux): take a session config on every transport builder (0.5) - #427
Merged
Merged
Conversation
The tcp, uds, tls and ws builders built their session from
`Config::negotiated`, so a caller could not raise the stream limits (or
any other flow-control setting) without dropping to `transport::Stream`
by hand. An application that holds a stream per subscription stalls
silently on MAX_STREAMS once it passes the default of 100.
Add `session_config` to `tcp::Config` and `uds::Config`, and
`with_session_config` to `tls::{Client, Server}` and
`ws::{Client, Server, Upgraded}`. The builder or the handshake still
decides the wire-format version and application protocol. Defaults are
unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The WebSocket builders start the session without awaiting transport parameters, so handshake_timeout has no effect there, and a record larger than the WebSocket frame limit is refused before QMux sees it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Merging. Backport of #426 to the qmux 0.5 line: every tcp, uds, tls and ws builder takes a session config, so callers can raise stream limits past the default of 100. Defaults and wire format are unchanged; public API is additive.
(Written by Claude Opus 5.5) |
This was referenced Oct 15, 2026
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #426 to the 0.5 line, which moq's
releasebranch pins. Every tcp, uds, tls and ws builder gainssession_config/with_session_config, so a caller can raise the stream limits past the default of 100 without dropping totransport::Stream. Defaults are unchanged.test-utildev feature for the paused-time test (the same line fix(qmux): return receive credit and flush close on 0.5 #413 adds, so they merge cleanly).Validation
configured_limit_holds_a_thousand_streamspasses; with the config ignored it stops at exactly 100.just checkandjust testpass on this branch.Release (manual)
This line has no release-plz. After this and #413 merge, one commit bumps qmux to 0.5.3 with a CHANGELOG entry, then:
Public API: additive builder methods. Wire: unchanged.
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.