Skip to content

feat(qmux): take a session config on every transport builder (0.5) - #427

Merged
kixelated merged 2 commits into
qmux-v0.5.xfrom
feat/qmux-builder-config-0.5
Oct 14, 2026
Merged

kixelated merged 2 commits into
qmux-v0.5.xfrom
feat/qmux-builder-config-0.5

Conversation

@kixelated

@kixelated kixelated commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Backport of #426 to the 0.5 line, which moq's release branch pins. Every tcp, uds, tls and ws builder gains session_config / with_session_config, so a caller can raise the stream limits past the default of 100 without dropping to transport::Stream. Defaults are unchanged.

Validation

  • configured_limit_holds_a_thousand_streams passes; with the config ignored it stops at exactly 100.
  • just check and just test pass on this branch.

Release (manual)

This line has no release-plz. After this and #413 merge, one commit bumps qmux to 0.5.3 with a CHANGELOG entry, then:

cargo publish -p qmux
git tag qmux-v0.5.3 && git push origin qmux-v0.5.3

Public API: additive builder methods. Wire: unchanged.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

The tcp, uds, tls and ws builders built their session from
`Config::negotiated`, so a caller could not raise the stream limits (or
any other flow-control setting) without dropping to `transport::Stream`
by hand. An application that holds a stream per subscription stalls
silently on MAX_STREAMS once it passes the default of 100.

Add `session_config` to `tcp::Config` and `uds::Config`, and
`with_session_config` to `tls::{Client, Server}` and
`ws::{Client, Server, Upgraded}`. The builder or the handshake still
decides the wire-format version and application protocol. Defaults are
unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T04:34:39.475940Z b8a014f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

The WebSocket builders start the session without awaiting transport
parameters, so handshake_timeout has no effect there, and a record
larger than the WebSocket frame limit is refused before QMux sees it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merging. Backport of #426 to the qmux 0.5 line: every tcp, uds, tls and ws builder takes a session config, so callers can raise stream limits past the default of 100. Defaults and wire format are unchanged; public API is additive.

(Written by Claude Opus 5.5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant