Skip to content

Panxo Bid Adapter and RTD Provider: update request handling and activity controls - #15875

Open
css12s wants to merge 1 commit into
prebid:masterfrom
css12s:panxo-adapter-rtd-update-20261027
Open

css12s wants to merge 1 commit into
prebid:masterfrom
css12s:panxo-adapter-rtd-update-20261027

Conversation

@css12s

@css12s css12s commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Type of change

  • Updated bidder adapter
  • Bugfix
  • Does this change affect user-facing APIs or examples documented on prebid.org?

Description of change

  • Group impressions by propertyKey and validate banner, video and native responses.
  • Honor standard floors and currency conversion.
  • Apply RTD activity controls and ignore callbacks from previous connections.
  • Remove legacy identity fields and limit Panxo RTD enrichment to the AI-visit flag.
  • Add synthetic test inventory, configuration types and regression tests.

Setup, external script behavior and migration restrictions are documented in the module docs. The bidder and RTD changes need to ship together.

The deprecated JS floor parameter remains a USD fallback. PBS uses standard OpenRTB floors; maintainer guidance on this legacy parameter difference is requested before merge.

Validation

Affected tests, disabled-feature tests, lint, types and build pass locally. These tests include the separate core fix for ad units with no enabled media types. Upstream CI is pending.

Other information

Docs: prebid/prebid.github.io#6494
Server: prebid/prebid-server#4723
Maintainer: prebid@panxo.ai

Core fix: #15874

@github-actions

Copy link
Copy Markdown

This PR introduces changes that may not work on all browsers. According to Babel, the following polyfills may be needed, and they are not automatically included:

  • Changes to modules/panxoBidAdapter.js may need:
    • es.iterator.every
    • es.iterator.reduce
    • es.iterator.some
    • es.json.parse
    • es.json.stringify
    • es.map.get-or-insert
    • es.map.get-or-insert-computed
    • es.set.difference.v2
    • es.set.intersection.v2
    • es.set.is-disjoint-from.v2
    • es.set.is-subset-of.v2
    • es.set.is-superset-of.v2
    • es.set.symmetric-difference.v2
    • es.set.union.v2
    • esnext.iterator.every
    • esnext.iterator.reduce
    • esnext.iterator.some
    • esnext.json.parse
    • esnext.map.get-or-insert
    • esnext.map.get-or-insert-computed
    • esnext.set.difference.v2
    • esnext.set.intersection.v2
    • esnext.set.is-disjoint-from.v2
    • esnext.set.is-subset-of.v2
    • esnext.set.is-superset-of.v2
    • esnext.set.symmetric-difference.v2
    • esnext.set.union.v2
  • Changes to modules/panxoRtdProvider.js may need:
    • es.set.difference.v2
    • es.set.intersection.v2
    • es.set.is-disjoint-from.v2
    • es.set.is-subset-of.v2
    • es.set.is-superset-of.v2
    • es.set.symmetric-difference.v2
    • es.set.union.v2
    • esnext.set.difference.v2
    • esnext.set.intersection.v2
    • esnext.set.is-disjoint-from.v2
    • esnext.set.is-subset-of.v2
    • esnext.set.is-superset-of.v2
    • esnext.set.symmetric-difference.v2
    • esnext.set.union.v2

The best way to address this is to provide good test coverage, as normal PR checks run unit tests on older browsers.

@barecheck

barecheck Bot commented Oct 27, 2026

Copy link
Copy Markdown

Barecheck - Code coverage report

Total: 91.78%

Your code coverage diff: 0.06% ▴

Uncovered files and lines
FileLines
modules/panxoBidAdapter.js470, 473

@css12s
css12s marked this pull request as ready for review October 28, 2026 08:55
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-28T08:55:43.539264Z bd9e448 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant