Repository navigation
Add the issue-priority skill for the Priority issue field - #613
Conversation
The skill gives the rules for the org issue field Priority (Urgent, High, Medium, Low) on clickhouse-cpp issues: reach tiers of the library, severity, the base-level matrix, modifiers, and confidence. People and automated triage use the same rules. AGENTS.md points to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AI review gate — auto-approved
History (latest 5 heads, newest first)
|
The severity section now starts with four impact classes: Security, Data integrity, Stability, and Performance. They are the same in every ClickHouse client repository. Each severity row names the impact that puts an issue in the row, and the reason line records the impacts. No priority level changes: each row keeps its conditions. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
I pushed one more commit after the approval: the severity section now names four impact classes (Security, Data integrity, Stability, Performance). The classes are the same in every ClickHouse client repository.
The description has a new section "Impact classes" with the same summary. |
The impact Security has two parts: a vulnerability, and authentication. Only a vulnerability uses the row "Wrong data or security". An authentication method that does not work is rated by its failure, and a request for a missing method is a feature request. Before, the impact table and the severity row disagreed, so a missing authentication method could read as Urgent on a Core path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
## Summary Names four impact classes in `.claude/skills/issue-priority/SKILL.md`: **Security**, **Data integrity**, **Stability**, and **Performance**. The classes are the same in every ClickHouse client repository, so that issues are classified with the same words in each client. clickhouse-cpp, clickhouse-cs, and clickhouse-odbc get the same text in ClickHouse/clickhouse-cpp#613, ClickHouse/clickhouse-cs#743, and ClickHouse/clickhouse-odbc#615. - Section "2. Severity" starts with a table that defines the four impacts. An issue has none, one, or more of them. - Each severity row names the impact that puts an issue in the row. - The reason line records the impacts. No priority level changes: each severity row keeps its conditions. How the classes change the priority is a later change. No library code changes, so there is no changelog entry. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Documentation-only change to agent triage rules; no runtime or library behavior. > > **Overview** > Documents a two-step triage flow in `.claude/skills/issue-priority/SKILL.md`: issues are first tagged with shared **impact** classes (**Security**, **Data integrity**, **Stability**, **Performance**), then mapped to the existing severity rows using explicit impact language. The skill description and the one-line **Reason** format now include impacts (`<impacts, or "no impact">`). > > Adds guidance that most issues have no impact, that the highest severity row wins when multiple impacts apply, and that non-vulnerability **Security** (broken or missing auth) is rated by failure type rather than the top severity row. **Reach**, base-level matrix, modifiers, and resulting priority levels are unchanged—classification vocabulary only, aligned with other ClickHouse client repos. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit d62ddb0. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Polyglot AI <293096396+polyglotAI-bot@users.noreply.github.com> Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
… priority A security issue must not stay public with a description of how to reproduce it. A confirmed vulnerability that is not public yet goes to a private GitHub vulnerability report; the public issue gets no Priority, and the rating goes into the report as the proposed severity. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AI review gate — AI review passedClean review from: Cursor Bugbot. |
…y row Review feedback (Copilot on clickhouse-js#1155, Bugbot on clickhouse-cpp#613): - the private-report rule also applies when code inspection confirms the vulnerability; - copy the issue text into the private report, and ask an administrator to delete the issue: closing does not hide its text; - the impact Security names memory corruption, and input from the application's users that stops the client; a hang or a crash that only a hostile server or network causes is Stability. AGENTS.md: a vulnerability that is not public yet goes into a private security report, never into an issue or a pull request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review feedback (Bugbot on clickhouse-js#1155): the private-report rule accepts a vulnerability that code inspection confirms, but section 2 gave an impact only when the issue or a reproduction showed it. Section 2 now also accepts code inspection, as section 5 already does (confidence MEDIUM). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…server Security review (ConnectorSec on clickhouse-odbc#615): the exclusion "a hang or a crash that only a hostile server or network causes" also covered memory corruption, which a crafted server response causes and which anyone on the network path can send over plain HTTP. The exclusion now covers hangs and crashes with no memory corruption only, and a crash on server data must have memory corruption ruled out by code inspection before it is rated by its failure. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Auto-approved by the AI review gate on 9cbc47f. Details in the approver's comment on this pull request.
Each ClickHouse client repository gets the same classification skill (.claude/skills/issue-classification/SKILL.md): the impacts (Security, Data integrity, Stability, Performance), the areas, the boundaries, the test for a vulnerability that is not public yet, and how to write the classification. Any agent can then classify an issue in the repository. A section "This repository" at the end holds local changes. The issue-priority skill no longer copies the impact definitions: it points to the classification skill and keeps the reach tiers, severity rows, matrix, modifiers, and the handling of a vulnerability. AGENTS.md points to both skills. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
91f5c05
…ority skill (#1155) ## Summary Adds a section "Vulnerabilities that are not public yet" to `.claude/skills/issue-priority/SKILL.md`. A security issue must not stay public with a description of how to reproduce it (team decision, 2026-11-18). When a reproduction or code inspection confirms a vulnerability that is not public yet (a leak of credentials or data, a value that changes a query, a skipped or weakened TLS or identity check, memory corruption, or input from the application's users that stops the client): - it goes into a private GitHub vulnerability report for this repository (private vulnerability reporting is on), never into a public issue, comment, or pull request; the text of a public issue about it is copied into the report first; - the public issue gets no Priority: it is closed with a comment that gives no details, and a repository administrator is asked to delete it, because closing does not hide its text; - the rules of this skill still rate the vulnerability, and the level and its reason go into the private report as the proposed severity. The impact Security now also names memory corruption, and says that a hang or a crash that only a hostile server or network causes is Stability. `AGENTS.md` gets one sentence after the issue-priority pointer: a vulnerability that is not public yet goes into a private security report, never into an issue or a pull request. A vulnerability that is already public (a published CVE or GHSA, for example in a dependency) and an authentication method that does not work or is missing get a Priority as before. Modifier 1 now points to the new section in place of "a private channel". The same text goes into the other client repositories: ClickHouse/clickhouse-cpp#613, ClickHouse/clickhouse-cs#743, ClickHouse/clickhouse-odbc#615, ClickHouse/clickhouse-go#2142, ClickHouse/ch-go#1233. No priority level changes. No library code changes, so there is no changelog entry. `prettier --check` passes on the file. ## Classification skill (added 2026-11-18) New file `.claude/skills/issue-classification/SKILL.md`, so that any agent can classify an issue in this repository: the impacts (Security, Data integrity, Stability, Performance), the areas, their boundaries, the test for a vulnerability that is not public yet, and how to write the classification line. Every ClickHouse client repository gets the same text; the section "This repository" at the end holds local changes. Please keep those small, so that the classes mean the same in every client. The issue-priority skill no longer copies the impact definitions: it points to the classification skill and keeps the reach tiers, the severity rows, the matrix, the modifiers, and the handling of a vulnerability. `AGENTS.md` points to both skills. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Documentation and agent-triage guidance only; no runtime or library behavior changes. > > **Overview** > Introduces a shared **issue-classification** agent skill that defines impact classes (Security, Data integrity, Stability, Performance), area classes, evidence rules, and how to write the `Classification` line—including **memory corruption** under Security and explicit handling of **confirmed but not-yet-public** vulnerabilities (private GitHub report only, never in public issues/PRs). > > **Issue-priority** no longer embeds the full impact table; severity now defers to the classification skill. It adds a **Vulnerabilities that are not public yet** section (close/delete public issues with no details, rate severity in the private report) and updates the untrusted-input modifier to point at that flow. > > **`AGENTS.md`** now directs triage to the classification skill and repeats that unpublicized vulnerabilities must use private vulnerability reporting. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 8440102. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Polyglot AI <293096396+polyglotAI-bot@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 91f5c05. Configure here.
… are vulnerabilities
Review feedback (Bugbot on clickhouse-cpp#613):
- a request to make an operation faster has the impact Performance but
is a feature request ("Cosmetic, docs, feature"); only a Performance
defect uses "Workaround exists";
- authentication means how the client takes credentials; a secret that
leaks is a vulnerability, not authentication;
- a dependency with a published CVE or GHSA uses "Wrong data or
security" when the client calls the vulnerable code, else it is a
dependency update; an unpublished dependency vulnerability goes to the
private report.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Auto-approved by the AI review gate on 4a6cd31. Details in the approver's comment on this pull request.
… in private Review feedback (Bugbot on clickhouse-odbc#615): the impact Security and the priority mapping named only a published CVE or GHSA, so an unpublished dependency vulnerability had no Security mapping; and the report to the dependency's maintainers did not say that it must be private. Both now cover a published or unpublished vulnerability, and the upstream report goes through the dependency's security policy, never a public issue. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Auto-approved by the AI review gate on 791a959. Details in the approver's comment on this pull request.
…nerabilities (#1156) ## Summary Follow-up to #1155. Three review findings (Cursor Bugbot on ClickHouse/clickhouse-cpp#613) apply to the same text here; this commit reached the #1155 branch only after the merge. - **Speed requests:** a request to make an operation faster has the impact Performance, but the priority rules mapped Performance to "Workaround exists", so a Core feature request became `Medium`. Now it is rated as a feature request ("Cosmetic, docs, feature"); only a defect with the impact Performance uses "Workaround exists". - **Secrets:** the part authentication included "the handling of secrets", so a leaked credential could be labelled authentication and miss "Wrong data or security". Now authentication is an authentication method that does not work or is missing, or how the client takes credentials; a secret that leaks (to a log, an error message, a URL, or another host) is a vulnerability. - **Dependencies:** a vulnerability in a dependency, published (CVE or GHSA) or not published yet, is a vulnerability when the client calls the vulnerable code ("Wrong data or security"); else the issue asks for a dependency update ("Cosmetic, docs, feature"). An unpublished one is on the list of "A vulnerability that is not public yet": it goes to a private report here, and to the dependency's maintainers in private, through their security policy, never in a public issue (Bugbot on ClickHouse/clickhouse-odbc#615). The other client repositories get the same text in their open PRs. No library code changes, so there is no changelog entry. `prettier --check` passes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Documentation-only changes to agent triage skills; no runtime library or security-sensitive code paths are modified. > > **Overview** > Updates the shared **issue-classification** and **issue-priority** agent skills so triage labels and severity rows stay consistent. > > **Classification** now treats dependency issues (published or unpublished CVE/GHSA) as **Security (vulnerability)** when the client calls the affected code, narrows **authentication** to broken/missing methods and credential handling (credential leaks are explicitly **vulnerabilities**), and adds unpublished dependency findings to the private-report checklist with guidance to contact upstream maintainers privately. > > **Priority** routes “make it faster” requests to **Cosmetic, docs, feature** while **Workaround exists** applies only to performance **defects**; dependency CVEs map to **Wrong data or security** when vulnerable code is on the execution path, otherwise to a low-priority dependency-update feature request. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 0a64bd3. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Polyglot AI <293096396+polyglotAI-bot@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Review feedback (Bugbot on clickhouse-odbc#615): the classification kept every unpublished dependency vulnerability private, but the severity rule rated one in code that the client does not call as a public dependency update. Now an unpublished one stays private also then; the low level is only the proposed severity of the private report. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Auto-approved by the AI review gate on 2e9e041. Details in the approver's comment on this pull request.

Summary
Adds
.claude/skills/issue-priority/SKILL.md: the rules for the org issue field Priority (Urgent,High,Medium,Low) on clickhouse-cpp issues. People and automated triage use the same file.AGENTS.mdpoints to it. clickhouse-js has the same skill (ClickHouse/clickhouse-js#1136), with reach tiers of its own.The rules:
Select()parses the column types, so a type-parser defect for a common type is Core.Execute/Select/Insert/Ping, failover, timeouts, TLS, error handling and the connection state after an error, the Native codec for the common types, the default CMake build on a CI-tested toolchain.BeginInsert/BeginSelect, settings and parameters, callbacks, external data,Enum/Map/Tuple/Bool/IP/Int128and nested wrappers, column methods, Bazel, MinGW, shared or system-dependency builds,CH_USE_3X_API.JSON,Time,Nested), unusual type names, bytes that a correct server does not send, caller input that the library does not reject, toolchains that CI does not test.examples/,bench/, tests, docs, and packages that other projects maintain (Conan, vcpkg, Homebrew).Urgent; a regression in the latestvX.Y.Ztag → up one level; a customer request linked from Linear → up one level, never toUrgent.Impact classes (added 2026-11-17)
The severity section now starts with four impact classes: Security, Data integrity, Stability, and Performance. They are the same in every ClickHouse client repository, so that issues are classified with the same words in each client.
Decisions for a maintainer
priority-high/priority-lowlabels win over the table (section 7). They are a maintainer's earlier decision. Only Nested tables support #40 has one today.Int128: it is deprecated but is the 2.x default. Its defects get a normal priority, and-DCH_USE_ABSEIL_FOR_BIGNUM=OFFis the workaround.pg_clickhousegives no modifier, because pg_clickhouse uses clickhouse-c since its v0.3.1.Calibration
The rules were applied to the 8 closed issues with a
priority-*label and to #40. 6 of 9 agree. The other 3 are one level higher with these rules:The old labels had only two levels. Change the tiers or the matrix as you like: the triage job reads this file from
masteron every run.No library code changes. The repo has no changelog.
Vulnerabilities that are not public yet (added 2026-11-18)
New section after "When to set no priority" (team decision): a security issue must not stay public with a description of how to reproduce it. When a reproduction or code inspection confirms a vulnerability that is not public yet (a leak of credentials or data, a value that changes a query, a skipped or weakened TLS or identity check, memory corruption, or input from the application's users that stops the client):
The impact Security now also names memory corruption, and says that a hang or a crash that only a hostile server or network causes is Stability (the clickhouse-cpp severity row already said so). Already public vulnerabilities (a published CVE or GHSA) and authentication methods keep a Priority on the issue. Modifier 1 points to the new section.
AGENTS.mdgets one sentence in its issue-triage part: a vulnerability that is not public yet goes into a private security report, never into an issue or a pull request. Same text in all client repositories. No priority level changes.Classification skill (added 2026-11-18)
New file
.claude/skills/issue-classification/SKILL.md, so that any agent can classify an issue in this repository: the impacts (Security, Data integrity, Stability, Performance), the areas, their boundaries, the test for a vulnerability that is not public yet, and how to write the classification line. Every ClickHouse client repository gets the same text; the section "This repository" at the end holds local changes. Please keep those small, so that the classes mean the same in every client.The issue-priority skill no longer copies the impact definitions: it points to the classification skill and keeps the reach tiers, the severity rows, the matrix, the modifiers, and the handling of a vulnerability.
AGENTS.mdpoints to both skills.🤖 Generated with Claude Code
Note
Low Risk
Documentation-only; no runtime or library behavior changes.
Overview
Adds automated triage documentation for ClickHouse client issues: a shared issue-classification skill (impacts and areas, including private handling of unconfirmed vulnerabilities) and a clickhouse-cpp-specific issue-priority skill (reach tiers, severity matrix, modifiers, confidence, and org Priority field rules).
AGENTS.mdnow directs agents to both skills and requires unpublicized vulnerabilities to go through private GitHub security reporting instead of public issues or PRs.Reviewed by Cursor Bugbot for commit 2e9e041. Bugbot is set up for automated code reviews on this repo. Configure here.