Skip to content

docs: handle vulnerabilities that are not public yet in the issue-priority skill - #1155

Merged
ccoltx merged 5 commits into
mainfrom
polyglot/issue-priority-private-vulnerabilities
Nov 18, 2026
Merged

ccoltx merged 5 commits into
mainfrom
polyglot/issue-priority-private-vulnerabilities

Conversation

@polyglotAI-bot

@polyglotAI-bot polyglotAI-bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Adds a section "Vulnerabilities that are not public yet" to .claude/skills/issue-priority/SKILL.md. A security issue must not stay public with a description of how to reproduce it (team decision, 2026-11-18). When a reproduction or code inspection confirms a vulnerability that is not public yet (a leak of credentials or data, a value that changes a query, a skipped or weakened TLS or identity check, memory corruption, or input from the application's users that stops the client):

  • it goes into a private GitHub vulnerability report for this repository (private vulnerability reporting is on), never into a public issue, comment, or pull request; the text of a public issue about it is copied into the report first;
  • the public issue gets no Priority: it is closed with a comment that gives no details, and a repository administrator is asked to delete it, because closing does not hide its text;
  • the rules of this skill still rate the vulnerability, and the level and its reason go into the private report as the proposed severity.

The impact Security now also names memory corruption, and says that a hang or a crash that only a hostile server or network causes is Stability. AGENTS.md gets one sentence after the issue-priority pointer: a vulnerability that is not public yet goes into a private security report, never into an issue or a pull request.

A vulnerability that is already public (a published CVE or GHSA, for example in a dependency) and an authentication method that does not work or is missing get a Priority as before. Modifier 1 now points to the new section in place of "a private channel".

The same text goes into the other client repositories: ClickHouse/clickhouse-cpp#613, ClickHouse/clickhouse-cs#743, ClickHouse/clickhouse-odbc#615, ClickHouse/clickhouse-go#2142, ClickHouse/ch-go#1233. No priority level changes.

No library code changes, so there is no changelog entry. prettier --check passes on the file.

Classification skill (added 2026-11-18)

New file .claude/skills/issue-classification/SKILL.md, so that any agent can classify an issue in this repository: the impacts (Security, Data integrity, Stability, Performance), the areas, their boundaries, the test for a vulnerability that is not public yet, and how to write the classification line. Every ClickHouse client repository gets the same text; the section "This repository" at the end holds local changes. Please keep those small, so that the classes mean the same in every client.

The issue-priority skill no longer copies the impact definitions: it points to the classification skill and keeps the reach tiers, the severity rows, the matrix, the modifiers, and the handling of a vulnerability. AGENTS.md points to both skills.

🤖 Generated with Claude Code


Note

Low Risk
Documentation and agent-triage guidance only; no runtime or library behavior changes.

Overview
Introduces a shared issue-classification agent skill that defines impact classes (Security, Data integrity, Stability, Performance), area classes, evidence rules, and how to write the Classification line—including memory corruption under Security and explicit handling of confirmed but not-yet-public vulnerabilities (private GitHub report only, never in public issues/PRs).

Issue-priority no longer embeds the full impact table; severity now defers to the classification skill. It adds a Vulnerabilities that are not public yet section (close/delete public issues with no details, rate severity in the private report) and updates the untrusted-input modifier to point at that flow.

AGENTS.md now directs triage to the classification skill and repeats that unpublicized vulnerabilities must use private vulnerability reporting.

Reviewed by Cursor Bugbot for commit 8440102. Bugbot is set up for automated code reviews on this repo. Configure here.

… priority

A security issue must not stay public with a description of how to
reproduce it. A confirmed vulnerability that is not public yet goes to a
private GitHub vulnerability report; the public issue gets no Priority,
and the rating goes into the report as the proposed severity.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The security-report workflow can exclude vulnerabilities confirmed by code inspection and leave reproduction details public because issue closure does not remove the report.

2 open issues
What changed in this PR

Updates the issue-priority skill to route confirmed, non-public vulnerabilities into private GitHub reports while keeping the existing priority scale.

Changes:

  • Adds private reporting and public-issue closure guidance, with the proposed severity recorded privately.
  • Preserves normal triage for published vulnerabilities and broken or missing authentication methods.
  • Updates the security modifier to reference the new guidance. No library code or public API changes.
File Description
.claude/​skills/​issue-priority/​SKILL.md Adds confidential vulnerability-handling guidance and updates the security modifier reference.

Review effort: Balanced

Comment thread .claude/skills/issue-priority/SKILL.md Resolved
Comment thread .claude/skills/issue-priority/SKILL.md Resolved

@security-ai-gate-reviewer security-ai-gate-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved by the AI review gate on 22a5200. Details in the approver's comment on this pull request.

@security-ai-gate-reviewer

security-ai-gate-reviewer Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

AI review gate — auto-approved

84401020d936 is approved by security-ai-gate-reviewer[bot], an automated identity, not a human. The approval stands on the required AI review: Cursor Bugbot concluded green on this commit and the AI review gate is SUCCESS (its own comment has the verdict), and the change touches no path that requires a human reviewer. It is bound to this commit: a new push dismisses it and the approver re-evaluates.

History (latest 5 heads, newest first)

  • 84401020d936 approved — green: Cursor Bugbot
  • 0ee6071ddeba approved — green: Cursor Bugbot
  • 22a5200b8bbb approved — green: Cursor Bugbot

…y row

Review feedback (Copilot on clickhouse-js#1155, Bugbot on
clickhouse-cpp#613):
- the private-report rule also applies when code inspection confirms the
  vulnerability;
- copy the issue text into the private report, and ask an administrator
  to delete the issue: closing does not hide its text;
- the impact Security names memory corruption, and input from the
  application's users that stops the client; a hang or a crash that only a
  hostile server or network causes is Stability.
AGENTS.md: a vulnerability that is not public yet goes into a private
security report, never into an issue or a pull request.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8a4e9f8. Configure here.

Comment thread .claude/skills/issue-priority/SKILL.md Resolved
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

AI review gate — AI review passed

Clean review from: Cursor Bugbot.

polyglotAI-bot and others added 2 commits November 18, 2026 18:15
Review feedback (Bugbot on clickhouse-js#1155): the private-report rule
accepts a vulnerability that code inspection confirms, but section 2 gave
an impact only when the issue or a reproduction showed it. Section 2 now
also accepts code inspection, as section 5 already does (confidence
MEDIUM).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…server

Security review (ConnectorSec on clickhouse-odbc#615): the exclusion "a
hang or a crash that only a hostile server or network causes" also
covered memory corruption, which a crafted server response causes and
which anyone on the network path can send over plain HTTP. The exclusion
now covers hangs and crashes with no memory corruption only, and a crash
on server data must have memory corruption ruled out by code inspection
before it is rated by its failure.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@security-ai-gate-reviewer security-ai-gate-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved by the AI review gate on 0ee6071. Details in the approver's comment on this pull request.

Each ClickHouse client repository gets the same classification skill
(.claude/skills/issue-classification/SKILL.md): the impacts (Security,
Data integrity, Stability, Performance), the areas, the boundaries, the
test for a vulnerability that is not public yet, and how to write the
classification. Any agent can then classify an issue in the repository.
A section "This repository" at the end holds local changes.

The issue-priority skill no longer copies the impact definitions: it
points to the classification skill and keeps the reach tiers, severity
rows, matrix, modifiers, and the handling of a vulnerability. AGENTS.md
points to both skills.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@security-ai-gate-reviewer security-ai-gate-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved by the AI review gate on 8440102. Details in the approver's comment on this pull request.

@ccoltx
ccoltx merged commit 90902f2 into main Nov 18, 2026
12 checks passed
@ccoltx
ccoltx deleted the polyglot/issue-priority-private-vulnerabilities branch November 18, 2026 18:44
ccoltx pushed a commit that referenced this pull request Nov 18, 2026
…nerabilities (#1156)

## Summary

Follow-up to #1155. Three review findings (Cursor Bugbot on
ClickHouse/clickhouse-cpp#613) apply to the same text here; this commit
reached the #1155 branch only after the merge.

- **Speed requests:** a request to make an operation faster has the
impact Performance, but the priority rules mapped Performance to
"Workaround exists", so a Core feature request became `Medium`. Now it
is rated as a feature request ("Cosmetic, docs, feature"); only a defect
with the impact Performance uses "Workaround exists".
- **Secrets:** the part authentication included "the handling of
secrets", so a leaked credential could be labelled authentication and
miss "Wrong data or security". Now authentication is an authentication
method that does not work or is missing, or how the client takes
credentials; a secret that leaks (to a log, an error message, a URL, or
another host) is a vulnerability.
- **Dependencies:** a vulnerability in a dependency, published (CVE or
GHSA) or not published yet, is a vulnerability when the client calls the
vulnerable code ("Wrong data or security"); else the issue asks for a
dependency update ("Cosmetic, docs, feature"). An unpublished one is on
the list of "A vulnerability that is not public yet": it goes to a
private report here, and to the dependency's maintainers in private,
through their security policy, never in a public issue (Bugbot on
ClickHouse/clickhouse-odbc#615).

The other client repositories get the same text in their open PRs. No
library code changes, so there is no changelog entry. `prettier --check`
passes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Documentation-only changes to agent triage skills; no runtime library
or security-sensitive code paths are modified.
> 
> **Overview**
> Updates the shared **issue-classification** and **issue-priority**
agent skills so triage labels and severity rows stay consistent.
> 
> **Classification** now treats dependency issues (published or
unpublished CVE/GHSA) as **Security (vulnerability)** when the client
calls the affected code, narrows **authentication** to broken/missing
methods and credential handling (credential leaks are explicitly
**vulnerabilities**), and adds unpublished dependency findings to the
private-report checklist with guidance to contact upstream maintainers
privately.
> 
> **Priority** routes “make it faster” requests to **Cosmetic, docs,
feature** while **Workaround exists** applies only to performance
**defects**; dependency CVEs map to **Wrong data or security** when
vulnerable code is on the execution path, otherwise to a low-priority
dependency-update feature request.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
0a64bd3. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Polyglot AI <293096396+polyglotAI-bot@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants