Repository navigation
Conversation
…order convention (#2490) - ftp: order the helpers read() and make() call directly by first use: _test_lines and _decode_args (read), then _make_code (make). Pure move: member set, every member's AST and the comments are unchanged.
JarryShaw
added
refactor
This was referenced Nov 1, 2026
Owner
Author
|
Cross-review (Sonnet) of all four #2490 branches, this one at |
JarryShaw
added
review: good-to-go
This was referenced Nov 1, 2026
Contributor
|
Coverage: 93.94% (unit tier, Python 3.15,
Per-file detail: the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseconst— regenerates constant or registry tables, members keeping their numeric valuesDescription of your pull request and other information
Part of #2490. A pure reorder to
protocol-member-order.rst, coveringpcapkit/protocols/application/ftp.py. An AST check confirms the member set and every member body are unchanged; only the order differs. The narrow tests for each touched protocol pass. Files that other streams are editing now are deferred (DTLS, IGMPv3, IPX, OSPF, IPv4, TCP, SCTP, IP_Pseudo). Open questions about cases the page does not cover are posted on #2490.