Repository navigation
test(smoke): expect the Commonly AI page titles #2715 shipped - #2760
Conversation
#2715 renamed the pre-rendered SEO page titles from '| Commonly' to '| Commonly AI'. The kind smoke test still asserted the old strings, so every PR's kind cluster smoke test fails on /compare/. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uub7iKypiDa4iTWuc1oYZQ
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update expected SEO titles smoke-tests/run.js |
The expected titles for three public SEO routes now end in “Commonly AI”. Canonical URLs and headings remain unchanged. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix
Possibly related PRs
- Team-Commonly/commonly#2715: Updates the SEO page title suffix to “Commonly AI,” which the smoke test now expects.
Merge Risk: 
Minimal · up to a3f55
-
No actionable merge-blocking risk remains.
Pre-merge checks: 
4
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
lilyshen0722
left a comment
There was a problem hiding this comment.
Gate at head a3f5523 (not an earlier head). Verdict: PASS. The diff is test-only: smoke-tests/run.js, 3 lines in the SEO route table.
Titles match main's generator and content. I extracted origin/main frontend/, ran generateSeoPages() against a stub Vite shell in a temp directory, and read the emitted pages. Each of the three smoke expectations matches exactly:
/compare/:<title>Commonly vs the alternatives | Commonly AI</title>, canonicalhttps://commonly.me/compare/,<h1>Commonly vs the alternatives</h1>. Source:generate-seo-pages.mjs:477anden.jsoncompare.title./use-cases/agent-collab/:<title>Orchestrate secure, customizable multi-agent workflows | Commonly AI</title>, canonical matches, h1 matches. Source:generate-seo-pages.mjs:499(${useCase.title} | Commonly AI) anduse-cases.json./guides/multi-agent-collaboration-platform/:<title>Multi-Agent Collaboration Platform | Commonly AI</title>fromguides.jsontitleTag, h1What Is a Multi-Agent Collaboration Platform?fromtitle, canonical matches,og:type=articleand"@type":"Article"both present.
The smoke file has no other title expectation that still reads | Commonly. The check at line 114 is html.includes('<title>…</title>'), and it passes for all three.
The kind smoke test will not run on #2760. .github/workflows/smoke-test.yml runs on a pull request only when the diff touches k8s/**, the Dockerfiles, _external/clawdbot, dev.sh, or .github/workflows/**. This PR touches only smoke-tests/run.js, so no kind run is triggered and the required green cannot come from this PR's own checks. To get a kind result for this head, dispatch smoke-test.yml on fix/smoke-seo-titles-commonly-ai (workflow_dispatch is allowed). I did not dispatch it. The lead or press can decide that, and I did not treat it as a gate condition, because the title and h1 evidence above is at the source. I did not check the #2759 kind failure's cause; the three stale strings are what this PR changes.
CI at posting: Backend tests 1/3 to 3/3, Service Tests, CLI/MCP and CodeRabbit pending; Frontend tests and Backend typecheck and lint pass. The green wait is the press's.
Written by Rhea, a Commonly agent — https://commonly.me/v2/pods/6a8f6dc7a1dccf2e02f31015
GATE: PASS
The kind cluster smoke test fails on every open PR, including #2756 and #2759:
/compare/: missing page-specific title.#2715 renamed the pre-rendered SEO page titles from
| Commonlyto| Commonly AI(frontend/scripts/generate-seo-pages.mjs, andtitleTaginguides.json).smoke-tests/run.jsstill asserted the old strings. Main hasn't run this workflow since 2b0ea66, so the break only shows up on PRs.This updates the three expected titles to match what the generator emits on main. Nothing else changes.
Verify: the kind cluster smoke test on this PR goes green.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Uub7iKypiDa4iTWuc1oYZQ