Skip to content

design(d215): /v2/profile/:id frames at 1440 and 390 (TASK-757) - #3215

Closed
lilyshen0722 wants to merge 1 commit into
ux/task-757-activityfrom
ux/task-757-profile
Closed

lilyshen0722 wants to merge 1 commit into
ux/task-757-activityfrom
ux/task-757-profile

Conversation

@lilyshen0722

Copy link
Copy Markdown
Contributor

Written by Ux Lead, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf

TASK-757 item 9: draws /v2/profile/:id (a person's public profile) into the d215 artboard at 1440 and 390, light and dark.

Stacked on #3214 (which is stacked on #3209). Retarget to main as those merge.

States (3 surfaces, 32 → 38 targets): person (Follow, recent public posts, joined pods), nothing public yet, load failed.

Flags for Lily (non-blocking)

  • The live card prints user.email under the name on a public page. The frame shows the handle instead; if the email stays, it should be owner-only.
  • The live error is a red line with no way out. The frame adds a Retry key, the one addition here.
  • Own profile is not drawn: /v2/profile redirects to Settings, where the Overview / Apps / API Token / User Admin tabs live.

Measured (node cap/measure_after.js, targets.json regenerated, node --test cap/measure_after.test.js 10/10): helper words 5 / 14, scroll 1.0× at both sizes. No contrast or 44px exceptions: rows and chips are 44px at 390, 32px at 1440.

🤖 Generated with Claude Code

…led at 1440 and 390 (TASK-757)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-authored-by: ux-lead <WyJ1eC1sZWFkIiwiZGVmYXVsdCJd@agents.commonly.invalid>
Agent-Model: claude/claude-opus-5-5/high

@lilyshen0722 lilyshen0722 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX-GATE: PASS @ 7668541 — three profile frames render at 1440 and 390 in light and dark; copy matches the live page

Rendered all 12 frame/theme combinations and read them against UserProfile.tsx.

  • Copy lifted from the live page: "Recent public posts", "Joined pods", "No public posts yet.", "No joined pods to show.", "Member since … ago", Follow / Unfollow, "Failed to fetch user data. Please try again later."
  • Fit: every frame scrolls 1.0×. targets.json has 38 rows; node --test cap/measure_after.test.js 10/10.
  • Identity bar: one ink key (Follow), no icons on rows because the row is the key, 44px at 390 and 32px at 1440, no shadows, "pod" never "room". Contrast and 44px exceptions: none.
  • Deliberate departures, flagged in the PR: handle instead of email on a public card; Retry added to the error line.

Written by Ux Lead, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf

GATE: PASS

@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@lilyshen0722

Copy link
Copy Markdown
Contributor Author

Closing: the person profile frames on main came in with #3308 and are scored as profile-1440 and profile-390 (passing on prod since #3402 and #3412). The branch is kept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant