Repository navigation
spec(ml): eval_hslm mirrors train_hslm's 31 b3_* speed=3 scratch arrays (Closes #10906) - #10907
Merged
Merged
Conversation
…ys, unblocking it (Closes #10906) PR #10866 added tr3_* and the b3_* module-level arrays to train_hslm.t27. use_resolve splices no var, so eval_hslm, which reaches tr3_forward through tr_window_forward, was BLOCKED with: use of undeclared identifier 'b3_q'. Declare the same 31 arrays with the same names, types and sizes. Tests 10/10, 0 vacuous, seal saved and verified on the Railway lab. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Oct 19, 2026
Open
This was referenced Oct 19, 2026
Contributor
This was referenced Oct 19, 2026
gHashTag
enabled auto-merge (squash)
October 19, 2026 06:53
gHashTag
added a commit
that referenced
this pull request
Oct 19, 2026
) (#10913) * ledger(t27b): rows for six specs master carries unlisted, max_not_pass 129 -> 130 (Closes #10912) As the steward applies UNLISTED (specs/tri/t27b/ledger_steward.t27): four pass rows (mos_psp103_50c_data, sar_adc, sar_comparator_psp, tri/worktrees/reap) and two blocked rows, ExprCall(undeclared fn), reason unimplemented (eval_hslm, ngram_hslm -- the same blocker hslm_corpus already carries). Verdicts are the UNLISTED lines of the t27b runs of #10908, #10855, #10907 and #10836 on current master. Not-pass rows become 129 blocked + 1 codegen = 130, so the cap rises by one, within the two new non-pass rows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * ledger(t27b): drop the eval_hslm row, max_not_pass back to 129 (Closes #10912) The PR's own t27b run reported eval_hslm.t27 STALE: on current master the reference no longer compiles it (undeclared identifier 'b3_q' after a train_hslm change), and the steward lists only what the reference passes. Five rows remain (four pass, ngram_hslm blocked); not-pass rows are 128 blocked + 1 codegen = 129, the cap master had. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude <claude@anthropic.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10906
What
specs/ml/eval_hslm.t27was BLOCKED withuse of undeclared identifier 'b3_q'since #10866. That PR addedspeed=3totrain_hslm.t27: thetr3_*functions and 31 module-levelb3_*scratch arrays.use_resolvesplices novar, so a module that reachestr3_forwardthroughtr_window_forward(eval does, viatr_valid_loss) must declare the arrays itself, as eval already does foract_*,kv_*,bw_*.The fix is the mirror: the same 31
b3_*declarations (names, types, sizes copied fromtrain_hslm.t27lines 586-616), nothing else.speed_levelstays 2 in eval, so no evaluation number moves. The seal is re-saved.Evidence (Railway lab, master b258b90 + this diff)
t27c test-report specs/ml/eval_hslm.t27 --verbose: 10 tests, 10 pass, 0 fail, vacuous passes 0 of 10 (before:BLOCKED).t27c seal specs/ml/eval_hslm.t27 --save, then--verify: all hashes MATCH, exit 0.bootstrap/srcis identical to master's (git diff empty); a fresh build of this worktree was not possible because the lab's cargo cache lacks the locked sha2 0.10.9.docs/reports/t27b_expectations.jsonhas no row forml/eval_hslm, so the ledger is unchanged.Note for #10896
That PR turns the
nn/hslmandb3_*state intothreadlocal var. When it lands, theb3_*mirror here must follow the same form (and rebase before it); I checked #10896 is still open, so this PR mirrors master as it is now.🤖 Generated with Claude Code