Repository navigation
spec(port): port the padding key derivation uniqueness guard (Refs #8884) - #9755
Closed
dmitrii-f-t27 wants to merge 2 commits into
Closed
dmitrii-f-t27 wants to merge 2 commits into
dmitrii-f-t27 wants to merge 2 commits into
Conversation
…ashTag#8884) The thirty-first W2 target of the CR-CHAT-04 ring tracker: the key-uniqueness rules - the batch ceiling, then per derivation the empty-label probe, the key-length check, the zero-key probe, the strictly-increasing index and the repeated-key scan - as the D5 verdict with every payload field, the original's rule order, and all ten PKDU tests transcribed plus helper and rule-order tests. The original's Vec<u8> key becomes the fixed [32]u8 form plus its length, the String label becomes its length - the only property any rule reads. The BTreeSet dedup becomes a scan over the visited derivations; the boundary fixture's little-endian index bytes come out of the identity byte table, no narrowing anywhere. Checks (conventions 0-14): t27b test 12 passed 0 failed; t27c test-report 12/12, 0 vacuous; gen-rust output compiles under rustc; coverage Untested 0; ASCII only; seal saved, all hashes MATCH;
Contributor
Author
|
Merge request for the gHashTag merger: steward READY (required all SUCCESS — validate, check-linked-issue, parse-ratchet, t27b-native-linux, t27b-native-macos; the red ones are non-required per Q16 and red on master too). Ledger row included; one-line rebase if the earlier lane PRs land first — I take it on request. |
This was referenced Oct 17, 2026
Merged
Merged
Merged
…ave2-ad # Conflicts: # docs/reports/t27b_expectations.json
Contributor
Author
|
Superseded by #10175: the remaining CR-CHAT targets now land as one port-wave batch per specs/policy/pr_budget.t27 (#10067/#10074), which asks for one PR per ring batch instead of one per file. The spec body, seal and ledger row in this PR are unchanged there; the batch also carries one self-consistent duplicate-body bless. Closing this one-file PR keeps the merge queue and the Actions queue small. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #8884 (CR-CHAT-04 ring tracker). Parent epic: gHashTag/trios#1812 (W2, own lane, T-PORT). Thirty-first W2 target delivered: the key-uniqueness rules — batch ceiling (65536), per-derivation empty-label probe, key-length check (32), zero-key probe, strictly-increasing index (u64), repeated-key scan ([32]u8) — D5 verdict carrying got / bound / got64 for every variant (the offending index rides got64 for IndexNotIncreasing and ZeroKey), original rule order, all ten PKDU tests transcribed plus helper and rule-order tests (12 total, 0 vacuous). Vec key → fixed [32]u8 + its length (bytes stay; zero probe and dedup read them); String label → its length (the only property any rule reads); BTreeSet → visited-scan; the boundary fixture's LE index bytes come out of the identity byte table — no narrowing anywhere. t27b 12/12 native; t27c 12/12; gen-rust compiles under rustc (0 errors, 0 &'static str, 0 Vec<const); coverage Untested 0; seal all hashes MATCH; ledger row included (pass, non-pass untouched). Dedup checked. Sequencing: one-line ledger rebase if the earlier lane PRs land first — I take it on request.