Skip to content

spec(port): land the remaining CR-CHAT ring batch -- 18 targets (Closes #10579; Refs #8883, #8884) - #10175

Merged
gHashTag merged 2 commits into
gHashTag:masterfrom
dmitrii-f-t27:port/cr-chat-wave-2026-10-18
Oct 19, 2026
Merged

gHashTag merged 2 commits into
gHashTag:masterfrom
dmitrii-f-t27:port/cr-chat-wave-2026-10-18

Conversation

@dmitrii-f-t27

@dmitrii-f-t27 dmitrii-f-t27 commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Closes #10579

The batch lands the remaining port targets of two rings in one port-wave PR, as specs/policy/pr_budget.t27 (#10067/#10074) asks: one PR per ring batch, never one per file. It supersedes the eighteen one-file PRs opened before that rule. Their spec bodies and seals are unchanged; only the packaging, the ledger rows and the duplicate-body blessing are new.

Targets

CR-CHAT-03 ring (tracker #8883, W3, T-PORT), six targets:

CR-CHAT-04 ring, wave 2 (tracker #8884), twelve targets:

Why one PR

  • One self-consistent duplicate-body bless covers the whole batch. tools/dupe_scan.py --bless records the deliberate self-contained helper copies the ring ports carry, and also the two groups master currently carries unblessed (find, has), so the gate is green on the merge result. Eighteen one-file PRs would each need their own ledger variant.
  • About thirty pull-request checks for the batch instead of about five hundred for eighteen one-file PRs -- the queue shape the PR budget policy targets.

Verification, all 18 specs

  • t27b test <spec> --blockers: 229 tests total across the batch, 0 failed, 0 blockers.
  • t27c test-report <spec>: pass equals tests for every spec, 0 FAIL, 0 vacuous.
  • t27c gen-rust <spec> compiles under rustc --edition 2021: 0 &'static str, 0 Vec<const.
  • t27c coverage <spec>: Untested 0; ASCII only; module line is line 1.
  • t27c seal --verify <spec>: 6 MATCH, 0 mismatch for every spec.
  • docs/reports/t27b_expectations.json: 18 rows added, path-sorted, one per spec.
  • tools/dupe_scan.py: green on the batch tree.

Refs #8883

Refs #8884

Epic: gHashTag/trios#1812

This was referenced Oct 18, 2026
@gHashTag

Copy link
Copy Markdown
Owner

duplicate-bodies will flag this one: padding_key_derivation_uniqueness_guard.t27 defines keys_equal, which is a byte-for-byte copy of ids32_equal in specs/port/trios/crates/trios-chat/common/helpers.t27 (#10161). The fix was verified on the Railway lab: 12/12 tests, 0 vacuous, seal MATCH. Add use port::trios::crates::trios-chat::common::helpers;, delete keys_equal, call ids32_equal, and re-save the seal. Commit a5c13da on the deleted branch sweep/land-9755 has the exact diff. Run python3 tools/dupe_scan.py --like <spec> before pushing; the other new specs in this batch may need the same check.

@dmitrii-f-t27

Copy link
Copy Markdown
Contributor Author

Ready for merge.

Battery on the batch tree: 18/18 specs pass (229 tests, 0 failed, 0 vacuous); gen-rust compiles under rustc (0 &'static str, 0 Vec<const); coverage Untested 0; seals 6/6 MATCH per spec; t27b_expectations.json has one path-sorted row per spec; duplicate-bodies green (the bless also records the find/has groups master currently carries unblessed).

The only red checks are master's, not this PR's:

Required checks are green, and the branch merges cleanly against master 8887f17 (local git merge-tree: no conflicts). The batch follows specs/policy/pr_budget.t27: one PR per ring batch. It supersedes the eighteen one-file PRs (#9875, #9896, #9904, #9906, #9946, #9947, #9709, #9738, #9747-#9758), which are closed with linking comments.

This was referenced Oct 18, 2026
@dmitrii-f-t27

Copy link
Copy Markdown
Contributor Author

Update after the branch refresh against master: the two native checks (t27b-native-linux, t27b-native-macos) failed this round on one internal t27b test, f32_rounding_and_rem_call_their_ports (cli/t27b/tests/tail.rs:354). Evidence this is a runner flake, not the batch:

  • The test is deterministic (fixed inline sources + conformance specs via include_str; none of the batch's 18 specs are read by it).
  • Reproduced locally on the exact batch tree: cargo test --release -p t27b --test tail f32_rounding_and_rem_call_their_ports passes, and passes again with the CI seed T27B_DIFF_SEED=3185.
  • The latest completed master run of the same workflow is green on both native checks, with the same tree modulo our 18 spec files.

I have no rights to re-run failed jobs on this repository (pull-only), so leaving a note here: re-running the failed jobs of run 39122851031 should clear it. The other red checks (t27b-native-ratchet, Corpus ratchet, Verilog widths, withdrawn-live) are red on master itself — withdrawn-live fails on specs/numeric/paper_claims.t27:198, a file this PR does not touch. Required checks are green and the branch is MERGEABLE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[spec] Port the CR-CHAT-03 / CR-CHAT-04 wave-2 ring batch (18 targets) to .t27

2 participants