Repository navigation
spec(port): port the commit signature forgery guard (Refs #8883) - #9904
Closed
dmitrii-f-t27 wants to merge 2 commits into
Closed
dmitrii-f-t27 wants to merge 2 commits into
dmitrii-f-t27 wants to merge 2 commits into
Conversation
The third CR-CHAT-03 ring target (W3, L-CHAT-3-csig, R-CHAT-3, RFC 9420 6.1/12): the commit-signature binding rules, in the original's fixed order - the blob non-empty and non-zero (the lazy-verifier trap), the group agreement, the epoch agreement, the committer a current member, the signer key the stored leaf-public, and the ops hash the locally computed one - as the D5 verdict with the one payload pair (the current and claimed epochs of the epoch rule), the original's rule order, and all ten CSF tests transcribed plus helper and rule-order tests. The original's transcript and view structs become flat parameters, the signature blob arriving as a plain slice. The view's Option<[u8; 32]> committer key becomes a member flag plus the stored key - the sentinel convention. The transcript's sender leaf rides along unread by every rule, exactly as in the original. The original's tenth test is a tautology green summary (a count asserted against itself); this port replaces it with a live canonical gate call, the WPS-10 precedent, so no test passes vacuously. Checks (conventions 0-14): t27b test 13 passed 0 failed; t27c test-report 13/13, 0 vacuous; gen-rust output compiles under rustc; coverage Untested 0; ASCII only; seal saved, all hashes MATCH;
Contributor
Author
|
All required checks green (validate, check-linked-issue, parse-ratchet, t27b-native-linux, t27b-native-macos); cli-tri / duplicate-bodies / t27b-native-ratchet are the known non-required reds. Steward READY. Third CR-CHAT-03 target (3/47 T-PORT) — requesting owner merge when convenient, Refs #8883. |
This was referenced Oct 17, 2026
Merged
Merged
Merged
This was referenced Oct 17, 2026
spec(policy): l2_generation -- gen/json/ is t27c gen-json's backend directory (Closes #10079)
#10082
Merged
Merged
Merged
Merged
Merged
# Conflicts: # docs/reports/t27b_expectations.json
Contributor
Author
|
Superseded by #10175: the remaining CR-CHAT targets now land as one port-wave batch per specs/policy/pr_budget.t27 (#10067/#10074), which asks for one PR per ring batch instead of one per file. The spec body, seal and ledger row in this PR are unchanged there; the batch also carries one self-consistent duplicate-body bless. Closing this one-file PR keeps the merge queue and the Actions queue small. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The third CR-CHAT-03 ring target (W3, tracker #8883, epic gHashTag/trios#1812): port of
crates/trios-chat/rings/CR-CHAT-03/src/commit_signature.rs(Wave-24 Lane A, L-CHAT-3-csig, R-CHAT-3, RFC 9420 6.1/12).Every MLS Commit is signed by its committer leaf key. The forgery gate pins the binding invariants before the caller delegates to the real signature check. Rules, in the original's fixed order:
Carried as the D5 verdict — the one variant with payload (
EpochMismatch) carries the current and claimed epochs; the rest are unit codes.Adaptations (t27 conventions): transcript/view structs → flat parameters, the signature blob as a plain slice; the view's
Option<[u8; 32]>committer key → member flag + stored key (sentinel convention); the transcript'ssender_leafrides along unread by every rule, exactly as in the original. The original's tenth test is a tautology green summary (a count asserted against itself) — replaced with a live canonical gate call, the WPS-10 precedent, so no test passes vacuously.All 10 original CSF tests transcribed with exact asserts (CSF-09 is the original's own check-order invariant: with every other field also wrong, the empty signature is still the answer), plus helper tests and a full rule-order ladder stacking every later violation under each earlier rule (13 total).
Checks (conventions 0-14):
t27b test13 passed 0 failed, 0 blockers;t27c test-report13/13, 0 vacuous; gen-rust output compiles under rustc (0'static str, 0Vec<const); coverage Untested 0; ASCII only; seal saved, all hashes MATCH; ledger row added todocs/reports/t27b_expectations.json.Refs #8883