Skip to content

docs(rfc): screen 03 becomes a startup prune of sync-generated crewmates - #13032

Merged
CrysisDeu merged 1 commit into
mainfrom
docs/rfc-crewmates-screen-03-prune
Sep 23, 2026
Merged

CrysisDeu merged 1 commit into
mainfrom
docs/rfc-crewmates-screen-03-prune

Conversation

@CrysisDeu

@CrysisDeu CrysisDeu commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

docs/request-for-change/rfc-crewmates-launch.md (accepted) decides screen 03 as
a user-facing opt-in step: "lists the existing custom agents, pre-checked, with
two actions: Add N crewmates and Not now". The product owner replaced
that decision on 2026-09-23, and the implementing PR
(#12798) now ships a
startup migration with no UI. The First Principles lane reads product shape off
the base branch, so the RFC on main must say what was actually decided.

Why it matters

Until the RFC records the new decision, #12798 is blocked as a product-shape
change without an RFC, and the launch's decision record describes a screen
nobody is building.

What changed (motivation → approach → change)

Docs only, one file. The screen 03 section is replaced by the decision taken:

Was Is
One-time opt-in over the Crewmates page, Add N crewmates / Not now, shown when the person has custom agents and no crewmates No user-facing step. A one-time migration at gateway startup removes the crewmates an earlier sync generated (empty member_id, shared default store, bound to the person's own custom agent) that were never chatted with; chatted ones stay exactly as they are on their V1 binding; only the config row goes, agent files and transcripts stay; unreadable history removes nothing; a marker makes it run once
— A person with custom agents and no crewmate is served by screen 02's empty state and New crewmate (#12924)

One short paragraph records the reasoning: the generated rows are leftover
state, not a choice; a memory binding is identity and is not rewritten; no
screen to maintain; the removal drops nothing the person made, one click
re-enrols any agent. It also says what happens to a generated row the person
edited but never chatted with (removed with its edits; accepted, because the
row is the sync's and the crewmate is one click away) and that member-aware
edits stamping member_id take a row out of the rule.

Three references to the old step are updated so the RFC does not contradict
itself: the § 6 backward-compatibility bullet (config key → marker file), the
§ 7 acceptance bullet (now names exactly the rows § 03 removes — package-sourced
rows and chatted rows stay), and the #12798 entry in § 8. Every other line
of the RFC is byte-identical. The section names #12224 as the change that
removed the enrol-on-mount call the generated rows came from.

Backwards compatibility

Compatible: a documentation change.

Tests

N/A — docs only; scripts/docs_lint.py passes.

Manual verification

N/A — docs only.

Related Issues

no linked issue: amends the accepted launch RFC for #12798.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@CrysisDeu
CrysisDeu requested review from a team and chenmingwei23 September 23, 2026 07:53
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 23, 2026
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Intent: record in the accepted CrewMates launch RFC the decision the product owner took for screen 03 on 2026-09-23 — a one-time startup prune of sync-generated crewmates instead of a user-facing opt-in — so the First Principles lane reads the real product shape off main for #12798.
Not a goal: any change to the other eight screens, the vocabulary, or the RFC's provenance; any code.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 23, 2026
@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of 46ae3ed7c620ead912652e292687618bae2a1bab — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Verify the cited 2026-09-23 product-owner decision is actually on record — the RFC amendment carries no link or approver for it.

Suggestions

  • Have § 03 also decide that the prune logs each removed row (name + agent binding), so a person who misses an edited row can see what went and re-enrol it.

[DESIGN-REVIEWED] 46ae3ed

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5 Review — ✅ no blocking findings

Reviewed 46ae3ed7c620ead912652e292687618bae2a1bab — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 46ae3ed

Verdict parsed from the review's SHA-scoped output markers for commit 46ae3ed7c620ead912652e292687618bae2a1bab.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 46ae3ed7c620ead912652e292687618bae2a1bab: <one-sentence reason>

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 23, 2026
…ed crewmates

The CrewMates launch RFC decided screen 03 as a user-facing opt-in step. The product owner replaced that on 2026-09-23: crewmates an earlier sync generated are pruned once at gateway startup (never-chatted rows removed, chatted rows untouched on their V1 binding), with no UI; a person with custom agents and no crewmate is served by screen 02's empty state and New crewmate. Only the screen 03 section, its backward-compatibility bullet, its acceptance bullet and the #12798 entry in the PR list change.
@CrysisDeu
CrysisDeu force-pushed the docs/rfc-crewmates-screen-03-prune branch from 005d137 to 46ae3ed Compare September 23, 2026 09:02
@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of 46ae3ed7c620ead912652e292687618bae2a1bab and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 46ae3ed

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 46ae3ed7c620ead912652e292687618bae2a1bab: <one-sentence reason>

@CrysisDeu
CrysisDeu enabled auto-merge (squash) September 23, 2026 09:28
@CrysisDeu
CrysisDeu merged commit 2fdadc7 into main Sep 23, 2026
92 of 93 checks passed
@CrysisDeu
CrysisDeu deleted the docs/rfc-crewmates-screen-03-prune branch September 23, 2026 09:29
wknight1 pushed a commit to wknight1/KiroCrew that referenced this pull request Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: checking Automated validation is still running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant