Skip to content

feat(ui): glass search field floating over the session and crew lists - #14896

Merged
CrysisDeu merged 1 commit into
mainfrom
feat/glass-search-dock
Sep 29, 2026
Merged

CrysisDeu merged 1 commit into
mainfrom
feat/glass-search-dock

Conversation

@CrysisDeu

@CrysisDeu CrysisDeu commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The search field at the top of the Sessions sidebar and of the Crew Members roster wears the same Liquid Glass material as the composer, and the list scrolls under it the way the transcript scrolls under the composer dock.

This is the maintainer's own request from the design session that produced it: with the composer band and the mobile Settings capsule on glass since #14460 / #14568, he asked for the two list search fields to join, and for the list to scroll under them like the transcript under the composer — with the first row clear of the field at rest. Since #14460 / #14568 the composer band and the mobile Settings search capsule are glass; the two list panels still open with a solid, bordered input sitting on a strip of panel background above the rows. The two search fields are the one surface a user sees on every visit that has not joined the material.

Why it matters

The dashboard's chrome now reads as two generations side by side: a glass composer at the bottom of the chat and a flat bordered field at the top of the list next to it. Aligning the list panels closes that gap on the two surfaces every user looks at first.

Not a goal

  • No change to what the field does: search, clear, the sort/filter menu, the flat-view toggle and the filter chips keep their behavior, test ids and accessible names.
  • No change to the material's recipe (Glass.tsx, ui/liquid-glass.tsx, the --glass-* tokens).
  • The board (columns) lane's column strip does not scroll under the field; see the known limit below.
  • No new fallback path: the three solidifying fallbacks in index.css already address every .liquid-glass host.

What changed (motivation → approach → change)

One field, one component. Both lists already render their search row through components/SearchFilterBar.tsx (pinned by searchFilterBar.parity.test.tsx), so the change to the field is made once. The row's SearchInput is replaced by a <Glass variant="chip" radius={10}> pane hosting the lucide Search glyph, a transparent <input>, the clear button and the trailing controls at their existing offsets (the right-padding / clear-offset table is unchanged). The input carries no ring of its own (focus-cue-ok, saying where the cue lives): .glass-shadow:focus-within — the cue the composer and the Settings capsule already give — steps the tint opaque and darkens the side lines on focus, and under the three solidifying fallbacks the same rule draws the 2px accent outline.

Rounded, not a capsule. Both were built and photographed on the real app. The composer's 16px turns a 32px field into a pill; the rows under it are rounded-md boxes, and the pill read as a foreign shape among rectangles. 10px keeps the corner family of the rows while the material stays the composer's.

The list scrolls under it. A new components/ListDock.tsx wraps each list: the dock (search field, filter chips, the list-level notices that already sat between them and the rows) is absolute top-0 over the lanes, and the lanes fill the panel to its top edge. At rest nothing is under the glass: the dock's height comes from the existing hooks/useMeasuredHeight.ts (the composer's own strip measurement — a callback ref plus ResizeObserver, so ListDock adds no measurement code of its own) and is written to --list-dock-h on the wrapper; LIST_BODY_CLS (components/listShell.ts, the class both lists' scrollers wear) pads its top by that variable — pt-[var(--list-dock-h,0.5rem)], falling back to the recipe's own p-2 for a body mounted with no dock — and sets the same value as scroll-pt-[…], so a row brought in by scrollIntoView (the roster's deep-linked ?member= row, block: 'nearest') lands below the glass instead of under it. Measured on the built sidebar: pane bottom 125px, first row top 129px, so the first row starts 4px below the pane and only slides under it once the user scrolls. A chip row appearing or an error notice mounting grows the dock and the padding follows in the same frame. The dock wrapper is pointer-events-none with each direct child re-enabled, so the empty space beside a short chip row still reaches the row underneath.

Pinned folder headers pin on the dock's bottom edge. A sticky folder header offsets itself from the lane's padding edge by --folder-row-sticky-inset (index.css), which was the lane's own p-2. Under the dock the lane's padding is the dock's height, so with the old inset a pinned header sat 4px under the dock. The variable now reads var(--list-dock-pin-inset, 0.5rem) and ListDock sets it to 0: the header sits exactly on the dock's bottom edge whatever the dock's last block is — the shelf's 4px fade under a bare field, a chip row, a notice with no bottom margin — so it never tucks under the dock's surface and never leaves a clear strip the rows show through (measured: dock bottom 44px from the lane top, pinned header top 44px). playwright/sidebar-sticky-folder-header.spec.ts measures headers against that pin edge (the dock's bottom, or 0 with no dock over the lane) instead of the lane's top.

Nothing else starts under the dock. The two list-level notices that rendered above the lane switch (remote instances loading, remote read failed) moved into the dock with the other notices; the board lane's container pads its top by the dock height (the columns scroll on their own inside the strip), so its hidden-folders line and board error stay reachable.

The shelf stands on a scrim. The dock is two layers in two materials. The field is the glass pane — rows show through it blurred, which is the point. What hangs under it (the filter chips, the list-level notices) is translucent tint tuned for the solid panel it used to sit on (a chip fills at 10% of its colour, a notice at 10% danger), so rows sliding under them rendered text through text. ListDock now takes field and shelf separately and stands the shelf on .list-dock-shelf (index.css): the panel's own surface faded in over the first 8px below the pane — the same move as the composer's context shelf onto the page colour (.glass-shelf, #14887) — in the same surface tokens as the pinned folder header, so scrim, pinned header and card are one colour on every surface (kiro-light's --panel, the /embed/sessions host's --bg). With nothing on the shelf it is 0px tall and paints nothing. The two sidebar notices also take actionPlacement="below", ErrorNotice's own escape hatch for a ~300px host, so their message no longer wraps to a word or two per line beside the action column.

Pointer events follow what the eye sees. The dock wrapper is pointer-events-none, so the transparent margin around the field passes a click to whatever is under it; the glass field and every focusable in the band (button, link, input, select, textarea, a tabindex'd or role=button element) re-arm. The shelf re-arms as a whole: it is opaque, and a click on what reads as blank panel beside a chip must land inert rather than open a session the scrim hides — the first cut let it through, and the blind read named that as an invisible target. Both facts are hit-tested in CI: playwright/sidebar-glass-dock.spec.ts (the E2E gate) asserts on the Sessions sidebar and the roster that every focusable inside the dock is what elementFromPoint returns at its centre, and that the space beside the lone filter chip lands on the dock, not on a row — so a future shelf control that forgot to re-arm goes red in CI instead of dead-clicking in production. The capture harness runs the same two assertions for its screenshots. The dock sits at z-30, above a pinned folder header's FOLDER_ROW_STICKY_Z (20): a header being pushed off its pin by the next folder travels up through the band, and at z-10 its opaque surface painted over the glass.

Keyboard reveal counts from the padding edge. clearPinnedHeaders (chat/sessionRowNav.ts) re-aligns an arrow-key-focused row that block: 'nearest' left under the pinned header stack, by testing whether the row lies within the stack's height of the lane's top. With the dock the stack starts at the lane's scroll-padding edge, so the band is scroll-padding-top + margin; the test now adds the scroller's scroll-padding-top (0 with no dock). This is what the Playwright sticky spec's arrow-key claim caught on the previous head (row 4 landed 11px under the pinned header).

useMeasuredHeight survives StrictMode. The hook's only disconnect lived in a cleanup-only effect; under StrictMode (dev) React replays cleanup + effect on mount while the callback ref runs once, so the observer was dead after the first render and the height frozen at its mount value — the dock stayed at its search-row height while an error notice grew it to 211px (caught by the harness's padding assertion). The effect now re-attaches to the node it still holds; useMeasuredHeight.test.tsx renders the hook under <StrictMode> and requires exactly one live observer that still updates the height. Production was not affected (no replay), but every dev-server read of the composer's strip heights was.

Where it is mounted. ChatSidebar.tsx: the search row, the tag chip, the filter chip row and the seed / folders / columns / folder-sort / rename notices move into the dock; the four lanes (tree, conductor, flat, board) are the children. MembersPage.tsx: the search row, the aggregate filter chip, the star-error notice and the gone-member notice move into the dock; the roster <ul> is the child. Neither page changes what it renders, only where the dock sits.

Known limit. In the board lane the columns scroll individually inside a horizontal strip, so the lane pads its top by --list-dock-h instead and column headers start below the glass rather than scrolling under it. Making the columns scroll under the dock means restructuring the column strip, which is out of this PR's scope.

Backwards compatibility

Compatible: no API, storage or i18n key changes; every test id, accessible name and placeholder on the field is unchanged; LIST_BODY_CLS gains one utility with a fallback equal to its previous padding.

Tests

  • src/test/ListDock.test.tsx (new): the measured dock height lands in --list-dock-h, a later ResizeObserver callback updates it, the dock wrapper is click-through with its children re-enabled, and children render as siblings of the dock.
  • src/test/listShellParity.test.ts: the LIST_BODY_CLS pin updated to the new string.
  • src/test/useMeasuredHeight.test.tsx (new): under <StrictMode> exactly one observer survives the effect replay and a later resize still updates the height.
  • src/test/ChatSidebar.arrowNav.test.tsx: a row 60px into a lane with 44px scroll-padding-top and a 56px header stack is re-aligned; one at 104px is left alone.
  • src/test/ListDock.test.tsx: also pins the per-control pointer re-arming (no [&>*]), the z-30 band, and that the shelf slot carries the scrim class and holds what hangs under the field.
  • playwright/sidebar-glass-dock.spec.ts (new, browser gate): every focusable inside the dock hit-tests to itself on both lists; the space beside the filter chip lands on the inert shelf, not on a hidden row.
  • playwright/sidebar-sticky-folder-header.spec.ts (browser gate): pinned headers are measured against the pin edge — the glass field's bottom — on all three surfaces; the nested-offset, hand-off, opacity and arrow-key claims are unchanged.
  • searchFilterBar.parity.test.tsx and the two pages' existing tests are unchanged and still address the same ids and names.
  • Full suite not run locally by policy; CI is the runner.

Manual verification

  • website/scripts/capture-glass-search-dock.mjs (new; nothing in CI runs it) photographs the real SPA over the shared stubbed API on / and /members, dark and light, at rest, scrolled and while typing. It asserts a live backdrop-filter: blur() layer inside the field and that each scroller's top padding equals the dock's height. The roster fixture holds 24 crewmates so the Members scrolled frame is a real scroll, not a rest frame. Extra scenes photograph the dock's GROWN states over scrolling rows: the running-only filter chip (rest + scrolled; the space beside the chip is hit-tested to reach the row), a pinned folder header measured on the pane's bottom edge (glassBottom === headerTop), the remote-instances error notice in the Sessions dock, a refused star write's notice in the roster dock (the dock's height is asserted equal to the scroller's padding in every scene), and the board lane stepping below the field.
  • Blind new-user read of the round-1 frames (a sub-agent that saw the pixels first): search box recognisable (glyph 5.2:1 dark / 6.2:1 light), first row clear at rest (8px), focus state unambiguous without a ring, scroll-under reads as frosted glass with no seams. Its two asks folded here: the placeholder lifted from text-muted/50 to /70 (it now sits over scrolled rows), and a genuinely scrolled Members frame. Its "the Members pane is inset relative to the cards" read did not reproduce: measured on the built roster the pane and the row buttons share the same edges (x 245–491 at 1280 wide).
  • Static gates locally: tsc, eslint on the changed files, i18n:check, scripts/docs-lint.sh.

Screenshots / video

Sessions sidebar, dark — at rest (first row below the pane), scrolled (rows under the pane), typing:

Sessions sidebar at rest, dark
Sessions sidebar scrolled under the glass, dark
Sessions sidebar while typing, dark

Sessions sidebar, dark — the dock grown by an active filter chip, at rest and with rows scrolled under field and chip:

Filter chip in the dock at rest, dark
Filter chip in the dock, rows scrolled under, dark

Sessions sidebar — a pinned folder header sitting on the glass field's bottom edge while its folder scrolls (dark, light):

Pinned folder header on the glass edge, dark
Pinned folder header on the glass edge, light

List-level notices in the dock over scrolled rows — the Sessions remote-instances error, the roster's refused star write:

Remote instances error in the Sessions dock, dark
Star write refused, notice in the roster dock, dark

Board lane, dark — columns step below the field (declared limit):

Board lane below the dock, dark

Crew Members roster, dark — at rest and scrolled (24-crewmate roster, so the scroll is real):

Crew Members roster at rest, dark
Crew Members roster scrolled under the glass, dark

Light, and the full Members page

Sessions sidebar scrolled, light
Crew Members roster at rest, light
Members page, dark

Review dispositions (round 1 → this head)

  • GPT / Opus BLOCK, hand-rolled <svg>: fixed — lucide Search.
  • Focus Cue Gate: fixed — focus-cue-ok on the input naming .glass-shadow:focus-within as the cue.
  • Design CONCERN, scrollIntoView lands under the dock: fixed — scroll-pt-[var(--list-dock-h,0.5rem)] on LIST_BODY_CLS.
  • Opus, non-scroller children under the dock: fixed — pre-lane notices moved into the dock; board lane pads its container.
  • Opus, pinned folder header under the glass: fixed — --list-dock-pin-inset, spec updated to the pin edge.
  • First Principles, ListDock re-implements useMeasuredHeight: fixed — it uses the hook; className / testId props and the default export dropped.
  • First Principles, premise: the float is the maintainer's own request from the design session (see Motivation).
  • UX BLOCK, Members "scrolled" frame identical to rest: fixed — 24-crewmate fixture, real scroll.
  • UX Watch, fade rows out before they reach the glass: not taken. Rows showing blurred through the pane is the material's point and matches the composer (feat(ui): one glass dock for the composer band #14568), where the transcript scrolls under the dock the same way; a fade above the pane would leave the glass nothing to refract.

Review dispositions (round 2 → this head)

  • GPT BLOCK, Sessions feature-map row stale: fixed — the row names SearchFilterBar + ListDock and the floating geometry.
  • Opus, dock z-10 under a pushed pinned header: fixed — z-30.
  • Opus, arrow-key reveal band measured from the lane edge: fixed — band is scroll-padding-top + margin; unit case added; this is also the E2E red on the previous head (the sticky spec's arrow-key claim; the two "skipped" specs were its serial siblings, main is green).
  • Opus, [&>*]:pointer-events-auto re-arms the whole band: fixed — per-control re-arming; harness hit-tests the gap beside a chip.
  • UX BLOCK, no frames of the grown dock / pinned header / notices / board: fixed — six new scenes above; the notice scene surfaced the StrictMode measurement bug fixed here.
  • First Principles, premise: the maintainer's request is asserted in the description; a confirming comment from him on this PR is the requested record.

Review dispositions (round 3 → this head)

  • Opus, --list-dock-pin-inset hardcoded to the search row's gap so a notice as last block put the header 4px under the dock: fixed — the inset is 0 and the header pins on the dock's bottom edge for every last block; the shelf always paints its 4px fade under a bare field so that edge is soft, not a clear slot.
  • Opus, the covered-row band padding + margin overshot the header stack by the inset: fixed by the same change — with inset 0 the stack ends exactly at padding + margin.
  • Design CONCERN, the re-arm list is an allowlist a future control could miss: widened to every focusable (input / select / textarea / tabindex / role=button); the hit-tests are now a CI Playwright spec (sidebar-glass-dock.spec.ts) as well as the harness.
  • UX CONCERN, chips and notices at 10% alpha over scrolling rows read as text through text: fixed — the shelf under the field stands on the panel-surface scrim (see "The shelf stands on a scrim"); frames re-captured. Its suggestion actionPlacement="below" on the two sidebar notices: taken.

Review dispositions (round 4 → this head)

  • UX CONCERN, the opaque shelf forwarded clicks beside a chip to rows it hides: fixed — the shelf re-arms pointer events as a whole, so that click is inert; the harness assertion and the CI spec now require exactly that.
  • Opus, the glass field has no edge where the material solidifies (no backdrop-filter, reduced transparency): already true on the base after fix(ui): fade the context shelf onto page colour; drop the composer's accent focus #14887, whose solidify blocks draw .liquid-glass { outline: 1px solid var(--border) }; this branch is rebased onto it and the field inherits the edge.
  • Design CONCERN, the hit-tests lived only in the manual harness: fixed — playwright/sidebar-glass-dock.spec.ts runs them in the E2E gate.
  • Frames re-captured on the rebased head so they show the retuned material from fix(ui): fade the context shelf onto page colour; drop the composer's accent focus #14887.

Review dispositions (round 5 → this head)

  • Opus, the grown dock's opaque shelf (z-30) sat above the sidebar / roster resize grip (z-10) and took the inner half of its 6px strip: fixed — both grips move to z-40, above the dock.
  • Backend Tests (Windows) shard 4 red on bebaaccf71: test_diag_procs::test_a_read_refused_as_too_soon_does_not_restart_the_window, a 0.8s timing floor on a shared runner; this PR touches no backend file.

Related Issues

Follows #14460 and #14568 (the composer and the mobile Settings capsule).

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@CrysisDeu
CrysisDeu requested a review from a team September 29, 2026 01:42
@CrysisDeu
CrysisDeu requested a review from a team as a code owner September 29, 2026 01:42
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 29, 2026
@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of 8be2dc3f1a287bee7727c69bf8f9fa14b5516cd9 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Verify the /embed/sessions host once by eye — the scrim rides --folder-row-sticky-bg there, but no capture scene photographs that surface.

[DESIGN-REVIEWED] 8be2dc3

Description read

[DESCRIPTION-READ] ebc526c8769f71b171e8c8e65d0f250934f61b27b237458bec2ca1afa26f86a6

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of 8be2dc3f1a287bee7727c69bf8f9fa14b5516cd9 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 8be2dc3

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 8be2dc3f1a287bee7727c69bf8f9fa14b5516cd9: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — 🟡 CONCERNS

Premise-level review of 8be2dc3f1a287bee7727c69bf8f9fa14b5516cd9 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: CONCERNS

The restyle's only checkable support is symmetry with the composer; the maintainer's design-session request exists nowhere but this description.

Not justified as shipped

  • Item 1 — inherited: the named harm is the twin — "the dashboard's chrome now reads as two generations side by side" — and the deciding fact, "the maintainer's own request from the design session," is asserted only by the description, so nothing checkable supports a look every returning user relearns.
    Clears when: the design-session request is pointed at (a linked issue or discussion), or a maintainer confirms it on this PR.

What this change ships

Inventory (10 items) — 9 justified

Intent: make the two list search fields wear the composer's Liquid Glass and let the rows scroll under them — an ADDITION (a restyle; behavior, test ids and names preserved).

  1. Both lists' search row is a glass pane floating over the rows, which scroll under it (first row clear at rest) — inherited: harm named only relative to the composer twin; request unrecorded.
  2. Filter chips and list-level notices ride the dock on an opaque scrim shelf; clicks beside them land inert — justified
  3. The two remote-instance notices moved up into the dock — justified
  4. Pinned folder headers now pin on the dock's bottom edge, not the lane top (spec rewritten to the new pin edge, declared) — justified
  5. The two sidebar notices' action button moved below the message (named wrapping harm in a ~300px host) — justified
  6. The board lane steps below the dock instead of scrolling under it (declared limit) — justified
  7. Keyboard- and deep-link-scrolled rows land below the dock, not under it — justified
  8. Both panels' resize grips raised above the dock (z-40) — justified
  9. Dev-only: measured strip heights no longer freeze after StrictMode's effect replay (fixes the composer's 3 existing useMeasuredHeight consumers too, with a regression test) — justified
  10. New hit-test E2E spec plus a capture harness (656 sibling capture-*.mjs scripts; the house pattern) — justified

Counted: ListDock 2 consumers (ChatSidebar, MembersPage); SearchInput keeps ~20 consumers elsewhere, so no dead code; useMeasuredHeight 3 consumers beyond the dock.

[FIRST-PRINCIPLES-REVIEWED] 8be2dc3

Description read

[DESCRIPTION-READ] e5418546ec843f80da278fe3c305e9155fd66b111934671990cc95d57d53dcbe

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — ✅ PASS

UX-level review of 8be2dc3f1a287bee7727c69bf8f9fa14b5516cd9 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Typing/focused state was captured only in dark (shot-03); verify the opaque-tint focus cue and clear button stay legible on kiro-light.

[UX-REVIEWED] 8be2dc3

Description read

[DESCRIPTION-READ] f4791954451ca146f1aaa3f993ddfc05da3c9266c8c2916f1ffd0f36755edff3

That sha256 names everything this verdict read: the PR description, plus the 18 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5 Review — ✅ no blocking findings

Reviewed 8be2dc3f1a287bee7727c69bf8f9fa14b5516cd9 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 8be2dc3

Verdict parsed from the review's SHA-scoped output markers for commit 8be2dc3f1a287bee7727c69bf8f9fa14b5516cd9.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 8be2dc3f1a287bee7727c69bf8f9fa14b5516cd9: <one-sentence reason>

@CrysisDeu
CrysisDeu force-pushed the feat/glass-search-dock branch from aadfcb7 to d84c17d Compare September 29, 2026 02:15
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 29, 2026
@CrysisDeu
CrysisDeu force-pushed the feat/glass-search-dock branch from d84c17d to 0b3da02 Compare September 29, 2026 02:56
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 29, 2026
@CrysisDeu
CrysisDeu force-pushed the feat/glass-search-dock branch from 0b3da02 to d93dda4 Compare September 29, 2026 03:34
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 29, 2026
@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 29, 2026
@CrysisDeu
CrysisDeu force-pushed the feat/glass-search-dock branch 2 times, most recently from a345b9f to 778ce98 Compare September 29, 2026 06:48
@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Sep 29, 2026
@CrysisDeu
CrysisDeu force-pushed the feat/glass-search-dock branch from 778ce98 to bebaacc Compare September 29, 2026 07:28
The Sessions sidebar and the Crew Members roster share one search row
(SearchFilterBar). It was a solid bordered input sitting above the list;
it is now a Liquid Glass pane (the composer's material, chip recipe, 10px
radius) that floats over the list inside a new ListDock, and the rows
scroll under it the way the transcript scrolls under the composer dock.

At rest nothing is under the glass: ListDock measures its own height
(search field, filter chips, list-level notices) with a ResizeObserver
and writes it to --list-dock-h, and LIST_BODY_CLS pads every list body's
top by that much, so the first row starts 4px below the pane and only
slides under it once the user scrolls. The dock wrapper is click-through
between its children so the row beside a short chip row stays reachable.

The input inside the pane is transparent and carries no ring of its own:
.glass-shadow:focus-within (the composer's and the Settings capsule's
cue) steps the tint opaque and darkens the side lines on focus.

Known limit: in the board (columns) lane the column strip pads its top
by the dock height instead, so column headers start below the glass and
do not scroll under it.
@CrysisDeu
CrysisDeu force-pushed the feat/glass-search-dock branch from bebaacc to 8be2dc3 Compare September 29, 2026 08:03
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Sep 29, 2026
@CrysisDeu
CrysisDeu merged commit 48b040c into main Sep 29, 2026
97 checks passed
@CrysisDeu
CrysisDeu deleted the feat/glass-search-dock branch September 29, 2026 08:55
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Sep 29, 2026
iamwhatever pushed a commit that referenced this pull request Sep 29, 2026
…#14995)

The dock shipped in #14896 ended 4px under the pane: the search row kept
its pb-1, and a bare field's shelf still painted a 4px scrim fade. A row
scrolling under the dock therefore emerged through a strip of a third
tone between the blurred glass and the sharp list, and that strip read as
a leftover box behind the pane.

The pane's bottom edge is now the dock's edge. The search row drops its
bottom padding, the shelf hides when empty (the roster's star-error
wrapper mounts only while there is an error, so it does not hold the
shelf open), and the 4px rest gap between dock and first row moves into
the measured variable: ListDock publishes --list-dock-h as its height
plus the gap and --list-dock-pin-inset as the gap, so the lane pads and
scroll-pads to dock + 4 while a pinned folder header still sits exactly
on the dock's bottom edge. The keyboard-reveal band subtracts the inset
too, so it ends where the header stack ends instead of 4px past it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant