Repository navigation
fix(onboarding): keep chapter footer on screen on narrow viewports - #14911
Conversation
On a phone the onboarding aside stacks above the step and the scrim scrolls. The panel was sized with 100vh (the LARGE viewport on iOS Safari) and the section assumed a 248px aside, so a taller aside pushed the step's Next / Not now buttons below the fold and under the browser toolbar. Pin the footer with position: sticky (the panel clips with overflow-clip, since overflow-hidden would become its scrollport), size with svh, and pad the footer bottom by the safe-area inset.
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Confirm on a physical iPhone that [DESIGN-REVIEWED] c843f09 Description read[DESCRIPTION-READ] 738aa9dceb343aa08c46bd217ffce4268698c878b058af777f6b683bd7393047 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Fable 5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Verify on a physical iPhone: the description admits Chromium cannot emulate Safari's large-viewport Not justified as shipped
What this change shipsInventory (9 items) — 6 justifiedIntent: FIX — on a phone, every onboarding chapter's Next / Not now buttons stay visible instead of hiding under the browser toolbar.
No prior test pinned [FIRST-PRINCIPLES-REVIEWED] c843f09 Description read[DESCRIPTION-READ] caf31ce667c071eb4d02740fb0d890a5ab47a1277b132baa9c875ec4396611a8 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Fable 5) — ✅ human override accepted@buluoray overrode this lane for |
The sticky footer sat flush against the scrolling list in the same bg-card, so a sliced row read as content cut off rather than a list scrolling under a bar; a top border on narrow viewports marks the edge. The Kiro CLI setup gate composes the same stacked panel and had the same off-screen footer. The pinned behaviour is now one PINNED_FOOTER_CLASS next to PANEL_CLASS / SECTION_CLASS, used by the chapter footer and the gate's, each adding its own padding and safe-area bottom inset. The i18n strict lint read the panel class string as prose once this branch touched its line, tripped by the min(...,calc(...)) arbitrary value. sm:h-[calc(100vh-48px)] sm:max-h-[760px] is the same height.
a0b43d6 to
c843f09
Compare
|
Opus 5 Review — ✅ no blocking findingsReviewed Review detailsThe pinned footer is lifted by the section's stale FINDING — website/src/components/OnboardingChapterShell.tsx:106 — [OPUS-REVIEWED] c843f09 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
|
|
/ai-review override ux c843f09: The earlier UX block on this head was a missing narrow-viewport screenshot of the Kiro CLI setup gate; the description now carries it (390x664, footer fully on screen) and UX re-reviewed this head as PASS. |
Human judgment recorded@buluoray marked the ux AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Problem / Motivation
Goal: On a phone, every onboarding chapter's Next / Not now buttons are visible without being hidden behind the browser toolbar.
On iOS Safari the Meet CrewMates chapter (and every chapter sharing
OnboardingChapterShell) renders its footer buttons below the fold: only the top edge of "Not now" / "Next" peeks out under the Safari toolbar.Why it matters
A first-run user on a phone sees a chapter with no visible way forward and has to discover that the overlay scrolls. It is the first screen of the crewmates feature.
Not a goal
sm:layout, which is unchanged.What changed (motivation → approach → change)
min-h-screen(100vh — the LARGE viewport on iOS Safari) and the sectionmin-h-[calc(100vh-248px)]assumed a 248px aside; the real aside is taller once its copy wraps, so the footer sits past the visible bottom, and 100vh adds the toolbar's height on top.OnboardingChapterShell.tsx, mobile classes only):sticky bottom-0 bg-card(sm:static), so it stays pinned to the bottom of the scrolling scrim while the body scrolls under it;overflow-hidden→overflow-clip— a hidden ancestor becomes the sticky element's scrollport and stops it pinning (website/docs/narrow-viewport.md);100vh/min-h-screen→svh, per the same doc;max(1.5rem, env(safe-area-inset-bottom))to clear the home indicator / floating toolbar.PINNED_FOOTER_CLASSbesidePANEL_CLASS/SECTION_CLASS, used by the chapter footer AND the Kiro CLI setup gate's footer (KiroPrerequisiteGate.tsx), which composes the same stacked panel and had the same off-screen actions;sm:h-[min(760px,calc(100vh-48px))]is rewritten as the equivalentsm:h-[calc(100vh-48px)] sm:max-h-[760px]: once this PR touched that line, the i18n strict lint read themin(…,calc(…))string as prose.The shared class constants also feed
KasLoginGateandKiroPrerequisiteGate; both get the samesvh+overflow-clip, and the gate's footer is pinned too. No visual difference on desktop.Backwards compatibility
Compatible: CSS classes only; no props, keys or APIs change.
Tests
OnboardingChapterShell.test.tsx: pins the sticky footer + safe-area inset, and that the mobile panel/section classes never use100vh/min-h-screen/overflow-hidden. Both tests fail against the pre-fix source (mutation-checked).KiroPrerequisiteGate.test.tsx: the gate's footer carries the pinned classes and the safe-area inset.safeArea.guard,MeetCrewmatesFlow, onboarding and gate suites pass (13 files / 168 tests);tscand eslint clean.Manual verification
Throwaway
--test-modegateway from this worktree, Chromium mobile emulation at 390×664 CSS px (iPhone width, height minus Safari chrome), Meet CrewMates opened via its reopen event:Not verified on a physical iPhone; Chromium cannot emulate Safari's large-viewport 100vh or a non-zero safe-area inset.
Screenshots / video
Kiro CLI setup gate, same stacked panel, at 390×664 with the prerequisite read stubbed as "CLI not installed": the footer box is y=591, height 73, fully on screen, pinned over the scrolling setup steps.
Related Issues
N/A — reported from a device screenshot.
Pattern harvest
Rule candidate: lint
Pattern:
min-h-screen/100vhon a mobile full-screen surface (should besvh/dvh), already described inwebsite/docs/narrow-viewport.mdbut not enforced.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement