Skip to content

feat(crewmates): show meet crewmates until seen, on first page visit too - #14914

Merged
iamwhatever merged 2 commits into
mainfrom
feat/crewmates-page-auto-meet
Sep 29, 2026
Merged

iamwhatever merged 2 commits into
mainfrom
feat/crewmates-page-auto-meet

Conversation

@buluoray

@buluoray buluoray commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The Meet CrewMates intro shows by itself the first time a user opens the Crewmates page, instead of only behind a button.

Today the chapter auto-fires only at the end of the first-run tour, and only for a workspace with no custom agents. Anyone else (an existing user, or a user with custom agents) lands on an empty Crewmates page and has to notice and click the small "Meet CrewMates" button to see the intro.

Why it matters

The Crewmates page is where people go to learn what a crewmate is. Most existing users never see the guided intro that creates their first crewmate because it is hidden behind a secondary button.

Not a goal

  • Changing when the tour-end auto-fire happens (its pending-mark timing stays).
  • Changing the flow's steps or copy.
  • The onboarding footer cut-off on phones (separate PR, #14911).

What changed (motivation → approach → change)

  • Symptom: first visit to /members with no crewmate shows only the empty state and a "Meet CrewMates" button.
  • Approach: the page tells the host it was entered, and the host (useMeetCrewmatesGate, the single owner of the flow's open state and its once-per-workspace rule) decides whether the flow is still due. The page itself never opens the flow directly.
  • Change:
    • Having seen the flow is the only condition on showing it. The gate no longer reads the roster or the installed agents, so existing crewmates and custom agents no longer suppress it, whether at the end of the tour or on the Crewmates page.
    • MembersPage dispatches mc-crewmates-page-entered on every visit. The gate opens the flow when first run is done and crewmates_onboarded is not set on the server. The entry is remembered, so a reload straight into /members still works even if the page loads before the theme boot.
    • useTheme exposes crewmatesFlowSeen (the server's crewmates_onboarded, plus its local cache). The existing crewmatesOnboarded can't be reused for the page path: it also counts an existing user as done.
    • The tour-end path keeps its mc-crewmates-pending timing, so an existing workspace isn't interrupted on its next load; it gets the flow on its first Crewmates page visit instead.
    • With the reads gone, the eligibility-read failure notice (MeetCrewmatesEligibilityNotice) has nothing to report, so it's removed, along with its two strings in all 13 locales.
    • Dismissing or completing persists crewmates_onboarded as before.
    • Specs updated: docs/system-specs/modules/config.md (Meet CrewMates first-run state) and the feature map. The decision itself is recorded as a dated screen 08 amendment in docs/request-for-change/rfc-crewmates-launch.md (this PR added to its implementation-prs), which supersedes the custom-agent exclusion.

Relates to screen 08 in docs/request-for-change/rfc-crewmates-launch.md, which decides the flow's content but not its trigger timing.

Backwards compatibility

Compatible: one added field on the theme context, and one added window event. Existing events, flags and the tour-end trigger are unchanged.

Tests

  • useMeetCrewmatesGate.test.tsx: the flow opens after the tour even with crewmates and a custom agent present, and neither roster nor agents are read. On page entry it opens for an existing user with crewmates and custom agents, and doesn't reopen on a second visit after dismissing. It doesn't open when the server says it was seen. An entry announced before the theme boot lands still opens it. It doesn't cover first-run chapters that are still running. Page-path cases fail if the gate uses crewmatesOnboarded instead of crewmatesFlowSeen (mutation-checked). The old "does not open when a crewmate / custom agent exists" and eligibility-notice cases are removed with the behaviour.
  • MembersPage.test.tsx: the page announces the visit with and without crewmates.
  • 31 related files / 718 tests and the 55 i18n test files pass; tsc, eslint and docs-lint are clean.

Manual verification

Ran a throwaway --test-mode gateway from this worktree. The workspace was already onboarded (no crewmates_onboarded) with the Crew Members preview on. Chromium ran at 390×664 and opened chat, then /members, with no clicks.

  • before (origin/main): /members shows the empty state and the "Meet CrewMates" button, and no flow opens;
  • after: the Meet CrewMates flow opens by itself on /members. Chat showed no dialog (0 dialogs), so the flow doesn't pop outside the page.

Screenshots / video

Before After
before: empty Crewmates page, flow only behind the button after: Meet CrewMates opens by itself on first visit

(The cut-off footer in "after" is fixed separately in #14911; this branch is based on main. The shots come from the first commit; the second only widens who sees this same surface, which the unit tests cover.)

Related Issues

N/A — product request.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

@buluoray
buluoray requested a review from a team September 29, 2026 03:26
@buluoray
buluoray requested a review from a team as a code owner September 29, 2026 03:26
@buluoray
buluoray requested a review from kyleseaman September 29, 2026 03:26
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 29, 2026
@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of cd6440d7c429b76adb2fb23ac5ddc37d404ae900 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Confirm the product owner actually made the 2026-09-28 screen 08 amendment this PR itself writes into rfc-crewmates-launch.md — it reverses the recorded custom-agent exclusion.

[DESIGN-REVIEWED] cd6440d

Description read

[DESCRIPTION-READ] 629acf234a4b1fb000894a8dbbab518860bb076471d2068fc0b0f3b040ad757b

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@buluoray

buluoray commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor Author

Scope update requested by the product owner: having seen Meet CrewMates is the only condition on showing it. Custom agents and existing crewmates no longer suppress it, at the tour end or on the Crewmates page. I edited the frozen Not a goal line to match, since it previously excluded the custom-agent rule. The Goal line is unchanged. Squashed into 8c166f1.

@buluoray buluoray changed the title feat(crewmates): open meet crewmates on the first crewmates page visit feat(crewmates): show meet crewmates until seen, on first page visit too Sep 29, 2026
@buluoray
buluoray force-pushed the feat/crewmates-page-auto-meet branch from 5117834 to 8c166f1 Compare September 29, 2026 03:41
@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of cd6440d7c429b76adb2fb23ac5ddc37d404ae900 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] cd6440d

False positive or not applicable? A repository writer can comment:
/ai-review override gpt cd6440d7c429b76adb2fb23ac5ddc37d404ae900: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — ✅ human override accepted

@buluoray overrode this lane for cd6440d7c429b76adb2fb23ac5ddc37d404ae900 via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — 🟡 CONCERNS

UX-level review of cd6440d7c429b76adb2fb23ac5ddc37d404ae900 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

Auto-opened flow's footer buttons are cut off at phone width — the blind reader "would not click these" — until #14911 lands.

Watch

  • Merge-order trap: this PR flips the flow from opt-in (button click) to auto-shown on every first /members visit, but at 390px shot-02's Back/Next buttons render as unreadable slivers — the blind reader said "I would not click these as shown… I can't read what I'd be agreeing to." Every phone user's first visit lands inside an overlay whose exit controls they cannot read; once per user, but it is the feature's entire entry moment. Land fix(onboarding): keep chapter footer on screen on narrow viewports #14911 first (or rebase this on it) so the auto-opened surface ships with a readable footer.

[UX-REVIEWED] cd6440d

Description read

[DESCRIPTION-READ] 678a9dfa5c6bb5852b74e17bac6fe5c77fc48d360d7dfda47bedb918e5ac3a23

That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 29, 2026
@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5 Review — ✅ no blocking findings

Reviewed cd6440d7c429b76adb2fb23ac5ddc37d404ae900 — this comment is updated in place on each push.

Review details

No blocking findings; two advisory.

FINDING — website/src/pages/members/MembersPage.tsx:709 — the mount effect fires window.dispatchEvent(new Event(CREWMATES_PAGE_ENTERED_EVENT)) on every visit with no target or preview check, so a deep link from the ungated Settings surfaces (AgentTemplatesTab.tsx:726 and MemberMemoryPanel.tsx:131 both navigate('/members?member=…'), neither reads PREVIEW_CREW) makes pageEntryDue open the portalled full-scrim four-step chapter over the crewmate the user asked to open, on a workspace that never enabled the crew preview → Fix: in that effect, dispatch only when the visit carries no ?member= target and usePreviewFlag(PREVIEW_CREW) is on.

FINDING — website/src/i18n/locales/en.json:4922 — dropping the roster/custom-agent conditions makes "step2_title": "Name your first crewmate" reachable for a workspace that already has crewmates (the PR's own gate test asserts the flow opens with Radar on the roster), so the step tells a user with N crewmates this is their first → Fix: pick the step-2 heading on whether the roster already holds a crewmate, adding the second key alongside step2_title in the locale files this PR already edits.

[OPUS-REVIEWED] cd6440d

Verdict parsed from the review's SHA-scoped output markers for commit cd6440d7c429b76adb2fb23ac5ddc37d404ae900.

False positive or not applicable? A repository writer can comment:
/ai-review override fable cd6440d7c429b76adb2fb23ac5ddc37d404ae900: <one-sentence reason>

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 29, 2026
@buluoray

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 7caf299: Product owner decision: whether the workspace has seen Meet CrewMates is the only condition on showing it, so custom agents and existing crewmates no longer suppress it, superseding the custom-agent exclusion in rfc-crewmates-launch.md.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@buluoray marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for 7caf2998726bc1618d0a61f9e9ca59de87bf2255.

Product owner decision: whether the workspace has seen Meet CrewMates is the only condition on showing it, so custom agents and existing crewmates no longer suppress it, superseding the custom-agent exclusion in rfc-crewmates-launch.md.

This decision applies only to this commit. A new push requires a new judgment.

Meet CrewMates only auto-fired at the end of the first-run tour, and
only for a workspace with no crewmates and no custom agents, so most
users reached the Crewmates page and had to find a button to see it.

Having seen the flow is now the only condition on showing it. The gate
no longer reads the roster or the installed agents, and the Crewmates
page announces each visit, so the flow opens on the first one unless
the server's crewmates_onboarded is already set. useTheme exposes that
record as crewmatesFlowSeen, because crewmatesOnboarded also counts an
existing user as done, and that user is exactly who this path is for.
The tour-end path keeps its pending-mark timing, so an existing
workspace is not interrupted on its next load.

With the eligibility reads gone, the notice for their failure has
nothing to report, so it is removed with its two strings.
Meet CrewMates now opens by itself on the first Crewmates page visit to
a workspace that has not seen it, so its dialog covered the member-memory
spec's clicks on /members. The Playwright auth setup already pre-sets the
first-run tour's flag; it now sets the chapter's render cache too, and the
GUI user-test seed marks dashboard.crewmates_onboarded for the same reason.
@buluoray

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles cd6440d: Product owner decision: whether the workspace has seen Meet CrewMates is the only condition on showing it, so custom agents and existing crewmates no longer suppress it; recorded as the screen 08 amendment in rfc-crewmates-launch.md in this PR.

@buluoray
buluoray force-pushed the feat/crewmates-page-auto-meet branch from 7caf299 to cd6440d Compare September 29, 2026 04:30
@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@buluoray marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for cd6440d7c429b76adb2fb23ac5ddc37d404ae900.

Product owner decision: whether the workspace has seen Meet CrewMates is the only condition on showing it, so custom agents and existing crewmates no longer suppress it; recorded as the screen 08 amendment in rfc-crewmates-launch.md in this PR.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: First Principles Review. Re-run the lane's latest workflow run for cd6440d7c429b76adb2fb23ac5ddc37d404ae900 manually from the Actions tab.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 29, 2026
@buluoray

Copy link
Copy Markdown
Contributor Author

UX Review CONCERNS on cd6440d — dispositions

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention labels Sep 29, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. The gate now keys only on whether this workspace has seen the flow; MembersPage announces every visit and the host decides. No security/auth touch; tests cover entry before theme boot, the server seen flag and first-run in progress.

Two non-blocking notes:

  • website/src/hooks/useMeetCrewmatesGate.ts (~84-92): pageEntered is set once and never reset. A user who visits /members before first-run or theme boot completes and then navigates away will get the flow on whatever page they are on when the conditions turn true. Clearing the flag on unmount (or checking the current route) would keep the 'never pops outside the page' claim exact.
  • website/src/components/MeetCrewmatesFlow.tsx:45-51: the JSDoc still says the event fires 'once its roster has loaded and holds no crewmate'; the code fires it on every mount.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants