Repository navigation
feat(crewmates): show meet crewmates until seen, on first page visit too - #14914
Conversation
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Confirm the product owner actually made the 2026-09-28 screen 08 amendment this PR itself writes into [DESIGN-REVIEWED] cd6440d Description read[DESCRIPTION-READ] 629acf234a4b1fb000894a8dbbab518860bb076471d2068fc0b0f3b040ad757b That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
|
Scope update requested by the product owner: having seen Meet CrewMates is the only condition on showing it. Custom agents and existing crewmates no longer suppress it, at the tour end or on the Crewmates page. I edited the frozen Not a goal line to match, since it previously excluded the custom-agent rule. The Goal line is unchanged. Squashed into 8c166f1. |
5117834 to
8c166f1
Compare
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
First Principles Review (Fable 5) — ✅ human override accepted@buluoray overrode this lane for |
UX Review (Fable 5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS Auto-opened flow's footer buttons are cut off at phone width — the blind reader "would not click these" — until #14911 lands. Watch
[UX-REVIEWED] cd6440d Description read[DESCRIPTION-READ] 678a9dfa5c6bb5852b74e17bac6fe5c77fc48d360d7dfda47bedb918e5ac3a23 That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5 Review — ✅ no blocking findingsReviewed Review detailsNo blocking findings; two advisory. FINDING — website/src/pages/members/MembersPage.tsx:709 — the mount effect fires FINDING — website/src/i18n/locales/en.json:4922 — dropping the roster/custom-agent conditions makes [OPUS-REVIEWED] cd6440d Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
|
/ai-review override first-principles 7caf299: Product owner decision: whether the workspace has seen Meet CrewMates is the only condition on showing it, so custom agents and existing crewmates no longer suppress it, superseding the custom-agent exclusion in rfc-crewmates-launch.md. |
Human judgment recorded@buluoray marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Meet CrewMates only auto-fired at the end of the first-run tour, and only for a workspace with no crewmates and no custom agents, so most users reached the Crewmates page and had to find a button to see it. Having seen the flow is now the only condition on showing it. The gate no longer reads the roster or the installed agents, and the Crewmates page announces each visit, so the flow opens on the first one unless the server's crewmates_onboarded is already set. useTheme exposes that record as crewmatesFlowSeen, because crewmatesOnboarded also counts an existing user as done, and that user is exactly who this path is for. The tour-end path keeps its pending-mark timing, so an existing workspace is not interrupted on its next load. With the eligibility reads gone, the notice for their failure has nothing to report, so it is removed with its two strings.
Meet CrewMates now opens by itself on the first Crewmates page visit to a workspace that has not seen it, so its dialog covered the member-memory spec's clicks on /members. The Playwright auth setup already pre-sets the first-run tour's flag; it now sets the chapter's render cache too, and the GUI user-test seed marks dashboard.crewmates_onboarded for the same reason.
|
/ai-review override first-principles cd6440d: Product owner decision: whether the workspace has seen Meet CrewMates is the only condition on showing it, so custom agents and existing crewmates no longer suppress it; recorded as the screen 08 amendment in rfc-crewmates-launch.md in this PR. |
7caf299 to
cd6440d
Compare
Human judgment recorded@buluoray marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
|
Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: First Principles Review. Re-run the lane's latest workflow run for |
|
UX Review CONCERNS on cd6440d — dispositions
|
iamwhatever
left a comment
There was a problem hiding this comment.
Reviewed. The gate now keys only on whether this workspace has seen the flow; MembersPage announces every visit and the host decides. No security/auth touch; tests cover entry before theme boot, the server seen flag and first-run in progress.
Two non-blocking notes:
- website/src/hooks/useMeetCrewmatesGate.ts (~84-92): pageEntered is set once and never reset. A user who visits /members before first-run or theme boot completes and then navigates away will get the flow on whatever page they are on when the conditions turn true. Clearing the flag on unmount (or checking the current route) would keep the 'never pops outside the page' claim exact.
- website/src/components/MeetCrewmatesFlow.tsx:45-51: the JSDoc still says the event fires 'once its roster has loaded and holds no crewmate'; the code fires it on every mount.
Problem / Motivation
Goal: The Meet CrewMates intro shows by itself the first time a user opens the Crewmates page, instead of only behind a button.
Today the chapter auto-fires only at the end of the first-run tour, and only for a workspace with no custom agents. Anyone else (an existing user, or a user with custom agents) lands on an empty Crewmates page and has to notice and click the small "Meet CrewMates" button to see the intro.
Why it matters
The Crewmates page is where people go to learn what a crewmate is. Most existing users never see the guided intro that creates their first crewmate because it is hidden behind a secondary button.
Not a goal
What changed (motivation → approach → change)
/memberswith no crewmate shows only the empty state and a "Meet CrewMates" button.useMeetCrewmatesGate, the single owner of the flow's open state and its once-per-workspace rule) decides whether the flow is still due. The page itself never opens the flow directly.MembersPagedispatchesmc-crewmates-page-enteredon every visit. The gate opens the flow when first run is done andcrewmates_onboardedis not set on the server. The entry is remembered, so a reload straight into/membersstill works even if the page loads before the theme boot.useThemeexposescrewmatesFlowSeen(the server'screwmates_onboarded, plus its local cache). The existingcrewmatesOnboardedcan't be reused for the page path: it also counts an existing user as done.mc-crewmates-pendingtiming, so an existing workspace isn't interrupted on its next load; it gets the flow on its first Crewmates page visit instead.MeetCrewmatesEligibilityNotice) has nothing to report, so it's removed, along with its two strings in all 13 locales.crewmates_onboardedas before.docs/system-specs/modules/config.md(Meet CrewMates first-run state) and the feature map. The decision itself is recorded as a dated screen 08 amendment indocs/request-for-change/rfc-crewmates-launch.md(this PR added to itsimplementation-prs), which supersedes the custom-agent exclusion.Relates to screen 08 in
docs/request-for-change/rfc-crewmates-launch.md, which decides the flow's content but not its trigger timing.Backwards compatibility
Compatible: one added field on the theme context, and one added window event. Existing events, flags and the tour-end trigger are unchanged.
Tests
useMeetCrewmatesGate.test.tsx: the flow opens after the tour even with crewmates and a custom agent present, and neither roster nor agents are read. On page entry it opens for an existing user with crewmates and custom agents, and doesn't reopen on a second visit after dismissing. It doesn't open when the server says it was seen. An entry announced before the theme boot lands still opens it. It doesn't cover first-run chapters that are still running. Page-path cases fail if the gate usescrewmatesOnboardedinstead ofcrewmatesFlowSeen(mutation-checked). The old "does not open when a crewmate / custom agent exists" and eligibility-notice cases are removed with the behaviour.MembersPage.test.tsx: the page announces the visit with and without crewmates.tsc, eslint anddocs-lintare clean.Manual verification
Ran a throwaway
--test-modegateway from this worktree. The workspace was already onboarded (nocrewmates_onboarded) with the Crew Members preview on. Chromium ran at 390×664 and opened chat, then/members, with no clicks./membersshows the empty state and the "Meet CrewMates" button, and no flow opens;/members. Chat showed no dialog (0 dialogs), so the flow doesn't pop outside the page.Screenshots / video
(The cut-off footer in "after" is fixed separately in #14911; this branch is based on main. The shots come from the first commit; the second only widens who sees this same surface, which the unit tests cover.)
Related Issues
N/A — product request.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement