Repository navigation
feat: create a crewmate from one card on the Crewmates page - #18805
Conversation
717dc98 to
7471249
Compare
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that a crewmate created with a failed [DESIGN-REVIEWED] 72dd1d3 Description read[DESCRIPTION-READ] cc706fb0e3ef5e597960f25f8f4e4bb6cda71c55b2cd4da74ec93b2420f6e542 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS Choosing a pose wipes the crewmate's own face, so Scribe and Radar end up as the same plain green ghost, and shot 4 doesn't match the shipped code. Watch
Suggestions
[UX-REVIEWED] 72dd1d3 Description read[DESCRIPTION-READ] 260c9872a1975ba7d27a0b0384fe53b82567590690bfc8f940be92a10bb7d1ae That sha256 names everything this verdict read: the PR description, plus the 16 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ human override accepted@buluoray overrode this lane for |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
7471249 to
7aa7b10
Compare
7aa7b10 to
95509ca
Compare
|
/ai-review override ux 95509ca: agent: owner decision -- the BLOCK is only for missing captures (the Advanced fold's lower half and the no-job greeting); the four attached screenshots cover the card, the fold, a prefilled card and a first greeting. |
Human judgment recorded@buluoray marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Human judgment recorded@buluoray marked the ux AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Human judgment recorded@buluoray marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
|
/ai-review override ux 1c347c1: screenshot evidence only; Ray (rayrayxu) decided not to re-capture the editor shots after the relabel. A unit test pins the shipped link: absent before an applied pick, labelled "Back to 's original look" after one, and it restores the original face. |
Human judgment recorded@buluoray marked the ux AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
|
/ai-review override first-principles 8191852: Ray (rayrayxu), the product owner, decided the one-card create replaces § 08's four-step flow and moves Built from and What it looks after under Advanced; the § 02 amendment records it. The |
|
/ai-review override ux 8191852: screenshot evidence only; Ray (rayrayxu) decided not to re-capture the editor shots after the relabel. A unit test pins the shipped link: absent before an applied pick, labelled "Back to 's original look" after one, and it restores the original face. |
Human judgment recorded@buluoray marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Human judgment recorded@buluoray marked the ux AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
|
|
|
|
|
|
Port of #17617 onto main. The Crewmates page creates a crewmate on one New crewmate card (Name, Avatar with Try another look, Create), with everything else under an inline Advanced settings fold, instead of the guided Meet CrewMates flow. The "+" menu, the empty roster's hero, the switcher, a crewmate's create link and the crewmate.create guide all open that card; the guide's crewmate.create action is one commit step. The card's create sends first_greeting. POST /api/agents then records a goal welcome (welcome_owed.json, kind "goal"), and the existing POST /api/members/{slug}/greet dispatch in mate_welcome.py runs a hidden goal kickoff: the crewmate introduces itself and asks what it should do, or confirms the job written under Advanced settings. The page asks for the greeting on dashboard-created rows as well as Mate's. Removed: MeetCrewmatesFlow, useMeetCrewmatesGate, the first-run chapter mount, the created-crewmate receipts, the seeded first-turn send and its retry notice, and the theme's crewmates_onboarded reads and writes (the gateway keeps carrying the flag for compatibility). Docs: RFC crewmates-launch section 02 amended (08 marked superseded), crew-mode, config, feature map, mcp, learn-cron-dashboard, crew-members and gui-user-test updated; UI index regenerated. Part of #18300
The New crewmate card drops the random re-roll. Its avatar tile now opens CrewAvatarBuilder in an icon-only mode (pose and colour), and a pick survives a renamed draft; with no pick the record keeps the name's own face. The Name field gets a visible label, and the first greeting is a short hello with the crewmate's name followed by one plain question about its goal.
|
/ai-review override first-principles 72dd1d3: Ray (rayrayxu), the product owner, decided the one-card create replaces § 08's four-step flow and moves Built from and What it looks after under Advanced; the § 02 amendment records it. The |
Human judgment recorded@buluoray marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Problem / Motivation
Goal: A person makes a crewmate on the Crewmates page from one short card (a name and a look), and the new crewmate opens its chat by asking what it should do.
Today the Crewmates page's New crewmate opens the guided Meet CrewMates flow: four steps (goal, name and starting setup, schedule, ready) before a crewmate exists, then a creation receipt and a first message the page sends in the user's name. Someone who just wants a teammate has to answer a job description and a schedule up front, in a form, before they have talked to it at all. The full form sits behind a separate Advanced row in the "+" menu, so there are two different create surfaces for one action.
Why it matters
Making a crewmate is the first thing a person does on the Crewmates page. Every extra step there is paid before they see any value, and the questions the guided flow asks (what exactly should it do, when should it run) are ones people answer better in conversation once the crewmate is in front of them. One card with a crewmate that asks for its own goal makes creating a crewmate a few seconds of work, and keeps the goal and schedule in the place where they can be discussed and changed.
Not a goal
crewmate.createproposals withfirst_greeting): they are not on main and stay in feat: let crewmates propose changes the user confirms as cards #18448.dashboard.crewmates_onboardedconfig field or its theme endpoints: the gateway keeps carrying it for compatibility.What changed (motivation → approach → change)
Goal → one create surface and a crewmate that asks for its own goal → port of #17617 (merged into
feat/crewmate-assistant-integrationas 49801cb) onto main, adapted to main's Mate welcome. The decision is recorded as an amendment to rfc-crewmates-launch.md § 02 in this PR (§ 08 marked superseded); that RFC isacceptedon main and the amendment ships here. The product owner (rayrayxu) made this decision, and the First Principles lane is overridden on that basis.NewCrewmateDialogbecomes the New crewmate card: the avatar, whose pencil opens the avatar editor (icon and colour only, with Back to 's original look to go back to the name's own face), Name under a visible label, and Create. There is no hint line under the name: the crewmate's first message says what happens next. Built from, What it looks after and the crew editor fields live under an inline Advanced settings fold in the same card. The "+" menu's one row, the empty roster's hero, the switcher, a crewmate's create link (/members?create=1&name=…&goal=…) and thecrewmate.createguide all open it; the hero's Advanced link and the crew manager's door open it unfolded.first_greeting: true.POST /api/agentsthen records a goal welcome (members.mark_welcome_owed(..., kind="goal")in the existingwelcome_owed.json). The existingPOST /api/members/{slug}/greetdispatch inmate_welcome.pyreads the kind (members.owed_welcome_kind) and runsgoal_kickoff: a hidden turn in which the crewmate introduces itself by name and asks what it should work on, or confirms the job written under Advanced settings, and offers a schedule only once the goal is clear. The page asks for the greeting on dashboard-created rows as well as Mate's (useFirstGreeting).crewmate.createchange card'sPOST /api/agentsstep now sends"first_greeting": True(change_card_catalog.build_preview), so a card-made crewmate opens with the same goal welcome; the goal kickoff may set up an agreed schedule "or as a change card they confirm".crewmate.createis now one commit step (the card's Create), completed only by the gateway from the crewmate it created, as before.MeetCrewmatesFlow,useMeetCrewmatesGateand the first-run chapter mount; the created-crewmate receipts (sessionStorage); the seeded first-turn send, its retry notice andChatPane'screwmateCreatedslot; the "+" menu's Advanced row (members.add-menu.advanced); the theme'screwmates_onboardedreads, writes and localStorage mirrors (api/client/themes.ts, plus the greeting comment inapi/client/agents.ts); i18n keys ini18n/locales/*.jsonanden.context.json(unused ones removed, the card's new ones added)./membersURL). The create-link effect now keeps the open chat in the URL and the landing effect waits for it.crew-members.mdand gui-user-test updated; UI index regenerated (npm run gen:ui).The #17617 change-card hunks held back for #18448 are now included (it merged):
change_card_catalog.py(DEFAULT_CREWMATE_TEMPLATEcomment,first_greetinginbuild_preview), itstest/test_change_cards.pyassertion, the kickoff wording, and the crew-mode text. Not ported:website/scripts/verify-crewmate-assistant.mjs(not on main) and #17617's Captain-specific code (main's first crewmate is Mate).Backwards compatibility
Compatible:
POST /api/agentsonly gains an optionalfirst_greetingflag (anything buttrueowes nothing); an existingwelcome_owed.jsonwith nokindstill reads as Mate's welcome, and an unknownkindowes nothing;crewmates_onboardedis still accepted and returned by the theme endpoints.MeetCrewmatesFlow; first run ends after the Customize tour (App.importChapterReopen.test.tsx,App.lookPreviewFrame.test.tsx)MembersPage.test.tsx"MembersPage create links open the New crewmate card")mc-members-created-receiptssessionStorage entry is never read again and dies with the tabChatPane.mateChat.test.tsx)GET /api/theme/bootstill carries the flag and nothing on the dashboard reads ittest_guide_routes.py::test_crewmate_create_steps_match_the_page)find_uifor "advanced crewmate setup" answers the "+" menu (test_find_ui_members.py)owed_welcome_kind(...) is not None(test_mate_welcome.py)Tests
test/test_api_agents_create_template.py::TestFirstGreetingOwed: afirst_greeting: truecreate records a goal welcome under its member id;None,False,"true"and1record nothing.test/test_mate_welcome.py::TestGoalWelcomeand the new route/dispatch cases: an owed crewmate greets once with the goal kickoff and no transcript row; a thread with messages or an unknown kind never greets; the kickoff names the crewmate (its key when unlabelled), never its template, and confirms a written goal.test/test_change_cards.py::test_crewmate_create_binds_its_schedule_to_the_created_identity: thecrewmate.createcard's create step builds fromkirocrewand carriesfirst_greeting: True, and its schedule step runs askirocrew. Removing thefirst_greetingline frombuild_previewturns this test red (KeyError: 'first_greeting').test/test_guide_routes.py/test_guide_runs.py:crewmate.createis one commit step matching the page; the card's fields accept every pre-fill the catalog allows; the store's moves around a commit stay covered with a two-UI-step rig.test/test_find_ui_members.py,test_slot_running_readers.py: the index and the reservation-reader list follow the change.NewCrewmateDialog.test.tsxandNewCrewmateDialog.guided.test.tsx(the card, its fold, drafts, guided Create),MembersPage.test.tsx(every door, create links keep the chat they came from, greeting asked for created crewmates),useFirstGreeting.test.tsx,rosterFilter.test.ts(hasNoCrewmates),GuideLayer.test.tsx(guide steps against the one-step action),CrewRoster.test.tsx(crew manager door opens unfolded).Gates run locally on the head this PR carries (rebased onto b54fde7, which includes #18448): black, isort and flake8 on the touched Python files;
tsc -p tsconfig.app.jsonandi18n:checkpass;gen:uiregenerated.scripts/local-gate.pyran the related sets: frontend 738 files / 18,855 tests passed; backend 86 failures across its three batches (doctor/STT, design-tweak preview, file explorer, terminal probe, skill roots and similar), and every one of them also fails on a clean detachedorigin/mainworktree in this sandbox, so none come from this diff.mypy src/kiro_crewreports 3 errors inwecom/client.py, a file this PR does not touch. The rebase conflicts were all two-sided additions (locale catalogs, crew-mode spec, feature map,ChatPaneprops) and kept both sides; the generated UI index was rebuilt.Manual verification
Still required: on a running dashboard, create a crewmate from the "+" menu, the empty roster's hero and a crewmate's create link, and confirm the new chat opens with the crewmate introducing itself and asking what it should do (or confirming the written job). Not done yet: the greeting text is the model's own words and was only checked through the kickoff string in unit tests.
Screenshots / video
Before (this PR's base
f07162523a, Crewmates preview on): New crewmate opens the four-step goal flow.Desktop (1440×900):
Phone (390×844):
After: taken on a fresh pod built from head
72dd1d3d58(Crewmates preview on).Desktop (1440×900). The card: the avatar's pencil, the Name label, Create:
The pencil opens the avatar editor, icon and colour only. Until a pick it previews the card's own face, nothing is framed and Apply is off; Back to Scribe's original look goes back to it after a pick:
The card after Apply:
With Advanced settings unfolded, down to the second Create at the end of the fields:
A card prefilled from
/members?create=1&name=Scribe&goal=…:The new crewmate's first message, a hello and its goal question:
Created with a goal under Advanced settings, the first message repeats the goal back and asks to confirm it:
Phone (390×844), same pod and head:
Related Issues
Part of #18300
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.