Skip to content

test(website): update two frontend tests left red on main - #16227

Merged
iamwhatever merged 1 commit into
kirodotdev:mainfrom
tilakputta:fix/main-red-frontend-tests
Oct 2, 2026
Merged

iamwhatever merged 1 commit into
kirodotdev:mainfrom
tilakputta:fix/main-red-frontend-tests

Conversation

@tilakputta

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Make main's frontend suite green again by updating two tests that crossed merges left stale.

Two frontend tests fail on a clean checkout of main (af162847d), and so on every PR that rebases onto it:

  • src/test/hoverVariantPolicy.test.ts fails with "DECORATIVE entry still matches a site: components/WelcomeView.tsx (sm:group-hover:line-clamp-none)".
  • src/test/SessionActionsMenu.duplicate.test.tsx fails with "Unable to find an element with the text: Duplicate".

Why it matters

Frontend Tests (1) and (2), and the Frontend Coverage Merge job that depends on them, are red for every open PR. That hides real frontend regressions and blocks an all-green check run on unrelated work.

Not a goal

  • No product or UI change: only the two test files are edited.
  • Not reworking the hover-variant policy or the session menu's fork item (its glyph still differs from the row button's; see below).

What changed (motivation → approach → change)

Backwards compatibility

Compatible: test-only change, no runtime code touched.

Removes nothing: the only deletion is a test-registry entry whose snippet no longer exists in the source.

Tests

  • Both tests fail on main and pass with this change: npx vitest run src/test/hoverVariantPolicy.test.ts src/test/SessionActionsMenu.duplicate.test.tsx src/test/WelcomeView* gives 60 passed.
  • tsc --noEmit and eslint on the two files pass.

Manual verification

N/A: test-only change with no rendered delta.

Related Issues

Main went red when #14807 crossed #15820 and #16101. Blocks an all-green run on #15250.

Pattern harvest

Not generalizable: two separate tests went stale because PRs that each passed on their own base were merged in parallel. Requiring branches to be up to date before merge would prevent this; a lint rule would not.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

@tilakputta
tilakputta requested a review from a team as a code owner October 2, 2026 19:02
@tilakputta
tilakputta requested a review from bolichen97 October 2, 2026 19:02
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Oct 2, 2026
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

GPT 5.6 Review (fork) — ✅ no blocking findings

Reviewed 26da2421b0868bded20e3aad5da35cc0fcb92b2c via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 26da242

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

UX Review (Fable 5, fork) — ✅ PASS

UX-level review of 26da2421b0868bded20e3aad5da35cc0fcb92b2c via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Nothing to check.

[UX-REVIEWED] 26da242

Description read

[DESCRIPTION-READ] 1b7167730d87f900eddd3d4152950c79bde3aff79fb5ae0501113fe60f02888b

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Design Review (Fable 5, fork) — ✅ PASS

Design-level review of 26da2421b0868bded20e3aad5da35cc0fcb92b2c via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

WelcomeView's hover-unclamp now permanently escapes the policy scan — confirm the arbitrary-variant blind spot in REVEAL is accepted or gets a follow-up.

Suggestions

[DESIGN-REVIEWED] 26da242

Description read

[DESCRIPTION-READ] 637342fe79b0a5fa85b1e25f85b2bff7394ddd6e836d59df5994809c60152c88

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Opus 5 Review (fork) — ✅ no blocking findings

Reviewed 26da2421b0868bded20e3aad5da35cc0fcb92b2c via the fork AI-review pipeline; updated in place on each push.

Review details

The touch-only ⋯ menu still draws the clipboard glyph beside the new "Fork chat" label — the exact glyph/label mismatch #16101 removed from the desktop row.

FINDING — website/src/components/SessionActionsMenu.tsx:276 — <Copy size={13} ... /> {i18nT('pages.chatSidebar.duplicate')} renders a clipboard icon next to "Fork chat" (en.json:6715), and ChatSidebar.tsx:1694 passes onDuplicate on every touch row via isMobile={isMobile || isTouchDevice}, so phone/tablet users see "copy text" affordance for the fork action while ChatSidebar.forkChatAction.test.tsx:86 only asserts svg.lucide-copy is absent from the row → Fix: swap Copy for GitFork in the import at SessionActionsMenu.tsx:3 and at line 276 (Copy has no other use in that file), and assert svg.lucide-git-fork in this PR's relabelled menu test.

[OPUS-REVIEWED] 26da242

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 2, 2026
@iamwhatever
iamwhatever merged commit 9eb318e into kirodotdev:main Oct 2, 2026
99 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants