Repository navigation
test(website): update two frontend tests left red on main - #16227
Conversation
GPT 5.6 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
UX Review (Fable 5, fork) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. [UX-REVIEWED] 26da242 Description read[DESCRIPTION-READ] 1b7167730d87f900eddd3d4152950c79bde3aff79fb5ae0501113fe60f02888b That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Fable 5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS WelcomeView's hover-unclamp now permanently escapes the policy scan — confirm the arbitrary-variant blind spot in REVEAL is accepted or gets a follow-up. Suggestions
[DESIGN-REVIEWED] 26da242 Description read[DESCRIPTION-READ] 637342fe79b0a5fa85b1e25f85b2bff7394ddd6e836d59df5994809c60152c88 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5 Review (fork) — ✅ no blocking findingsReviewed Review detailsThe touch-only FINDING — website/src/components/SessionActionsMenu.tsx:276 — [OPUS-REVIEWED] 26da242 |
Problem / Motivation
Goal: Make main's frontend suite green again by updating two tests that crossed merges left stale.
Two frontend tests fail on a clean checkout of
main(af162847d), and so on every PR that rebases onto it:src/test/hoverVariantPolicy.test.tsfails with "DECORATIVE entry still matches a site: components/WelcomeView.tsx (sm:group-hover:line-clamp-none)".src/test/SessionActionsMenu.duplicate.test.tsxfails with "Unable to find an element with the text: Duplicate".Why it matters
Frontend Tests (1) and (2), and the Frontend Coverage Merge job that depends on them, are red for every open PR. That hides real frontend regressions and blocks an all-green check run on unrelated work.
Not a goal
What changed (motivation → approach → change)
sm:group-hover:line-clamp-nonein WelcomeView as a deliberate decorative hover. fix(chat): keep floating composer chrome off the transcript and hero #15820 then rewrote that class to[@media(min-width:640px)_and_(min-height:600px)]:group-hover:line-clamp-none, which the policy's reveal pattern does not match. So the registry entry now points at nothing, and the test's stale-entry check fails. Removing the stale entry is the fix; the new class needs no entry because the policy does not flag it.pages.chatSidebar.duplicateto "Fork chat" in every locale, and the menu item reads that key. The test now looks for "Fork chat".Backwards compatibility
Compatible: test-only change, no runtime code touched.
Removes nothing: the only deletion is a test-registry entry whose snippet no longer exists in the source.
Tests
mainand pass with this change:npx vitest run src/test/hoverVariantPolicy.test.ts src/test/SessionActionsMenu.duplicate.test.tsx src/test/WelcomeView*gives 60 passed.tsc --noEmitand eslint on the two files pass.Manual verification
N/A: test-only change with no rendered delta.
Related Issues
Main went red when #14807 crossed #15820 and #16101. Blocks an all-green run on #15250.
Pattern harvest
Not generalizable: two separate tests went stale because PRs that each passed on their own base were merged in parallel. Requiring branches to be up to date before merge would prevent this; a lint rule would not.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement