Repository navigation
feat(skills): ship dashboard-manager and retire the template picker - #18755
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The rewrite teaches tools this base doesn't have yet ( Not justified as shipped
What this change shipsInventory (7 items) — 4 justifiedIntent: an agent writes the Dashboard page somebody asked for instead of picking one from a catalog. This is an ADDITION (it rewrites a shipped skill).
[FIRST-PRINCIPLES-REVIEWED] 88efc91 Description read[DESCRIPTION-READ] 84036d4f0572566af42f972668fe95dd380d10263ba672e311658706c0fbc23c That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS This skill ships before the tools it teaches: on this base the tools refuse an agent-written page, and the catalog flow that does work is no longer taught. Watch
[DESIGN-REVIEWED] 88efc91 Description read[DESCRIPTION-READ] 612aa95d2c4aa6a0c07fc5698e012ff8a61d7aee579c1e226559aeeb3533eb5e That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsNo findings that block the merge; three advisory findings show the rewritten skill pointing the agent at tools that don't exist in this tree. FINDING — src/kiro_crew/builtin_skills/dashboard/SKILL.md:37 — When a person says "I want one that shows X", step 1 tells the agent "A save writes the package as a STAGED copy", but FINDING — src/kiro_crew/builtin_skills/dashboard/SKILL.md:51 — "Go back" is sent to FINDING — src/kiro_crew/builtin_skills/dashboard/GALLERY.md:31 — For shipped pages it says "Nothing resolves one by name at run time", yet [OPUS-REVIEWED] 88efc91 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
9946759 to
dbf6234
Compare
dbf6234 to
cbc0b1c
Compare
cbc0b1c to
9f3cf8e
Compare
9f3cf8e to
9a9b0c8
Compare
65b3b63 to
de29606
Compare
ef8c4cf to
af93d98
Compare
1601642 to
ff8a1a2
Compare
ff8a1a2 to
f96fe22
Compare
af93d98 to
b5f6ff9
Compare
b29a25a to
6eb2109
Compare
… start from The `dashboard` skill taught a catalog flow -- search, preview a `template_id`, apply -- and stated that the agent cannot write the page. The RFC's amendment of 2026-10-12 retires that flow and records that a crewmate composes its own page, and the base serves an authored page through the frame, so that body described a flow the product has left and taught none of the one it has. It is rewritten in place, keeping its name and its triggers, and now carries the whole job in seven sections: who owns the page and the gate it goes through; design freedom with the honesty rules that bound it; the manager view's five questions and one-screen limits; the frame contract, including `window.kirocrew.subscribe(name, cb)` for anything the page draws; which values exist, through `dashboard_types` and the generated fold list; the theme and reach contract; and the gallery. Section 1 teaches the gate the amendment's Decision 1 records: a save STAGES a page, and the live path is stage -> preview -> a person approves -> apply, with `artifact_revert` on the package artifact as the undo and no dashboard-specific rollback verb beside it. `dashboard_save`, the tool that stages an authored page, is named with the pull request that ships it, so the section describes the recorded contract rather than the pre-gate behaviour. It also states what a save does on this base in the meantime: it BINDS the page, the tab keeps drawing the template instance, no version is cut, and agentic field writes are refused `package_display_pending` until a person cuts one -- so the page an agent saved is not yet the page the person sees. The base's layout lock is carried into the same section rather than dropped by the rewrite, and it names the gap an agent would otherwise walk into: the lock is a ceiling over the crewmate, so a locked tab ignores a bound package and serves the template page, `dashboard_apply` and `dashboard_rollback` answer `dashboard_locked`, and `artifact_revert` is NOT lock-aware -- it succeeds while nothing on the tab changes and no error says why. Read the `[DASHBOARD]` block rather than inferring the lock from a tool that answered yes. `GALLERY.md` lists `gallery/`'s whole packages beside the pages that shipped, with the reader question each answers. Every entry is optional and nothing resolves one by name at run time: they are source to read, copy and adapt. The dispatch-tree package sits among them on the same footing, never the default and never assumed, and the three things worth taking from it are named: bind a cell or subscribe, build rows with `textContent`, and declare every field the markup binds.
Problem / Motivation
Goal: one
dashboardskill that tells an agent how to write the Dashboard tab page somebody asked for, instead of telling it to pick one and that it may not write one.The shipped
dashboardskill teaches a catalog flow -- search, preview atemplate_id, apply -- and states in so many words "You cannot write the page yourself." The RFC amendment of 2026-10-12, merged to main in #19287, retires that flow and records that a crewmate composes its own page, and the base now serves an authored page through the frame. So that body describes a flow the product has left and forbids the one it has.The rest an agent needs is scattered: honesty rules in the artifacts skill, the frame contract in a module docstring, the fold catalogue in a dev-only skill, theme in the widgets skill.
Why it matters
This skill is what every member prompt and the dashboard subagent charter send an agent to read. While it ships, the honest answer to "show me where this project stands" is "pick one of these twelve", and an agent that reads it refuses work it can do.
Not a goal
.pyfile. Hosting, saving and pushing are other PRs on this issue.dashboard_templates/stays on disk; removing the id flow is a later PR. This PR stops the skill from teaching it.What changed (motivation -> approach -> change)
Goal: the agent writes the page, and one document tells it how.
Approach. A new skill under a new name, with this one retired, was the earlier shape of this PR and was worse: it deleted a skill two shipped prompts still name and needed a
_RELOCATED_SKILLSmigration row. Rewriting in place keeps the name, the existing triggers and every caller.builtin_skills/dashboard/SKILL.mdrewritten, samename:and two added triggers, now carrying the whole job in seven sections: (1) ownership, the stage -> preview -> approve -> apply gate, and the layout lock; (2) design freedom bounded by the honesty rules; (3) the manager view's five questions and one-screen limits; (4) the frame contract --data-dashboard-fieldsets text only,window.kirocrew.fieldsfor a chart,window.kirocrew.subscribe(name, cb)for anything drawn,connect-src 'none', the no-script fallback under an admin ceiling, the staleness band; (5) which values exist, throughdashboard_types, the generated fold list anddashboard_fields; (6) theme and reach via thewidgetscontract; (7) the gallery.builtin_skills/dashboard/GALLERY.md(new) listsgallery/'s whole packages beside the pages that shipped and the crew-drawer boards, with the reader question each answers. Every entry is optional and nothing resolves one by name at run time.Section 1 teaches the gate that amendment's Decision 1 records rather than the behaviour that predates it: a save STAGES a page, it cuts no version and is fed no values, and the live path is stage -> preview -> a person approves -> apply, where apply takes no page argument so what lands is provably the page the person read. The undo is
artifact_reverton the package artifact; there is no dashboard-specific rollback verb beside it.dashboard_save, the tool that stages an authored page, is named with the PR that ships it, #18851, so an agent reading this today knows which half is in its hands. The section also records why the gate may not simply be dropped: the no-wrapper exemption of 2026-10-11 was granted on it.Section 1 also states what a save does on this base while
dashboard_saveis unmerged, because the earlier revision of this paragraph got it backwards. A save does not land the page:mcp_tools/artifacts.pytells the caller that saving akind='dashboard'package BINDS the crewmate's page to it "while the page still draws from its template instance", andapplied_package_version(dashboard/handlers/member_dashboard.py) serves only a version a PERSON cut. So the page an agent saved is not yet the page the person sees, and agentic field writes are refusedpackage_display_pendinguntil the cut happens.The base's layout lock is carried into that same section rather than dropped by the rewrite, and it now names the gap an agent would otherwise walk into. The lock is a ceiling over the crewmate: a locked tab ignores a bound package and serves the template page, and
dashboard_applyanddashboard_rollbackanswerdashboard_locked.artifact_revert, the undo this skill names, is NOT lock-aware -- it succeeds while nothing on the tab changes and no error says why -- so the skill tells the agent to read the[DASHBOARD]LOCKED block rather than infer the lock from a tool that answered yes. The base paragraph that described the "Dynamic Dashboard" Feature Preview switch is gone from main already, and this rewrite does not reintroduce it.The dispatch tree is one gallery row on the same footing as the others, with a paragraph saying it is never the default, never assumed by a prompt or a test, and that a page showing no tree is correct.
check_builtin_skill_scope.pyrefuses asrc/kiro_crew/...path or a repository URL inside a shipped skill, so the gallery uses skill-relative paths likegallery/dispatch-tree/package.jsonand names the shipped pages by their directory name.Backwards compatibility
Compatible: the skill keeps its
name:and every existing trigger, so every prompt and every trigger match resolves as before. It adds two triggers:build a dashboard,dashboard gallery. No field, type, validator, tool or public function changes, and nothing is deleted or relocated.It does take sentences away from a shipped skill -- the catalog flow, and the base's own gallery section, whose substance moves into
GALLERY.mdand sections 4 and 7 -- so every reader of those, found by grepping the base:agent.py's dashboard manager charter, which loads this skill -- entry: subagent -- still resolves, because the skill keeps its name. Rewritten in the prompt PR.context_assembly/member.pyitem 7, injected on every member turn -- entry: chat -- same: the name it loads is unchanged. That item still names the catalog verbs; the prompt PR on Dynamic Dashboard v3: drop built-in templates, compose a dashboard from a data-type catalog and store it as a dashboard artifact #18642 is where it changes.dashboard_templates/dashboard_preview/dashboard_applytools -- entry: subagent, crew page -- all three stay registered and granted; the skill stops teaching their flow, the verbs still resolve.dashboard_rollback-- entry: crew page -- stays registered and granted; the skill now namesartifact_revertas the page's undo, which is what Decision 1 of the merged amendment records.dashboard_lockedanswer -- entry: crew page -- unchanged and still taught, moved into section 1 from the base's own section 4, withartifact_revert's lock blindness stated beside it.Tests
No test file changes. The rewrite is held by the guards
builtin_skills/already carries, and three of them bound this work:check_builtin_skill_scope.py, which is why the gallery cites no repository path;test_builtin_skill_index_line.py, which pins every packaged description at or under 300 characters because the session-start index truncates there, and this one measures 285; andtest_skill_home_paths.py, whoseLEGACY_HOMEpattern\.kirocrew(?![-.])reads a bare`window.kirocrew`as the pre-move data home, so section 4 names the object only in its dotted forms.Run on this head with
-n 2. Every command exited 0.test_skill_home_paths.pytest_docs_lint_fact_checks.pytest_builtin_skill_index_line.pytest_builtin_skill_packaging.pytest_builtin_skill_scope.pytest_skill_budget.pytest_builtin_skill_sync_safety.pytest_skills.pytest_skills_frontmatter.pytest_skills_composition_contract.pytest_brand_name_gate.pytest_dashboard_gallery_dispatch_tree.pytest_dashboard_gallery_real_tree.pytest_dashboard_structure_lock.pyscripts/docs_lint.pyscripts/check_builtin_skill_scope.pyscripts/check_brand_name.py0 binaries, 0 non-ASCII bytes in either skill file.
Manual verification
Every claim was read off this base rather than written from memory: the frame's three value paths, the gallery's one package and twelve shipped pages, the layout lock's refusal code, and each tool the skill names.
window.kirocrew.subscriberesolves on the base indashboard_frame.pyandartifact_store/dashboard_package.py, andgallery/dispatch-tree/package.jsonis on disk -- both arrived on main with the frame-host PR, which is why this PR no longer needs to point at an unmerged branch for either.PREVIEW_DASHBOARDand "Feature Preview" are 0 hits on the base, matching the rewrite.Screenshots / video
N/A -- the diff is two markdown documents. Nothing under
website/src/is modified, so there is no rendered delta.Related Issues
Refs #18642
The T3 one-pager for #18642 was approved, so this line opens its PRs.
Based on
main. The two earlier bases this PR stood on are both merged: the frame host that putswindow.kirocrew.subscribeand thegallery/dispatch-treepackage on the tree, and the RFC amendment in #19287 that records the flow this skill teaches.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
I confirm that this contribution is made under the terms of the Apache-2.0 license, per the Licensing section of CONTRIBUTING.md.