Repository navigation
fix(crew): default new mates to an icon and retire new ghost-face authoring - #20392
Conversation
First Principles Review (Opus 5.5) — ✅ human override accepted@dodgeblaster overrode this lane for |
Design Review (Opus 5.5) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS The icon default is only applied by two frontend callers, so crewmates created by the backend (first-run crewmate, CLI Watch
[DESIGN-REVIEWED] ce080fe Description read[DESCRIPTION-READ] b3d947dda9ad0e31ab8f3858a4045f26eab069ef6f42e045650944ff05104454 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsNo findings that block the merge. FINDING — website/src/components/CrewAvatarBuilder.tsx:440 — [OPUS-REVIEWED] ce080fe Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS The new default icon changes colour and pose as the user types the name, and the blind reader read that as random. Watch
Suggestions
[UX-REVIEWED] ce080fe Description read[DESCRIPTION-READ] 9c4445a555e0455a54875e6e20b074c251f7f6041b75b10cf18406a7498be6e3 That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
ed6731b to
44225ee
Compare
44225ee to
34ba31e
Compare
34ba31e to
80250b5
Compare
e313e85 to
ddf5c67
Compare
|
/ai-review override first-principles ddf5c67: agent: team decision — default-to-icon and retiring new ghost-face authoring follow accepted #16232 (icon tier supersedes the ghost builder); the djb2->DiceBear seeding swap is a deliberate team choice to reuse the ghost tier's generation mechanism. The theme-accent-seed and duplicate-palette defects it flagged are fixed in this head. |
Human judgment recorded@dodgeblaster marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
ddf5c67 to
c1458a7
Compare
|
/ai-review override first-principles c1458a7: agent: team decision — default-to-icon and retiring new ghost-face authoring follow accepted #16232; the djb2->DiceBear seeding swap is a deliberate team choice (seeding engine only, curated icon art model unchanged). This head additionally fixes the UX-flagged create/editor colour mismatch: the editor's un-picked icon draft now seeds its colour from the name (matching the create preview) so an untouched Apply saves the icon shown, per the product rule that name-seeding is a default an explicit pick overrides, frozen into a stored choice at create and never re-rolled on later rename. |
|
AI-review override not recorded: keep the reason to 500 characters or fewer. |
c1458a7 to
bec089f
Compare
|
/ai-review override first-principles bec089f: agent: team decision — default-to-icon and retiring new ghost-face authoring follow accepted #16232; the djb2->DiceBear seeding swap is a deliberate team choice (seeding engine only, curated icon art model unchanged). This head also closes the GPT+Opus-flagged reset path (a non-ghost crew Reset no longer lands on the ghost trait builder, so Reset is not a route to author a new ghost), fixes the UX create/editor colour mismatch (editor un-picked icon colour now seeds from the name, matching the create preview), and updates crew-mode.md in the same commit per the same-commit spec rule. |
|
AI-review override not recorded: keep the reason to 500 characters or fewer. |
|
Rebased onto fresh |
|
@crew-pr-reviewer could you re-review the current head
CI is green on this head (GPT fresh, Opus fresh, Design/UX green, backend shards cleared after the rebase onto the |
4d5af1b to
2d18e81
Compare
|
@kirocrew-agent /ai-review override first-principles 2d18e81: This is a frontend-only PR (zero .py in the diff). The RFC-status First Principles finding is not applicable to this change; the referenced RFC is accepted/in-progress on main. Override posted on the current head. |
|
Rebased onto fresh main ( |
…horing A new crewmate is born wearing an icon avatar instead of the name-derived ghost fallback, and the Ghost face authoring tab is hidden for crews that do not already wear a ghost (existing ghost mates keep rendering and editing). The new mate's default icon pose and background are seeded from its name through DiceBear's seeded prng -- the same generation mechanism the ghost tier uses -- rather than a bespoke djb2 hash. The icon tier stays the curated fixed pose set; only the seeding engine behind the name-typed default changed.
2d18e81 to
ce080fe
Compare
|
agent: /ai-review override lane=first-principles head=ce080fe4c7358ab5dfa1a4d747d3bedb17e07a72 Posted on behalf of @dodgeblaster (maintainer). The default-to-icon + retire-new-ghost-authoring product-shape change is the team's recorded decision for this PR (follows accepted #16232); the djb2→DiceBear seeding swap is a deliberate team choice (seeding engine only, curated icon art model unchanged). This override clears the First Principles block for this head. Re-posted after a clean rebase onto fresh main (no code change). |
|
Rebased onto fresh |
|
@crew-pr-reviewer could you re-review the current head
Head |
|
/ai-review override first-principles ce080fe: team decision — default-to-icon and retiring new ghost-face authoring follow accepted #16232; the djb2→DiceBear seeding swap is a deliberate team choice (seeding engine only, curated icon art model unchanged). This head only rebases onto fresh main (766c658); no code change since the prior override. |
Human judgment recorded@dodgeblaster marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
…2644) A new crewmate created through the UI gets a name-seeded icon avatar (#20392), but one created headlessly (POST /api/agents with no avatar, or `kirocrew agent create`) stored an empty override and rendered the trait ghost #20392 is retiring. Apply the same default server-side at the shared create point so every path lands on the same icon. A new module crew_avatar_seed.py reproduces the frontend's DiceBear-seeded pick (avatarPoses.ts, @dicebear/core 9.4.3) exactly -- the PRNG, the UTF-16 seed hashing, and the draw sequence createAvatar makes before the pose/bg pick -- so a given name yields the same icon the UI previews. Both create paths apply default_icon_avatar(display_name or name) only when no avatar was supplied; an explicit avatar is never overridden.
Problem / Motivation
Goal: A new crewmate is born wearing an icon avatar, and nobody can author a new ghost-face avatar in the create or edit flow.
Creating a crewmate without opening the avatar editor stored no avatar, so the mate fell back to the name-derived ghost face — the very face the icon tier was meant to replace. And the avatar editor still offered the "Ghost face" tab, letting anyone build a new 捏脸 ghost.
Why it matters
New mates looked like the retired ghost even though the product moved to icon avatars (#16232), and the ghost-face authoring UI the icon tier was meant to supersede was still reachable. Left alone, every new mate reads as the old style and the deprecated builder keeps producing more ghost records.
Not a goal
What changed (motivation → approach → change)
A new mate stored no avatar unless the user picked one, so it wore the name's ghost. Now a create defaults the look to a name-seeded icon — a pose and a background colour derived from the name — shown in the create preview and stored on create, so the mate is born as an icon, not a ghost. When the editor is opened from create without a pick, its fresh draft seeds pose AND colour from the name — the same icon the create preview shows — so an un-touched Apply saves exactly what the user was looking at; the explicit-pick path and the edit-an-existing-crew path (which has no name, and still seeds the colour from the active theme accent) are unchanged.
The name-to-default seeding runs through DiceBear's seeded prng, the same generation mechanism the ghost tier already uses, instead of a bespoke djb2 hash. The icon tier is unchanged otherwise: still one curated pose per avatar from the fixed set, still the fixed background palette, same stored record. Only the engine behind the name-typed default moved.
The avatar editor (
components/CrewAvatarBuilder.tsx) still had a Ghost face tab that authored a new trait ghost. The tab is now shown only when the crew already wears a ghost, keyed off the stored record so an existing ghost mate keeps the tab even after visiting another tier. A new icon, picture or pack crew has no path to author a ghost, and nothing about the ghost data model, its readers, orkiroGhostAvatarchanged, so every stored ghost avatar still renders and stays editable.Backwards compatibility
Compatible: no stored avatar shape changes; existing ghost records render and edit exactly as before. New mates gain a stored icon avatar they did not have, which the server already accepts (
_safe_avatar). The Ghost face tab is hidden for non-ghost crews but preserved for crews that already wear a ghost. Un-customized default icons may map to a different pose/colour than before, because the seeding engine changed; a stored or user-picked avatar is untouched.Tests
avatarPoses.test.ts:seedIconPose/seedIconBgsuites assert the contract that holds across the engine swap — palette and pose-set membership, stability per name, empty-name fallback, spread across distinct names, and pose/colour decorrelation.NewCrewmateDialog.test.tsx: a no-pick create sends a name-seeded icon avatar (pose + hex bg); the untouched editor previews the icon, not the trait ghost.CrewAvatarBuilder.test.tsx/.reactions.test.tsx/.library.test.tsx: the Ghost face tab is absent for a non-ghost crew and present for an existing ghost crew; the removed pack/picture→ghost authoring paths are converted to assert the tab is gone.Manual verification
Verified in a Dev Fleet pod: creating a mate without opening the editor shows a coloured icon (not a ghost); the colour and pose shift with the typed name; the Customize avatar dialog shows Icon · Picture · Library with no Ghost face tab for a new mate.
Screenshots / video
Issue link
Part of #18616
Pattern harvest
Rule candidate: When a change hides or removes a UI authoring path, grep every test (not just name-matched ones) that reaches that path and update or convert it — a diff-scoped local runner skips consumer tests whose filenames don't match the changed module, and CI's full shard is where they surface.
Pattern: This fix hid the Ghost face tab and changed the create default; the local scoped runner was green while CI's
Frontend Tests (4)shard failed onCrewRoster.test.tsxandMembersPage.test.tsx— consumers of the changed avatar modules that reach the removed tab or assert the old no-avatar contract.