Skip to content

test(acp): record #20743's members in the AcpProvider binding census - #20894

Closed
jeeshofone wants to merge 1 commit into
kirodotdev:mainfrom
jeeshofone:fix/20893-acp-bindings-census
Closed

jeeshofone wants to merge 1 commit into
kirodotdev:mainfrom
jeeshofone:fix/20893-acp-bindings-census

Conversation

@jeeshofone

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Make test/test_acp_bindings.py pass on main again by recording the AcpProvider members that #20743 changed.

#20838 froze a census of every AcpProvider member, with a digest of each signature. #20743 then gave AcpProvider an approval_withdrawable class flag and a withdraw_if keyword on approve_tool. The census lists neither change, so test_the_member_set_is_the_frozen_inventory and test_each_member_keeps_its_kind_shape_and_owner[approve_tool] fail on main.

Why it matters

Every PR that runs the backend tests picks up these two failures from main.

Not a goal

  • Changing src/. The members are right, the census is stale.
  • Changing the census checks or the sibling *_bindings censuses.

What changed (motivation → approach → change)

The census is a frozen inventory, so the fix is to bring its two entries up to the shape #20743 gave them: a new approval_withdrawable data entry, and the new signature digest for approve_tool. Each entry carries a one-line comment saying what the change is. The entries are the only change, in test/test_acp_bindings.py.

Backwards compatibility

Compatible: test-only change, no runtime behaviour touched.

Removes nothing: two census entries are added or updated and none is dropped.

Tests

test/test_acp_bindings.py fails on origin/main (2 failed, 144 passed) and passes with this change. test/test_client_bindings.py and the other *_bindings censuses pass.

Manual verification

N/A — unit coverage sufficient: the change is to a unit test's expected values.

Related Issues

Fixes #20893

Pattern harvest

Not generalizable: a cross-PR race where one PR froze a census and another changed a frozen member before the first landed.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@jeeshofone
jeeshofone requested review from a team and KiroCrewCaptain as code owners October 15, 2026 16:18
@jeeshofone
jeeshofone requested a review from bolichen97 October 15, 2026 16:18
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Oct 15, 2026
@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ⏭️ skipped

Revision 819bc6b6239f70800c39d89899d47e3668a9a96f touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ⏭️ skipped

Revision 819bc6b6239f70800c39d89899d47e3668a9a96f ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 819bc6b6239f70800c39d89899d47e3668a9a96f via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] 819bc6b

Description read

[DESCRIPTION-READ] 8c60e8ba2c78b9151df32af13e7830fb88ab7dc003d17787172d8110fc5bb13d

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 819bc6b6239f70800c39d89899d47e3668a9a96f via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 819bc6b

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 819bc6b6239f70800c39d89899d47e3668a9a96f via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 819bc6b

…ng census

kirodotdev#20743 gave AcpProvider an `approval_withdrawable` class flag and a
`withdraw_if` keyword on `approve_tool`. The frozen census added with
kirodotdev#20838 listed neither, so test_acp_bindings failed on main. Add the flag
and update the `approve_tool` signature digest.

Fixes kirodotdev#20893
@jeeshofone
jeeshofone force-pushed the fix/20893-acp-bindings-census branch from d6a1acd to 819bc6b Compare October 15, 2026 17:04
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 15, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the red main. #20743 added the approval_withdrawable class flag and the withdraw_if keyword on approve_tool, but the AcpProvider binding census in test/test_acp_bindings.py was not updated, so test_the_member_set_is_the_frozen_inventory and test_each_member_keeps_its_kind_shape_and_owner[approve_tool] fail on main (Backend Tests shard 5, Linux and Windows, plus the Coverage Gate downstream).

Verified: the new data row matches the existing _abc_impl / reports_effort_support shape, and d240c0f882a7 is the digest CI reports for the new signature. With this diff applied on current main, test/test_acp_bindings.py passes locally (147 passed).

#20902 makes the same change; whichever lands second can be closed.

@buluoray
buluoray enabled auto-merge (squash) October 15, 2026 17:31
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 15, 2026
@buluoray

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew Auto-Pipeline [operator: buluoray#ce473fca]: closing as a duplicate of #20902, which records the same two census rows without inline comments, matching the rest of the table. Thanks for jumping on the red main!

@buluoray buluoray closed this Oct 15, 2026
auto-merge was automatically disabled October 15, 2026 17:36

Pull request was closed

@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

main red: test_acp_bindings census not updated for #20743 (approval_withdrawable, approve_tool)

2 participants