Repository navigation
test(acp): record #20743's members in the AcpProvider binding census - #20894
jeeshofone wants to merge 1 commit into
Conversation
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5, fork) — ⏭️ skippedRevision |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] 819bc6b Description read[DESCRIPTION-READ] 8c60e8ba2c78b9151df32af13e7830fb88ab7dc003d17787172d8110fc5bb13d That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
…ng census kirodotdev#20743 gave AcpProvider an `approval_withdrawable` class flag and a `withdraw_if` keyword on `approve_tool`. The frozen census added with kirodotdev#20838 listed neither, so test_acp_bindings failed on main. Add the flag and update the `approve_tool` signature digest. Fixes kirodotdev#20893
d6a1acd to
819bc6b
Compare
buluoray
left a comment
There was a problem hiding this comment.
Fixes the red main. #20743 added the approval_withdrawable class flag and the withdraw_if keyword on approve_tool, but the AcpProvider binding census in test/test_acp_bindings.py was not updated, so test_the_member_set_is_the_frozen_inventory and test_each_member_keeps_its_kind_shape_and_owner[approve_tool] fail on main (Backend Tests shard 5, Linux and Windows, plus the Coverage Gate downstream).
Verified: the new data row matches the existing _abc_impl / reports_effort_support shape, and d240c0f882a7 is the digest CI reports for the new signature. With this diff applied on current main, test/test_acp_bindings.py passes locally (147 passed).
#20902 makes the same change; whichever lands second can be closed.
|
🤖 Kiro Crew Auto-Pipeline [operator: buluoray#ce473fca]: closing as a duplicate of #20902, which records the same two census rows without inline comments, matching the rest of the table. Thanks for jumping on the red main! |
Pull request was closed
Problem / Motivation
Goal: Make
test/test_acp_bindings.pypass on main again by recording theAcpProvidermembers that #20743 changed.#20838 froze a census of every
AcpProvidermember, with a digest of each signature. #20743 then gaveAcpProvideranapproval_withdrawableclass flag and awithdraw_ifkeyword onapprove_tool. The census lists neither change, sotest_the_member_set_is_the_frozen_inventoryandtest_each_member_keeps_its_kind_shape_and_owner[approve_tool]fail on main.Why it matters
Every PR that runs the backend tests picks up these two failures from main.
Not a goal
src/. The members are right, the census is stale.*_bindingscensuses.What changed (motivation → approach → change)
The census is a frozen inventory, so the fix is to bring its two entries up to the shape #20743 gave them: a new
approval_withdrawabledata entry, and the new signature digest forapprove_tool. Each entry carries a one-line comment saying what the change is. The entries are the only change, intest/test_acp_bindings.py.Backwards compatibility
Compatible: test-only change, no runtime behaviour touched.
Removes nothing: two census entries are added or updated and none is dropped.
Tests
test/test_acp_bindings.pyfails onorigin/main(2 failed, 144 passed) and passes with this change.test/test_client_bindings.pyand the other*_bindingscensuses pass.Manual verification
N/A — unit coverage sufficient: the change is to a unit test's expected values.
Related Issues
Fixes #20893
Pattern harvest
Not generalizable: a cross-PR race where one PR froze a census and another changed a frozen member before the first landed.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.