Repository navigation
test(providers): list approval_withdrawable and approve_tool's new signature - #20902
Conversation
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] 37d5f8c Description read[DESCRIPTION-READ] 627f9782a0d160cd3ba7d46eaaab453ca19b04e28ab061e30efcc9ed40ffd7dd That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
buluoray
left a comment
There was a problem hiding this comment.
Fixes the red main: records #20743's approval_withdrawable flag and approve_tool's new signature digest (d240c0f882a7, the value CI reports) in the AcpProvider binding census. The data row matches the existing _abc_impl / reports_effort_support shape. The same two rows applied on current main pass test/test_acp_bindings.py locally (147 passed). Preferred over #20894 because it keeps the table uncommented like the rest of the census.
Problem / Motivation
Goal:
test/test_acp_bindings.pypasses on main again, so PRs stop failing a Backend Tests shard for a reason outside their diff.Two reds on main @ 9dafed1, both in
test/test_acp_bindings.py:test_the_member_set_is_the_frozen_inventory:AcpProvider.approval_withdrawableis not in the inventory.test_each_member_keeps_its_kind_shape_and_owner[approve_tool]:approve_toolgainedwithdraw_if, so its signature digest is nowd240c0f882a7.#20743 added both. #20838 froze the inventory around the same time, so neither PR's CI saw the other's change.
Why it matters
Every open PR whose Backend Tests shard runs this file is red.
Not a goal
approve_toolorapproval_withdrawablebehavior.What changed (motivation → approach → change)
One
datarow forapproval_withdrawable, and the new digest forapprove_tool. Same as the other members' rows.Backwards compatibility
Compatible: test-only change.
Removes nothing.
Tests
test/test_acp_bindings.py: 2 failed on main @ 9dafed1, 147 passed with this change.flake8andblack --checkon the file exit 0.Manual verification
N/A: the existing test covers it.
Related Issues
Closes #20901
Pattern harvest
Not generalizable: a merge-order collision the existing test already catches.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)