Skip to content

test(providers): list approval_withdrawable and approve_tool's new signature - #20902

Merged
buluoray merged 1 commit into
mainfrom
fix/acp-bindings-approval-withdrawable
Oct 15, 2026
Merged

buluoray merged 1 commit into
mainfrom
fix/acp-bindings-approval-withdrawable

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: test/test_acp_bindings.py passes on main again, so PRs stop failing a Backend Tests shard for a reason outside their diff.

Two reds on main @ 9dafed1, both in test/test_acp_bindings.py:

  • test_the_member_set_is_the_frozen_inventory: AcpProvider.approval_withdrawable is not in the inventory.
  • test_each_member_keeps_its_kind_shape_and_owner[approve_tool]: approve_tool gained withdraw_if, so its signature digest is now d240c0f882a7.

#20743 added both. #20838 froze the inventory around the same time, so neither PR's CI saw the other's change.

Why it matters

Every open PR whose Backend Tests shard runs this file is red.

Not a goal

  • Changing approve_tool or approval_withdrawable behavior.

What changed (motivation → approach → change)

One data row for approval_withdrawable, and the new digest for approve_tool. Same as the other members' rows.

Backwards compatibility

Compatible: test-only change.

Removes nothing.

Tests

  • test/test_acp_bindings.py: 2 failed on main @ 9dafed1, 147 passed with this change.
  • flake8 and black --check on the file exit 0.

Manual verification

N/A: the existing test covers it.

Related Issues

Closes #20901

Pattern harvest

Not generalizable: a merge-order collision the existing test already catches.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

…gnature

#20743 added AcpProvider.approval_withdrawable and the withdraw_if parameter on
approve_tool while #20838 froze the provider inventory, so test_acp_bindings
fails on main. Record both.

Closes #20901
@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 15, 2026 17:24
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 37d5f8c86d80f16c5829e652c5b0048c6178d304 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 37d5f8c86d80f16c5829e652c5b0048c6178d304 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 37d5f8c86d80f16c5829e652c5b0048c6178d304 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] 37d5f8c

Description read

[DESCRIPTION-READ] 627f9782a0d160cd3ba7d46eaaab453ca19b04e28ab061e30efcc9ed40ffd7dd

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 37d5f8c86d80f16c5829e652c5b0048c6178d304 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 37d5f8c

Verdict parsed from the review's SHA-scoped output markers for commit 37d5f8c86d80f16c5829e652c5b0048c6178d304.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 37d5f8c86d80f16c5829e652c5b0048c6178d304: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 37d5f8c86d80f16c5829e652c5b0048c6178d304 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 37d5f8c

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 37d5f8c86d80f16c5829e652c5b0048c6178d304: <one-sentence reason>

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the red main: records #20743's approval_withdrawable flag and approve_tool's new signature digest (d240c0f882a7, the value CI reports) in the AcpProvider binding census. The data row matches the existing _abc_impl / reports_effort_support shape. The same two rows applied on current main pass test/test_acp_bindings.py locally (147 passed). Preferred over #20894 because it keeps the table uncommented like the rest of the census.

@buluoray
buluoray merged commit 0694e63 into main Oct 15, 2026
98 of 100 checks passed
@buluoray
buluoray deleted the fix/acp-bindings-approval-withdrawable branch October 15, 2026 17:34
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Oct 15, 2026
@iamwhatever iamwhatever mentioned this pull request Oct 15, 2026
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_acp_bindings fails on main: approval_withdrawable and approve_tool missing from inventory

2 participants