Skip to content

feat(dashboard): the warm welcome reports like a manager: ask, progress, what needs you - #23847

Merged
iamwhatever merged 1 commit into
mainfrom
feat/warm-brief-manager-report
Oct 25, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
feat/warm-brief-manager-report

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: When the owner comes back to a crewmate chat, the warm welcome reads like a manager's report: is it on track, what must the owner do, how far is it from the goal (counted from the real work ledger), and what did they ask for.

The warm welcome card (#22839) shows four short fields. The owner says it carries too little to act on. It does not say whether the work is on track, how much is done, or what is left, and people forget what a task line was about.

Why it matters

The brief is the first thing the owner reads after time away. If it cannot tell them where things stand and what they must do, they have to scroll the transcript or ask, which is the work the brief exists to save.

Not a goal

  • Changing when the brief fires, the opener, the failure line, spend, or staleness rules.
  • Letting the model report progress numbers: the count comes from the work ledger only.
  • The cold welcome / Recap (MateWelcomeCard, mateGreeting, member_recap).
  • Making any field a link, a button or markdown.

What changed (motivation → approach → change)

Part Before After
Top line now status chip (on track / waiting on you / blocked / done) + headline
Needs you action action + what it unblocks, highlighted, shown first after the top line
Progress none N of M done bar, counted by the gateway over the current goal's work items; the model's numbers are ignored
What is left none remaining, one line from the model
Done / Next Next only Done (≤4) and Next (≤3)
Room for the AI none up to two extra sections {title, items} for a risk, a cost or a choice

The gateway side lives in dashboard/warm_task_brief.py; the card is chat/WarmBriefCard.tsx.

The prompt now casts the model as a professional manager reporting to the owner who hired it: lead with on-track and what needs the owner, remind them what they asked, say how far from the goal in real terms, no filler, never an invented number. The snapshot it reads carries the same accepted/total count, so its "what is left" line agrees with the bar. An unknown status falls back to "waiting on you" when something needs the owner, else "on track"; "on track" or "done" above a Needs you box reads as "waiting on you".

Every new field goes through the same redaction, control-marker defang and caps as before, and the card draws each one as a plain text node. The plain-text content copy follows the card's order, with labels in the request's language. The new card labels are added to every locale (locales/en.manual.json and the translated catalogs).

The decision is recorded in docs/request-for-change/rfc-delayed-task-brief.md (a dated 2026-10-24 amendment in the status list and section 5.1, on top of the accepted RFC). The session and history specs and the feature map name the new fields; website/scripts/capture-warm-brief-card.mjs captures the new card.

Backwards compatibility

Compatible: a stored brief in the older shape (asked, now, needs_you, next) still draws, now as the headline and with no status chip; a malformed one keeps the ordinary bubble, as before. A model reply in the older now or prose message shape is read as the headline.

Removes nothing: the older fields are still read; only new fields are written.

Tests

  • test/test_warm_task_brief.py: the full return-to-result path stores the new shape and its plain text in report order; every language has every label.
  • test/test_warm_task_brief_shape.py (the pure parse/cap/redact tests, split out to stay under the 2,000-line test-file cap): progress comes from the ledger even when the model returns other numbers, counts only the current goal's items after a new goal, and is left out with no items or when the goal's items cannot be told apart; status vocabulary fallback; caps and item limits on every field and list, including extra; malformed extra sections dropped; redaction, rejoined tokens and every control marker defanged in every new field, extra titles and items included; prose-only and headline-less replies refused; Chinese labels.
  • website/src/test/warmTaskBrief.test.tsx: card section order; empty sections left out; no bar without a count; older shape renders; status and progress validation; caps; markup in every field stays text; chat search counts match the card's text nodes.

Nearby inputs checked: no work items (tested), all items done (tested, 2 of 2), model omits headline (tested, refused), prose only (tested, refused → failure line), very long fields (tested, capped), [OPTIONS: inside extra (tested, defanged).

Proof: not provable -- other: a feature change, not a fix; the new tests pin new behaviour

Manual verification

Captured the real Members page with node scripts/capture-warm-brief-card.mjs (dark and light, 1280 px and 320 px for before/after): card drawn, no link/button/img inside, bar only with a count, reload draws the same card, card fits the viewport, no page errors.

Screenshots / video

After (dark, 1280 px):

after dark

After (light, 320 px) and a blocked brief in Chinese:

after light 320

chinese

Older brief, no work items, all done, injection

before

no work items

all done

injection

Related Issues

Closes #23827

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 24, 2026 21:28
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 24, 2026
@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 5649df0ab9fa68b85e5ad468e7b0bee441bbe166 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the progress count comes only from the gateway's ledger, briefs stored in the older shape still draw, and no reader outside the patch reads meta.now.

Notes

  • _goal_progress returns no count when the goal's items cannot be told apart, for example when two items were created in the same second at the cut. With a model-written remaining line next to it, the bar can disappear between visits for no reason the owner can see. Worth watching, not fixing here.

[DESIGN-REVIEWED] 5649df0

Description read

[DESCRIPTION-READ] 0bdd732de4f78f464811f943d50b99ed19c245d72113728cf00c2a15df1a4f93

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 5649df0ab9fa68b85e5ad468e7b0bee441bbe166 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. extra sections and the done list go beyond the frozen Goal. Whether the RFC amendment, which only this diff adds, counts as a recorded decision for the replaced card is a judgement call.

Notes

  • Item 6 — oversized: the Goal names on-track, needs-you, progress and asked. "up to two extra sections {title, items} for a risk, a cost or a choice" is outside it. Subtraction: delete _clean_extra, _MAX_EXTRA_SECTIONS, _MAX_EXTRA_TITLE_CHARS, the extra prompt field and the card's extra rendering; a risk or choice that needs the owner already fits in needs_you.
  • Item 5 — oversized: the done list (≤4) answers none of the Goal's four questions, and progress already says how much is done. Subtraction: delete done, _MAX_DONE_ITEMS and the "Done so far" label.
  • Item 1 — inherited: the 2026-10-24 amendment that covers the new four-to-nine-field shape exists only in this diff. The base's accepted RFC section 5.1 pins the four-field card this PR replaces. That reads as proposed, not recorded, if a maintainer counts a card redesign as product shape.

What this change ships

Inventory (8 items) — 5 justified

Intent: when the owner comes back, show them status, what needs them, real progress and their original ask. ADDITION.

  1. The card's top line shows a status chip (on track / waiting on you / blocked / done) and a headline instead of now — inherited
  2. Needs you moves up to come straight after the top line, highlighted — justified
  3. An "N of M done" bar, counted by the gateway from the current goal's ledger items — justified
  4. A one-line "what is left" from the model — justified
  5. A Done list of up to four items — oversized
  6. Up to two sections the model writes itself — oversized
  7. Older stored briefs and older now/message replies still draw — justified
  8. The plain-text content follows the new order, with labels in every language — justified

[FIRST-PRINCIPLES-REVIEWED] 5649df0

Description read

[DESCRIPTION-READ] 6cc26c797edf3d725027fbb92a09e114c144a16769fa93357e3933634737ccee

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 5649df0ab9fa68b85e5ad468e7b0bee441bbe166 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. Every element this PR adds appears in a screenshot, and the blind reader read the status chip, headline and progress bar correctly. The card has no clickable controls, as the PR states.

Notes

  • STATUS_CHIP.done uses the same bg-ok-subtle text-ok-text as on_track. The reader said "On track" and "Done" "are hard to tell apart at a glance". Give done its own neutral or muted token.
  • The needs_you chip says "Waiting on you" next to a box headed "Needs you". The reader saw them as the same message twice and could not say how it differs from "Blocked". Either drop the chip when the box is shown, or rename the chip so it reads as a status rather than a repeat of the box.
  • When there is no progress count, warm-brief-progress still shows the "Progress" heading with only "Left: …" under it. The reader wondered "whether something failed to load" (shot-05). Leave out the heading when there is no bar, or call it "Left" on its own.

[UX-REVIEWED] 5649df0

Description read

[DESCRIPTION-READ] 8756fca3d3ee759638b70043ca1b84c10c835a51170023cb119b5d8b0b29f5d5

That sha256 names everything this verdict read: the PR description, plus the 10 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 5649df0ab9fa68b85e5ad468e7b0bee441bbe166 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 5649df0

Verdict parsed from the review's SHA-scoped output markers for commit 5649df0ab9fa68b85e5ad468e7b0bee441bbe166.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 5649df0ab9fa68b85e5ad468e7b0bee441bbe166 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 5649df0ab9fa68b85e5ad468e7b0bee441bbe166 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 5649df0

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 5649df0ab9fa68b85e5ad468e7b0bee441bbe166 false-positive: <reason, 20 to 500 characters>

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Reject mismatched header/item counts in both directions span=856bc90726e9 -- fixed

fixed in fd7d659: _goal_progress now omits progress whenever the stored item count differs from the header's created_total, in either direction, so a create landing between the two reads can no longer cut an item.
Regression case added to test_progress_counts_the_current_goal_never_the_model (header 6, seven stored items -> no count); test/test_warm_task_brief.py 338 passed.

@iamwhatever
iamwhatever force-pushed the feat/warm-brief-manager-report branch from 2c415ad to fd7d659 Compare October 24, 2026 22:01
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 24, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: main merged #23828 into src/kiro_crew/dashboard/warm_task_brief.py and test/test_warm_task_brief.py, which made this PR CONFLICTING (fd7d659 -> f19d75a on 0dab198). Resolved by keeping both: the snapshot carries #23828's running_workers and this PR's progress. test_warm_task_brief.py + test_slot_running_readers.py 355 passed; warmTaskBrief/ChatPane.preparing vitest 69 passed; flake8/isort/mypy/black clean. CI re-running.

@iamwhatever
iamwhatever force-pushed the feat/warm-brief-manager-report branch from fd7d659 to f19d75a Compare October 24, 2026 23:11
@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 24, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • A backward clock correction counts the previous goal as current progress span=856bc90726e9 -- rebutted

Rebutted: disproportionate, as the Opus adjudication found. It needs a backward wall-clock step landing exactly between the last item of one goal and the first of the next; the effect is one wrong display count, no data written or lost.
Closing it needs a durable per-item creation sequence or goal-membership field in the work-ledger write protocol (work_ledger_writes.py _create_item) plus legacy handling, a schema change outside this PR's goal.
The guards this PR does carry (count mismatch, unparseable times, ties at the cut) already omit progress whenever the order is visibly unknown.

@iamwhatever
iamwhatever force-pushed the feat/warm-brief-manager-report branch from f19d75a to 0507f66 Compare October 24, 2026 23:22
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Bundle Size Gate red here is inherited from main: pristine main @ 0dab198 already builds ModelEffortDropdown over its 500 KB budget (505.0 KB per #23867). This PR's merge ref measures 507.9 KB, so the card adds about 2.9 KB. #23867 re-measures the ceiling to 531 KB, which covers that. Waiting for #23867 to land, then this PR rebases and re-runs the gate; no override requested.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 25, 2026
@iamwhatever iamwhatever reopened this Oct 25, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 25, 2026
@iamwhatever

iamwhatever commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor Author

Rebased: the fresh run after close/reopen still measured ModelEffortDropdown against a 500 KB budget because GitHub's merge ref (a1967ed) was still built on 0dab198, before #23867's 531 KB ceiling (3503760). Rebased 0507f66 -> bcbfa5d onto main, which carries #23867. Warm-brief pytest 353 passed, warmTaskBrief vitest 66 passed. No code change. CI re-running.

@iamwhatever
iamwhatever force-pushed the feat/warm-brief-manager-report branch from 0507f66 to bcbfa5d Compare October 25, 2026 02:07
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 25, 2026
@iamwhatever

iamwhatever commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor Author
  • An unreadable header counts previous goals as current progress span=856bc90726e9 -- fixed

fixed in 5649df0: _goal_progress returns no count when the conductor record is unavailable; only a readable header with goal_version == 0 counts every item on the board.
A healthy board cannot hold items without a header (_create_item writes the header first under the conductor lock), so (None, items) always means an unreadable header.
Tests: the record-None cases now expect no count, and a readable never-a-goal board still counts every item; warm-brief pytest 354 passed.

@iamwhatever
iamwhatever force-pushed the feat/warm-brief-manager-report branch from bcbfa5d to 5649df0 Compare October 25, 2026 02:23
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 25, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at 5649df0ab9fa68b85e5ad468e7b0bee441bbe166.

The returning owner now gets a status, what needs them, a real progress count and what is left, instead of four thin fields. The count comes from the work ledger, and the model's numbers are ignored (_goal_progress, and _parse_result takes progress from the snapshot). Where the current goal's items cannot be named (unreadable or legacy header, item count different from created_total, unparseable or tied creation times), the card shows no count rather than a wrong one.

Checked:

  • Every new field, including extra titles, goes through _clean (redaction, marker defang, cap). The card draws each one as a plain text node, and the renderer re-validates status and progress on its own.
  • All 8 new card keys are present in en.manual.json, en-XA and all 12 translated catalogs, with both placeholders kept in progress_count. The backend label rows are zip(strict=True), so a missing label fails at import.
  • No docs/decisions/ entry covers the warm brief, so nothing is contradicted. The change is recorded as a dated amendment on the accepted rfc-delayed-task-brief.md, and the session/history specs and feature map are updated in the same commit.
  • Locally on this head: backend 354 passed, warmTaskBrief.test.tsx 66 passed, src/i18n 1035 passed, lint:i18n OK, tsc -p tsconfig.app.json clean.
  • 10 mutations, each with a named red test: gateway progress dropped, count-mismatch guard, tie guard, unreadable header, status coercion, empty extra sections, extra title skipping _clean, and on the frontend the progress bound, the now fallback and status validation. None survived.

Non-blocking follow-up: in Hindi, Bengali and Russian the card uses the informal you while the copied plain text (_TEXT_LABEL_ROWS) uses the formal one, so Copy reads in a different register from the card. This predates the PR for the existing labels, but it now covers more lines.

@iamwhatever
iamwhatever enabled auto-merge (squash) October 25, 2026 06:35
@iamwhatever
iamwhatever merged commit 74c8d95 into main Oct 25, 2026
107 checks passed
@iamwhatever
iamwhatever deleted the feat/warm-brief-manager-report branch October 25, 2026 07:09
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 25, 2026
iamwhatever pushed a commit that referenced this pull request Oct 26, 2026
Bring the delayed-task-brief RFC and its directory index into agreement
with the document's amendments and with what shipped on main.

The warm task brief shipped in #20422 and its 2026-10-18, 2026-10-22 and
2026-10-24 amendments shipped in #21750, #22828, #22839 and #23847, but
the RFC still read `accepted` ("nothing built yet") with
implementation-prs [] and a 2026-10-14 audit stamp.

The front matter now records status implemented, those five PRs, and
last-audited 2026-10-26 at 1cf77b5; the section 1 status and
"Audited on" lines match it; and the snapshot's third field is renamed
"Suggested actions" to match the section 3.5 output it feeds.

The README index row no longer describes the superseded preparing-status
design or says implementation waits for the RFC. It reads implemented,
names the shipped PRs, and summarises the shipped trigger and card.
The audit paragraph gains a dated re-audit sentence for the row.

Closes #20887
iamwhatever pushed a commit that referenced this pull request Oct 28, 2026
Bring the delayed-task-brief RFC and its directory index into agreement
with the document's amendments and with what shipped on main.

The warm task brief shipped in #20422 and its amendments shipped in
#21750, #22828, #22839, #23847, #24512 and #24307, but the RFC still
read `accepted` ("nothing built yet") with implementation-prs [] and a
2026-10-14 audit stamp.

The front matter now records status implemented, those seven PRs, and
last-audited 2026-10-28 at 7cbf872; the section 1 status and
"Audited on" lines match it; and the snapshot's third field is renamed
"Suggested actions" to match the section 3.5 output it feeds.

The README index row no longer describes the superseded preparing-status
design or says implementation waits for the RFC. It reads implemented,
names the shipped PRs, and summarises the shipped trigger, the
free-form brief card and the leave-after-opener rule. The audit
paragraph gains a dated re-audit sentence for the row.

Closes #20887
iamwhatever pushed a commit that referenced this pull request Oct 29, 2026
Bring the delayed-task-brief RFC and its directory index into agreement
with the document's amendments and with what shipped on main.

The warm task brief shipped in #20422 and its amendments shipped in
#21750, #22828, #22839, #23847, #24512 and #24307, but the RFC still
read `accepted` ("nothing built yet") with implementation-prs [] and a
2026-10-14 audit stamp.

The 2026-10-28 writer amendment (section 3.8, #25433) is design only:
main has no wake turn and no `dashboard.warm_brief_wake` setting. So
the front matter now records status partial, those seven PRs, and
last-audited 2026-10-29 at 4d36177; the section 1 status line
names what shipped and that section 3.8 is not built; the "Audited on"
line matches; and the snapshot's third field is renamed "Suggested
actions" to match the section 3.5 output it feeds.

The README index row no longer describes the superseded preparing-status
design or says implementation waits for the RFC. It reads partial,
names the shipped PRs, summarises the shipped trigger, the free-form
brief card and the leave-after-opener rule, and names the unbuilt
writer amendment. The audit paragraph gains a dated re-audit sentence
for the row.

Closes #20887
iamwhatever pushed a commit that referenced this pull request Nov 2, 2026
…21712)

Bring the delayed-task-brief RFC and its directory index into agreement
with the document's amendments and with what shipped on main.

The warm task brief shipped in #20422 and its amendments shipped in
#21750, #22828, #22839, #23847, #24512, #24307, #25881 (Crew Mode
scope), #26500 (fixed progress orb) and #26652 (first part of the
2026-10-31 redesign), yet the front matter and README row still
read `accepted` ("nothing built yet") with implementation-prs [] and a
2026-10-14 audit stamp.

Not built on main: the 2026-10-28 writer amendment (section 3.8; main
has no wake turn and no `dashboard.warm_brief_wake` setting), the
2026-11-01 trigger amendment (#26938 is open), and the live checks,
links and copied option buttons of section 3.9.3. So the front matter
now records status partial, those ten PRs, and last-audited 2026-11-01
at fed53fc; the section 1 status line names what shipped and what
is not built; the "Audited on" line matches; and the snapshot's third
field is renamed "Suggested actions" to match the section 3.5 output it
feeds.

The README index row no longer describes the superseded preparing-status
design or says implementation waits for the RFC. It reads partial,
names the shipped PRs, summarises the shipped trigger, the one-message
brief with its fixed card and quiet return, and names the unbuilt
parts. The audit paragraph gains a dated re-audit sentence for the row.

Closes #20887
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warm welcome brief: report like a manager (status, progress, what needs you)

2 participants