Repository navigation
feat(crew-mode): lightning bolt for Ultra Mode, chat icon for session count, Board tab - #26291
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the rulings are recorded in a decision entry, the removed layout-id exports have no reader left in the tree, and the screenshots cover each reshaped surface. Notes
[DESIGN-REVIEWED] cb7066c Description read[DESCRIPTION-READ] f0da02486954a40322dac71848466868125f33ad90b535ee633a4d14a2e72d5a That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ human override accepted@bolichen97 overrode this lane for |
UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing the one-word Ultra Mode row states ("Needs you" / "Running" / "Paused") and their tooltips. The after shot also still shows the full "Loop 7/300 · Nothing changed sinc…" line, which contradicts the stated change. Evidence gaps
Notes
[UX-REVIEWED] cb7066c Description read[DESCRIPTION-READ] 92cc28e47f8ec659c010ca386d92f177b34404544e53f380d635334c4d30b8ff That sha256 names everything this verdict read: the PR description, plus the 11 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ human override acceptedReviewed Human judgment by @bolichen97 overrides the Opus 5.5 finding for [OPUS-OVERRIDE] cb7066c Verdict recorded from an authorized human decision for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
53fdaed to
ed3975b
Compare
|
[operator: bolichen97] Maintainer ruling for this PR, relayed at his direction by the agent driving it. Decided by Bolin Chen (maintainer, Crew Mode design owner):
|
ed3975b to
a5724d1
Compare
|
/ai-review override first-principles a5724d1 owner-decision: The maintainer ruled every item this PR ships, including the Board tab name, the one-word Ultra Mode row state and "From the main chat": #26291 (comment). The new decision entry records it and supersedes "the Crew tab keeps its name"; the Goal names all of it. |
Human judgment recorded@bolichen97 recorded a owner-decision release (class
This decision applies only to this commit. A new push requires a new judgment. |
|
Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: First Principles Review. Re-run the lane's latest workflow run for |
a5724d1 to
0fb132e
Compare
|
/ai-review override first-principles 0fb132e owner-decision: The maintainer ruled every item this PR ships, including the Board tab name, the one-word Ultra Mode row state and "From the main chat": #26291 (comment). The new decision entry records it and supersedes "the Crew tab keeps its name"; the Goal names all of it. |
Human judgment recorded@bolichen97 recorded a owner-decision release (class
This decision applies only to this commit. A new push requires a new judgment. |
… count, Board tab Ultra Mode wears a lightning bolt instead of the Kiro ghost: the sidebar row's ULTRA MODE eyebrow, the composer chip and mark, and the Sessions filter. The root row's session count wears the chat icon. The side panel tab reads "Board" (the view id stays `workers`) with the bolt, and the Feature Preview card says the crew is tracked on a Board. The composer mark drops the layout id it shared with the old chip, so nothing slides into place on mount or on a session switch. An Ultra Mode row's own state is one word (Needs you, Running, Paused) with the full line in its tooltip, and a message the main chat delivered reads "From the main chat" instead of "From conductor".
0fb132e to
cb7066c
Compare
|
/ai-review override first-principles cb7066c owner-decision: The maintainer ruled every item this PR ships, including the Board tab name, the one-word Ultra Mode row state and "From the main chat": #26291 (comment). The new decision entry records it and supersedes "the Crew tab keeps its name"; the Goal names all of it. |
|
/ai-review override fable cb7066c owner-decision: The flag is the recorded-decisions rule asking for a maintainer ruling on the Supersedes line. The maintainer ruled the bolt, the Board tab name and the one-word row: #26291 (comment), and the new entry records exactly that. The Running-tooltip note is fixed in this head. |
Human judgment recorded@bolichen97 recorded a owner-decision release (class
This decision applies only to this commit. A new push requires a new judgment. |
|
Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: First Principles Review. Re-run the lane's latest workflow run for |
Human judgment recorded@bolichen97 recorded a owner-decision release (class
This decision applies only to this commit. A new push requires a new judgment. |
|
Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: Opus 5.5. Re-run the lane's latest workflow run for |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approved on behalf of the watch holder (bolichen). Design and First Principles pass on this head, UX skipped or pass, no conflict, no open change request.
Problem / Motivation
Goal: Ultra Mode wears a lightning bolt wherever it is marked, the Sessions row counts sessions with the chat icon, an Ultra Mode row's own state is one short word, the side-panel tab for the Ultra Mode task board reads Board, and no Ultra Mode text says "conductor". The maintainer's ruling: #26291 (comment), recorded in
docs/decisions/2026-10-30-ultra-mode-is-marked-with-a-bolt-and-its-tab-is-the-board.md, which supersedes "the Crew tab keeps its name".#25872 shipped Ultra Mode with the Kiro ghost as its mark. The ghost is the product's own mascot, so it does not say "this chat runs Ultra Mode". On the Sessions row it also stood for the session count, where the chat icon already means "sessions". The side-panel tab said Crew for what is the Ultra Mode task board.
Why it matters
The owner wants one clear mark for Ultra Mode and words that match what each place does. A lightning bolt reads as "Ultra"; the chat icon reads as "sessions"; "Board" names the page.
Not a goal
workers, so stored tabs keep working with no migration.lucide-react(Zap,MessageSquare), already used across the app.What changed (motivation → approach → change)
Zap)MessageSquare) + N, then ● running"conductor" in user text: the one Ultra Mode hit was the seed header (
pages.chat.userMessage.seed_from_conductor, documented inwebsite/src/lib/crewSeed.ts), now "From the main chat" in all twelve catalogs. The other hits name different features and are left as they are: the Folder conductor preview, the agent label of the conductor template, and the Crew Board page (/crew-board), which shows the ledger's conductor session.Where it lands:
website/src/pages/chat-sidebar(SessionRow.tsx,filters.tsx),website/src/components(CrewModeChip.tsx,crew/CrewModeMarks.tsx),website/src/pages/chat(SidePanelTabIcons.tsxand the composer comment inpage/ComposerDockView.tsx), the tab labelcommandCenter.workersandfeaturePreviewsTab.crew_mode_descin the twelve catalogs ofwebsite/src/i18n(plusen.context.json), the regenerated settings registry (website/src/components/commandPalette/settingsRegistry.gen.ts,src/kiro_crew/docs/settings-registry.generated.json), the user docsrc/kiro_crew/docs/agents.md, and the new decision entry plus its row indocs/decisions/README.md.The chip "flying" into the new chat (owner report on gateway e598df5). On that build the chip shared a framer-motion
layoutIdwith the composer mark, so it slid in from the mark's old place. On currentmainI measured it on a pod with the preview on: on a new chat opened from an Ultra Mode chat, the chip, the memory-mode chip and the composer all move right by the same 233 px. The side panel closing re-centers the column; the chip never moves on its own (its offset from the memory chip stays 179 px). This PR also removes the now-unused sharedlayoutIdandCrewModeMarkSourcefrom the mark, so nothing in Ultra Mode can slide on mount or on a session switch. Measurements are in Manual verification.Backwards compatibility
Compatible: icon and label only. The
workersview id, routes, stored tabs and the preview flag are unchanged.Reader: website/src/components/crew/CrewModeMarks.tsx:CREW_MODE_MARK_LAYOUT_ID -- composer -- removed with
CrewModeMarkSource; no caller left in the tree (only its own test, replaced)Tests
CrewModeChip.test.tsx: the chip wears the lightning bolt, not the ghost.CrewModeMarks.test.tsx: the composer mark wears the lightning bolt, not the ghost (replaces the removed mark-source test).ChatSidebar.conductorLane.test.tsx: the eyebrow mark is a 12 px bolt; the session count wears the chat icon and no ghost.sidePanelAddMenu.test.tsx,sidePanelCrewDefaultTab.test.tsx: the tab is found and named "Board".FeaturePreviewIntro.test.tsx: the card line says "Board".ChatSidebar.conductorLane.test.tsx: an Ultra Mode row whose own state is a question reads "Needs you" with "Needs your answer" in its tooltip and nowhere in the row; an approval reads "Needs you" with "Approval needed · 1" in the tooltip; live work reads "Running".ChatSidebar.conductorLane.test.tsx: a failed crew read keeps the row's own "Needs you" beside the failure; a stalled goal loop maps to "Paused", never "Running". An Ultra Mode root with no crew member yet still shows its one word, not the full line. Queued children and a passive monitor map to "Waiting", never "Done", and every live state keeps its own line (tool phase, loop cycle, workflow, sub-agent count) in the tooltip.UserMessage.sessionSeed.test.tsx: a message the Crew Mode root sent reads "From the main chat", never "conductor".Manual verification
Pod of this branch, preview on, real sessions (1440x900, English). Chip position sampled every 40 ms after pressing New from the Ultra Mode chat "Tea Shop Launch Planning":
The chip moves only with the whole column. Switching back to the Ultra Mode chat and forward again moves everything 10 px the same way, as the panel toggles.
Screenshots
Sessions rows, before and after:
Each Ultra Mode row reads one word (Waiting, Running, Done here). Read from the DOM on this head: "Garden cafe opening" says Running with the tooltip "Loop 7/300 · Nothing changed since the last check…"; its old full line no longer shows on the row.
Side-panel tabs, before and after:
New chat with Ultra Mode on, before and after:
Board tab and a crew member view, after
Related Issues
Follow-up to #25872.
Checklist