Skip to content

fix(dashboard): put Explore behind a default-off Feature Preview - #27449

Merged
bolichen97 merged 1 commit into
mainfrom
fix/explore-feature-preview
Nov 2, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/explore-feature-preview

Conversation

@bolichen97

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Explore no longer shows for everyone by default; it appears only for users who turn on its Feature Preview.

Explore (the top-bar "Explore N/7" pill, the Explore sheet with the "Kiro Crew in 15 seconds" clip, Try today, the milestone notice and the Try today card on a new chat) shipped on by default in #26488. The bundled intro clip has Chinese text burned into its frames, so English users see Chinese the first time they open the sheet.

Why it matters

Every user, on main and on the 0.12.0 insider line, gets an unfinished surface in the top bar and a clip in a language most of them do not read.

Not a goal

  • Deleting Explore or changing how the server records milestones.
  • Re-recording or replacing the intro clip.
  • Changing what Explore does once the preview is on.

What changed (motivation → approach → change)

Explore now sits behind a new Feature Preview, Explore (mc-preview-explore), off by default, the same way Ultra Mode did in #25872. With it off there is no Explore pill (desktop or phone), no Explore menu row, no milestone notice, no Try today card on a new chat, no Explore sheet, and Settings hides the Display > Explore switch, including from settings search. Turning the preview off also closes an open sheet. With it on everything works as today, and Display > Explore (dashboard.milestones_enabled) stays the inner switch. The flag lives in previewFlags.ts with a useExplorePreview hook in usePreviewFlag.ts, and its card copy is added to every locale under website/src/i18n. The gateway syncs the switch as dashboard.feature_previews.explore. The generated settings and UI indexes in src/kiro_crew/docs, config-baseline.json and the feature map in docs/feature-map/README.md are updated to match.

Backwards compatibility

Compatible: no key, route or API changes; dashboard.milestones_enabled keeps its meaning and the server keeps recording milestones.

Reader: website/src/shell/topbar/shellHeader.tsx:ShellHeader -- crew page -- pill and sheet mount only with the preview on; MobileTopBar.explorePreview.test.tsx
Reader: website/src/pages/chat/page/MobileTopBar.tsx:MobileTopBar -- crew page -- phone pill and menu row gated; MobileTopBar.explorePreview.test.tsx
Reader: website/src/components/WelcomeView.tsx:WelcomeView -- chat -- Try today card gated; milestones.test.tsx
Reader: website/src/pages/settings/DisplayPanel.tsx:DisplayPanel -- crew page -- Explore switch hidden while off; DisplayPanel.milestones.test.tsx
Reader: website/src/components/commandPalette/settingsSearchCore.ts:settingEntryOffered -- crew page -- search hides Display > Explore while off; SettingsSearch.test.tsx, settingsSearchGovernance.test.ts
Reader: src/kiro_crew/config/sections_dashboard.py:dashboard.milestones_enabled -- release -- unchanged default and meaning; test_config_baseline.py

Tests

  • MobileTopBar.explorePreview.test.tsx (new): pill and menu row absent with the preview off, present with it on.
  • milestones.test.tsx, DisplayPanel.milestones.test.tsx: surfaces and the Display switch follow the preview.
  • SettingsSearch.test.tsx: an open search drops Display > Explore when the preview turns off.
  • settingsSearchGovernance.test.ts: the entry is not offered while the preview is off.

Proof: not provable -- frontend test (prove.py runs Python only)

Local: tsc clean, eslint clean, vitest 63 files / 963 tests green; Python config baseline, feature preview, find_ui and ui-index tests green except test_find_ui_auto.py::test_the_generated_auto_tier_answers_labels_only_it_carries[continue with github...], which fails the same on clean main.

Manual verification

Pod built from this head: fresh install shows no Explore pill and no Try today card; turning on Developer > Feature previews > Explore adds the "Explore 0/6" pill and the Try today card.

Screenshots / video

Preview off (default):

Preview off: no Explore pill, no Try today card

Preview on:

Preview on: Explore pill in the top bar and Try today card

Related Issues

Closes #27424

Sibling sweep

Swept: git grep -nE "useMilestones|MilestonesPill|MilestonesIndicator|MilestoneNoticeToast|MilestonesMenuItem|tryToday" -- website/src
Sibling: website/src/shell/notifications/notificationSheet.tsx -- changed here
Sibling: website/src/pages/chat/page/MobileTopBar.tsx -- changed here
Sibling: website/src/components/WelcomeView.tsx -- changed here

Pattern harvest

Not generalizable: a product ruling to move one shipped feature behind a preview, not a code defect class.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@bolichen97 bolichen97 self-assigned this Nov 1, 2026
@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners November 1, 2026 22:21
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 5d2df0141fd1a2321da6bd96a01858adc77ad0cd — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: every Explore surface on the frontend now checks one default-off preview flag, and the server-side meaning of dashboard.milestones_enabled does not change.

Notes

  • The flag hides Explore only in the browser; the server still counts milestones while it is off (decision D18). So the clip and the counting are still live, and a later decision to drop Explore entirely will need server-side work.

[DESIGN-REVIEWED] 5d2df01

Description read

[DESCRIPTION-READ] 536008331498ecdafd3aa5538bfe1c7c738bdb4dfe61b55087e2aacb34c9a0e1

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 5d2df0141fd1a2321da6bd96a01858adc77ad0cd — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing the new Explore card in Developer > Feature previews. That card is the only way to turn Explore on, and no screenshot shows it.

Evidence gaps

  • Developer > Feature previews > Explore card (FeaturePreviewsSection.tsx, label "Explore", description "Adds Explore to the top bar: features to try, your progress, and a Try today card on a new chat."). It appears in neither shot-01 nor shot-02, so the blind reader never saw it. A screenshot of the Feature previews tab showing the card next to its siblings, off and on, would close this.
  • Display > Explore switch, hidden while the preview is off and shown while it is on (DisplayPanel.tsx). Neither state is shown. A screenshot of the Display panel in each preview state would close this.

Notes

  • The blind reader could not tell whether "Explore 0/6" and "Try today: 3 new features" are "one thing or three". Both appear at once when the preview turns on. That confusion comes from the existing Explore design, so it belongs in a follow-up, not this PR.

[UX-REVIEWED] 5d2df01

Description read

[DESCRIPTION-READ] 3ee2dad286fc1148cd9a738e22cb6445d9c6d5829280c327b5480835a5071bde

That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ human override accepted

@bolichen97 overrode this lane for 5d2df0141fd1a2321da6bd96a01858adc77ad0cd via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 5d2df0141fd1a2321da6bd96a01858adc77ad0cd — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 5d2df01

Verdict parsed from the review's SHA-scoped output markers for commit 5d2df0141fd1a2321da6bd96a01858adc77ad0cd.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 5d2df0141fd1a2321da6bd96a01858adc77ad0cd false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings (all downgraded on adjudication)

GPT 6.1 flagged blocking issues on 5d2df0141fd1a2321da6bd96a01858adc77ad0cd; Opus 5.5 adjudication downgraded every one of them. Downgraded: the remedy each one needs is disproportionate to the harm it prevents. Adjudication downgraded all 1 blocking finding(s): the remedy each one requires is disproportionate to the harm it prevents.

This comment is updated in place on each push.

Review details

BLOCKING -- website/src/components/commandPalette/settingsSearchCore.ts:169 -- Refresh Search Everywhere results when Explore preview changes

if (entry.configKey === 'dashboard.milestones_enabled') return readPreviewFlag(PREVIEW_EXPLORE)
Trigger: Search Everywhere’s Settings tab shows Display > Explore, then another dashboard disables the preview. settingsProvider.search() applies this predicate only when searching; CommandPalette caches the results under a key without preview state, and neither preview events nor config refresh invalidate that cache.
Outcome: The open palette retains Display > Explore after its switch disappears; selecting the result navigates to a setting that is no longer rendered.
Anchor: defect
Fix: Subscribe the palette to preview changes and include the preview revision in its search query key for both Settings and All results.

[BLOCK-MERGE-DOWNGRADED] 5d2df01
[GPT-REVIEWED] 5d2df01

Adjudication (Opus 5.5) — is blocking on each finding proportionate?

LOW harm. The stale row only shows up if three things happen together: the palette is open on a query that matches Display > Explore, the preview is switched off in another dashboard while it is open, and the user then picks that row. Confirmed at settingsSearchCore.ts:169, which reads the flag only at search time, and CommandPalette.tsx:393, whose queryKey has no preview state. Picking the row just opens the Display tab without the switch: no data loss, nothing granted, and it is visible.
Recovery: the results have a 10s staleTime (CommandPalette.tsx:397), and the next keystroke changes debouncedQuery, which is in the key, so the search runs again. The same stale-flag pattern already exists for the session-environments preview at settingsSearchCore.ts:165.
Fix cost: the palette would need to subscribe to preview events and every provider's key would carry a preview revision. That is permanent palette-wide machinery for a self-correcting cosmetic row that only a cross-tab change can produce.

[ADJUDICATION] 5d2df0141fd1a2321da6bd96a01858adc77ad0cd total=1 uphold=0 downgrade=1
DOWNGRADE F1 website/src/components/commandPalette/settingsSearchCore.ts:169 reason=disproportionate-remedy
[GPT-ADJUDICATED] 5d2df0141fd1a2321da6bd96a01858adc77ad0cd

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 5d2df0141fd1a2321da6bd96a01858adc77ad0cd false-positive: <reason, 20 to 500 characters>

@bolichen97
bolichen97 enabled auto-merge (squash) November 1, 2026 22:39
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 1, 2026
@bolichen97
bolichen97 force-pushed the fix/explore-feature-preview branch from 53aed11 to 94aa243 Compare November 1, 2026 23:28
@bolichen97

Copy link
Copy Markdown
Contributor Author

Dispositions for the BLOCKs on 53aed11 (now at head 94aa243)

  • Opus 5.5, ui-index.generated.json Display > Explore ungated — fixed

fixed in 94aa243: new SETTING_PREVIEW map in website/src/uiLocations/descriptors.ts gives display.explore the mc-preview-explore requirement; ui-index.mjs applies a per-setting gate before the tab gate; PREVIEW_FLAG_ENABLERS maps the flag to developer.explore; index regenerated.
Tests: uiIndex.test.ts "gives one setting its own preview requirement on an ungated tab" and "keeps Display > Explore behind the Explore preview, and not its own switch".

  • First Principles, product-shape change without accepted RFC (item 1, target=first-principles) — needs-a-decision, decided by the product owner

The product owner (bolichen97) ruled on 2026-11-01 that Explore ships behind a default-off Feature Preview and is backported to the 0.12.0 insider line. That ruling is now recorded in the RFC as D18, which supersedes D3 (docs/request-for-change/rfc-achievement-feature-discovery.md section 7.1).
Hiding only the intro clip would not meet the ruling: the ruling covers the whole Explore surface, and the clip is one reason, not the scope.

  • First Principles, second off-switch for the same surfaces (items 2 and 5, target=first-principles) — rebutted

The two switches have different jobs. dashboard.feature_previews.explore is the release gate, with the same mechanism every not-yet-GA surface uses (Ultra Mode #25872, Shared Crew). dashboard.milestones_enabled stays the user's own on/off once the preview is on (RFC D18).
Flipping milestones_enabled to default-off instead would change a user setting's default, hide the switch's meaning, and leave no path to retire the gate when Explore leaves preview.

  • Local GPT review on c33ff78dc5, stale counts after re-enabling Explore — fixed

fixed in 94aa243: useExplorePreviewSwitch (useMilestones.ts) reads milestones once on the off-to-on transition; refetchOnMount:false is kept. Test milestones.test.tsx "reads milestones again when the preview turns back on..." is red without the fix and green with it; 5 shuffled runs of the file pass.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 1, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

Disposition, GPT span=4c779d0a23ef (settingsSearchCore.ts:169, cached palette rows after the preview turns off in another tab) — rebutted

Disproportionate, and the lane's own adjudication already downgraded it ([BLOCK-MERGE-DOWNGRADED]): it needs the preview flipped in another tab and a return to the palette within the 10 s staleTime (CommandPalette.tsx:397); the cost is one row that opens a panel without the switch, and it clears itself.
The same class already exists on main for the Session Environments preview gate on the line above (settingsSearchCore.ts:166); this PR follows that gate and does not widen the palette cache contract. Invalidating palette caches on preview changes is a separate change for every preview gate.

First Principles span=6965797e564b (product-shape) — needs-a-decision, decided by the product owner (bolichen97, 2026-11-01), recorded as RFC D18 in this diff. Waiting on a maintainer override or a base-merged D18.

Explore (the top-bar "Explore N/7" pill and its phone twins, the Explore
sheet, the milestone notice, the Try today card on a new chat and the
Display > Explore switch) now shows only while the Feature Preview
mc-preview-explore is on. It is off by default: the sheet is still
settling and its intro clip has Chinese text burned into the frames.

With the preview on nothing changes, and dashboard.milestones_enabled
stays the inner switch. The gateway keeps the switch as
dashboard.feature_previews.explore, and the server keeps recording
milestones either way.

Closes #27424
@bolichen97
bolichen97 force-pushed the fix/explore-feature-preview branch from 94aa243 to 5d2df01 Compare November 2, 2026 00:18
@bolichen97

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 5d2df01 product-shape: Owner ruling by bolichen97 on 2026-11-01: Explore ships behind a default-off Feature Preview and is backported to 0.12.0; recorded in this PR as RFC D18, superseding D3.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

AI-review override not recorded: product-shape is not a release class. Use /ai-review override <fable|gpt|design|ux|first-principles|scope|all> <current-sha> <class>[ #N]: <reason, 20 to 500 characters>, where <class> is one of false-positive, not-applicable, pre-existing, evidence-supplied, infra-failure, reissue, deferred, owner-decision. What each class needs: docs/ci/ci-and-reviews.md#risk-release-records.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 2, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

Owner decision (bolichen97, 2026-11-01): Explore ships behind a default-off Feature Preview (mc-preview-explore) and is backported to the 0.12.0 insider line. This supersedes RFC D3 and is recorded in this PR as RFC D18. I accept the First Principles product-shape finding (span=3d7c1e549983) as decided.

@bolichen97

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 5d2df01 owner-decision: Explore default-off behind a Feature Preview, backported to 0.12.0, recorded as RFC D18 superseding D3. Decision: #27449 (comment)

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Human judgment recorded

@bolichen97 recorded a owner-decision release (class owner-decision) for the first-principles AI finding on 5d2df0141fd1a2321da6bd96a01858adc77ad0cd.

Explore default-off behind a Feature Preview, backported to 0.12.0, recorded as RFC D18 superseding D3. Decision: #27449 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of the watch holder (bolichen). Lanes pass on 5d2df01, no conflict, no open change request. The maintainer confirmed the team discussed and agreed this design. Merges once PR Readiness passes.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 2, 2026
@bolichen97
bolichen97 merged commit 763378e into main Nov 2, 2026
96 of 97 checks passed
@bolichen97
bolichen97 deleted the fix/explore-feature-preview branch November 2, 2026 01:10
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 2, 2026
bolichen97 added a commit that referenced this pull request Nov 2, 2026
) (#27603)

Explore (the top-bar "Explore N/7" pill and its phone twins, the Explore
sheet, the milestone notice, the Try today card on a new chat and the
Display > Explore switch) now shows only while the Feature Preview
mc-preview-explore is on. It is off by default: the sheet is still
settling and its intro clip has Chinese text burned into the frames.

With the preview on nothing changes, and dashboard.milestones_enabled
stays the inner switch. The gateway keeps the switch as
dashboard.feature_previews.explore, and the server keeps recording
milestones either way.

Closes #27424


(cherry picked from commit 763378e)

Co-authored-by: w <w@k.local>
KiroCrewCaptain pushed a commit that referenced this pull request Nov 2, 2026
Carries the cherry-pick of #27449 (#27603): Explore moves behind a default-off Feature Preview, and the 0.12.0 CHANGELOG lists it under previews.

Co-authored-by: w <w@k.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explore is on by default and its intro video shows Chinese to every user; put it behind a default-off Feature Preview

2 participants