Repository navigation
fix(dashboard): put Explore behind a default-off Feature Preview - #27449
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: every Explore surface on the frontend now checks one default-off preview flag, and the server-side meaning of Notes
[DESIGN-REVIEWED] 5d2df01 Description read[DESCRIPTION-READ] 536008331498ecdafd3aa5538bfe1c7c738bdb4dfe61b55087e2aacb34c9a0e1 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing the new Explore card in Developer > Feature previews. That card is the only way to turn Explore on, and no screenshot shows it. Evidence gaps
Notes
[UX-REVIEWED] 5d2df01 Description read[DESCRIPTION-READ] 3ee2dad286fc1148cd9a738e22cb6445d9c6d5829280c327b5480835a5071bde That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ human override accepted@bolichen97 overrode this lane for |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findings (all downgraded on adjudication)GPT 6.1 flagged blocking issues on This comment is updated in place on each push. Review detailsBLOCKING -- website/src/components/commandPalette/settingsSearchCore.ts:169 -- Refresh Search Everywhere results when Explore preview changes
Adjudication (Opus 5.5) — is blocking on each finding proportionate?LOW harm. The stale row only shows up if three things happen together: the palette is open on a query that matches Display > Explore, the preview is switched off in another dashboard while it is open, and the user then picks that row. Confirmed at False positive or not applicable? A repository writer can comment: |
53aed11 to
94aa243
Compare
|
Dispositions for the BLOCKs on 53aed11 (now at head 94aa243)
|
|
Disposition, GPT span=4c779d0a23ef (
First Principles span=6965797e564b (product-shape) — |
Explore (the top-bar "Explore N/7" pill and its phone twins, the Explore sheet, the milestone notice, the Try today card on a new chat and the Display > Explore switch) now shows only while the Feature Preview mc-preview-explore is on. It is off by default: the sheet is still settling and its intro clip has Chinese text burned into the frames. With the preview on nothing changes, and dashboard.milestones_enabled stays the inner switch. The gateway keeps the switch as dashboard.feature_previews.explore, and the server keeps recording milestones either way. Closes #27424
94aa243 to
5d2df01
Compare
|
/ai-review override first-principles 5d2df01 product-shape: Owner ruling by bolichen97 on 2026-11-01: Explore ships behind a default-off Feature Preview and is backported to 0.12.0; recorded in this PR as RFC D18, superseding D3. |
|
AI-review override not recorded: |
|
Owner decision (bolichen97, 2026-11-01): Explore ships behind a default-off Feature Preview ( |
|
/ai-review override first-principles 5d2df01 owner-decision: Explore default-off behind a Feature Preview, backported to 0.12.0, recorded as RFC D18 superseding D3. Decision: #27449 (comment) |
Human judgment recorded@bolichen97 recorded a owner-decision release (class
This decision applies only to this commit. A new push requires a new judgment. |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approved on behalf of the watch holder (bolichen). Lanes pass on 5d2df01, no conflict, no open change request. The maintainer confirmed the team discussed and agreed this design. Merges once PR Readiness passes.
) (#27603) Explore (the top-bar "Explore N/7" pill and its phone twins, the Explore sheet, the milestone notice, the Try today card on a new chat and the Display > Explore switch) now shows only while the Feature Preview mc-preview-explore is on. It is off by default: the sheet is still settling and its intro clip has Chinese text burned into the frames. With the preview on nothing changes, and dashboard.milestones_enabled stays the inner switch. The gateway keeps the switch as dashboard.feature_previews.explore, and the server keeps recording milestones either way. Closes #27424 (cherry picked from commit 763378e) Co-authored-by: w <w@k.local>
Problem / Motivation
Goal: Explore no longer shows for everyone by default; it appears only for users who turn on its Feature Preview.
Explore (the top-bar "Explore N/7" pill, the Explore sheet with the "Kiro Crew in 15 seconds" clip, Try today, the milestone notice and the Try today card on a new chat) shipped on by default in #26488. The bundled intro clip has Chinese text burned into its frames, so English users see Chinese the first time they open the sheet.
Why it matters
Every user, on main and on the 0.12.0 insider line, gets an unfinished surface in the top bar and a clip in a language most of them do not read.
Not a goal
What changed (motivation → approach → change)
Explore now sits behind a new Feature Preview, Explore (
mc-preview-explore), off by default, the same way Ultra Mode did in #25872. With it off there is no Explore pill (desktop or phone), no Explore menu row, no milestone notice, no Try today card on a new chat, no Explore sheet, and Settings hides the Display > Explore switch, including from settings search. Turning the preview off also closes an open sheet. With it on everything works as today, and Display > Explore (dashboard.milestones_enabled) stays the inner switch. The flag lives inpreviewFlags.tswith auseExplorePreviewhook inusePreviewFlag.ts, and its card copy is added to every locale underwebsite/src/i18n. The gateway syncs the switch asdashboard.feature_previews.explore. The generated settings and UI indexes insrc/kiro_crew/docs,config-baseline.jsonand the feature map indocs/feature-map/README.mdare updated to match.Backwards compatibility
Compatible: no key, route or API changes;
dashboard.milestones_enabledkeeps its meaning and the server keeps recording milestones.Reader: website/src/shell/topbar/shellHeader.tsx:ShellHeader -- crew page -- pill and sheet mount only with the preview on; MobileTopBar.explorePreview.test.tsx
Reader: website/src/pages/chat/page/MobileTopBar.tsx:MobileTopBar -- crew page -- phone pill and menu row gated; MobileTopBar.explorePreview.test.tsx
Reader: website/src/components/WelcomeView.tsx:WelcomeView -- chat -- Try today card gated; milestones.test.tsx
Reader: website/src/pages/settings/DisplayPanel.tsx:DisplayPanel -- crew page -- Explore switch hidden while off; DisplayPanel.milestones.test.tsx
Reader: website/src/components/commandPalette/settingsSearchCore.ts:settingEntryOffered -- crew page -- search hides Display > Explore while off; SettingsSearch.test.tsx, settingsSearchGovernance.test.ts
Reader: src/kiro_crew/config/sections_dashboard.py:dashboard.milestones_enabled -- release -- unchanged default and meaning; test_config_baseline.py
Tests
MobileTopBar.explorePreview.test.tsx(new): pill and menu row absent with the preview off, present with it on.milestones.test.tsx,DisplayPanel.milestones.test.tsx: surfaces and the Display switch follow the preview.SettingsSearch.test.tsx: an open search drops Display > Explore when the preview turns off.settingsSearchGovernance.test.ts: the entry is not offered while the preview is off.Proof: not provable -- frontend test (prove.py runs Python only)
Local:
tscclean, eslint clean, vitest 63 files / 963 tests green; Python config baseline, feature preview, find_ui and ui-index tests green excepttest_find_ui_auto.py::test_the_generated_auto_tier_answers_labels_only_it_carries[continue with github...], which fails the same on clean main.Manual verification
Pod built from this head: fresh install shows no Explore pill and no Try today card; turning on Developer > Feature previews > Explore adds the "Explore 0/6" pill and the Try today card.
Screenshots / video
Preview off (default):
Preview on:
Related Issues
Closes #27424
Sibling sweep
Swept: git grep -nE "useMilestones|MilestonesPill|MilestonesIndicator|MilestoneNoticeToast|MilestonesMenuItem|tryToday" -- website/src
Sibling: website/src/shell/notifications/notificationSheet.tsx -- changed here
Sibling: website/src/pages/chat/page/MobileTopBar.tsx -- changed here
Sibling: website/src/components/WelcomeView.tsx -- changed here
Pattern harvest
Not generalizable: a product ruling to move one shipped feature behind a preview, not a code defect class.
Checklist