Repository navigation
refactor: rename the Enterprise Edition to the LTS Edition - #32970
Conversation
Sensitive Change ReviewSensitive files changed:
|
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. This is a coherent rename at the edition seam: no LTS build has shipped, and the old names have no reader left anywhere in the tree. Notes
[DESIGN-REVIEWED] f2088fb Description read[DESCRIPTION-READ] b9dc956152ee1eea3753b9c9a5dd95e6f028e3631a15583342569f8887828637 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. This is a rename refactor: the dashboard's English strings are unchanged, and the only reworded copy is backend text that appears only in an LTS build, which has not shipped yet. Notes
[UX-REVIEWED] f2088fb Description read[DESCRIPTION-READ] e4a658d5a7c80a483cb7c5af7415823cfc43b61b4a91692c339905daae266282 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS This is a pure rename at the edition seam. No LTS build has shipped, so no user has to relearn a name, and the keep-list leaves every name another product owns alone. What this change shipsInventory (8 items) — 8 justifiedIntent: give the build edition one name, LTS, that no other product uses, before its release pipeline lands. This is an ADDITION (a relabel).
[FIRST-PRINCIPLES-REVIEWED] f2088fb Description read[DESCRIPTION-READ] a66814b79dd8953fa4d8804b89b74e28640164e5b4b677e66489f6952eed5138 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Security Scope Review -- ✅ PASSWhich legitimate operations does Verdict basis: adjudicated, zero confirmed regressions. Security scope review -- adjudicated candidates
No candidate flipped from allowed to refused. Scope-Verdict: PASS Reason: Only checked for the change's effect on what gets refused: this diff renames the "enterprise" edition to "lts" across 232 files and makes no guard stricter. With the enterprise→lts rename factored out, every source hunk matches line for line apart from comments and reflowed lines. The shell deny composite ( TIGHTENING: none in the shell deny tiers. The nearest change is the edition allow-set -- ADJUDICATED: 16 candidates, 0 confirmed newly-refused PLATFORM COVERAGE: posix rows cover the Makefile and UNADJUDICATED: The edition validators are not shell-deny guards, so no verdict exists for them.
Neither input is a security tightening that over-refuses, and I did not demonstrate either as a gap on a real call path. Both are named here for the release-process owners to check. [SCOPE-REVIEWED] f2088fb |
Sensitive change review
|
1 similar comment
Sensitive change review
|
ee4eca1 to
6a20a78
Compare
Sensitive change review
|
6a20a78 to
25c5bb2
Compare
Sensitive change review
|
25c5bb2 to
375a43e
Compare
Sensitive change review
|
9cb4d83 to
a7a2b72
Compare
Sensitive change review
|
The build edition formerly called enterprise is now lts (Long Term Support). EDITION=lts replaces EDITION=enterprise; the old value fails the build with a 'renamed to lts' error instead of aliasing. Edition modules, functions, tests, UI text, CLI help, the RFC and specs follow. Names that belong to the Kiro enterprise management service, the enterprise platform profile and companion contract, Slack Enterprise Grid and GitHub Enterprise are kept.
Sensitive change review
|
a7a2b72 to
f2088fb
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approving. A maintainer signed off the design for this team change (the LTS rename and RFC decision D10).
Earlier request: fixed on this head. test/test_instances_proxy.py:155 now patches edition.is_lts. The three optional points (the issue and D10 wording, the backend text note, the merge order with #32882) are answered in the body, the RFC and your reply.
Verified on f2088fb: once enterprise to lts is normalized, no branch, condition or check changes. Wire fields, the gate code, the EDITION file writer and reader, and the audit read id all move on both sides at once. A merge with current main is clean and leaves no edition.is_enterprise, enterprise_sign_in or enterprise_gate name in the backend, tests or dashboard. PR Readiness is green and every review lane says PASS. Done well: the keep-list is applied exactly, and the old build value is refused with no alias, pinned by two new tests.
Security: the sensitive files (sandbox_*.py, gate_tiers.py, hooks.py, safety_override_permits.py, KasLoginGate.tsx) only rename is_enterprise() to is_lts() and reword comments. The Security Scope lane found 0 newly refused operations. The protected-read id in hooks.py and KIRO_CLI_STORE_READ_ID were renamed together, so the fail-closed registration check still holds. A missed call site would fail to import. It would not open a gate.
Optional:
hooks.py:1536: shipped oss builds already emitenterprise_sign_in.kiro_cli_storeon the KAS spawn path (auth/bridge.py), so this changes an oss audit label. Add one line under Backwards compatibility, or keep the old id string.- A few comments still call the edition "enterprise":
KasLoginGate.tsx:736,website/capture/shoot-lts-sign-in-only.mjs:1, andenterprise_policy_fetch.pylines 14, 350 and 366. website/electron/test/edition.test.js:36: the near-miss rows still use "enterprise", so they no longer test the exact match on "lts". Add "LTS", " lts" and "lts\n\n". The body also says this test covers the unknown-value branch ofbuild-desktop.sh, but it does not check that branch.
Carries every change that landed on the built-in Code Review Sage after this repository's snapshot and was not here yet, so a user on this copy has each of them: - kirodotdev/KiroCrew#32970: the Enterprise Edition is now the LTS Edition. The review floor asked only edition.is_enterprise and enterprise_boot, which a current host no longer has, so an LTS build read as oss and a review fell back to Kiro CLI. It now asks is_lts and lts_boot first and the old names second. The test dependency pins Kiro Crew main af94fac51f so the suite runs against the names a current host has. - kirodotdev/KiroCrew#31136: a namespace body that is JSON but not an object answers 400 body_not_object. - kirodotdev/KiroCrew#21307: the poster pipes the draft review on stdin (gh api --input -) instead of a temp file. - kirodotdev/KiroCrew#32618: a review that finishes while open shows its report. - kirodotdev/KiroCrew#33108: Dismiss finding and Undo keep focus while they save. - kirodotdev/KiroCrew#32865: Open shared copy goes through the host's navigator, so an app pop-out hands the page to the main window. - kirodotdev/KiroCrew#29272: comment citations follow the split files. Each fix has a test that fails without it. PORTING.md lists them under "Fixes since the port", with the GitLab port (kirodotdev/KiroCrew#33491) that had no row yet. Part of kirodotdev/KiroCrew#26967. Co-authored-by: Bolin Chen <bolichen@amazon.com>
Problem / Motivation
Goal: The build edition formerly called the Enterprise Edition is named the LTS (Long Term Support) Edition everywhere Crew names the edition.
The owner decided on 2026-11-07 to rename the edition. Today the build value, the edition modules, tests, UI text, CLI help, the RFC and the specs all say "enterprise", which also collides with names that belong to other products (the Kiro enterprise management service, Slack Enterprise Grid, GitHub Enterprise).
Why it matters
The release pipeline for this edition is being built now and will use
ltsnames. If the code keepsenterprise, the build value, artifacts and docs disagree with the pipeline, and "enterprise" keeps meaning three different things in one codebase.Not a goal
GetEffectiveEnterpriseManagementResourceWithToken,kirocps://enterprise-management,enterprise_policy_fetch.py,EnterprisePolicyError,ENTERPRISE_POLICY_URL).enterpriseplatform profile and companion contract (PROFILE_ENTERPRISE,KIROCREW_PROFILE=enterprise,PlatformContext.is_enterprise, thekirocrew_enterprisepackage). An LTS build still resolves to that profile.slack/enterprise.py,SlackEnterpriseGate, theenterprise_origin_mismatchaudit code), GitHub Enterprise names, or the organisation governance ceiling prose.ossedition.What changed (motivation → approach → change)
Owner decision → rename at the edition seam only, keep every name another product owns → one commit, docs and code together.
EDITION=ltsreplacesEDITION=enterpriseinMakefile,setup.py/_edition_stamp.pyandpackaging/build-desktop.sh.EDITIONSis{"oss", "lts"}.EDITION=enterprise(andKIROCREW_BUILD_EDITION=enterprise) is now just an unknown edition:make,setup.pyandbuild-desktop.shfail it with their existing unknown-edition error, which listsossandlts. No special case is added.edition.is_enterprise()→edition.is_lts(). Edition modules renamed:enterprise_boot→lts_boot,enterprise_gate→lts_gate(EnterpriseGate→LtsGate),enterprise_sign_in→lts_sign_in,enterprise_signin_gateway→lts_signin_gateway,dashboard/enterprise_gate_middleware→dashboard/lts_gate_middleware. Edition wire fields (lts_login_required,lts_sign_in_command,lts_sign_in_only,lts_signed_in_restart,lts_start_command,lts_sign_in_needs_start_url, gate codelts_gate_closed) renamed on the backend and the dashboard together.test/test_instances_proxy.py(added on main by fix(instances): send a same-origin Origin on hub-to-peer requests #32942; its edition patch now targetsis_lts),src/kiro_crew/beacon.py,src/kiro_crew/mcp_shared_policy.py,website/src/components,website/src/test,.gitignore,AGENTS.md,AUTOSDE.yaml,src/kiro_crew/acp_backends.py,src/kiro_crew/agent_materialization,src/kiro_crew/agent_sdk,src/kiro_crew/approval_mode_policy.py,src/kiro_crew/apps,src/kiro_crew/auth,src/kiro_crew/cli.py,src/kiro_crew/cli_commands.py,src/kiro_crew/cli_doctor.py,src/kiro_crew/computer_use,src/kiro_crew/config,src/kiro_crew/crewmate_harness.py,src/kiro_crew/dashboard,src/kiro_crew/decisions,src/kiro_crew/edition.py,src/kiro_crew/edition_install_fence.py,src/kiro_crew/edition_locks.py,src/kiro_crew/enterprise_boot.py,src/kiro_crew/enterprise_gate.py,src/kiro_crew/enterprise_sign_in.py,src/kiro_crew/enterprise_signin_gateway.py,src/kiro_crew/extension_governance.py,src/kiro_crew/hook_event_governance.py,src/kiro_crew/hook_runtime,src/kiro_crew/hooks.py,src/kiro_crew/kiro_prerequisite.py,src/kiro_crew/kiro_prerequisite_probe.py,src/kiro_crew/kiro_prerequisite_process.py,src/kiro_crew/kiro_prerequisite_service.py,src/kiro_crew/knowledge,src/kiro_crew/lts_boot.py,src/kiro_crew/lts_gate.py,src/kiro_crew/lts_sign_in.py,src/kiro_crew/lts_signin_gateway.py,src/kiro_crew/metrics,src/kiro_crew/publish_governance.py,src/kiro_crew/publish_provider.py,src/kiro_crew/safety_override_permits.py,src/kiro_crew/sandbox_launch_mark.py,src/kiro_crew/sandbox_precreate.py,src/kiro_crew/sandbox_tiers.py,src/kiro_crew/sandbox_unavailable.py,src/kiro_crew/sandbox_wrap.py,src/kiro_crew/security,src/kiro_crew/session_background.py,src/kiro_crew/session_environment.py,src/kiro_crew/slack,src/kiro_crew/tunnel,src/kiro_crew/webhook_sources.py,src/kiro_crew/webhooks.py,website/src/api,website/src/pages,website/src/types. Each swapsis_enterprise()foris_lts(), an edition import, or edition wording in a comment, docstring or message.en.manual.jsonand every locale; the dashboard English strings are unchanged. Backend text that names the edition now says LTS:edition_locks.LOCKED_REASON("turned off in the LTS edition"),edition_locks.UNNAMED_REASON("off by default in the LTS edition until a policy enables it"), and thekirocrew doctorissue row ("LTS sign-in: ...").docs/request-for-change/rfc-crew-lts-edition.mdwith a new decision D10 recording the rename and the keep-list; all links, the RFC index and the system specs follow.*lts*; one test pins thatenterprisefails as an unknown edition.Backwards compatibility
Breaking:
EDITION=enterpriseandKIROCREW_BUILD_EDITION=enterprisestop building with the existing unknown-edition error. Writer sweep on origin/main @ 0bdd18d: the only writers areMakefile,setup.py(via_edition_stamp.py),packaging/build-desktop.shand their tests, all changed here. No workflow on main passesEDITION=enterprise. No LTS build has shipped, so no installed build carries the old stamp, the old wire field names or the old gate code.Reader: src/kiro_crew/dashboard/server.py:enterprise_login_source -- crew page -- calls
lts_login_sourcein this PR; noenterprise_login_sourceleft in the tree (git grep).Reader: src/kiro_crew/dashboard/server_runtime/api_entrypoint.py:enterprise_login_source -- crew page -- calls
lts_login_sourcein this PR; noenterprise_login_sourceleft in the tree (git grep).Reader: src/kiro_crew/dashboard/server.py:install_enterprise_gate -- crew page -- calls
install_lts_gatein this PR; noinstall_enterprise_gateleft in the tree (git grep).Reader: src/kiro_crew/dashboard/server_runtime/api_entrypoint.py:install_enterprise_gate -- crew page -- calls
install_lts_gatein this PR; noinstall_enterprise_gateleft in the tree (git grep).Reader: src/kiro_crew/dashboard/server_runtime/middleware_chain.py:enterprise_gate_middleware_for -- crew page -- calls
lts_gate_middleware_forin this PR; noenterprise_gate_middleware_forleft in the tree (git grep).Reader: src/kiro_crew/agent_sdk/backends.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/apps/builtins/code_review_sage/sage_lib/review_pool.py:is_enterprise -- app -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/cli.py:is_enterprise -- release -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/cli_doctor.py:is_enterprise -- release -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/dashboard/lts_gate_middleware.py:is_enterprise -- crew page -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/dashboard/messaging_api/spawn.py:is_enterprise -- crew page -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/dashboard/origin.py:is_enterprise -- crew page -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/dashboard/tailnet.py:is_enterprise -- crew page -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/dashboard/urls.py:is_enterprise -- crew page -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/edition_install_fence.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/edition_locks.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/lts_boot.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/lts_gate.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/lts_signin_gateway.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/extension_governance.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/hook_runtime/gate_tiers.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/kiro_prerequisite_probe.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/kiro_prerequisite_service.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/knowledge/llm_pool.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/platform/bootstrap.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/platform/discovery.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/platform/enterprise_policy_fetch.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/platform/governance.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/platform/governance_parts/carriers.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/platform/governance_parts/evaluator.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/platform/governance_parts/matching.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/platform/governance_parts/parsing.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/platform/governance_parts/tiers.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/platform/policy_distribution_boot.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/platform/policy_distribution_source.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/platform/profile.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/platform/update_layout.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/publish_provider.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/safety_override_permits.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/sandbox_tiers.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/session_background.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).Reader: src/kiro_crew/slack/gateway_runtime/service_boot.py:is_enterprise -- chat -- calls
edition.is_lts()in this PR; noedition.is_enterpriseleft in the tree (git grep).The external
kirocrew_enterprisecompanion is outside this repository; it composes theenterpriseprofile, which this PR keeps; a companion that callededition.is_enterprise()directly would need the same rename.Tests
test/test_edition.py:enterprisefails as an unknown edition instamp_fileand inmake check-edition.website/electron/test/edition.test.js:build-desktop.shstageslts; any other value hits the unknown-edition branch.test_lts_boot.py,test_lts_gate.py,test_lts_sign_in.py,test_lts_signin_gateway.py,test_lts_harness_floor.py,test_lts_unkeyed_locks.py,test_governance_lts_*,test_llm_pool_lts_floor.py) keep their assertions under the new names.Proof: not provable -- other: a rename with no behaviour fix; the old-value test pins the existing unknown-edition error.
Local: black, isort, flake8, mypy, file line cap, flake ratchet,
tsc, eslint, i18n check, 1655 related vitest tests and 3361 electron tests pass. One electron test (posixDescendantPids finds a gateway a shim forked) fails on this host on main too. Local GPT and Opus reviews: clean after one fix (the Slack audit code was restored toenterprise_origin_mismatch).Manual verification
N/A — the rename has no runtime path that unit tests do not cover; CI runs the full suite.
Screenshots / video
Why no screenshot: in the dashboard only i18n key names and code identifiers changed; every rendered dashboard string is byte-for-byte the same.
Related Issues
Closes #32968
Checklist
Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.