Skip to content

refactor: rename the Enterprise Edition to the LTS Edition - #32970

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
feat/lts-edition-rename
Nov 8, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
feat/lts-edition-rename

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The build edition formerly called the Enterprise Edition is named the LTS (Long Term Support) Edition everywhere Crew names the edition.

The owner decided on 2026-11-07 to rename the edition. Today the build value, the edition modules, tests, UI text, CLI help, the RFC and the specs all say "enterprise", which also collides with names that belong to other products (the Kiro enterprise management service, Slack Enterprise Grid, GitHub Enterprise).

Why it matters

The release pipeline for this edition is being built now and will use lts names. If the code keeps enterprise, the build value, artifacts and docs disagree with the pipeline, and "enterprise" keeps meaning three different things in one codebase.

Not a goal

  • Renaming names that belong to the Kiro enterprise management service and its API (GetEffectiveEnterpriseManagementResourceWithToken, kirocps://enterprise-management, enterprise_policy_fetch.py, EnterprisePolicyError, ENTERPRISE_POLICY_URL).
  • Renaming the enterprise platform profile and companion contract (PROFILE_ENTERPRISE, KIROCREW_PROFILE=enterprise, PlatformContext.is_enterprise, the kirocrew_enterprise package). An LTS build still resolves to that profile.
  • Renaming Slack Enterprise Grid names (slack/enterprise.py, SlackEnterpriseGate, the enterprise_origin_mismatch audit code), GitHub Enterprise names, or the organisation governance ceiling prose.
  • Changing the oss edition.
  • The release pipeline itself (a separate PR).

What changed (motivation → approach → change)

Owner decision → rename at the edition seam only, keep every name another product owns → one commit, docs and code together.

  • Build value. EDITION=lts replaces EDITION=enterprise in Makefile, setup.py / _edition_stamp.py and packaging/build-desktop.sh. EDITIONS is {"oss", "lts"}.
  • Old value not aliased. EDITION=enterprise (and KIROCREW_BUILD_EDITION=enterprise) is now just an unknown edition: make, setup.py and build-desktop.sh fail it with their existing unknown-edition error, which lists oss and lts. No special case is added.
  • Code. edition.is_enterprise() → edition.is_lts(). Edition modules renamed: enterprise_boot → lts_boot, enterprise_gate → lts_gate (EnterpriseGate → LtsGate), enterprise_sign_in → lts_sign_in, enterprise_signin_gateway → lts_signin_gateway, dashboard/enterprise_gate_middleware → dashboard/lts_gate_middleware. Edition wire fields (lts_login_required, lts_sign_in_command, lts_sign_in_only, lts_signed_in_restart, lts_start_command, lts_sign_in_needs_start_url, gate code lts_gate_closed) renamed on the backend and the dashboard together.
  • Call sites, renames only (no logic change): test/test_instances_proxy.py (added on main by fix(instances): send a same-origin Origin on hub-to-peer requests #32942; its edition patch now targets is_lts), src/kiro_crew/beacon.py, src/kiro_crew/mcp_shared_policy.py, website/src/components, website/src/test, .gitignore, AGENTS.md, AUTOSDE.yaml, src/kiro_crew/acp_backends.py, src/kiro_crew/agent_materialization, src/kiro_crew/agent_sdk, src/kiro_crew/approval_mode_policy.py, src/kiro_crew/apps, src/kiro_crew/auth, src/kiro_crew/cli.py, src/kiro_crew/cli_commands.py, src/kiro_crew/cli_doctor.py, src/kiro_crew/computer_use, src/kiro_crew/config, src/kiro_crew/crewmate_harness.py, src/kiro_crew/dashboard, src/kiro_crew/decisions, src/kiro_crew/edition.py, src/kiro_crew/edition_install_fence.py, src/kiro_crew/edition_locks.py, src/kiro_crew/enterprise_boot.py, src/kiro_crew/enterprise_gate.py, src/kiro_crew/enterprise_sign_in.py, src/kiro_crew/enterprise_signin_gateway.py, src/kiro_crew/extension_governance.py, src/kiro_crew/hook_event_governance.py, src/kiro_crew/hook_runtime, src/kiro_crew/hooks.py, src/kiro_crew/kiro_prerequisite.py, src/kiro_crew/kiro_prerequisite_probe.py, src/kiro_crew/kiro_prerequisite_process.py, src/kiro_crew/kiro_prerequisite_service.py, src/kiro_crew/knowledge, src/kiro_crew/lts_boot.py, src/kiro_crew/lts_gate.py, src/kiro_crew/lts_sign_in.py, src/kiro_crew/lts_signin_gateway.py, src/kiro_crew/metrics, src/kiro_crew/publish_governance.py, src/kiro_crew/publish_provider.py, src/kiro_crew/safety_override_permits.py, src/kiro_crew/sandbox_launch_mark.py, src/kiro_crew/sandbox_precreate.py, src/kiro_crew/sandbox_tiers.py, src/kiro_crew/sandbox_unavailable.py, src/kiro_crew/sandbox_wrap.py, src/kiro_crew/security, src/kiro_crew/session_background.py, src/kiro_crew/session_environment.py, src/kiro_crew/slack, src/kiro_crew/tunnel, src/kiro_crew/webhook_sources.py, src/kiro_crew/webhooks.py, website/src/api, website/src/pages, website/src/types. Each swaps is_enterprise() for is_lts(), an edition import, or edition wording in a comment, docstring or message.
  • UI and messages. i18n keys for the edition sign-in screen renamed in en.manual.json and every locale; the dashboard English strings are unchanged. Backend text that names the edition now says LTS: edition_locks.LOCKED_REASON ("turned off in the LTS edition"), edition_locks.UNNAMED_REASON ("off by default in the LTS edition until a policy enables it"), and the kirocrew doctor issue row ("LTS sign-in: ...").
  • Docs. The RFC moves to docs/request-for-change/rfc-crew-lts-edition.md with a new decision D10 recording the rename and the keep-list; all links, the RFC index and the system specs follow.
  • Tests. Edition test files renamed to *lts*; one test pins that enterprise fails as an unknown edition.

Backwards compatibility

Breaking: EDITION=enterprise and KIROCREW_BUILD_EDITION=enterprise stop building with the existing unknown-edition error. Writer sweep on origin/main @ 0bdd18d: the only writers are Makefile, setup.py (via _edition_stamp.py), packaging/build-desktop.sh and their tests, all changed here. No workflow on main passes EDITION=enterprise. No LTS build has shipped, so no installed build carries the old stamp, the old wire field names or the old gate code.

Reader: src/kiro_crew/dashboard/server.py:enterprise_login_source -- crew page -- calls lts_login_source in this PR; no enterprise_login_source left in the tree (git grep).
Reader: src/kiro_crew/dashboard/server_runtime/api_entrypoint.py:enterprise_login_source -- crew page -- calls lts_login_source in this PR; no enterprise_login_source left in the tree (git grep).
Reader: src/kiro_crew/dashboard/server.py:install_enterprise_gate -- crew page -- calls install_lts_gate in this PR; no install_enterprise_gate left in the tree (git grep).
Reader: src/kiro_crew/dashboard/server_runtime/api_entrypoint.py:install_enterprise_gate -- crew page -- calls install_lts_gate in this PR; no install_enterprise_gate left in the tree (git grep).
Reader: src/kiro_crew/dashboard/server_runtime/middleware_chain.py:enterprise_gate_middleware_for -- crew page -- calls lts_gate_middleware_for in this PR; no enterprise_gate_middleware_for left in the tree (git grep).
Reader: src/kiro_crew/agent_sdk/backends.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/apps/builtins/code_review_sage/sage_lib/review_pool.py:is_enterprise -- app -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/cli.py:is_enterprise -- release -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/cli_doctor.py:is_enterprise -- release -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/dashboard/lts_gate_middleware.py:is_enterprise -- crew page -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/dashboard/messaging_api/spawn.py:is_enterprise -- crew page -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/dashboard/origin.py:is_enterprise -- crew page -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/dashboard/tailnet.py:is_enterprise -- crew page -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/dashboard/urls.py:is_enterprise -- crew page -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/edition_install_fence.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/edition_locks.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/lts_boot.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/lts_gate.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/lts_signin_gateway.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/extension_governance.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/hook_runtime/gate_tiers.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/kiro_prerequisite_probe.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/kiro_prerequisite_service.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/knowledge/llm_pool.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/platform/bootstrap.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/platform/discovery.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/platform/enterprise_policy_fetch.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/platform/governance.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/platform/governance_parts/carriers.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/platform/governance_parts/evaluator.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/platform/governance_parts/matching.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/platform/governance_parts/parsing.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/platform/governance_parts/tiers.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/platform/policy_distribution_boot.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/platform/policy_distribution_source.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/platform/profile.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/platform/update_layout.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/publish_provider.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/safety_override_permits.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/sandbox_tiers.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/session_background.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).
Reader: src/kiro_crew/slack/gateway_runtime/service_boot.py:is_enterprise -- chat -- calls edition.is_lts() in this PR; no edition.is_enterprise left in the tree (git grep).

The external kirocrew_enterprise companion is outside this repository; it composes the enterprise profile, which this PR keeps; a companion that called edition.is_enterprise() directly would need the same rename.

Tests

  • test/test_edition.py: enterprise fails as an unknown edition in stamp_file and in make check-edition.
  • website/electron/test/edition.test.js: build-desktop.sh stages lts; any other value hits the unknown-edition branch.
  • Renamed edition suites (test_lts_boot.py, test_lts_gate.py, test_lts_sign_in.py, test_lts_signin_gateway.py, test_lts_harness_floor.py, test_lts_unkeyed_locks.py, test_governance_lts_*, test_llm_pool_lts_floor.py) keep their assertions under the new names.

Proof: not provable -- other: a rename with no behaviour fix; the old-value test pins the existing unknown-edition error.

Local: black, isort, flake8, mypy, file line cap, flake ratchet, tsc, eslint, i18n check, 1655 related vitest tests and 3361 electron tests pass. One electron test (posixDescendantPids finds a gateway a shim forked) fails on this host on main too. Local GPT and Opus reviews: clean after one fix (the Slack audit code was restored to enterprise_origin_mismatch).

Manual verification

N/A — the rename has no runtime path that unit tests do not cover; CI runs the full suite.

Screenshots / video

Why no screenshot: in the dashboard only i18n key names and code identifiers changed; every rendered dashboard string is byte-for-byte the same.

Related Issues

Closes #32968

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners November 8, 2026 06:25
@iamwhatever
iamwhatever requested a review from Zedmor November 8, 2026 06:25
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Sensitive Change Review

Sensitive files changed:

  • src/kiro_crew/hook_runtime/gate_tiers.py

  • src/kiro_crew/hook_runtime/governance_gate.py

  • src/kiro_crew/hooks.py

  • src/kiro_crew/platform/security_authority.py

  • src/kiro_crew/sandbox_launch_mark.py

  • src/kiro_crew/sandbox_precreate.py

  • src/kiro_crew/sandbox_tiers.py

  • src/kiro_crew/sandbox_unavailable.py

  • src/kiro_crew/sandbox_wrap.py

  • src/kiro_crew/security/redaction_switch.py

  • @iamwhatever posted a complete reasoning template for f2088fb.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of f2088fb2cbb34775bc99d116c6fdff782ee82ee6 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks. This is a coherent rename at the edition seam: no LTS build has shipped, and the old names have no reader left anywhere in the tree.

Notes

  • The edition's audit read id has changed from enterprise_sign_in.kiro_cli_store to lts_sign_in.kiro_cli_store. SEL rows already written keep the old id, so a filter on audit history has to match both ids.
  • The description was cut off partway through its Reader: list. Readers past the cut were not checked against it. A tree-wide grep found no old-name reader left (edition.is_enterprise, the old wire fields, EDITION=enterprise).

[DESIGN-REVIEWED] f2088fb

Description read

[DESCRIPTION-READ] b9dc956152ee1eea3753b9c9a5dd95e6f028e3631a15583342569f8887828637

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of f2088fb2cbb34775bc99d116c6fdff782ee82ee6 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check. This is a rename refactor: the dashboard's English strings are unchanged, and the only reworded copy is backend text that appears only in an LTS build, which has not shipped yet.

Notes

  • edition_locks.LOCKED_REASON "turned off in the LTS edition" never says what "LTS" means. Writing out "Long Term Support" once, at least in the first message a locked user sees, would help them understand why the switch is off.

[UX-REVIEWED] f2088fb

Description read

[DESCRIPTION-READ] e4a658d5a7c80a483cb7c5af7415823cfc43b61b4a91692c339905daae266282

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of f2088fb2cbb34775bc99d116c6fdff782ee82ee6 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

This is a pure rename at the edition seam. No LTS build has shipped, so no user has to relearn a name, and the keep-list leaves every name another product owns alone.

What this change ships

Inventory (8 items) — 8 justified

Intent: give the build edition one name, LTS, that no other product uses, before its release pipeline lands. This is an ADDITION (a relabel).

  1. Building the edition now takes EDITION=lts / KIROCREW_BUILD_EDITION=lts instead of enterprise — justified
  2. EDITION=enterprise now fails with the existing unknown-edition error, with no alias — justified
  3. Edition modules and symbols renamed (is_lts, LtsGate, lts_boot, lts_sign_in, lts_gate_middleware) — justified
  4. Dashboard wire fields and the lts_gate_closed gate code renamed on both backend and frontend — justified
  5. The lock-reason messages and the kirocrew doctor sign-in row now say "LTS" — justified
  6. Sign-in screen i18n keys renamed in every locale; the English text is unchanged — justified
  7. The RFC moves to rfc-crew-lts-edition.md with decision D10, and every link and spec follows it — justified
  8. Edition test files renamed, plus one test that pins enterprise as an unknown edition — justified

[FIRST-PRINCIPLES-REVIEWED] f2088fb

Description read

[DESCRIPTION-READ] a66814b79dd8953fa4d8804b89b74e28640164e5b4b677e66489f6952eed5138

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed f2088fb2cbb34775bc99d116c6fdff782ee82ee6 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] f2088fb

Verdict parsed from the review's SHA-scoped output markers for commit f2088fb2cbb34775bc99d116c6fdff782ee82ee6.

False positive or not applicable? A repository writer can comment:
/ai-review override fable f2088fb2cbb34775bc99d116c6fdff782ee82ee6 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of f2088fb2cbb34775bc99d116c6fdff782ee82ee6 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] f2088fb

False positive or not applicable? A repository writer can comment:
/ai-review override gpt f2088fb2cbb34775bc99d116c6fdff782ee82ee6 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Security Scope Review -- ✅ PASS

Which legitimate operations does f2088fb2cbb34775bc99d116c6fdff782ee82ee6 newly refuse? Updated in place on each push. A script-confirmed regression blocks; the model proposes candidates and never decides a refusal.

Verdict basis: adjudicated, zero confirmed regressions.

Security scope review -- adjudicated candidates

  • macos-latest (platform posix): 10 classified, 0 newly refused, 10 still allowed.
  • ubuntu-latest (platform posix): 10 classified, 0 newly refused, 10 still allowed.
  • windows-latest (platform windows): 6 classified, 0 newly refused, 6 still allowed.

No candidate flipped from allowed to refused.

Scope-Verdict: PASS

Reason: Only checked for the change's effect on what gets refused: this diff renames the "enterprise" edition to "lts" across 232 files and makes no guard stricter. With the enterprise→lts rename factored out, every source hunk matches line for line apart from comments and reflowed lines. The shell deny composite (sensitive-bash, exfil, deny-rules) has no changed pattern; the only edit there is a renamed audit-only read id. The one value-level effect is outside the shell classifier and is named under UNADJUDICATED: the build-time edition validator now refuses the old value enterprise.

TIGHTENING: none in the shell deny tiers. The nearest change is the edition allow-set -- -EDITIONS = frozenset({"oss", "enterprise"}) / +EDITIONS = frozenset({"oss", "lts"}) (src/kiro_crew/edition.py), with the same change in the Makefile (override EDITIONS := oss lts), in packaging/build-desktop.sh (lts) case arm) and in website/electron/edition.js (text === EDITION_LTS). This renames which value counts as the non-oss edition; it adds no refusal of an attack shape.

ADJUDICATED: 16 candidates, 0 confirmed newly-refused

PLATFORM COVERAGE: posix rows cover the Makefile and build-desktop.sh build commands (EDITION=lts, KIROCREW_BUILD_EDITION=lts, EDITION=oss as the one-token-off neighbour), kirocrew doctor, kiro-cli whoami, the edition tests, and reading the baked website/electron/EDITION file. windows rows cover the same operations in Windows spelling: set VAR=... && and PowerShell $env: for the edition variable, .exe names for kirocrew and kiro-cli, findstr and type with \ paths. The diff adds no new path, separator, interpreter or environment-variable assumption; it renames the value an existing variable carries. So these rows probe the only platform-sensitive spellings it touches. No any rows were written, because every row names an executable or a path.

UNADJUDICATED: The edition validators are not shell-deny guards, so no verdict exists for them.

  • Call paths:
    • KIROCREW_BUILD_EDITION / EDITION= → Makefile check-edition against EDITIONS
    • setup.py build_py → kiro_crew.edition refusing values outside EDITIONS
    • packaging/build-desktop.sh case statement (exits non-zero on an unknown value)
    • at runtime, website/electron/edition.js reads website/electron/EDITION, and any text other than exactly lts reads as oss
  • Inputs I would have submitted:
    • make wheel EDITION=enterprise and KIROCREW_BUILD_EDITION=enterprise make desktop from an existing CI job or a release maintainer's habit. Both are now refused at build time, loudly, with a message that names the allowed values.
    • an already-installed desktop app whose baked EDITION file contains enterprise. After an upgrade that re-reads an unchanged file, it would read as oss, which drops the LTS floors rather than adding a refusal. This would only matter if an installed bundle outlives its own rebuild; the file is packed into app.asar, so that is not normally the case.

Neither input is a security tightening that over-refuses, and I did not demonstrate either as a gap on a real call path. Both are named here for the release-process owners to check.

[SCOPE-REVIEWED] f2088fb

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 8, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: ee4eca1
  • What rule changed: no rule. The ten sensitive files change 22 lines each way, all renames of the build edition: edition.is_enterprise() -> edition.is_lts(), "enterprise build" -> "LTS build" in comments and docstrings, and the protected-read id enterprise_sign_in.kiro_cli_store -> lts_sign_in.kiro_cli_store in hooks.py (it must match lts_sign_in.KIRO_CLI_STORE_READ_ID, which this PR renames with it).
  • Before -> after (what was allowed/blocked, now): the same. Every gate that ran only in an enterprise build now runs only in an LTS build, under the same checks; nothing new is allowed or blocked in either edition.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): an LTS-only gate stops firing in an LTS build if a call site kept the old name. The old name no longer exists, so such a site would fail to import instead of silently opening. git grep finds no is_enterprise() edition call and no enterprise_sign_in id left. The oss edition is untouched.
  • Evidence checked (which sandbox result proves it): the protected-read map key and KIRO_CLI_STORE_READ_ID are equal (git grep -n "lts_sign_in.kiro_cli_store" shows only those two sites). In the whole diff, the 76 lines that drop an is_enterprise() call are replaced by 77 lines that call is_lts(); local Opus review checked each edition gate kept its check.
  • No regression:
    • Tools still work (which tools/commands were run, result): local black, isort, flake8, mypy, file line cap, flake ratchet and test/test_edition.py pass on this head; local GPT and Opus reviews clean.
    • Backward compatible (old config / old data / old callers still work, how checked): oss builds unchanged. EDITION=enterprise is refused with "renamed to 'lts'" by design (owner decision 2026-11-07, RFC D10). No LTS build has shipped, so no installed data carries the old id.
    • Existing tests (which suites passed on this head): CI backend and frontend suites on this head (see checks); locally the renamed edition suites and the Slack/sign-in suites passed on the pre-rebase head.
  • How to undo: revert this PR's single commit.

1 similar comment
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: ee4eca1
  • What rule changed: no rule. The ten sensitive files change 22 lines each way, all renames of the build edition: edition.is_enterprise() -> edition.is_lts(), "enterprise build" -> "LTS build" in comments and docstrings, and the protected-read id enterprise_sign_in.kiro_cli_store -> lts_sign_in.kiro_cli_store in hooks.py (it must match lts_sign_in.KIRO_CLI_STORE_READ_ID, which this PR renames with it).
  • Before -> after (what was allowed/blocked, now): the same. Every gate that ran only in an enterprise build now runs only in an LTS build, under the same checks; nothing new is allowed or blocked in either edition.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): an LTS-only gate stops firing in an LTS build if a call site kept the old name. The old name no longer exists, so such a site would fail to import instead of silently opening. git grep finds no is_enterprise() edition call and no enterprise_sign_in id left. The oss edition is untouched.
  • Evidence checked (which sandbox result proves it): the protected-read map key and KIRO_CLI_STORE_READ_ID are equal (git grep -n "lts_sign_in.kiro_cli_store" shows only those two sites). In the whole diff, the 76 lines that drop an is_enterprise() call are replaced by 77 lines that call is_lts(); local Opus review checked each edition gate kept its check.
  • No regression:
    • Tools still work (which tools/commands were run, result): local black, isort, flake8, mypy, file line cap, flake ratchet and test/test_edition.py pass on this head; local GPT and Opus reviews clean.
    • Backward compatible (old config / old data / old callers still work, how checked): oss builds unchanged. EDITION=enterprise is refused with "renamed to 'lts'" by design (owner decision 2026-11-07, RFC D10). No LTS build has shipped, so no installed data carries the old id.
    • Existing tests (which suites passed on this head): CI backend and frontend suites on this head (see checks); locally the renamed edition suites and the Slack/sign-in suites passed on the pre-rebase head.
  • How to undo: revert this PR's single commit.

@iamwhatever
iamwhatever force-pushed the feat/lts-edition-rename branch from ee4eca1 to 6a20a78 Compare November 8, 2026 08:02
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: 6a20a78
  • What rule changed: no rule. The ten sensitive files change 22 lines each way, all renames of the build edition: edition.is_enterprise() -> edition.is_lts(), "enterprise build" -> "LTS build" in comments and docstrings, and the protected-read id enterprise_sign_in.kiro_cli_store -> lts_sign_in.kiro_cli_store in hooks.py (it must match lts_sign_in.KIRO_CLI_STORE_READ_ID, which this PR renames with it).
  • Before -> after (what was allowed/blocked, now): the same. Every gate that ran only in an enterprise build now runs only in an LTS build, under the same checks; nothing new is allowed or blocked in either edition.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): an LTS-only gate stops firing in an LTS build if a call site kept the old name. The old name no longer exists, so such a site would fail to import instead of silently opening. git grep finds no is_enterprise() edition call and no enterprise_sign_in id left. The oss edition is untouched.
  • Evidence checked (which sandbox result proves it): the protected-read map key and KIRO_CLI_STORE_READ_ID are equal (git grep -n "lts_sign_in.kiro_cli_store" shows only those two sites). In the whole diff, the 76 lines that drop an is_enterprise() call are replaced by 77 lines that call is_lts(); local Opus review checked each edition gate kept its check.
  • No regression:
    • Tools still work (which tools/commands were run, result): local black, isort, flake8, mypy, file line cap, flake ratchet and test/test_edition.py pass on this head; local GPT and Opus reviews clean.
    • Backward compatible (old config / old data / old callers still work, how checked): oss builds unchanged. EDITION=enterprise is refused with "renamed to 'lts'" by design (owner decision 2026-11-07, RFC D10). No LTS build has shipped, so no installed data carries the old id.
    • Existing tests (which suites passed on this head): CI backend and frontend suites on this head (see checks); locally the edition, LTS gate and boot suites pass on this head (275 passed).
  • How to undo: revert this PR's single commit.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision readiness: checking Automated validation is still running labels Nov 8, 2026
@iamwhatever
iamwhatever force-pushed the feat/lts-edition-rename branch from 6a20a78 to 25c5bb2 Compare November 8, 2026 09:15
@iamwhatever

iamwhatever commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: 25c5bb2
  • What rule changed: no rule. The ten sensitive files change 22 lines each way, all renames of the build edition: edition.is_enterprise() -> edition.is_lts(), "enterprise build" -> "LTS build" in comments and docstrings, and the protected-read id enterprise_sign_in.kiro_cli_store -> lts_sign_in.kiro_cli_store in hooks.py (it must match lts_sign_in.KIRO_CLI_STORE_READ_ID, which this PR renames with it).
  • Before -> after (what was allowed/blocked, now): the same. Every gate that ran only in an enterprise build now runs only in an LTS build, under the same checks; nothing new is allowed or blocked in either edition.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): an LTS-only gate stops firing in an LTS build if a call site kept the old name. The old name no longer exists, so such a site would fail to import instead of silently opening. git grep finds no is_enterprise() edition call and no enterprise_sign_in id left. The oss edition is untouched.
  • Evidence checked (which sandbox result proves it): the protected-read map key and KIRO_CLI_STORE_READ_ID are equal (git grep -n "lts_sign_in.kiro_cli_store" shows only those two sites). In the whole diff, the 76 lines that drop an is_enterprise() call are replaced by 77 lines that call is_lts(); local Opus review checked each edition gate kept its check.
  • No regression:
    • Tools still work (which tools/commands were run, result): local black, isort, flake8, mypy, file line cap, flake ratchet and test/test_edition.py pass on this head; local GPT and Opus reviews clean.
    • Backward compatible (old config / old data / old callers still work, how checked): oss builds unchanged. EDITION=enterprise fails with the existing unknown-edition error; there is no special case and no alias (RFC D10). No LTS build has shipped, so no installed data carries the old id.
    • Existing tests (which suites passed on this head): CI backend and frontend suites on this head (see checks); locally the edition, LTS gate and boot suites pass on this head (226 passed).
  • How to undo: revert this PR's single commit.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 8, 2026
@iamwhatever
iamwhatever force-pushed the feat/lts-edition-rename branch from 25c5bb2 to 375a43e Compare November 8, 2026 11:29
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: 375a43e
  • What rule changed: no rule. The ten sensitive files change 22 lines each way, all renames of the build edition: edition.is_enterprise() -> edition.is_lts(), "enterprise build" -> "LTS build" in comments and docstrings, and the protected-read id enterprise_sign_in.kiro_cli_store -> lts_sign_in.kiro_cli_store in hooks.py (it must match lts_sign_in.KIRO_CLI_STORE_READ_ID, which this PR renames with it).
  • Before -> after (what was allowed/blocked, now): the same. Every gate that ran only in an enterprise build now runs only in an LTS build, under the same checks; nothing new is allowed or blocked in either edition.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): an LTS-only gate stops firing in an LTS build if a call site kept the old name. The old name no longer exists, so such a site would fail to import instead of silently opening. git grep finds no is_enterprise() edition call and no enterprise_sign_in id left. The oss edition is untouched.
  • Evidence checked (which sandbox result proves it): the protected-read map key and KIRO_CLI_STORE_READ_ID are equal (git grep -n "lts_sign_in.kiro_cli_store" shows only those two sites). In the whole diff, the 76 lines that drop an is_enterprise() call are replaced by 77 lines that call is_lts(); local Opus review checked each edition gate kept its check.
  • No regression:
    • Tools still work (which tools/commands were run, result): local black, isort, flake8, mypy, file line cap, flake ratchet and test/test_edition.py pass on this head; local GPT and Opus reviews clean.
    • Backward compatible (old config / old data / old callers still work, how checked): oss builds unchanged. EDITION=enterprise fails with the existing unknown-edition error; there is no special case and no alias (RFC D10). No LTS build has shipped, so no installed data carries the old id.
    • Existing tests (which suites passed on this head): CI backend and frontend suites on this head (see checks); locally the edition, LTS gate and boot suites pass on this head (217 passed).
  • How to undo: revert this PR's single commit.

@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 8, 2026
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 8, 2026
@iamwhatever
iamwhatever force-pushed the feat/lts-edition-rename branch from 9cb4d83 to a7a2b72 Compare November 8, 2026 19:46
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: a7a2b72
  • What rule changed: no rule. The ten sensitive files change 22 lines each way, all renames of the build edition: edition.is_enterprise() -> edition.is_lts(), "enterprise build" -> "LTS build" in comments and docstrings, and the protected-read id enterprise_sign_in.kiro_cli_store -> lts_sign_in.kiro_cli_store in hooks.py (it must match lts_sign_in.KIRO_CLI_STORE_READ_ID, which this PR renames with it).
  • Before -> after (what was allowed/blocked, now): the same. Every gate that ran only in an enterprise build now runs only in an LTS build, under the same checks; nothing new is allowed or blocked in either edition.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): an LTS-only gate stops firing in an LTS build if a call site kept the old name. The old name no longer exists, so such a site would fail to import instead of silently opening. git grep finds no is_enterprise() edition call and no enterprise_sign_in id left. The oss edition is untouched.
  • Evidence checked (which sandbox result proves it): the protected-read map key and KIRO_CLI_STORE_READ_ID are equal (git grep -n "lts_sign_in.kiro_cli_store" shows only those two sites). In the whole diff, the 84 lines that drop an is_enterprise() call are replaced by 85 lines that call is_lts(); local Opus review checked each edition gate kept its check.
  • No regression:
    • Tools still work (which tools/commands were run, result): local black, isort, flake8, mypy, file line cap, flake ratchet and test/test_edition.py pass on this head; local GPT and Opus reviews clean.
    • Backward compatible (old config / old data / old callers still work, how checked): oss builds unchanged. EDITION=enterprise fails with the existing unknown-edition error; there is no special case and no alias (RFC D10). No LTS build has shipped, so no installed data carries the old id.
    • Existing tests (which suites passed on this head): CI backend and frontend suites on this head (see checks); locally the edition, LTS gate and boot suites pass on this head (227 passed).
  • How to undo: revert this PR's single commit.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 8, 2026
The build edition formerly called enterprise is now lts (Long Term Support).
EDITION=lts replaces EDITION=enterprise; the old value fails the build with
a 'renamed to lts' error instead of aliasing. Edition modules, functions,
tests, UI text, CLI help, the RFC and specs follow. Names that belong to
the Kiro enterprise management service, the enterprise platform profile and
companion contract, Slack Enterprise Grid and GitHub Enterprise are kept.
@iamwhatever

iamwhatever commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: f2088fb
  • What rule changed: no rule. The ten sensitive files change 22 lines each way, all renames of the build edition: edition.is_enterprise() -> edition.is_lts(), "enterprise build" -> "LTS build" in comments and docstrings, and the protected-read id enterprise_sign_in.kiro_cli_store -> lts_sign_in.kiro_cli_store in hooks.py (it must match lts_sign_in.KIRO_CLI_STORE_READ_ID, which this PR renames with it).
  • Before -> after (what was allowed/blocked, now): the same. Every gate that ran only in an enterprise build now runs only in an LTS build, under the same checks; nothing new is allowed or blocked in either edition.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): an LTS-only gate stops firing in an LTS build if a call site kept the old name. The old name no longer exists, so such a site would fail to import instead of silently opening. git grep finds no is_enterprise() edition call and no enterprise_sign_in id left. The oss edition is untouched.
  • Evidence checked (which sandbox result proves it): the protected-read map key and KIRO_CLI_STORE_READ_ID are equal (git grep -n "lts_sign_in.kiro_cli_store" shows only those two sites). In the whole diff, the 84 lines that drop an is_enterprise() call are replaced by 85 lines that call is_lts(); local Opus review checked each edition gate kept its check.
  • No regression:
    • Tools still work (which tools/commands were run, result): local black, isort, flake8, mypy, file line cap, flake ratchet and test/test_edition.py pass on this head; local GPT and Opus reviews clean.
    • Backward compatible (old config / old data / old callers still work, how checked): oss builds unchanged. EDITION=enterprise fails with the existing unknown-edition error; there is no special case and no alias (RFC D10). No LTS build has shipped, so no installed data carries the old id.
    • Existing tests (which suites passed on this head): CI backend and frontend suites on this head (see checks); locally the edition, LTS gate and boot suites pass on this head (229 passed).
  • How to undo: revert this PR's single commit.

@iamwhatever
iamwhatever force-pushed the feat/lts-edition-rename branch from a7a2b72 to f2088fb Compare November 8, 2026 20:45
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 8, 2026
@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) November 8, 2026 21:58

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. A maintainer signed off the design for this team change (the LTS rename and RFC decision D10).

Earlier request: fixed on this head. test/test_instances_proxy.py:155 now patches edition.is_lts. The three optional points (the issue and D10 wording, the backend text note, the merge order with #32882) are answered in the body, the RFC and your reply.

Verified on f2088fb: once enterprise to lts is normalized, no branch, condition or check changes. Wire fields, the gate code, the EDITION file writer and reader, and the audit read id all move on both sides at once. A merge with current main is clean and leaves no edition.is_enterprise, enterprise_sign_in or enterprise_gate name in the backend, tests or dashboard. PR Readiness is green and every review lane says PASS. Done well: the keep-list is applied exactly, and the old build value is refused with no alias, pinned by two new tests.

Security: the sensitive files (sandbox_*.py, gate_tiers.py, hooks.py, safety_override_permits.py, KasLoginGate.tsx) only rename is_enterprise() to is_lts() and reword comments. The Security Scope lane found 0 newly refused operations. The protected-read id in hooks.py and KIRO_CLI_STORE_READ_ID were renamed together, so the fail-closed registration check still holds. A missed call site would fail to import. It would not open a gate.

Optional:

  • hooks.py:1536: shipped oss builds already emit enterprise_sign_in.kiro_cli_store on the KAS spawn path (auth/bridge.py), so this changes an oss audit label. Add one line under Backwards compatibility, or keep the old id string.
  • A few comments still call the edition "enterprise": KasLoginGate.tsx:736, website/capture/shoot-lts-sign-in-only.mjs:1, and enterprise_policy_fetch.py lines 14, 350 and 366.
  • website/electron/test/edition.test.js:36: the near-miss rows still use "enterprise", so they no longer test the exact match on "lts". Add "LTS", " lts" and "lts\n\n". The body also says this test covers the unknown-value branch of build-desktop.sh, but it does not check that branch.

@KiroCrewCaptain
KiroCrewCaptain merged commit c5a0c26 into main Nov 8, 2026
116 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the feat/lts-edition-rename branch November 8, 2026 21:58
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 8, 2026
@LuisBrel LuisBrel mentioned this pull request Nov 8, 2026
5 tasks done
KiroCrewCaptain added a commit to KiroCrewCaptain/kirocrew-app-code-review-sage that referenced this pull request Nov 15, 2026
Carries every change that landed on the built-in Code Review Sage after
this repository's snapshot and was not here yet, so a user on this copy
has each of them:

- kirodotdev/KiroCrew#32970: the Enterprise Edition is now the LTS
  Edition. The review floor asked only edition.is_enterprise and
  enterprise_boot, which a current host no longer has, so an LTS build
  read as oss and a review fell back to Kiro CLI. It now asks is_lts and
  lts_boot first and the old names second. The test dependency pins
  Kiro Crew main af94fac51f so the suite runs against the names a
  current host has.
- kirodotdev/KiroCrew#31136: a namespace body that is JSON but not an
  object answers 400 body_not_object.
- kirodotdev/KiroCrew#21307: the poster pipes the draft review on stdin
  (gh api --input -) instead of a temp file.
- kirodotdev/KiroCrew#32618: a review that finishes while open shows its
  report.
- kirodotdev/KiroCrew#33108: Dismiss finding and Undo keep focus while
  they save.
- kirodotdev/KiroCrew#32865: Open shared copy goes through the host's
  navigator, so an app pop-out hands the page to the main window.
- kirodotdev/KiroCrew#29272: comment citations follow the split files.

Each fix has a test that fails without it. PORTING.md lists them under
"Fixes since the port", with the GitLab port (kirodotdev/KiroCrew#33491)
that had no row yet.

Part of kirodotdev/KiroCrew#26967.

Co-authored-by: Bolin Chen <bolichen@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename the Enterprise Edition to the LTS Edition

2 participants