Repository navigation
ci: install Playwright's ubuntu24.04 Chromium on the ubuntu-26.04 fork runner - #37653
Conversation
|
@iamwhatever could you review this one? It is our push, so our approval does not count. It only touches the three Playwright install steps in AI-assisted, sent by Bolin Review bot |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the override is scoped to Ubuntu 26.04+ only, so every other host is unchanged, and if it fails, fork PRs stay red as they already are. Notes
[DESIGN-REVIEWED] 7fad108 Description read[DESCRIPTION-READ] 5fa2f56e1bddfe76ea8125220cdca9899eabaa274f83bc912b7455a471827daa That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: the change fixes a red CI build caused by an external runner image, and the guard covers all three Playwright install sites (3 of 3 matches for Not checked: that the ubuntu24.04 Chromium build actually launches on the ubuntu-26.04 fork runner. Notes
What this change shipsInventory (3 items) — 2 justifiedIntent: let fork PRs install and launch Playwright Chromium again on the fork runner's new image. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 7fad108 Description read[DESCRIPTION-READ] ac4867985dcdb1e5b5e2f26cc114e35aac4a9d093ba2bcf2462475bf4f714c67 That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsNo findings. Notes:
[OPUS-REVIEWED] 7fad108 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Code change approver recommendation: ApproveWhy: the decider estimates an 8% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. The PR adds a guarded PLAYWRIGHT_HOST_PLATFORM_OVERRIDE=ubuntu24.04- to all three Playwright install sites. These are the only Playwright installs in .github/. The guard only takes effect on Ubuntu 26.04+; on other hosts it sources /etc/os-release, which sets no exported variables, so they keep their current behaviour. The value is written to GITHUB_ENV before the e2e non-root boundary, so test_ci_nonroot_boundary's ordering assertion still holds. ci-shell keeps the environment (passthrough, or runuser -m), and the Playwright children inherit os.environ, so the override reaches every step that launches the browser. The scheduling test's step matcher was updated correctly. If the 24.04 Chromium build doesn't run on 26.04, fork PRs stay red as they are today. No blocking issues. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
…k runner Playwright 1.58.2 has no ubuntu26.04 host entry, and kirocrew-linux-4-core now boots ubuntu-26.04, so every fork PR's E2E, render benchmark and i18n render gate fail at 'npx playwright install chromium'. On that image only, set PLAYWRIGHT_HOST_PLATFORM_OVERRIDE to the ubuntu24.04 build and carry it through GITHUB_ENV to the steps that launch the browser. Part of #37647.
ed8394c to
7fad108
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approved. On this head the review checked these points. The guard uses Playwright's own PLAYWRIGHT_HOST_PLATFORM_OVERRIDE. It only fires when /etc/os-release reports Ubuntu 26 or later, so every other host is left alone, and an empty or non-numeric version also leaves the old behaviour in place. All three npx playwright install chromium sites (i18n-render, bench-render, e2e) are patched. The new e2e GITHUB_ENV write still runs before the run-as-runner boundary that test_ci_nonroot_boundary.py pins. The updated test lookup keeps the existing checks. This head's Render Benchmark job (132916194655) ran on the ubuntu-26.04 fork runner. In that job the guard fired, the ubuntu24.04 Chromium downloaded, and the benchmark launched it and passed.
Done well: a narrow fix that fails safe, using the supported override and not a version bump or a hand-rolled download.
Optional:
.github/workflows/ci.yml:4554: the comment says the Playwright version step is the last GitHub file-command writer. The Chromium install step now comes after it and writesGITHUB_ENV, so the comment should name that step.- The body says the fix is not yet proven on ubuntu-26.04 and that main is unaffected. Render Benchmark runs on the fork runner for every run, including main, and job 132916194655 already proves the install and the launch there. Only the E2E and i18n lanes still wait for a fork PR.
- No test pins the guard, so a later edit could drop it from one of the three pasted copies and nothing would go red. A small parametrized test, or one shared helper script, would cover that.
…k runner (#37653) (#37818) Playwright 1.58.2 has no ubuntu26.04 host entry, and kirocrew-linux-4-core now boots ubuntu-26.04, so every fork PR's E2E, render benchmark and i18n render gate fail at 'npx playwright install chromium'. On that image only, set PLAYWRIGHT_HOST_PLATFORM_OVERRIDE to the ubuntu24.04 build and carry it through GITHUB_ENV to the steps that launch the browser. Part of #37647. (cherry picked from commit b5ac843) Co-authored-by: Bolin Chen <bolichen@amazon.com>
Problem / Motivation
Goal: Fork PRs get a working Playwright Chromium again on the fork runner.
The fork runner
kirocrew-linux-4-corenow boots ubuntu-26.04 (image 20261103.629).website/package.jsonpins Playwright 1.58.2, which has no ubuntu26.04 host entry, sonpx playwright install chromiumstops withERROR: Playwright does not support chromium on ubuntu26.04-x64. Every fork PR goes red on E2E (stub ACP backend, offline), Render Benchmark (counter budgets) and i18n Render Gate, whatever it changes (seen on #37626 and #37627).mainand same-repo PRs run on the CodeBuild fleet and are not affected.Why it matters
Contributors see three red checks they did not cause, and auto-merge cannot land an approved fork PR.
Not a goal
What changed
The three
npx playwright install chromiumsteps in.github/workflows/ci.ymlnow first check/etc/os-release. On Ubuntu 26.04 or later only, they setPLAYWRIGHT_HOST_PLATFORM_OVERRIDE=ubuntu24.04-<arch>(Playwright's own override, read inplaywright-core/lib/server/utils/hostPlatform.js) and write it toGITHUB_ENV, so the later steps that launch the browser resolve the same build. On every other host the step runs exactly as before.test/test_e2e_ci_scheduling.pyfound the install step by its exactruntext; it now matches arunwhose last line is the install command.Backwards compatibility
Compatible: hosts that are not Ubuntu 26.04+ run the same command with the same environment.
Removes nothing.
Tests
test/test_e2e_ci_scheduling.py: 13 passed. The CI-surface tests (test_ci_*,test_workflow*,test_prepare_pr_profiles.py): 4185 passed with this change.24.04(unchanged) and26.04(override set).PLAYWRIGHT_HOST_PLATFORM_OVERRIDE=ubuntu24.04-x64 npx playwright install --dry-run chromiumwith Playwright 1.58.2 resolveschromium v1208(linux64/chrome-linux64.zip).Not verified here: a real run on the ubuntu-26.04 runner. This PR's own checks run on CodeBuild, so the proof is the next fork PR's E2E job.
Related Issues
Part of #37647
Checklist
AI-assisted, sent by Bolin Review bot