Skip to content

chore(deps): run the m1 dependency audit - #177

Merged
kixelated merged 3 commits into
mainfrom
quest/m1/audit-deps
Nov 20, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest/m1/audit-deps

Conversation

@kixelated

@kixelated kixelated commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Runs the m1 deps audit (first run, covering releases from the repository's start through 2026-11-20) and plans the next run in m2.

Changes

  • jiff 0.2.40 → 1.0.1. Its one breaking change that hit us is the to_zoned → to_zoned_datetime rename (src/cli.rs, src/safe.rs). 1.0 also brings the 0.2.42 to 0.2.46 bug fixes, including an out-of-bounds timestamp parse (jiff#714).
  • rusqlite 0.41.1 → 0.43.0. This bundles SQLite 3.54.1 and fixes several use-after-free bugs. The bugs are in APIs we don't call, but 0.41 gets no more fixes. One behavior change: 0.43 rejects empty or comment-only SQL, and none of our statements are like that.
  • ctrlc 3.5.3 and ureq 3.5.2 (patch releases), plus cargo update for the transitive crates (24 packages).
  • Dropped thiserror. It derived Error for one struct (safe::ScanError) with a {message} format, so a 6-line Display and Error impl replaces it, along with thiserror-impl from the build. Nothing else in the tree depends on it.
  • Nix installer: check.yml's Source job moves from DeterminateSystems/nix-installer-action (an untagged main commit of 2026-05-28, 34 commits behind) to cachix/install-nix-action v32.0.0 (bb0495a). It is the only workflow that installs Nix. The action enables nix-command flakes by default and passes GITHUB_TOKEN to Nix, so it needs no inputs. The m2 audit stub drops its check that upstream Nix is still supported, since the new action installs it by design.
  • Next run: deleted quest/m1/audit-deps.md and added quest/m2/audit-deps.md, scheduled for 2026-11-27 and requiring m1. quest/m2/README.md matches the copy in kixel-ai/token-max#178 byte for byte, so the two merge cleanly.

Public API and wire impact: none. ScanError keeps its Display and Error behavior.

Findings with no change

  • Upstream health: every crate, action and cargo-dist upstream is unarchived. All published or committed within the past year, most within the past month. winapi-util's last release was 2025-09, but it is a small, stable BurntSushi crate.
  • Up to date already: actions/checkout v7.0.1, upload-artifact v7.0.2, download-artifact v8.0.2, attest-build-provenance v4.2.2, crates-io-auth-action v1.0.6, cargo-dist 0.34.0, and every other crate.
  • Pullfrog is pinned at v0.1.127 while v0.1.139 is out. That pin follows the org standard in dotfiles' repo-settings, so a bump belongs there, not here.
  • Rust 1.100 came out on 2026-11-12, and the dev shell's nixpkgs gives 1.99. nixpkgs is a commit pin, which this audit skips. 1.100 has nothing we need, so rust-version = "1.99" stays.
  • Forks, vendored code, workarounds: none. No comment or issue link in the code names a dependency workaround.
  • Held-back majors: none.
  • What let the findings in: stale versions are what this per-milestone audit exists to catch. The untagged main pin is now first on the m2 stub's list to check. I added no gate check, since a single grep for one pin style isn't worth its weight.

Validation

  • nix develop --command quest gate just check: fmt, clippy -D warnings, 581 unit tests and 40 integration tests pass, and quest check passes.
  • Differential run on the real surface: built main's release binary in a scratch worktree, then ran both binaries as token-max sessions --since 2026-11-10 --offline on this host's real transcripts. This covers about 6,600 sessions (1,770 from T3's SQLite through rusqlite) and the jiff --since parsing. Output matches on all 6,598 sessions not modified during the runs. The 24 differing lines all belong to sessions that were active while the commands ran (last activity within the runs' window).
  • The Nix installer switch only runs in CI's Source job, which skips drafts, so it is unverified until the PR is marked ready; quest check passes locally.

Decisions

  • Nix installer for CI: ✅ switch to cachix/install-nix-action (rejected: keep the DeterminateSystems v23 pin, switch to Determinate Nix). Maintainer's decision in this comment: v23 calls upstream Nix (determinate: false) unsupported, and the new action installs it by design, the Nix the dev shell assumes. moq-dev/quest and moq-dev/moq get the same switch in their own PRs.

Follow-ups

None. Each finding was either fixed here or needs no change.

Models

Size: M
Implementer: Claude, claude-opus-5-5, unknown effort (arm A)
Implementer: Claude Code, claude-sonnet-5-5, unknown effort (iterate, XS, arm A)

🤖 Generated with Claude Code

Review

Rewritten by quest review after each round.

  • Head: fd68ef8

  • Base: origin/main at 309b526

  • Risk: high, it changes .github/workflows/check.yml, which is always high: workflows run with the repository's secrets and decide what merges and ships

  • Classified: high by the always-high paths

  • Reviewer: Codex, gpt-6.1-sol, high effort

  • Session: 01a1fa46-3269-7df1-ba07-b312caebea6c, round 1

  • Score: 9/10, No actionable regressions or blockers were found; the dependency API updates and manual error implementation preserve behavior, but builds and tests were not run as instructed.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

  • Reviewer: Codex, gpt-6.1-sol, medium effort, shadow

  • Session: 01a1fa46-326a-7821-bffc-d60770f01cda, round 1

  • Score: 9/10, The dependency updates and API adaptations appear consistent with no actionable regressions found, though builds and tests were not run as instructed.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

Summary by CodeRabbit

  • Documentation
    • Added documentation for the m2 dependency audit, including its scope, baseline, schedule, and relationship to m1.
    • Updated the m2 overview to note that it follows m1.
    • Removed the m1 dependency-audit documentation.
  • Updates
    • Adjusted date and time handling when parsing CLI dates and scan timestamps.

Quest-Claim: dd15771873895cef
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The pull request updates dependencies and time parsing, changes the Nix installer action in the source workflow, and revises milestone audit documentation.

Changes: Runtime dependency and parsing updates

Layer / File(s) Summary
Dependency and source updates
Cargo.toml, src/safe.rs, src/cli.rs
The manifest updates four dependencies and removes thiserror. ScanError now implements Display and Error directly. Two date-time conversions use to_zoned_datetime.

Workflow installer update

Layer / File(s) Summary
Nix installer action
.github/workflows/check.yml
The source job uses the pinned Cachix Nix installer action in place of the pinned Determinate Systems action.

Milestone audit documentation

Layer / File(s) Summary
Milestone and dependency audit documentation
quest/m1/audit-deps.md, quest/m2/README.md, quest/m2/audit-deps.md
The m1 dependency audit document is removed. The m2 README identifies the milestone as following m1, and the m2 audit document describes audit scope, exclusions, a pin-comment check, a scheduled run, and the m1 dependency.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: pullfrog

Merge Risk: Minimal · up to fd68e

This PR updates dependencies, swaps the Nix installer action in CI, and moves the dependency-audit docs. No concrete merge-blocking risk was found; the installer change is unverified in CI but is a low-impact, easily reverted change.

Security architecture risk: Minimal · up to fd68e

The inspected changes establish no material security regression. The replacement installer is commit-pinned, workflow permissions remain read-only, and the error implementation preserves its message-based contract. This assessment does not certify the upgraded dependencies or installer internals.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • observed — The installer replacement is confined to the Source job in the inspected workflow. The macOS and Windows platform jobs continue to run Cargo tests without that Nix installation step.

Trust Boundaries and Controls

  • observed — The trusted installer provider changes, but the workflow retains contents: read permissions, a commit-pinned installer reference, and checkout with persist-credentials disabled. The installer step adds no explicit secret inputs. These controls bound the declared workflow authority; they do not establish how the external action handles credentials internally.
Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "chore(deps): run the m1 dependency audit" matches the main purpose of the PR, which runs the m1 dependency audit and schedules the m2 audit. The title is specific and short. However, the ch…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "chore(deps): run the m1 dependency audit" matches the main purpose of the PR, which runs the m1 dependency audit and schedules the m2 audit. The title is specific and short. However, the changeset also includes substantial dependency upgrades (jiff, rusqlite, ctrlc, ureq), removal of thiserror with manual Display/Error implementations, and a CI installer change. The title does not mention these, but the task says it need not cover every detail.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
Fix failing CI checks

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3c129a63-c404-4027-8e59-dcedf6ff7504
Commits

Reviewing files that changed from the base of the PR and between 309b526 and fd68ef8.

Files ignored due to path filters: 1

  • Cargo.lock is excluded by !**/*.lock
Files selected for processing: 7

  • .github/workflows/check.yml
  • Cargo.toml
  • quest/m1/audit-deps.md
  • quest/m2/README.md
  • quest/m2/audit-deps.md
  • src/cli.rs
  • src/safe.rs
Files with no reviewable changes: 1

  • quest/m1/audit-deps.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.

Take jiff 1.0 and rusqlite 0.43, the patch releases of ctrlc and ureq,
and a lockfile refresh. Drop thiserror for a manual Error impl on the one
type that used it. Pin the Nix installer action to its v23 release
instead of an untagged main commit. Plan the next run in m2.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Audit dependencies chore(deps): run the m1 dependency audit Nov 20, 2026
@kixelated

Copy link
Copy Markdown
Collaborator Author

Maintainer decision on the Nix installer for CI:

  • ✅ switch check.yml to cachix/install-nix-action (rejected: keep the DeterminateSystems v23 pin, switch to Determinate Nix)

Reason: it installs upstream Nix as its supported mode, matching the nixpkgs Nix the dev shell uses, while v23 of the DeterminateSystems action calls determinate: false unsupported and may remove it.

(Written by Claude Opus 5.5)

The DeterminateSystems v23 action calls upstream Nix unsupported.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 20, 2026 18:45
@kixelated

Copy link
Copy Markdown
Collaborator Author

Applied the Nix installer decision on head fd68ef8: check.yml's Source job now uses cachix/install-nix-action v32.0.0, the only workflow that installs Nix. Recorded under ## Decisions, and the ## Waiting item is cleared.

(Written by Claude Sonnet 5.5)

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound — a routine dependency audit that fixes what it finds in place and drops a dependency that had a single use.

Reviewed changes: the full diff, with a grep for leftover to_zoned, thiserror and nix-installer references. Nothing remains.

  • Dependency bumps — jiff 1.0.1, rusqlite 0.43.0, ctrlc 3.5.3 and ureq 3.5.2 in Cargo.toml, with the lockfile regenerated.
  • jiff API rename — to_zoned becomes to_zoned_datetime in src/cli.rs and src/safe.rs. The call sites are otherwise unchanged.
  • thiserror removed — ScanError gets a hand-written Display that writes message and an empty Error impl, matching the old #[error("{message}")] behaviour.
  • Nix installer — the check.yml Source job moves to cachix/install-nix-action, pinned by full SHA with a release tag comment. The new action needs no inputs.
  • Quest files — quest/m1/audit-deps.md is removed, and quest/m2/README.md and quest/m2/audit-deps.md plan the next run.

I did not build or run tests. The PR reports just check and a differential run against real transcripts as passing. The Nix installer change only runs in CI, so CI on this PR is its first real test.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit 57a9847 Nov 20, 2026
15 of 20 checks passed
@kixelated
kixelated deleted the quest/m1/audit-deps branch November 20, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant