Repository navigation
chore(deps): run the m1 dependency audit - #177
Conversation
Quest-Claim: dd15771873895cef
Take jiff 1.0 and rusqlite 0.43, the patch releases of ctrlc and ureq, and a lockfile refresh. Drop thiserror for a manual Error impl on the one type that used it. Pin the Nix installer action to its v23 release instead of an untagged main commit. Plan the next run in m2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Maintainer decision on the Nix installer for CI:
Reason: it installs upstream Nix as its supported mode, matching the nixpkgs Nix the dev shell uses, while v23 of the DeterminateSystems action calls (Written by Claude Opus 5.5) |
The DeterminateSystems v23 action calls upstream Nix unsupported. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Applied the Nix installer decision on head fd68ef8: (Written by Claude Sonnet 5.5) |
There was a problem hiding this comment.
✅ No new issues found.
Approach: sound — a routine dependency audit that fixes what it finds in place and drops a dependency that had a single use.
Reviewed changes: the full diff, with a grep for leftover to_zoned, thiserror and nix-installer references. Nothing remains.
- Dependency bumps —
jiff1.0.1,rusqlite0.43.0,ctrlc3.5.3 andureq3.5.2 inCargo.toml, with the lockfile regenerated. jiffAPI rename —to_zonedbecomesto_zoned_datetimeinsrc/cli.rsandsrc/safe.rs. The call sites are otherwise unchanged.thiserrorremoved —ScanErrorgets a hand-writtenDisplaythat writesmessageand an emptyErrorimpl, matching the old#[error("{message}")]behaviour.- Nix installer — the
check.ymlSource job moves tocachix/install-nix-action, pinned by full SHA with a release tag comment. The new action needs no inputs. - Quest files —
quest/m1/audit-deps.mdis removed, andquest/m2/README.mdandquest/m2/audit-deps.mdplan the next run.
I did not build or run tests. The PR reports just check and a differential run against real transcripts as passing. The Nix installer change only runs in CI, so CI on this PR is its first real test.
claude-sonnet-5-5 | 𝕏

Runs the m1
depsaudit (first run, covering releases from the repository's start through 2026-11-20) and plans the next run in m2.Changes
to_zoned→to_zoned_datetimerename (src/cli.rs,src/safe.rs). 1.0 also brings the 0.2.42 to 0.2.46 bug fixes, including an out-of-bounds timestamp parse (jiff#714).cargo updatefor the transitive crates (24 packages).thiserror. It derivedErrorfor one struct (safe::ScanError) with a{message}format, so a 6-lineDisplayandErrorimpl replaces it, along withthiserror-implfrom the build. Nothing else in the tree depends on it.check.yml's Source job moves fromDeterminateSystems/nix-installer-action(an untaggedmaincommit of 2026-05-28, 34 commits behind) tocachix/install-nix-actionv32.0.0 (bb0495a). It is the only workflow that installs Nix. The action enablesnix-command flakesby default and passesGITHUB_TOKENto Nix, so it needs no inputs. The m2 audit stub drops its check that upstream Nix is still supported, since the new action installs it by design.quest/m1/audit-deps.mdand addedquest/m2/audit-deps.md, scheduled for 2026-11-27 and requiring m1.quest/m2/README.mdmatches the copy in kixel-ai/token-max#178 byte for byte, so the two merge cleanly.Public API and wire impact: none.
ScanErrorkeeps itsDisplayandErrorbehavior.Findings with no change
repo-settings, so a bump belongs there, not here.rust-version = "1.99"stays.mainpin is now first on the m2 stub's list to check. I added no gate check, since a single grep for one pin style isn't worth its weight.Validation
nix develop --command quest gate just check: fmt, clippy-D warnings, 581 unit tests and 40 integration tests pass, andquest checkpasses.token-max sessions --since 2026-11-10 --offlineon this host's real transcripts. This covers about 6,600 sessions (1,770 from T3's SQLite through rusqlite) and the jiff--sinceparsing. Output matches on all 6,598 sessions not modified during the runs. The 24 differing lines all belong to sessions that were active while the commands ran (last activity within the runs' window).quest checkpasses locally.Decisions
cachix/install-nix-action(rejected: keep the DeterminateSystems v23 pin, switch to Determinate Nix). Maintainer's decision in this comment: v23 calls upstream Nix (determinate: false) unsupported, and the new action installs it by design, the Nix the dev shell assumes. moq-dev/quest and moq-dev/moq get the same switch in their own PRs.Follow-ups
None. Each finding was either fixed here or needs no change.
Models
Size: M
Implementer: Claude, claude-opus-5-5, unknown effort (arm A)
Implementer: Claude Code, claude-sonnet-5-5, unknown effort (iterate, XS, arm A)
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.Head: fd68ef8
Base: origin/main at 309b526
Risk: high,
it changes .github/workflows/check.yml, which is always high: workflows run with the repository's secrets and decide what merges and shipsClassified: high by the always-high paths
Reviewer: Codex, gpt-6.1-sol, high effort
Session:
01a1fa46-3269-7df1-ba07-b312caebea6c, round 1Score: 9/10,
No actionable regressions or blockers were found; the dependency API updates and manual error implementation preserve behavior, but builds and tests were not run as instructed.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none
Reviewer: Codex, gpt-6.1-sol, medium effort, shadow
Session:
01a1fa46-326a-7821-bffc-d60770f01cda, round 1Score: 9/10,
The dependency updates and API adaptations appear consistent with no actionable regressions found, though builds and tests were not run as instructed.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none
Summary by CodeRabbit