Skip to content

Complete Go starter validation and polyglot scenario readiness - #21828

Merged
David Pine (IEvangelist) merged 4 commits into
mainfrom
ievangelist-go-ci-scenario-readiness
Nov 6, 2026
Merged

David Pine (IEvangelist) merged 4 commits into
mainfrom
ievangelist-go-ci-scenario-readiness

Conversation

@IEvangelist

@IEvangelist David Pine (IEvangelist) commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Description

Go starters should build from their shipped files without an initial aspire run repairing dependencies, and Go preview validation should exercise the same runtime and native-runner paths as other AppHosts.

  • Ship a tidy API go.mod and generated go.sum. Add starter scenarios checking gitignore, readonly API build, tidy stability, health and weather responses; remove the Kubernetes manual-tidy workaround.
  • Honor the existing --use-redis-cache false option for Go. Omitted/true retains Redis; false omits the integration and resource. Cover all three scaffold choices with generated-source snapshots and both HTTP lifecycle variants with Docker E2E.
  • Add go vet to Go polyglot fixtures, an EF Core fixture, and Foundry tool/AKS node-pool parity. Exercise configuration-section list getters in the real Go runtime smoke.
  • Add Go to all six native starter-validation platforms, with official checksum-verified Go installation, timeout budget, and runtime-only selector edges for Go hosting, Go codegen, and Redis. Linux retains API/Redis readiness; containerless Windows/macOS use the cache-free starter with API readiness unchanged.
  • Add isolated-local-feed Go/Java scaffolding and restore to the stabilization smoke without rewriting template pins. Use a genuine Release bundled driver outside repository mode, cold consumer caches, and exact hosting-package extraction/provenance checks. Enable Java only in its subprocess.
  • Select languages by name rather than picker position. Restore stale Java/TypeScript SDK baselines after aspire add so the following aspire restore genuinely tests regeneration. Establish the TypeScript baseline with an actual restore before reading cache metadata.
  • Wait for the TypeScript Kubernetes application's actual Ready pod; exercise the Go Helm namespace/chart-version callback.

Relates to #21202, #21206, #21209, #21210, #21201, and #21108.

User-facing usage

# Default retains Redis.
aspire new aspire-go-starter --name GoReady --non-interactive --suppress-agent-init

# Containerless starter: the Go API runs without Redis or a Docker daemon.
aspire new aspire-go-starter --name GoReady --use-redis-cache false --non-interactive --suppress-agent-init

Both variants emit api/go.sum and an already-tidy API module. Its API can build with go build -mod=readonly without first running the AppHost's tidy resource.

Dependencies and remaining acceptance

This PR is independent of #21823. Root-module brownfield E2E #21825 merged into the #21823 feature branch, not directly into main; its delivery follows #21823. #21806 independently covers other Go init/build/vet/stable-restore scenarios.

The existing stabilization gate remains disabled (STABILIZATION_ENABLED: 'false'); enabling it needs a separate CI/policy decision. Current Aspire.Hosting.Java.csproj still sets SuppressFinalPackageVersion=true while the Java starter pins the requested Aspire version. The corrected smoke reaches actual NuGet restore and exposes that mismatch: Aspire.Hosting.Java (= 17.0.0) is unavailable, the nearest local package is 17.0.0-dev, and nuget.org versions are not considered. No pin substitution or Java release-policy change is included.

Native Linux validation built the genuine stabilized Release CLI/payload and proved cold Go/Redis package restore and C# restore. This is not a clean stabilization pass: the unsuppressed stable pack first reproduced NU5104 on existing .NET 11 preview dependencies. The diagnostic consumer feed downgraded only NU5104 with WarningsNotAsErrors=NU5104; that exception is not committed. The final smoke correctly exits 1 with only Java in its failure list.

The bounded shared-image fix is separate in #21849; this PR does not modify image Dockerfiles or the image-build implementation. Its b8274fc8e0 image job and all four uploads passed, Infrastructure passed 2090/2090 including all 13 new image cases, and all 116 CLI archive E2E jobs passed. Earlier Windows extension fake-timer and DCP Docker-startup failures were investigated with same-source passing main controls; the morning live refresh reports its Final Results passing. It remains independently review-gated. Do not infer actual timeout/fallback execution from a healthy-mirror image pass.

No action SHA is added or changed. No official Azure DevOps pipeline is modified. Parent's Go-minimum-version map rule/theory and the other owner's extension-e2e map block are untouched. The cache option uses existing embedded CLI inputs; no additional selector rule is required. The stabilization script remains advisory/disabled rather than being presented as a regular-PR gate.

This does not close #21108: live Azure Container Apps deployment and real missing/old-toolchain E2E remain uncovered here. Cross-language lifecycle redesigns are deferred.

CI failures diagnosed and fixed

Original-head run 42116644663 exposed two causes:

  • Windows x64/ARM64 and macOS x64/ARM64 starter validation failed because Redis could not start: the Windows Docker engine pipe was absent and macOS had no Docker executable. The API correctly waited on its unhealthy dependency. Those native runners now use the supported cache-free variant; Linux and Docker E2E retain Redis coverage. No readiness assertion was removed.
  • TypeScriptCodegenValidationTests read .codegen-hash immediately after init, which supplies SDK sources but not restore-cache metadata. An explicit baseline restore now precedes the snapshot and stale-cache assertions.

Head 1ab3ad1e30: all six native starter lanes passed, including both Redis-enabled Ubuntu lanes and all four formerly failing Windows/macOS lanes, in run 42151619597. Packaged CI subsequently passed GoStarterReadinessTests (both cache choices), GoStarterTemplateTests, JavaCodegenValidationTests, and TypeScriptCodegenValidationTests. All originally failing targeted lanes/classes therefore have passing coverage.

The shared image job first timed out at 45 minutes twice. Attempt 2 fetched 108 MB from Azure Ubuntu in 41 minutes 29 seconds (43.4 kB/s), versus a following GitHub download at 80.1 MB/s; GHA cache import also returned HTTP 400 service-unavailable responses. After #21849's same-input image control passed with all four uploads, one evidence-based product revalidation was started. Attempt 3's image job passed and admitted packaged E2E. No blind retries were made. The successful infrastructure control used a healthy primary mirror; it does not demonstrate timeout/fallback execution in that CI run.

Head bd30794b9e: historical failures and final outcome are distinct. In run 42167868738, all six native starter lanes and Go/Java/TypeScript SDK validation passed. The first shared image job was canceled after 45 minutes 22 seconds with Azure Ubuntu apt downloads still running and all four uploads skipped; the initial Linux tree-actions attempt also failed on a stale immutable Running snapshot. The morning live refresh subsequently shows Final Results passing, including GoStarterReadinessTests. This session did not initiate retries. A passing later attempt does not repair the tree-actions race: its separate test-only fix #21854 still needs independent approval/merge and incorporation before claiming the race fixed in this checkout.

Latest head 0bb6569d91 requires fresh checks, now running in 42222384609. Both new review findings are corrected: SDK selection accepts only exact numeric MAJOR.MINOR.PATCH package filenames, and Go starter startup is inside its existing cleanup scope. Both threads were replied to and resolved with evidence. Earlier-head CI is not presented as latest-head proof.

Per the user's explicit authorization, the coordinator enabled normal native squash auto-merge at 05:22:46Z on 2026-11-06. It remains enabled behind required fresh checks and review requirements. No admin bypass is authorized or used; the PR is not merged.

Stabilization review corrections

The smoke now publishes a Release CLI with its real stabilized bundle outside the checkout, propagates stabilization into child payload builds, and clears inherited ASPIRE_REPO_ROOT for every consumer invocation. Consumer packages are isolated after the driver build so build-time extraction cannot hide a missing stable package. Successful guest restores must produce metadata for the exact hosting pins, including Redis for Go; provenance is retained in the output.

The real run also exposed two stale smoke assumptions: a pre-owned parent feed mapping conflicts with scaffolding's project-local channel policy, and current C# file-based templates use #:package Aspire.Hosting.AppHost@<version>, not the obsolete SDK directive. The smoke now lets the CLI establish its own authoritative project-scoped feed mapping and checks the current hosting-package contract. No customer NuGet policy is changed.

Validation

  • .\restore.cmd - passed.
  • dotnet build tests\Aspire.Cli.EndToEnd.Tests\Aspire.Cli.EndToEnd.Tests.csproj --no-restore --nologo -v quiet - passed, zero warnings/errors; repeated successfully after removing temporary fault injection for 0bb6569d91.
  • dotnet test --project tests\Aspire.Cli.Tests\Aspire.Cli.Tests.csproj --no-launch-profile -- --filter-class '*.NewCommandTemplateConfigPersistenceTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true' - passed, 59 tests including default/true/false Go package and generated-source assertions. Existing ILCompiler NU1903 advisory was emitted.
  • With ASPIRE_E2E_CLI_ARCHIVE_DIR=artifacts\readiness-ci\cli-archive-new and ASPIRE_E2E_DOTNET_IMAGE=aspire-e2e-polyglot-base:latest, dotnet test --project tests\Aspire.Cli.EndToEnd.Tests\Aspire.Cli.EndToEnd.Tests.csproj --no-launch-profile -- --filter-method '*.RestoreGeneratesSdkFiles_WithConfiguredToolchain' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true' - passed, all four npm/bun/yarn/pnpm cases against exact 1ab3ad1e30 Linux CLI/packages. The corresponding packaged CI class also passed above.
  • With ASPIRE_E2E_CLI_ARCHIVE_DIR=artifacts\readiness-ci\cli-archive-new and ASPIRE_E2E_POLYGLOT_GO_IMAGE=aspire-go-e2e-6972:latest, dotnet test --project tests\Aspire.Cli.EndToEnd.Tests\Aspire.Cli.EndToEnd.Tests.csproj --no-launch-profile -- --filter-method '*.StarterShipsTidyApiAndServesRequests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true' - 1 passed/1 failed locally against exact 1ab3ad1e30. Cache-free passed actual scaffolding, readonly API build, tidy check, API-up, health/weather and stop without a Docker socket. Redis timed out locally. The unchanged 2859e199e2 control reproduced the same timeout on this Docker Desktop host; no workaround or weaker assertion was added. Both cases subsequently passed packaged CI, linked above. After the cleanup-scope correction, this local command again passed cache-free and failed Redis on API readiness; the independent CLI stop log confirmed successful shutdown, while the shared terminal helper observed the prior ERR prompt. That local run is not claimed green.
  • Temporary fault-injection validation used that same E2E command with only the cache-free case and a shell wrapper returning HTTP 503 for the Dashboard probe after a real packaged AppHost launch - intentionally failed. Terminal output showed dashboard-http-failed, then cleanup invocation; the CLI log confirmed apphost.go stopped successfully and exit 0. The wrapper and temporary test edit were removed before the final clean build/commit. This verifies partial-start cleanup, not a successful readiness scenario.
  • docker run --rm --entrypoint bash -v "${PWD}:/workspace:ro" aspire-go-e2e-6972:latest -c "sed 's/\r$//' /workspace/artifacts/readiness-ci/validate-stable-sdk-selection.sh | bash" - passed actual smoke-script preflight cases for missing SDK, prerelease-only, mixed stable/dev/preview/rc/build-metadata/four-component filenames, multi-digit stable versions, and feed paths with spaces. The instrumented driver received BundleVersion=17.0.0 from the mixed feed. Invalid-only feeds exited 1 with the explicit missing-stable diagnostic. Temporary harness removed after retaining logs; not a new all-language stabilization pass.
  • dotnet test --project tests\Infrastructure.Tests\Infrastructure.Tests.csproj --no-launch-profile -- --filter-class '*.TestTriggerMapTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true' - passed, 176 tests.
  • dotnet run --project tools\SelectTests -- --changed-files artifacts\readiness-changed-files.txt --explain - passed against the real graph/map; Go hosting/codegen, Redis, starter checksum and EF Core fixture inputs select starter-validation/polyglot with zero unattributed files. Schedule-only deployment remains advisory.
  • $env:DOTNET_ROOT = Join-Path $PWD '.dotnet'; $env:ASPIRE_REPO_ROOT = $PWD; .\artifacts\bin\Aspire.Cli\Debug\net11.0\aspire.exe restore --apphost tests\PolyglotAppHosts\<integration>\Go\apphost.go --non-interactive - passed separately for Aspire.Hosting.EntityFrameworkCore, Aspire.Hosting.Foundry, and Aspire.Hosting, generating actual SDK bindings.
  • docker run --rm --entrypoint bash -v "${PWD}:/workspace" aspire-go-e2e-6972:latest -c 'set -e; for fixture in Aspire.Hosting.EntityFrameworkCore Aspire.Hosting.Foundry Aspire.Hosting; do cd "/workspace/tests/PolyglotAppHosts/$fixture/Go"; gofmt -w apphost.go; go build -buildvcs=false -o /tmp/fixture ./...; go vet ./...; done' - passed for all three fixtures.
  • docker run --rm --entrypoint bash -v "${PWD}:/workspace:ro" aspire-go-e2e-6972:latest -c 'set -e; bash -n /workspace/.github/workflows/polyglot-validation/test-go.sh /workspace/.github/workflows/polyglot-validation/test-go-playground.sh /workspace/eng/scripts/stabilization-smoke-init-restore.sh; work=$(mktemp -d); trap "rm -rf $work" EXIT; cp /workspace/src/Aspire.Cli/Templating/Templates/go-starter/api/* "$work/"; cd "$work"; sed -i "s/{{projectNameLower}}/starter/g" go.mod; go build -mod=readonly -o /tmp/go-ready-api .; go mod tidy -diff; go vet ./...' - passed without a dependency-repair command.
  • Native Linux ./restore.sh -p:SkipTestProjects=true -p:SkipPlaygroundProjects=true - passed with the pinned SDK.
  • Native Linux ./dotnet.sh pack src/Aspire.Hosting.AppHost/Aspire.Hosting.AppHost.csproj -c Release -p:StabilizePackageVersion=true -p:SkipNativeBuild=true --nologo -v quiet - failed as expected on existing NU5104 preview dependencies; not counted as a stabilization pass.
  • To isolate consumer behavior, the diagnostic feed used for project in Aspire.Hosting Aspire.Hosting.AppHost Aspire.Hosting.Dotnet Aspire.TypeSystem Aspire.Hosting.CodeGeneration.Go Aspire.Hosting.CodeGeneration.Java Aspire.Hosting.Go Aspire.Hosting.Redis Aspire.Hosting.Java Aspire.Hosting.JavaScript Aspire.AppHost.Sdk Aspire.ProjectTemplates; do ./dotnet.sh pack "src/$project/$project.csproj" -c Release -p:StabilizePackageVersion=true -p:SkipNativeBuild=true -p:WarningsNotAsErrors=NU5104 --nologo -v quiet; done - passed. No suppression is committed; Java remains 17.0.0-dev by existing policy.
  • Native Linux STABILIZATION_SMOKE_CONFIGURATION=Release ASPIRE_REPO_ROOT=/work/source bash eng/scripts/stabilization-smoke-init-restore.sh - built the genuine stabilized Release driver/payload and completed the consumer flow. Exit 1 is the expected Java policy failure, not an all-language pass. Go/Redis 17.0.0 metadata names /work/source/artifacts/packages/Release/Shipping; C# 17.0.0 restored; Java reached real NuGet restore and rejected its absent stable pin with no nuget.org fallback. Output assertions confirmed the final failure list is exactly java. Sources were 1ab3ad1e30 plus the final smoke correction; no mixed PR-stamped CLI was used.
  • bash -n eng/scripts/stabilization-smoke-init-restore.sh, PowerShell parser validation of eng\scripts\cli-starter-validation.ps1, and git diff --check - passed.
  • Full Infrastructure.Tests.TestTriggerMap namespace was not passed on this Windows host: WSL's bash.exe cannot find /bin/bash; a narrowed run also encountered readonly .git cleanup failures. Not counted as successful validation.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 21828

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 21828"

@github-actions github-actions Bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 5, 2026
@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Windows/macOS Go validation lacks a usable container runtime, the Java smoke test cannot select its disabled template, and repository-mode restores bypass the pinned packages the stable-feed check is intended to verify.

3 open issues
What changed in this PR

This PR advances Go AppHost preview readiness by shipping build-ready starter dependencies and expanding validation across CLI scenarios, polyglot fixtures, and native runners. It also strengthens Java and TypeScript restore tests. The stabilization gate remains disabled, and several runtime scenarios still require CI execution.

Changes:

  • Ship a tidy Go starter module and checksums, with build, health, and weather-response checks.
  • Expand Go fixture coverage, runtime list-getter checks, and native-runner validation.
  • Replace positional language selection and strengthen SDK regeneration and Kubernetes readiness assertions.
File Description
tests/​PolyglotAppHosts/​Aspire.Hosting/​Go/​apphost.go Adds AKS node-pool and persistent-volume coverage.
tests/​PolyglotAppHosts/​Aspire.Hosting.Foundry/​Go/​apphost.go Attaches Foundry tools to a prompt agent.
tests/​PolyglotAppHosts/​Aspire.Hosting.EntityFrameworkCore/​Go/​go.mod Defines the new Go fixture module.
tests/​PolyglotAppHosts/​Aspire.Hosting.EntityFrameworkCore/​Go/​aspire.config.json Configures EF Core fixture integrations.
tests/​PolyglotAppHosts/​Aspire.Hosting.EntityFrameworkCore/​Go/​apphost.go Exercises migration configuration and publishing APIs.
tests/​Infrastructure.Tests/​TestTriggerMap/​TestTriggerMapTests.cs Checks Go starter runtime-package routing.
tests/​Aspire.Cli.EndToEnd.Tests/​TypeScriptPublishTests.cs Selects TypeScript by name.
tests/​Aspire.Cli.EndToEnd.Tests/​TypeScriptCodegenValidationTests.cs Restores stale SDK files before testing regeneration.
tests/​Aspire.Cli.EndToEnd.Tests/​SecretTypeScriptAppHostTests.cs Uses named language selection.
tests/​Aspire.Cli.EndToEnd.Tests/​LocalConfigMigrationTests.cs Uses named language selection.
tests/​Aspire.Cli.EndToEnd.Tests/​KubernetesDeployTypeScriptTests.cs Waits for the application pod to become Ready.
tests/​Aspire.Cli.EndToEnd.Tests/​JavaScriptPublishTests.cs Uses named language selection.
tests/​Aspire.Cli.EndToEnd.Tests/​JavaPolyglotTests.cs Selects Java independently of picker order.
tests/​Aspire.Cli.EndToEnd.Tests/​JavaPolyglotApphostDirectoryTests.cs Uses named Java selection.
tests/​Aspire.Cli.EndToEnd.Tests/​JavaCodegenValidationTests.cs Tests restore from a stale SDK baseline.
tests/​Aspire.Cli.EndToEnd.Tests/​Helpers/​KubernetesDeployTestHelpers.cs Corrects the tool-installation comment.
tests/​Aspire.Cli.EndToEnd.Tests/​Helpers/​CliE2EAutomatorHelpers.cs Centralizes language selection by display name.
tests/​Aspire.Cli.EndToEnd.Tests/​GoStarterReadinessTests.cs Checks starter dependencies, gitignore, and HTTP responses.
tests/​Aspire.Cli.EndToEnd.Tests/​GoKubernetesDeployTests.cs Removes manual tidy and exercises Helm configuration.
tests/​Aspire.Cli.EndToEnd.Tests/​GoEmptyAppHostTemplateTests.cs Checks the generated gitignore entry.
src/​Aspire.Cli/​Templating/​Templates/​go-starter/​api/​go.sum Ships dependency checksums.
src/​Aspire.Cli/​Templating/​Templates/​go-starter/​api/​go.mod Aligns dependency declarations with tidy output.
eng/​scripts/​stabilization-smoke-init-restore.sh Adds Go/Java scaffolding and isolated-cache restore checks.
eng/​scripts/​cli-starter-validation.ps1 Adds the Go starter and API/Redis readiness checks.
eng/​github-ci/​test-trigger-map.yml Routes Go and Redis changes to starter validation.
docs/​ci/​test-trigger-map.md Documents expanded validation coverage and gating.
.github/​workflows/​polyglot-validation/​test-go.sh Exercises configuration child-list decoding at runtime.
.github/​workflows/​polyglot-validation/​test-go-playground.sh Runs go vet on Go fixtures.
.github/​workflows/​cli-starter-validation.yml Installs checksum-verified Go and increases timeouts.
.github/​workflows/​ci.yml Updates comments describing stabilization smoke coverage.

Review effort: Balanced

Comment thread eng/scripts/cli-starter-validation.ps1 Resolved
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Honor the existing Redis opt-out for Go without changing its default. Keep Linux Redis readiness and exercise both generated starter variants. Restore the TypeScript SDK before snapshotting cache metadata.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The Java smoke test cannot reach package-pin validation on a clean runner because the experimental Java feature flag is not enabled, causing scaffolding to fail.

2 open issues
1 resolved since last review

Review effort: Balanced

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The smoke script can select prerelease artifacts instead of stable packages, and partial test startup failures can bypass cleanup and leave a Docker container running.

2 open issues
2 resolved since last review

Review effort: Balanced

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@aspire-repo-bot
aspire-repo-bot Bot requested a balanced review from Copilot November 6, 2026 13:03
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Tests selector

4 / 101 PR test projects · 4 PR jobs, from 37 changed files.

Selected PR test projects (4 / 101)

Aspire.Cli.EndToEnd.Tests, Aspire.Cli.Tests, Aspire.Hosting.CodeGeneration.Go.Tests, Infrastructure.Tests

Selected PR jobs (4)

cli-starter-validation, extension-e2e, polyglot, typescript-api-compat


How these were chosen — grouped by what changed

📦 affected project Aspire.Cli
→ 1 test: Aspire.Cli.EndToEnd.Tests

📄 .github/workflows/ci.yml (changed)
→ 1 directly: Infrastructure.Tests

📄 .github/workflows/cli-starter-validation.yml (changed)
→ 1 directly: Infrastructure.Tests

📄 .github/workflows/polyglot-validation/test-go-playground.sh (changed)
→ 1 directly: Infrastructure.Tests

📄 .github/workflows/polyglot-validation/test-go.sh (changed)
→ 1 directly: Infrastructure.Tests

📄 eng/github-ci/test-trigger-map.yml (changed)
→ 1 directly: Infrastructure.Tests

🔧 src/Aspire.Cli/Templating/Templates/go-starter/api/go.mod (changed source)
→ 1 via the project graph: Aspire.Hosting.CodeGeneration.Go.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/GoEmptyAppHostTemplateTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/GoKubernetesDeployTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/GoStarterReadinessTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/Helpers/CliE2EAutomatorHelpers.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/Helpers/KubernetesDeployTestHelpers.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/JavaCodegenValidationTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/JavaPolyglotApphostDirectoryTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/JavaPolyglotTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/JavaScriptPublishTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/KubernetesDeployTypeScriptTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/LocalConfigMigrationTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/SecretTypeScriptAppHostTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/TypeScriptCodegenValidationTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/TypeScriptPublishTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.Tests/Commands/NewCommandTemplateConfigPersistenceTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Snapshots/NewCommandTemplateConfigPersistenceTests.GoStarterHonorsRedisChoice_choice=default.verified.go (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Snapshots/NewCommandTemplateConfigPersistenceTests.GoStarterHonorsRedisChoice_choice=false.verified.go (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Snapshots/NewCommandTemplateConfigPersistenceTests.GoStarterHonorsRedisChoice_choice=true.verified.go (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Infrastructure.Tests/TestTriggerMap/TestTriggerMapTests.cs (changed test)
→ 1 directly: Infrastructure.Tests

Job reasons

Job Triggered by
cli-starter-validation • .github/workflows/cli-starter-validation.yml, eng/scripts/cli-starter-validation.ps1
• affected project Aspire.Cli
extension-e2e • src/Aspire.Cli/Templating/CliTemplateFactory.GoStarterTemplate.cs, src/Aspire.Cli/Templating/CliTemplateFactory.cs, src/Aspire.Cli/Templating/Templates/go-starter/api/go.mod, src/Aspire.Cli/Templating/Templates/go-starter/api/go.sum, src/Aspire.Cli/Templating/Templates/go-starter/apphost.go, src/Aspire.Cli/Templating/Templates/go-starter/aspire.config.json
• affected project Aspire.Cli
polyglot • .github/workflows/polyglot-validation/test-go-playground.sh, .github/workflows/polyglot-validation/test-go.sh, tests/PolyglotAppHosts/Aspire.Hosting.EntityFrameworkCore/Go/apphost.go, tests/PolyglotAppHosts/Aspire.Hosting.EntityFrameworkCore/Go/aspire.config.json, tests/PolyglotAppHosts/Aspire.Hosting.EntityFrameworkCore/Go/go.mod, tests/PolyglotAppHosts/Aspire.Hosting.Foundry/Go/apphost.go, tests/PolyglotAppHosts/Aspire.Hosting/Go/apphost.go
• affected project Aspire.Cli
typescript-api-compat affected project Aspire.Cli

Selection computed for commit 0bb6569.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Cross-platform startup and packaged Go lifecycle changes require runtime validation unavailable in this review environment, and latest-head CI is still in progress.

No open issues 🎉

2 resolved since last review

Review effort: Balanced

@IEvangelist
David Pine (IEvangelist) merged commit 5138b2a into main Nov 6, 2026
226 checks passed
@microsoft-github-policy-service microsoft-github-policy-service Bot added this to the 17.1 milestone Nov 6, 2026
@aspire-repo-bot

Copy link
Copy Markdown
Contributor

Pull request created: #2078

Generated by PR Documentation Check · copilot · auto · 25.6 AIC · ⌖ 1.16 AIC · ⊞ 7.4K

@aspire-repo-bot

Copy link
Copy Markdown
Contributor

📝 Documentation has been drafted in microsoft/aspire.dev#2078 targeting release/17.0.

Documented --use-redis-cache for aspire-go-starter in aspire-new.mdx. Triggered signals: pr_body_has_cli_flag_mention (--use-redis-cache false), pr_body_has_user_facing_section (User-facing usage), pr_body_has_deprecation_marker (references to the obsolete SDK directive, with no docs impact).

Note

This draft PR needs human review before merging.

Mitch Denny (mitchdenny) pushed a commit that referenced this pull request Nov 10, 2026
## Description

Go starters should build from their shipped files without an initial
`aspire run` repairing dependencies, and Go preview validation should
exercise the same runtime and native-runner paths as other AppHosts.

- Ship a tidy API `go.mod` and generated `go.sum`. Add starter scenarios
checking gitignore, readonly API build, tidy stability, health and
weather responses; remove the Kubernetes manual-tidy workaround.
- Honor the existing `--use-redis-cache false` option for Go.
Omitted/true retains Redis; false omits the integration and resource.
Cover all three scaffold choices with generated-source snapshots and
both HTTP lifecycle variants with Docker E2E.
- Add `go vet` to Go polyglot fixtures, an EF Core fixture, and Foundry
tool/AKS node-pool parity. Exercise configuration-section list getters
in the real Go runtime smoke.
- Add Go to all six native starter-validation platforms, with official
checksum-verified Go installation, timeout budget, and runtime-only
selector edges for Go hosting, Go codegen, and Redis. Linux retains
API/Redis readiness; containerless Windows/macOS use the cache-free
starter with API readiness unchanged.
- Add isolated-local-feed Go/Java scaffolding and restore to the
stabilization smoke without rewriting template pins. Use a genuine
Release bundled driver outside repository mode, cold consumer caches,
and exact hosting-package extraction/provenance checks. Enable Java only
in its subprocess.
- Select languages by name rather than picker position. Restore stale
Java/TypeScript SDK baselines after `aspire add` so the following
`aspire restore` genuinely tests regeneration. Establish the TypeScript
baseline with an actual restore before reading cache metadata.
- Wait for the TypeScript Kubernetes application's actual Ready pod;
exercise the Go Helm namespace/chart-version callback.

Relates to #21202, #21206, #21209, #21210, #21201, and #21108.

### User-facing usage

```bash
# Default retains Redis.
aspire new aspire-go-starter --name GoReady --non-interactive --suppress-agent-init

# Containerless starter: the Go API runs without Redis or a Docker daemon.
aspire new aspire-go-starter --name GoReady --use-redis-cache false --non-interactive --suppress-agent-init
```

Both variants emit `api/go.sum` and an already-tidy API module. Its API
can build with `go build -mod=readonly` without first running the
AppHost's tidy resource.

### Dependencies and remaining acceptance

This PR is independent of #21823. Root-module brownfield E2E #21825
merged into the #21823 feature branch, not directly into main; its
delivery follows #21823. #21806 independently covers other Go
init/build/vet/stable-restore scenarios.

The existing stabilization gate remains disabled
(`STABILIZATION_ENABLED: 'false'`); enabling it needs a separate
CI/policy decision. Current `Aspire.Hosting.Java.csproj` still sets
`SuppressFinalPackageVersion=true` while the Java starter pins the
requested Aspire version. The corrected smoke reaches actual NuGet
restore and exposes that mismatch: `Aspire.Hosting.Java (= 17.0.0)` is
unavailable, the nearest local package is `17.0.0-dev`, and nuget.org
versions are not considered. No pin substitution or Java release-policy
change is included.

Native Linux validation built the genuine stabilized Release CLI/payload
and proved cold Go/Redis package restore and C# restore. This is **not a
clean stabilization pass**: the unsuppressed stable pack first
reproduced NU5104 on existing .NET 11 preview dependencies. The
diagnostic consumer feed downgraded only NU5104 with
`WarningsNotAsErrors=NU5104`; that exception is not committed. The final
smoke correctly exits 1 with only Java in its failure list.

The bounded shared-image fix is separate in #21849; this PR does not
modify image Dockerfiles or the image-build implementation. Its
`b8274fc8e0` image job and all four uploads passed, Infrastructure
passed 2090/2090 including all 13 new image cases, and all 116 CLI
archive E2E jobs passed. Earlier Windows extension fake-timer and DCP
Docker-startup failures were investigated with same-source passing main
controls; the morning live refresh reports its Final Results passing. It
remains independently review-gated. Do not infer actual timeout/fallback
execution from a healthy-mirror image pass.

No action SHA is added or changed. No official Azure DevOps pipeline is
modified. Parent's Go-minimum-version map rule/theory and the other
owner's extension-e2e map block are untouched. The cache option uses
existing embedded CLI inputs; no additional selector rule is required.
The stabilization script remains advisory/disabled rather than being
presented as a regular-PR gate.

This does not close #21108: live Azure Container Apps deployment and
real missing/old-toolchain E2E remain uncovered here. Cross-language
lifecycle redesigns are deferred.

### CI failures diagnosed and fixed

Original-head run
[42116644663](https://github.com/microsoft/aspire/actions/runs/42116644663)
exposed two causes:

- Windows x64/ARM64 and macOS x64/ARM64 starter validation failed
because Redis could not start: the Windows Docker engine pipe was absent
and macOS had no Docker executable. The API correctly waited on its
unhealthy dependency. Those native runners now use the supported
cache-free variant; Linux and Docker E2E retain Redis coverage. No
readiness assertion was removed.
- `TypeScriptCodegenValidationTests` read `.codegen-hash` immediately
after init, which supplies SDK sources but not restore-cache metadata.
An explicit baseline restore now precedes the snapshot and stale-cache
assertions.

**Head `1ab3ad1e30`: all six native starter lanes passed**, including
both Redis-enabled Ubuntu lanes and all four formerly failing
Windows/macOS lanes, in [run
42151619597](https://github.com/microsoft/aspire/actions/runs/42151619597).
Packaged CI subsequently passed
[GoStarterReadinessTests](https://github.com/microsoft/aspire/actions/runs/42151619597/job/127721672515)
(both cache choices),
[GoStarterTemplateTests](https://github.com/microsoft/aspire/actions/runs/42151619597/job/127721672968),
[JavaCodegenValidationTests](https://github.com/microsoft/aspire/actions/runs/42151619597/job/127721672216),
and
[TypeScriptCodegenValidationTests](https://github.com/microsoft/aspire/actions/runs/42151619597/job/127721664876).
All originally failing targeted lanes/classes therefore have passing
coverage.

The shared image job first timed out at 45 minutes twice. Attempt 2
fetched 108 MB from Azure Ubuntu in 41 minutes 29 seconds (43.4 kB/s),
versus a following GitHub download at 80.1 MB/s; GHA cache import also
returned HTTP 400 service-unavailable responses. After #21849's
same-input image control passed with all four uploads, one
evidence-based product revalidation was started. [Attempt 3's image job
passed](https://github.com/microsoft/aspire/actions/runs/42151619597/job/127718680817)
and admitted packaged E2E. No blind retries were made. The successful
infrastructure control used a healthy primary mirror; it does not
demonstrate timeout/fallback execution in that CI run.

**Head `bd30794b9e`: historical failures and final outcome are
distinct.** In [run
42167868738](https://github.com/microsoft/aspire/actions/runs/42167868738),
all six native starter lanes and Go/Java/TypeScript SDK validation
passed. The first [shared image
job](https://github.com/microsoft/aspire/actions/runs/42167868738/job/127729647462)
was canceled after 45 minutes 22 seconds with Azure Ubuntu apt downloads
still running and all four uploads skipped; the initial Linux
tree-actions attempt also failed on a stale immutable Running snapshot.
The morning live refresh subsequently shows [Final Results
passing](https://github.com/microsoft/aspire/actions/runs/42167868738/job/127754717945),
including
[GoStarterReadinessTests](https://github.com/microsoft/aspire/actions/runs/42167868738/job/127747615122).
This session did not initiate retries. A passing later attempt does not
repair the tree-actions race: its separate test-only fix #21854 still
needs independent approval/merge and incorporation before claiming the
race fixed in this checkout.

**Latest head `0bb6569d91` requires fresh checks**, now running in
[42222384609](https://github.com/microsoft/aspire/actions/runs/42222384609).
Both new review findings are corrected: SDK selection accepts only exact
numeric MAJOR.MINOR.PATCH package filenames, and Go starter startup is
inside its existing cleanup scope. Both threads were replied to and
resolved with evidence. Earlier-head CI is not presented as latest-head
proof.

Per the user's explicit authorization, the coordinator enabled normal
native **squash auto-merge** at 05:22:46Z on 2026-11-06. It remains
enabled behind required fresh checks and review requirements. No admin
bypass is authorized or used; the PR is not merged.

### Stabilization review corrections

The smoke now publishes a Release CLI with its real stabilized bundle
outside the checkout, propagates stabilization into child payload
builds, and clears inherited `ASPIRE_REPO_ROOT` for every consumer
invocation. Consumer packages are isolated after the driver build so
build-time extraction cannot hide a missing stable package. Successful
guest restores must produce metadata for the exact hosting pins,
including Redis for Go; provenance is retained in the output.

The real run also exposed two stale smoke assumptions: a pre-owned
parent feed mapping conflicts with scaffolding's project-local channel
policy, and current C# file-based templates use `#:package
Aspire.Hosting.AppHost@<version>`, not the obsolete SDK directive. The
smoke now lets the CLI establish its own authoritative project-scoped
feed mapping and checks the current hosting-package contract. No
customer NuGet policy is changed.

### Validation

- `.\restore.cmd` - passed.
- `dotnet build
tests\Aspire.Cli.EndToEnd.Tests\Aspire.Cli.EndToEnd.Tests.csproj
--no-restore --nologo -v quiet` - passed, zero warnings/errors; repeated
successfully after removing temporary fault injection for `0bb6569d91`.
- `dotnet test --project tests\Aspire.Cli.Tests\Aspire.Cli.Tests.csproj
--no-launch-profile -- --filter-class
'*.NewCommandTemplateConfigPersistenceTests' --filter-not-trait
'quarantined=true' --filter-not-trait 'outerloop=true'` - passed, 59
tests including default/true/false Go package and generated-source
assertions. Existing ILCompiler NU1903 advisory was emitted.
- With
`ASPIRE_E2E_CLI_ARCHIVE_DIR=artifacts\readiness-ci\cli-archive-new` and
`ASPIRE_E2E_DOTNET_IMAGE=aspire-e2e-polyglot-base:latest`, `dotnet test
--project
tests\Aspire.Cli.EndToEnd.Tests\Aspire.Cli.EndToEnd.Tests.csproj
--no-launch-profile -- --filter-method
'*.RestoreGeneratesSdkFiles_WithConfiguredToolchain' --filter-not-trait
'quarantined=true' --filter-not-trait 'outerloop=true'` - passed, all
four npm/bun/yarn/pnpm cases against exact `1ab3ad1e30` Linux
CLI/packages. The corresponding packaged CI class also passed above.
- With
`ASPIRE_E2E_CLI_ARCHIVE_DIR=artifacts\readiness-ci\cli-archive-new` and
`ASPIRE_E2E_POLYGLOT_GO_IMAGE=aspire-go-e2e-6972:latest`, `dotnet test
--project
tests\Aspire.Cli.EndToEnd.Tests\Aspire.Cli.EndToEnd.Tests.csproj
--no-launch-profile -- --filter-method
'*.StarterShipsTidyApiAndServesRequests' --filter-not-trait
'quarantined=true' --filter-not-trait 'outerloop=true'` - 1 passed/1
failed locally against exact `1ab3ad1e30`. Cache-free passed actual
scaffolding, readonly API build, tidy check, API-up, health/weather and
stop without a Docker socket. Redis timed out locally. The unchanged
`2859e199e2` control reproduced the same timeout on this Docker Desktop
host; no workaround or weaker assertion was added. **Both cases
subsequently passed packaged CI**, linked above. After the cleanup-scope
correction, this local command again passed cache-free and failed Redis
on API readiness; the independent CLI stop log confirmed successful
shutdown, while the shared terminal helper observed the prior ERR
prompt. That local run is not claimed green.
- Temporary fault-injection validation used that same E2E command with
only the cache-free case and a shell wrapper returning HTTP 503 for the
Dashboard probe after a real packaged AppHost launch - intentionally
failed. Terminal output showed `dashboard-http-failed`, then cleanup
invocation; the CLI log confirmed `apphost.go stopped successfully` and
exit 0. The wrapper and temporary test edit were removed before the
final clean build/commit. This verifies partial-start cleanup, not a
successful readiness scenario.
- `docker run --rm --entrypoint bash -v "${PWD}:/workspace:ro"
aspire-go-e2e-6972:latest -c "sed 's/\r$//'
/workspace/artifacts/readiness-ci/validate-stable-sdk-selection.sh |
bash"` - passed actual smoke-script preflight cases for missing SDK,
prerelease-only, mixed
stable/dev/preview/rc/build-metadata/four-component filenames,
multi-digit stable versions, and feed paths with spaces. The
instrumented driver received `BundleVersion=17.0.0` from the mixed feed.
Invalid-only feeds exited 1 with the explicit missing-stable diagnostic.
Temporary harness removed after retaining logs; not a new all-language
stabilization pass.
- `dotnet test --project
tests\Infrastructure.Tests\Infrastructure.Tests.csproj
--no-launch-profile -- --filter-class '*.TestTriggerMapTests'
--filter-not-trait 'quarantined=true' --filter-not-trait
'outerloop=true'` - passed, 176 tests.
- `dotnet run --project tools\SelectTests -- --changed-files
artifacts\readiness-changed-files.txt --explain` - passed against the
real graph/map; Go hosting/codegen, Redis, starter checksum and EF Core
fixture inputs select starter-validation/polyglot with zero unattributed
files. Schedule-only deployment remains advisory.
- `$env:DOTNET_ROOT = Join-Path $PWD '.dotnet'; $env:ASPIRE_REPO_ROOT =
$PWD; .\artifacts\bin\Aspire.Cli\Debug\net11.0\aspire.exe restore
--apphost tests\PolyglotAppHosts\<integration>\Go\apphost.go
--non-interactive` - passed separately for
`Aspire.Hosting.EntityFrameworkCore`, `Aspire.Hosting.Foundry`, and
`Aspire.Hosting`, generating actual SDK bindings.
- `docker run --rm --entrypoint bash -v "${PWD}:/workspace"
aspire-go-e2e-6972:latest -c 'set -e; for fixture in
Aspire.Hosting.EntityFrameworkCore Aspire.Hosting.Foundry
Aspire.Hosting; do cd "/workspace/tests/PolyglotAppHosts/$fixture/Go";
gofmt -w apphost.go; go build -buildvcs=false -o /tmp/fixture ./...; go
vet ./...; done'` - passed for all three fixtures.
- `docker run --rm --entrypoint bash -v "${PWD}:/workspace:ro"
aspire-go-e2e-6972:latest -c 'set -e; bash -n
/workspace/.github/workflows/polyglot-validation/test-go.sh
/workspace/.github/workflows/polyglot-validation/test-go-playground.sh
/workspace/eng/scripts/stabilization-smoke-init-restore.sh;
work=$(mktemp -d); trap "rm -rf $work" EXIT; cp
/workspace/src/Aspire.Cli/Templating/Templates/go-starter/api/*
"$work/"; cd "$work"; sed -i "s/{{projectNameLower}}/starter/g" go.mod;
go build -mod=readonly -o /tmp/go-ready-api .; go mod tidy -diff; go vet
./...'` - passed without a dependency-repair command.
- Native Linux `./restore.sh -p:SkipTestProjects=true
-p:SkipPlaygroundProjects=true` - passed with the pinned SDK.
- Native Linux `./dotnet.sh pack
src/Aspire.Hosting.AppHost/Aspire.Hosting.AppHost.csproj -c Release
-p:StabilizePackageVersion=true -p:SkipNativeBuild=true --nologo -v
quiet` - failed as expected on existing NU5104 preview dependencies; not
counted as a stabilization pass.
- To isolate consumer behavior, the diagnostic feed used `for project in
Aspire.Hosting Aspire.Hosting.AppHost Aspire.Hosting.Dotnet
Aspire.TypeSystem Aspire.Hosting.CodeGeneration.Go
Aspire.Hosting.CodeGeneration.Java Aspire.Hosting.Go
Aspire.Hosting.Redis Aspire.Hosting.Java Aspire.Hosting.JavaScript
Aspire.AppHost.Sdk Aspire.ProjectTemplates; do ./dotnet.sh pack
"src/$project/$project.csproj" -c Release
-p:StabilizePackageVersion=true -p:SkipNativeBuild=true
-p:WarningsNotAsErrors=NU5104 --nologo -v quiet; done` - passed. No
suppression is committed; Java remains `17.0.0-dev` by existing policy.
- Native Linux `STABILIZATION_SMOKE_CONFIGURATION=Release
ASPIRE_REPO_ROOT=/work/source bash
eng/scripts/stabilization-smoke-init-restore.sh` - built the genuine
stabilized Release driver/payload and completed the consumer flow.
**Exit 1 is the expected Java policy failure, not an all-language
pass.** Go/Redis `17.0.0` metadata names
`/work/source/artifacts/packages/Release/Shipping`; C# `17.0.0`
restored; Java reached real NuGet restore and rejected its absent stable
pin with no nuget.org fallback. Output assertions confirmed the final
failure list is exactly `java`. Sources were `1ab3ad1e30` plus the final
smoke correction; no mixed PR-stamped CLI was used.
- `bash -n eng/scripts/stabilization-smoke-init-restore.sh`, PowerShell
parser validation of `eng\scripts\cli-starter-validation.ps1`, and `git
diff --check` - passed.
- Full `Infrastructure.Tests.TestTriggerMap` namespace was not passed on
this Windows host: WSL's `bash.exe` cannot find `/bin/bash`; a narrowed
run also encountered readonly `.git` cleanup failures. Not counted as
successful validation.

## Checklist

- Is this feature complete?
  - [ ] Yes. Ready to ship.
  - [x] No. Follow-up changes expected.
- Are you including unit tests for the changes and scenario tests if
relevant?
  - [x] Yes
  - [ ] No
- Did you add public API?
  - [ ] Yes
    - If yes, did you have an API Review for it?
      - [ ] Yes
      - [ ] No
- Did you add `<remarks />` and `<code />` elements on your triple slash
comments?
      - [ ] Yes
      - [ ] No
  - [x] No
- Does the change make any security assumptions or guarantees?
  - [ ] Yes
    - If yes, have you done a threat model and had a security review?
      - [ ] Yes
      - [ ] No
  - [x] No

---------

Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
(cherry picked from commit 5138b2a)
Mitch Denny (mitchdenny) pushed a commit that referenced this pull request Nov 10, 2026
## Description

Go starters should build from their shipped files without an initial
`aspire run` repairing dependencies, and Go preview validation should
exercise the same runtime and native-runner paths as other AppHosts.

- Ship a tidy API `go.mod` and generated `go.sum`. Add starter scenarios
checking gitignore, readonly API build, tidy stability, health and
weather responses; remove the Kubernetes manual-tidy workaround.
- Honor the existing `--use-redis-cache false` option for Go.
Omitted/true retains Redis; false omits the integration and resource.
Cover all three scaffold choices with generated-source snapshots and
both HTTP lifecycle variants with Docker E2E.
- Add `go vet` to Go polyglot fixtures, an EF Core fixture, and Foundry
tool/AKS node-pool parity. Exercise configuration-section list getters
in the real Go runtime smoke.
- Add Go to all six native starter-validation platforms, with official
checksum-verified Go installation, timeout budget, and runtime-only
selector edges for Go hosting, Go codegen, and Redis. Linux retains
API/Redis readiness; containerless Windows/macOS use the cache-free
starter with API readiness unchanged.
- Add isolated-local-feed Go/Java scaffolding and restore to the
stabilization smoke without rewriting template pins. Use a genuine
Release bundled driver outside repository mode, cold consumer caches,
and exact hosting-package extraction/provenance checks. Enable Java only
in its subprocess.
- Select languages by name rather than picker position. Restore stale
Java/TypeScript SDK baselines after `aspire add` so the following
`aspire restore` genuinely tests regeneration. Establish the TypeScript
baseline with an actual restore before reading cache metadata.
- Wait for the TypeScript Kubernetes application's actual Ready pod;
exercise the Go Helm namespace/chart-version callback.

Relates to #21202, #21206, #21209, #21210, #21201, and #21108.

### User-facing usage

```bash
# Default retains Redis.
aspire new aspire-go-starter --name GoReady --non-interactive --suppress-agent-init

# Containerless starter: the Go API runs without Redis or a Docker daemon.
aspire new aspire-go-starter --name GoReady --use-redis-cache false --non-interactive --suppress-agent-init
```

Both variants emit `api/go.sum` and an already-tidy API module. Its API
can build with `go build -mod=readonly` without first running the
AppHost's tidy resource.

### Dependencies and remaining acceptance

This PR is independent of #21823. Root-module brownfield E2E #21825
merged into the #21823 feature branch, not directly into main; its
delivery follows #21823. #21806 independently covers other Go
init/build/vet/stable-restore scenarios.

The existing stabilization gate remains disabled
(`STABILIZATION_ENABLED: 'false'`); enabling it needs a separate
CI/policy decision. Current `Aspire.Hosting.Java.csproj` still sets
`SuppressFinalPackageVersion=true` while the Java starter pins the
requested Aspire version. The corrected smoke reaches actual NuGet
restore and exposes that mismatch: `Aspire.Hosting.Java (= 17.0.0)` is
unavailable, the nearest local package is `17.0.0-dev`, and nuget.org
versions are not considered. No pin substitution or Java release-policy
change is included.

Native Linux validation built the genuine stabilized Release CLI/payload
and proved cold Go/Redis package restore and C# restore. This is **not a
clean stabilization pass**: the unsuppressed stable pack first
reproduced NU5104 on existing .NET 11 preview dependencies. The
diagnostic consumer feed downgraded only NU5104 with
`WarningsNotAsErrors=NU5104`; that exception is not committed. The final
smoke correctly exits 1 with only Java in its failure list.

The bounded shared-image fix is separate in #21849; this PR does not
modify image Dockerfiles or the image-build implementation. Its
`b8274fc8e0` image job and all four uploads passed, Infrastructure
passed 2090/2090 including all 13 new image cases, and all 116 CLI
archive E2E jobs passed. Earlier Windows extension fake-timer and DCP
Docker-startup failures were investigated with same-source passing main
controls; the morning live refresh reports its Final Results passing. It
remains independently review-gated. Do not infer actual timeout/fallback
execution from a healthy-mirror image pass.

No action SHA is added or changed. No official Azure DevOps pipeline is
modified. Parent's Go-minimum-version map rule/theory and the other
owner's extension-e2e map block are untouched. The cache option uses
existing embedded CLI inputs; no additional selector rule is required.
The stabilization script remains advisory/disabled rather than being
presented as a regular-PR gate.

This does not close #21108: live Azure Container Apps deployment and
real missing/old-toolchain E2E remain uncovered here. Cross-language
lifecycle redesigns are deferred.

### CI failures diagnosed and fixed

Original-head run
[42116644663](https://github.com/microsoft/aspire/actions/runs/42116644663)
exposed two causes:

- Windows x64/ARM64 and macOS x64/ARM64 starter validation failed
because Redis could not start: the Windows Docker engine pipe was absent
and macOS had no Docker executable. The API correctly waited on its
unhealthy dependency. Those native runners now use the supported
cache-free variant; Linux and Docker E2E retain Redis coverage. No
readiness assertion was removed.
- `TypeScriptCodegenValidationTests` read `.codegen-hash` immediately
after init, which supplies SDK sources but not restore-cache metadata.
An explicit baseline restore now precedes the snapshot and stale-cache
assertions.

**Head `1ab3ad1e30`: all six native starter lanes passed**, including
both Redis-enabled Ubuntu lanes and all four formerly failing
Windows/macOS lanes, in [run
42151619597](https://github.com/microsoft/aspire/actions/runs/42151619597).
Packaged CI subsequently passed
[GoStarterReadinessTests](https://github.com/microsoft/aspire/actions/runs/42151619597/job/127721672515)
(both cache choices),
[GoStarterTemplateTests](https://github.com/microsoft/aspire/actions/runs/42151619597/job/127721672968),
[JavaCodegenValidationTests](https://github.com/microsoft/aspire/actions/runs/42151619597/job/127721672216),
and
[TypeScriptCodegenValidationTests](https://github.com/microsoft/aspire/actions/runs/42151619597/job/127721664876).
All originally failing targeted lanes/classes therefore have passing
coverage.

The shared image job first timed out at 45 minutes twice. Attempt 2
fetched 108 MB from Azure Ubuntu in 41 minutes 29 seconds (43.4 kB/s),
versus a following GitHub download at 80.1 MB/s; GHA cache import also
returned HTTP 400 service-unavailable responses. After #21849's
same-input image control passed with all four uploads, one
evidence-based product revalidation was started. [Attempt 3's image job
passed](https://github.com/microsoft/aspire/actions/runs/42151619597/job/127718680817)
and admitted packaged E2E. No blind retries were made. The successful
infrastructure control used a healthy primary mirror; it does not
demonstrate timeout/fallback execution in that CI run.

**Head `bd30794b9e`: historical failures and final outcome are
distinct.** In [run
42167868738](https://github.com/microsoft/aspire/actions/runs/42167868738),
all six native starter lanes and Go/Java/TypeScript SDK validation
passed. The first [shared image
job](https://github.com/microsoft/aspire/actions/runs/42167868738/job/127729647462)
was canceled after 45 minutes 22 seconds with Azure Ubuntu apt downloads
still running and all four uploads skipped; the initial Linux
tree-actions attempt also failed on a stale immutable Running snapshot.
The morning live refresh subsequently shows [Final Results
passing](https://github.com/microsoft/aspire/actions/runs/42167868738/job/127754717945),
including
[GoStarterReadinessTests](https://github.com/microsoft/aspire/actions/runs/42167868738/job/127747615122).
This session did not initiate retries. A passing later attempt does not
repair the tree-actions race: its separate test-only fix #21854 still
needs independent approval/merge and incorporation before claiming the
race fixed in this checkout.

**Latest head `0bb6569d91` requires fresh checks**, now running in
[42222384609](https://github.com/microsoft/aspire/actions/runs/42222384609).
Both new review findings are corrected: SDK selection accepts only exact
numeric MAJOR.MINOR.PATCH package filenames, and Go starter startup is
inside its existing cleanup scope. Both threads were replied to and
resolved with evidence. Earlier-head CI is not presented as latest-head
proof.

Per the user's explicit authorization, the coordinator enabled normal
native **squash auto-merge** at 05:22:46Z on 2026-11-06. It remains
enabled behind required fresh checks and review requirements. No admin
bypass is authorized or used; the PR is not merged.

### Stabilization review corrections

The smoke now publishes a Release CLI with its real stabilized bundle
outside the checkout, propagates stabilization into child payload
builds, and clears inherited `ASPIRE_REPO_ROOT` for every consumer
invocation. Consumer packages are isolated after the driver build so
build-time extraction cannot hide a missing stable package. Successful
guest restores must produce metadata for the exact hosting pins,
including Redis for Go; provenance is retained in the output.

The real run also exposed two stale smoke assumptions: a pre-owned
parent feed mapping conflicts with scaffolding's project-local channel
policy, and current C# file-based templates use `#:package
Aspire.Hosting.AppHost@<version>`, not the obsolete SDK directive. The
smoke now lets the CLI establish its own authoritative project-scoped
feed mapping and checks the current hosting-package contract. No
customer NuGet policy is changed.

### Validation

- `.\restore.cmd` - passed.
- `dotnet build
tests\Aspire.Cli.EndToEnd.Tests\Aspire.Cli.EndToEnd.Tests.csproj
--no-restore --nologo -v quiet` - passed, zero warnings/errors; repeated
successfully after removing temporary fault injection for `0bb6569d91`.
- `dotnet test --project tests\Aspire.Cli.Tests\Aspire.Cli.Tests.csproj
--no-launch-profile -- --filter-class
'*.NewCommandTemplateConfigPersistenceTests' --filter-not-trait
'quarantined=true' --filter-not-trait 'outerloop=true'` - passed, 59
tests including default/true/false Go package and generated-source
assertions. Existing ILCompiler NU1903 advisory was emitted.
- With
`ASPIRE_E2E_CLI_ARCHIVE_DIR=artifacts\readiness-ci\cli-archive-new` and
`ASPIRE_E2E_DOTNET_IMAGE=aspire-e2e-polyglot-base:latest`, `dotnet test
--project
tests\Aspire.Cli.EndToEnd.Tests\Aspire.Cli.EndToEnd.Tests.csproj
--no-launch-profile -- --filter-method
'*.RestoreGeneratesSdkFiles_WithConfiguredToolchain' --filter-not-trait
'quarantined=true' --filter-not-trait 'outerloop=true'` - passed, all
four npm/bun/yarn/pnpm cases against exact `1ab3ad1e30` Linux
CLI/packages. The corresponding packaged CI class also passed above.
- With
`ASPIRE_E2E_CLI_ARCHIVE_DIR=artifacts\readiness-ci\cli-archive-new` and
`ASPIRE_E2E_POLYGLOT_GO_IMAGE=aspire-go-e2e-6972:latest`, `dotnet test
--project
tests\Aspire.Cli.EndToEnd.Tests\Aspire.Cli.EndToEnd.Tests.csproj
--no-launch-profile -- --filter-method
'*.StarterShipsTidyApiAndServesRequests' --filter-not-trait
'quarantined=true' --filter-not-trait 'outerloop=true'` - 1 passed/1
failed locally against exact `1ab3ad1e30`. Cache-free passed actual
scaffolding, readonly API build, tidy check, API-up, health/weather and
stop without a Docker socket. Redis timed out locally. The unchanged
`2859e199e2` control reproduced the same timeout on this Docker Desktop
host; no workaround or weaker assertion was added. **Both cases
subsequently passed packaged CI**, linked above. After the cleanup-scope
correction, this local command again passed cache-free and failed Redis
on API readiness; the independent CLI stop log confirmed successful
shutdown, while the shared terminal helper observed the prior ERR
prompt. That local run is not claimed green.
- Temporary fault-injection validation used that same E2E command with
only the cache-free case and a shell wrapper returning HTTP 503 for the
Dashboard probe after a real packaged AppHost launch - intentionally
failed. Terminal output showed `dashboard-http-failed`, then cleanup
invocation; the CLI log confirmed `apphost.go stopped successfully` and
exit 0. The wrapper and temporary test edit were removed before the
final clean build/commit. This verifies partial-start cleanup, not a
successful readiness scenario.
- `docker run --rm --entrypoint bash -v "${PWD}:/workspace:ro"
aspire-go-e2e-6972:latest -c "sed 's/\r$//'
/workspace/artifacts/readiness-ci/validate-stable-sdk-selection.sh |
bash"` - passed actual smoke-script preflight cases for missing SDK,
prerelease-only, mixed
stable/dev/preview/rc/build-metadata/four-component filenames,
multi-digit stable versions, and feed paths with spaces. The
instrumented driver received `BundleVersion=17.0.0` from the mixed feed.
Invalid-only feeds exited 1 with the explicit missing-stable diagnostic.
Temporary harness removed after retaining logs; not a new all-language
stabilization pass.
- `dotnet test --project
tests\Infrastructure.Tests\Infrastructure.Tests.csproj
--no-launch-profile -- --filter-class '*.TestTriggerMapTests'
--filter-not-trait 'quarantined=true' --filter-not-trait
'outerloop=true'` - passed, 176 tests.
- `dotnet run --project tools\SelectTests -- --changed-files
artifacts\readiness-changed-files.txt --explain` - passed against the
real graph/map; Go hosting/codegen, Redis, starter checksum and EF Core
fixture inputs select starter-validation/polyglot with zero unattributed
files. Schedule-only deployment remains advisory.
- `$env:DOTNET_ROOT = Join-Path $PWD '.dotnet'; $env:ASPIRE_REPO_ROOT =
$PWD; .\artifacts\bin\Aspire.Cli\Debug\net11.0\aspire.exe restore
--apphost tests\PolyglotAppHosts\<integration>\Go\apphost.go
--non-interactive` - passed separately for
`Aspire.Hosting.EntityFrameworkCore`, `Aspire.Hosting.Foundry`, and
`Aspire.Hosting`, generating actual SDK bindings.
- `docker run --rm --entrypoint bash -v "${PWD}:/workspace"
aspire-go-e2e-6972:latest -c 'set -e; for fixture in
Aspire.Hosting.EntityFrameworkCore Aspire.Hosting.Foundry
Aspire.Hosting; do cd "/workspace/tests/PolyglotAppHosts/$fixture/Go";
gofmt -w apphost.go; go build -buildvcs=false -o /tmp/fixture ./...; go
vet ./...; done'` - passed for all three fixtures.
- `docker run --rm --entrypoint bash -v "${PWD}:/workspace:ro"
aspire-go-e2e-6972:latest -c 'set -e; bash -n
/workspace/.github/workflows/polyglot-validation/test-go.sh
/workspace/.github/workflows/polyglot-validation/test-go-playground.sh
/workspace/eng/scripts/stabilization-smoke-init-restore.sh;
work=$(mktemp -d); trap "rm -rf $work" EXIT; cp
/workspace/src/Aspire.Cli/Templating/Templates/go-starter/api/*
"$work/"; cd "$work"; sed -i "s/{{projectNameLower}}/starter/g" go.mod;
go build -mod=readonly -o /tmp/go-ready-api .; go mod tidy -diff; go vet
./...'` - passed without a dependency-repair command.
- Native Linux `./restore.sh -p:SkipTestProjects=true
-p:SkipPlaygroundProjects=true` - passed with the pinned SDK.
- Native Linux `./dotnet.sh pack
src/Aspire.Hosting.AppHost/Aspire.Hosting.AppHost.csproj -c Release
-p:StabilizePackageVersion=true -p:SkipNativeBuild=true --nologo -v
quiet` - failed as expected on existing NU5104 preview dependencies; not
counted as a stabilization pass.
- To isolate consumer behavior, the diagnostic feed used `for project in
Aspire.Hosting Aspire.Hosting.AppHost Aspire.Hosting.Dotnet
Aspire.TypeSystem Aspire.Hosting.CodeGeneration.Go
Aspire.Hosting.CodeGeneration.Java Aspire.Hosting.Go
Aspire.Hosting.Redis Aspire.Hosting.Java Aspire.Hosting.JavaScript
Aspire.AppHost.Sdk Aspire.ProjectTemplates; do ./dotnet.sh pack
"src/$project/$project.csproj" -c Release
-p:StabilizePackageVersion=true -p:SkipNativeBuild=true
-p:WarningsNotAsErrors=NU5104 --nologo -v quiet; done` - passed. No
suppression is committed; Java remains `17.0.0-dev` by existing policy.
- Native Linux `STABILIZATION_SMOKE_CONFIGURATION=Release
ASPIRE_REPO_ROOT=/work/source bash
eng/scripts/stabilization-smoke-init-restore.sh` - built the genuine
stabilized Release driver/payload and completed the consumer flow.
**Exit 1 is the expected Java policy failure, not an all-language
pass.** Go/Redis `17.0.0` metadata names
`/work/source/artifacts/packages/Release/Shipping`; C# `17.0.0`
restored; Java reached real NuGet restore and rejected its absent stable
pin with no nuget.org fallback. Output assertions confirmed the final
failure list is exactly `java`. Sources were `1ab3ad1e30` plus the final
smoke correction; no mixed PR-stamped CLI was used.
- `bash -n eng/scripts/stabilization-smoke-init-restore.sh`, PowerShell
parser validation of `eng\scripts\cli-starter-validation.ps1`, and `git
diff --check` - passed.
- Full `Infrastructure.Tests.TestTriggerMap` namespace was not passed on
this Windows host: WSL's `bash.exe` cannot find `/bin/bash`; a narrowed
run also encountered readonly `.git` cleanup failures. Not counted as
successful validation.

## Checklist

- Is this feature complete?
  - [ ] Yes. Ready to ship.
  - [x] No. Follow-up changes expected.
- Are you including unit tests for the changes and scenario tests if
relevant?
  - [x] Yes
  - [ ] No
- Did you add public API?
  - [ ] Yes
    - If yes, did you have an API Review for it?
      - [ ] Yes
      - [ ] No
- Did you add `<remarks />` and `<code />` elements on your triple slash
comments?
      - [ ] Yes
      - [ ] No
  - [x] No
- Does the change make any security assumptions or guarantees?
  - [ ] Yes
    - If yes, have you done a threat model and had a security review?
      - [ ] Yes
      - [ ] No
  - [x] No

---------

Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
(cherry picked from commit 5138b2a)
@IEvangelist

Copy link
Copy Markdown
Member Author

/backport to release/17.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/17.0 (link to workflow run)

Jose Perez Rodriguez (joperezr) pushed a commit that referenced this pull request Nov 11, 2026
…eadiness (#22104)

Backport of #21828 to release/17.0

/cc @IEvangelist

## Description

Standalone backport of Go starter validation and polyglot scenario
readiness. Targets `release/17.0` directly; the old chained backport
#22007 is left untouched.

Relates to #21202, #21206, #21209, #21210, #21201, and #21108. Does not
close their remaining work.

## Checklist

- Is this feature complete?
  - [x] Yes. Ready to ship.
  - [ ] No. Follow-up changes expected.
- Are you including unit tests for the changes and scenario tests if
relevant?
  - [x] Yes
  - [ ] No
- Did you add public API?
  - [ ] Yes
    - If yes, did you have an API Review for it?
      - [ ] Yes
      - [ ] No
- Did you add `<remarks />` and `<code />` elements on your triple slash
comments?
      - [ ] Yes
      - [ ] No
  - [x] No
- Does the change make any security assumptions or guarantees?
  - [ ] Yes
    - If yes, have you done a threat model and had a security review?
      - [ ] Yes
      - [ ] No
  - [x] No

## Customer Impact

Go starters ship tidy API dependencies without requiring the first run
to repair them, honor Redis exclusion, and gain native starter and
polyglot scenario coverage. Cache-free starters can run without a Docker
daemon.

## Testing

Backport verification: the aggregate diff has the same stable patch ID
as merged source commit `5138b2a86ab20b3834b01983382a8b478d6b6a39`:
`654ff923aac88d60791888affc4885c77b0c09c6`. The PR targets
`release/17.0` directly and has no native stack membership.

Source-PR validation, not rerun locally on this backport:

```powershell
dotnet test --project tests\Aspire.Cli.Tests\Aspire.Cli.Tests.csproj --no-launch-profile -- --filter-class '*.NewCommandTemplateConfigPersistenceTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'
```

Passed: 59 tests, including default/true/false Redis scaffold choices.
Source [packaged
CI](https://github.com/microsoft/aspire/actions/runs/42151619597) passed
both Redis choices in GoStarterReadinessTests and all six native starter
lanes. The source local Redis readiness run timed out; only the
cache-free local case passed, so local Redis validation is not claimed
green.

No local release-branch tests were rerun. Release-branch CI was pending
when this section was written; this is not a claim that backport CI has
passed.

## Risk

Medium. Changes starter scaffolding and shared CI/scenario validation,
including runtime-only test-selection edges and stabilization smoke
coverage.

## Regression?

Unknown. The source PR does not identify a regressing release.

---------

Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Go AppHost preview] CLI end-to-end and publish/deploy coverage

3 participants