Repository navigation
Conversation
Contributor
Author
Stack LinksThis PR is part of a local stacked series:
This comment was autogenerated by stax |
Contributor
|
✅ DCO Check Passed Thanks @geoHeil, all your commits are properly signed off. 🎉 |
Contributor
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
geoHeil
commented
Oct 4, 2026
geoHeil
force-pushed
the
2026-10-04-docs/review-guardrails
branch
from
October 4, 2026 07:31
bd32091 to
0969034
Compare
This was referenced Oct 4, 2026
PeterStaar-IBM
force-pushed
the
2026-10-04-docs/review-guardrails
branch
from
October 5, 2026 06:07
4107df4 to
9ca5f9f
Compare
geoHeil
force-pushed
the
2026-10-04-docs/review-guardrails
branch
from
October 5, 2026 07:39
9ca5f9f to
d46a609
Compare
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
geoHeil
force-pushed
the
2026-10-04-docs/review-guardrails
branch
from
October 5, 2026 10:42
d46a609 to
9fc55ce
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewers now have one set of review steps with explicit evidence and exit criteria. It covers the exact PR commit, prior findings, source content, document-tree ownership and order, exports, meaningful regression tests, severity, and validation limits. The same steps are available to human and agent reviewers.
The guidance uses 50 recent PRs with submitted reviews by users listed in MAINTAINERS.md. The sample contains 61 reviews and runs from #4551 to #4411, ordered by PR creation date. The research informed the review steps. The PR keeps that research history here; shipped guidance contains only the durable review principles. Short LGTM reviews show acceptance; they do not prove a specific rule was checked.
Sutura supplied the small task-router and skill-discovery pattern. A Python check rejects missing skill files, unrouted contributor skills, and incorrect Codex/Claude links. It runs through existing hooks and CI. Skill-only paths now trigger CI, including the lint hook. The check proves routing and link integrity; reviewers still assess behavior and test quality. Package usage skills remain separate.
Validation: 7 route tests and 8 existing PR fast-check tests pass.
make validate, the route check, Ruff, scoped ty, and workflow path-selection checks pass. Fullmake checkstops at the existing 1000-line check for 11 unchanged files. Its earlier Ruff, ty, Tach, and module-coverage steps pass. Dprint and lock checks pass separately. No conversion outputs changed.Depends on #4552. #4554 adds the ty upgrade above this PR.