Skip to content

chore(review): add evidence-based review steps and skill route gate - #4553

Closed
geoHeil wants to merge 17 commits into
mainfrom
2026-10-04-docs/review-guardrails
Closed

geoHeil wants to merge 17 commits into
mainfrom
2026-10-04-docs/review-guardrails

Conversation

@geoHeil

@geoHeil geoHeil commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Reviewers now have one set of review steps with explicit evidence and exit criteria. It covers the exact PR commit, prior findings, source content, document-tree ownership and order, exports, meaningful regression tests, severity, and validation limits. The same steps are available to human and agent reviewers.

The guidance uses 50 recent PRs with submitted reviews by users listed in MAINTAINERS.md. The sample contains 61 reviews and runs from #4551 to #4411, ordered by PR creation date. The research informed the review steps. The PR keeps that research history here; shipped guidance contains only the durable review principles. Short LGTM reviews show acceptance; they do not prove a specific rule was checked.

Sutura supplied the small task-router and skill-discovery pattern. A Python check rejects missing skill files, unrouted contributor skills, and incorrect Codex/Claude links. It runs through existing hooks and CI. Skill-only paths now trigger CI, including the lint hook. The check proves routing and link integrity; reviewers still assess behavior and test quality. Package usage skills remain separate.

Validation: 7 route tests and 8 existing PR fast-check tests pass. make validate, the route check, Ruff, scoped ty, and workflow path-selection checks pass. Full make check stops at the existing 1000-line check for 11 unchanged files. Its earlier Ruff, ty, Tach, and module-coverage steps pass. Dprint and lock checks pass separately. No conversion outputs changed.

Depends on #4552. #4554 adds the ty upgrade above this PR.

@geoHeil

geoHeil commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor Author

@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

✅ DCO Check Passed

Thanks @geoHeil, all your commits are properly signed off. 🎉

@geoHeil
geoHeil marked this pull request as ready for review October 4, 2026 07:22
@geoHeil
geoHeil added this pull request to stack #4555 October 4, 2026 07:26
@mergify

mergify Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 Merge protection satisfied — ready to merge.

Show 1 satisfied protection

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

Comment thread .agents/skills/review/references/review-evidence.md Outdated
geoHeil added 12 commits October 5, 2026 12:42
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
@geoHeil
geoHeil force-pushed the 2026-10-04-docs/review-guardrails branch from d46a609 to 9fc55ce Compare October 5, 2026 10:42
@geoHeil

geoHeil commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #4580. This PR carried downstream stack commits and showed 176 files. #4580 contains only the review guardrails on current main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant