Skip to content

chore(types): mark method overrides explicitly - #4556

Merged
PeterStaar-IBM merged 1 commit into
2026-10-04-docs/review-guardrailsfrom
2026-10-04-fix/explicit-overrides
Oct 5, 2026
Merged

PeterStaar-IBM merged 1 commit into
2026-10-04-docs/review-guardrailsfrom
2026-10-04-fix/explicit-overrides

Conversation

@geoHeil

@geoHeil geoHeil commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Docling overrides inherited methods without explicit @override markers. New ty reports 300 warnings for these methods.

Add the markers with typing_extensions.override across 91 files. Method bodies, annotations, and existing imports are unchanged, apart from import consolidation. This PR forms the first type cleanup layer below the ty upgrade.

Validation: Ruff lint and format pass. An AST and import comparison confirms that the change adds only override metadata. The existing ty 0.0.33 check passes. New ty reports no remaining missing-override warnings; the later cleanup PRs address the other diagnostics.

@geoHeil

geoHeil commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor Author

@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

✅ DCO Check Passed

Thanks @geoHeil, all your commits are properly signed off. 🎉

Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
@geoHeil
geoHeil force-pushed the 2026-10-04-fix/explicit-overrides branch from f4be1a0 to 47e581b Compare October 4, 2026 09:30
@codecov

codecov Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

@geoHeil
geoHeil added this pull request to stack #4562 October 4, 2026 10:29
@PeterStaar-IBM
PeterStaar-IBM merged commit 30bf998 into 2026-10-04-docs/review-guardrails Oct 5, 2026
26 checks passed
@PeterStaar-IBM
PeterStaar-IBM deleted the 2026-10-04-fix/explicit-overrides branch October 5, 2026 04:56
PeterStaar-IBM pushed a commit that referenced this pull request Oct 5, 2026
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants