Repository navigation
chore(types): mark method overrides explicitly - #4556
Merged
PeterStaar-IBM merged 1 commit intoOct 5, 2026
Merged
PeterStaar-IBM merged 1 commit into
PeterStaar-IBM merged 1 commit into
Conversation
This was referenced Oct 4, 2026
Contributor
Author
Stack LinksThis PR is part of a local stacked series:
This comment was autogenerated by stax |
Contributor
|
✅ DCO Check Passed Thanks @geoHeil, all your commits are properly signed off. 🎉 |
This was referenced Oct 4, 2026
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
geoHeil
force-pushed
the
2026-10-04-fix/explicit-overrides
branch
from
October 4, 2026 09:30
f4be1a0 to
47e581b
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
PeterStaar-IBM
merged commit Oct 5, 2026
30bf998
into
2026-10-04-docs/review-guardrails
26 checks passed
PeterStaar-IBM
pushed a commit
that referenced
this pull request
Oct 5, 2026
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docling overrides inherited methods without explicit
@overridemarkers. New ty reports 300 warnings for these methods.Add the markers with
typing_extensions.overrideacross 91 files. Method bodies, annotations, and existing imports are unchanged, apart from import consolidation. This PR forms the first type cleanup layer below the ty upgrade.Validation: Ruff lint and format pass. An AST and import comparison confirms that the change adds only override metadata. The existing ty 0.0.33 check passes. New ty reports no remaining missing-override warnings; the later cleanup PRs address the other diagnostics.