Repository navigation
fix(backends): make parsed data and model contracts explicit - #4557
Merged
PeterStaar-IBM merged 3 commits intoOct 5, 2026
Merged
PeterStaar-IBM merged 3 commits into
PeterStaar-IBM merged 3 commits into
Conversation
This was referenced Oct 4, 2026
Contributor
Author
Stack LinksThis PR is part of a local stacked series:
This comment was autogenerated by stax |
Contributor
|
✅ DCO Check Passed Thanks @geoHeil, all your commits are properly signed off. 🎉 |
This was referenced Oct 4, 2026
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
geoHeil
force-pushed
the
2026-10-04-fix/python-type-contracts
branch
from
October 4, 2026 09:30
31c74b9 to
bd9060c
Compare
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
PeterStaar-IBM
merged commit Oct 5, 2026
e4e4d5e
into
2026-10-04-docs/review-guardrails
26 checks passed
PeterStaar-IBM
pushed a commit
that referenced
this pull request
Oct 5, 2026
* fix(backends): make parsed data and model contracts explicit Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com> * fix(html): preserve invalid option failure contract Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com> * fix(html): preserve invalid option failure contract Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com> --------- Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New ty finds incomplete or incorrect backend contracts for parsed values, backend options, document nodes, and third-party APIs.
State the actual types and narrow parsed values where they enter the backend. Keep supported conversion behavior and public Python 3.10 compatibility. Remove ineffective ignores and impossible branches. The ODS image pass also calls a method that does not exist in odfdo, which drops floating images. Use the existing image loader and leave cell images with their rich cell, so each picture has one owner.
Validation: ty 0.0.84 passes for all backend files on Python 3.10 and 3.13. The old ty 0.0.33 check exits successfully.
make validatepasses. Focused tests cover the source, stored document tree, and exported output. Two new ODS cases check image pixels, ownership, and HTML embedding. No reference data was changed.Five line-local notes cover verified dependency stub limits: four openpyxl private fields and Pillow read-only streams. No type rule is disabled.