Repository navigation
fix(types): align core Python contracts with ty - #4558
Merged
PeterStaar-IBM merged 9 commits intoOct 5, 2026
Merged
PeterStaar-IBM merged 9 commits into
PeterStaar-IBM merged 9 commits into
Conversation
This was referenced Oct 4, 2026
Contributor
|
✅ DCO Check Passed Thanks @geoHeil, all your commits are properly signed off. 🎉 |
Contributor
Author
Stack LinksThis PR is part of a local stacked series:
This comment was autogenerated by stax |
This was referenced Oct 4, 2026
geoHeil
force-pushed
the
2026-10-04-fix/core-model-contracts
branch
from
October 4, 2026 09:30
2eb23f4 to
4c8742f
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
geoHeil
force-pushed
the
2026-10-04-fix/core-model-contracts
branch
from
October 4, 2026 09:52
4c8742f to
2de2e7c
Compare
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
geoHeil
force-pushed
the
2026-10-04-fix/core-model-contracts
branch
from
October 4, 2026 09:52
2de2e7c to
3f08558
Compare
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
PeterStaar-IBM
merged commit Oct 5, 2026
5726a06
into
2026-10-04-docs/review-guardrails
26 checks passed
PeterStaar-IBM
pushed a commit
that referenced
this pull request
Oct 5, 2026
* fix(types): align core Python contracts with ty Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com> * fix(types): clarify inference engine contracts for ty Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com> * fix(types): clarify stage and OCR contracts for ty Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com> * fix(types): guard optional input formats Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com> * fix(core): preserve threaded and VLM result contracts Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com> * fix(types): narrow optional VLM engine selection Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com> * fix(types): preserve MLX path contract Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com> * fix(types): preserve MLX path contract Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com> * fix(types): remove stale MLX ignore Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com> --------- Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New ty diagnostics covered core parsing, pipeline, inference, and stage contracts. This patch adds explicit models and guards at those boundaries, and fixes three real incomplete-result cases in RapidOCR: missing text, missing confidence, and detection-only output now log and skip. Complete OCR text, confidence, and coordinates stay unchanged.
The changes stay in Python code and focused regression tests. They do not disable a ty rule or widen values to
Any.Validation: ty 0.0.84 passes on Python 3.10 and 3.13. Focused core and model tests pass, including 91 tests with one existing skip.
make validatepasses. The backend contract patch below this branch has separate source, model, and export tests.