Repository navigation
feat(ui): one glass dock for the composer band - #14568
Conversation
|
Intent. Every surface in the composer band (follow-up chips, tip / folder-suggestion / question cards, memory chip, jump-to-bottom button, sub-agent approval card, tool approval bar) wears the Liquid Glass material #14460 gave the composer, and the recipe lives in one wrapper ( Not in scope. Transcript scrolling under the dock (ChatPage layout, follows this PR); glass on the peek-stacked queue cards (they would show through each other); ErrorNotice; any change to the optics landed in #14460. Reviewers: a CONCERN that asks to make chips use the component form should weigh the measured zero-pixel bend at chip size and the pinned chip tree in |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Verify before merge: that minting the tool-bar's permission row from a spawn frame routes a spawn decision to the correct spawn and cannot double-approve when both asks are live — a screenshot can't confirm approval routing. [DESIGN-REVIEWED] a120137 |
First Principles Review (Fable 5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS Item 8 rides along beyond the frozen Goal: the spawn/tool approval arbitration (button-withholding + new copy + new plural i18n keys in every catalog) is an interaction-behavior change, not "wear the same material." Not justified as shipped
What this change shipsInventory (10 items) — 9 justifiedIntent: Make every control in the composer band wear one shared Liquid Glass material and let the transcript scroll under the dock like an iOS toolbar. ADDITION / refactor.
Deleted pins ( [FIRST-PRINCIPLES-REVIEWED] a120137 |
UX Review (Fable 5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS Settings capsule's new neutral focus cue is invisible: the blind reader called the rest and focused frames pixel-identical in both themes. Watch
Suggestions
[UX-REVIEWED] a120137 |
Opus 5 Review — ✅ no blocking findingsReviewed Review detailsAdvisory only: the new FINDING — website/src/index.css:2946 — [OPUS-REVIEWED] a120137 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
|
Scope update on For the CI lanes: |
76851c9 to
4317666
Compare
4317666 to
21b8e79
Compare
|
|
|
|
|
|
|
|
|
|
|
|
|
…allback Three follow-ups on the glass dock that shipped in #14568. The composer's focus cue is the glass itself, no theme color. The dock wore `composer-halo` (an accent glow, plus a 1px accent ring in dark themes) and the input wrapper turned its border `accent/50` on focus; every other glass pane wore the neutral `glass-shadow`. Now the dock wears `glass-shadow` too and the wrapper's border stays transparent: focus is the material getting a step clearer (`--glass-tint-focus` and `--glass-edge-focus`), the same cue as the Settings capsule and the cards. `composer-halo` and its memory-mode forms are gone. While a tool approval is pending the dock stacks `approval-glow` on `glass-shadow`: the glow takes the shadow slot, the focus step stays. The follow-up chips lost their top and bottom hairline: the chip row is `overflow-x-auto`, which also clips vertically, and the 0.5px line is drawn just outside the box. The row gets `py-px -my-px` so the line paints at the same row height. Hover feedback on glass buttons survives the three solidifying fallbacks: `.glass-hover` steps `--glass-tint`, which only the hidden frost layer reads, so each fallback block moves the step onto the solid fill (the contrast block at twice the mix). The jump-to-bottom pill floats 24px clear of the dock instead of 8px, where glass on glass read as one pane bleeding into the other.
…allback Three follow-ups on the glass dock that shipped in #14568. The composer's focus cue is the glass itself, no theme color. The dock wore `composer-halo` (an accent glow, plus a 1px accent ring in dark themes) and the input wrapper turned its border `accent/50` on focus; every other glass pane wore the neutral `glass-shadow`. Now the dock wears `glass-shadow` too and the wrapper's border stays transparent: focus is the material getting a step clearer (`--glass-tint-focus` and `--glass-edge-focus`), the same cue as the Settings capsule and the cards. `composer-halo` and its memory-mode forms are gone. While a tool approval is pending the dock stacks `approval-glow` on `glass-shadow`: the glow takes the shadow slot, the focus step stays. The follow-up chips lost their top and bottom hairline: the chip row is `overflow-x-auto`, which also clips vertically, and the 0.5px line is drawn just outside the box. The row gets `py-px -my-px` so the line paints at the same row height. Hover feedback on glass buttons survives the three solidifying fallbacks: `.glass-hover` steps `--glass-tint`, which only the hidden frost layer reads, so each fallback block moves the step onto the solid fill (the contrast block at twice the mix). The jump-to-bottom pill floats 24px clear of the dock instead of 8px, where glass on glass read as one pane bleeding into the other.
…allback Three follow-ups on the glass dock that shipped in #14568. The composer's focus cue is the glass itself, no theme color. The dock wore `composer-halo` (an accent glow, plus a 1px accent ring in dark themes) and the input wrapper turned its border `accent/50` on focus; every other glass pane wore the neutral `glass-shadow`. Now the dock wears `glass-shadow` too and the wrapper's border stays transparent: focus is the material getting a step clearer (`--glass-tint-focus` and `--glass-edge-focus`), the same cue as the Settings capsule and the cards. `composer-halo` and its memory-mode forms are gone. While a tool approval is pending the dock stacks `approval-glow` on `glass-shadow`: the glow takes the shadow slot, the focus step stays. The follow-up chips lost their top and bottom hairline: the chip row is `overflow-x-auto`, which also clips vertically, and the 0.5px line is drawn just outside the box. The row gets `py-px -my-px` so the line paints at the same row height. Hover feedback on glass buttons survives the three solidifying fallbacks: `.glass-hover` steps `--glass-tint`, which only the hidden frost layer reads, so each fallback block moves the step onto the solid fill (the contrast block at twice the mix). The jump-to-bottom pill floats 24px clear of the dock instead of 8px, where glass on glass read as one pane bleeding into the other.
…allback Three follow-ups on the glass dock that shipped in #14568. The composer's focus cue is the glass itself, no theme color. The dock wore `composer-halo` (an accent glow, plus a 1px accent ring in dark themes) and the input wrapper turned its border `accent/50` on focus; every other glass pane wore the neutral `glass-shadow`. Now the dock wears `glass-shadow` too and the wrapper's border stays transparent: focus is the material getting a step clearer (`--glass-tint-focus` and `--glass-edge-focus`), the same cue as the Settings capsule and the cards. `composer-halo` and its memory-mode forms are gone. While a tool approval is pending the dock stacks `approval-glow` on `glass-shadow`: the glow takes the shadow slot, the focus step stays. The follow-up chips lost their top and bottom hairline: the chip row is `overflow-x-auto`, which also clips vertically, and the 0.5px line is drawn just outside the box. The row gets `py-px -my-px` so the line paints at the same row height. Hover feedback on glass buttons survives the three solidifying fallbacks: `.glass-hover` steps `--glass-tint`, which only the hidden frost layer reads, so each fallback block moves the step onto the solid fill (the contrast block at twice the mix). The jump-to-bottom pill floats 24px clear of the dock instead of 8px, where glass on glass read as one pane bleeding into the other.
…allback Three follow-ups on the glass dock that shipped in #14568. The composer's focus cue is the glass itself, no theme color. The dock wore `composer-halo` (an accent glow, plus a 1px accent ring in dark themes) and the input wrapper turned its border `accent/50` on focus; every other glass pane wore the neutral `glass-shadow`. Now the dock wears `glass-shadow` too and the wrapper's border stays transparent: focus is the material getting a step clearer (`--glass-tint-focus` and `--glass-edge-focus`), the same cue as the Settings capsule and the cards. `composer-halo` and its memory-mode forms are gone. While a tool approval is pending the dock stacks `approval-glow` on `glass-shadow`: the glow takes the shadow slot, the focus step stays. The follow-up chips lost their top and bottom hairline: the chip row is `overflow-x-auto`, which also clips vertically, and the 0.5px line is drawn just outside the box. The row gets `py-px -my-px` so the line paints at the same row height. Hover feedback on glass buttons survives the three solidifying fallbacks: `.glass-hover` steps `--glass-tint`, which only the hidden frost layer reads, so each fallback block moves the step onto the solid fill (the contrast block at twice the mix). The jump-to-bottom pill floats 24px clear of the dock instead of 8px, where glass on glass read as one pane bleeding into the other.
Problem / Motivation
Goal: Everything that floats over the transcript in the band above the input box — the follow-up chips, the tip and folder-suggestion cards, the question card, the memory-mode chip, the jump-to-bottom button, the sub-agent approval card and the tool approval bar — wears the same Liquid Glass material the composer got in #14460, the recipe lives in one place, and the transcript scrolls under that dock the way content scrolls under an iOS toolbar.
After #14460 the composer is a glass pane, but every other control in the same band is still a solid
bg-bg-elevatedbox with its own border. The band reads as one glass object sitting among a scatter of unrelated cards, and a tool approval bar fused to the composer's top meets the pane at a visible seam (solid box above, glass below). The recipe (tint, edge, light band, halo) was also restated per call site.And the glass had nothing to refract: the transcript scroller ended where the composer began, with an opaque fade band between them, so the only thing ever behind the pane was the page background. Measured on the 40-message transcript at the bottom: 0 text nodes under the glass.
Why it matters
The composer band is the one region every user looks at every turn. Half glass and half card looks unfinished, and the seam at the approval bar shows up exactly when the user is being asked to decide something. A glass dock over a blank strip is also a material with no job: the blur, tint and edge only read as glass once real content moves beneath them, which is why the layout change ships with the material rather than after it.
Not a goal
QueueStack). They overlap in a peek stack, and a translucent card shows the cards behind it, which is why they were hard-coded opaque before this PR. They stay opaque.ErrorNotice. It is the standard error component and is left as is.ChatPane/ split-grid composers. They keep their own layout; this PR is the main chat page only.What changed (motivation → approach → change)
One material, one place. The recipe moves into
components/Glass.tsx, a thin polymorphic wrapper over theui/liquid-glassprimitive: the pane IS the host element, there is no wrapper box. The pane draws no ring — its top and bottom are the light bands, its left and right a 1px--glass-edgeline, nothing around the corners, as in the reference material (two lit edges set against thin dark sides) — so the host carries only the caller's shadow. Call sites say what they are (variant:panelfor composer-sized boxes at frost 6 / light 25,chipfor the small pills and cards at frost 4 / light 18), how round they are (radius) and which element they ARE (as:div,spanorbutton— a follow-up chip is<Glass as="button" onClick …>, so the button is the flex item, carries the width cap, the entrance animation and its own handler, and the effect layers sit inside it under the label atz-index: -1in the host's own isolated stacking context; a<button>host stays valid phrasing content because the layers are<span>s).classNameon the host carries layout plus the box-shadow state the caller owns:glass-shadow(the neutral rest shadow; its focus-within form deepens the shadow and swaps the tint for--glass-tint-focus, a brighter, more opaque step of the same hue, and the side lines for--glass-edge-focus, the same ink at about twice the alpha, instead of colouring),composer-halo(the session composer's own accent focus glow) orapproval-glowwhile a decision is pending. Which shadow a pane wears at this instant is the caller's state, not the material's, so it is not a prop, and the accent glow is the composer's alone — the material never lights up in the theme colour, so the mobile Settings capsule now focuses by deepening its shadow, lighting its tint a step and darkening its two side lines, not by turning accent (measured on the built capsule, whole pane incl. shadow: +4.6 in light, +23.4 in dark after the focus tint was stepped up to darkrgba(84,84,92,.72)/ light white.92— the first.60/.72step read as no change in a still, and the tint step alone still went unread beside unchanged edges, so the side lines now step with it: light black.24→.60, dark white.14→.55; measured on the built capsule at mid-height, 2×: the side line goes 65 → 174 in dark while the interior goes 27 → 68, and 195 → 128 in light while the interior goes 240 → 254 — the largest pixel change between the rest and focused frames is now 110 in dark and 85 in light, against 42 and 68 on the previous head). Under the three solidifying fallbacks none of those layers paint, so there the same.glass-shadow:focus-withinrule draws the app's standard 2px accent outline instead — a solid box holding focus must show it. The optics are not open at the call site. The composer and the capsule both render through it;SidePanelLayout.tsxdrops its hand-built hairline + halo box.One dock pane. The composer's approval bar, the notice row, the composer and the collapsed bar now share ONE pane (
composer-dock). Theinput-wrapperstays transparent in every state — the previous solid fallback while an approval was fused above it is gone, since there is no longer a seam to hide — and the dock swaps its resting halo for the approval glow while a decision is pending, so the whole pane says "waiting on you" rather than one bar inside it. The pane stays mounted across the transition, so an approval never remounts the editor. The sub-agent approval card (spawn) is a separateGlasspane in the plain material, on purpose: the first round's UX read saw a warn-tinted spawn card and the warn tool-approval bar in one band as ONE request ("I'd fear double-approving"), so the card keeps its Bot framing and pulse and drops the shared warn tint, and the two asks stop looking alike. The third round's blind read still hesitated over the two panes ("is this a second, separate question or the same one … one click only answers half of it"), so while a tool approval is pending the spawn card withholds its own Approve/Reject and glow and keeps only its count and "Review in panel", and its line reads "N sub-agents pending — answer the request below first" (new plural keycomponents.chatInput.spawn_pending, all catalogs) rather than "awaiting your approval", so the line points at the surface that holds the decision instead of at itself. The blind read of the previous head then tripped on the vocabulary — the line sent it to a bar that says "Allow once / Reject" while the card's live state says "Approve / Reject" for the same act, and it could not tell whether those are one decision — so the line now names the ORDER ("answer … first") rather than a synonym for the buttons, and the card's live-state sibling line, which was an English literal on main, is the plural keycomponents.chatInput.spawn_awaitingin every catalog. The per-agent rows collapse out (AnimatePresence, height + opacity) when a tool approval lands, the same way the action area cross-fades, instead of unmounting on one frame under a fading header. One set of decision buttons on screen at a time; the dock's glow marks the one that is live. A spawn approval frame also mints the bar's own permission row (useWebSocketapproval→sseChatMessage), so the bar's decision on a spawn IS the spawn decision, and the card takes the buttons back only once no permission row is pending after the last user message — in practice when the user sends a message while the spawn still waits (a new user turn retires the stale rows). The action area's three forms (resolving / panel link / Approve + Reject) cross-fade underAnimatePresence mode="wait"instead of swapping, so the slot reads as one control changing state.The primitive on every surface, no CSS twin. The first push gave the small surfaces a CSS copy of the material (
.glass-pane): same tint and edges, no refraction, because at chip size the bend measured as zero pixels and the primitive's extra DOM would have broken the chip tree that the entrance animation andFollowUpBar.test.tsxaddress by structure. The copy drifted from the primitive on every re-tune (its top light was a hard 1px line with no bevel, and the capsule and the chips visibly read as two materials), so it is gone:FollowUpBar(each chip, and the split wrapper when instant-send is on),TipCard,FolderSuggestionCard,QuestionCard,MemoryModeChipand the jump-to-bottom button inapp-sdk/ChatScrollChrome.tsxrenderGlassitself in thechiprecipe, hosted AS the button or card element (as), so the chip tree is unchanged — one element is the control, the flex item and the pane — and every pane carries the primitive's bands, bevel, side lines, hairlines and refraction map (about 120×30 device px per chip; the map is rasterised once per settled size). Theborder border-transparentthe chips kept so their box does not move by a pixel stays; nothing is drawn. Picked, pending and hover states mix their colour INTO the tint on the host instead of carrying a second recipe:glass-accent(a picked chip, an attached card),glass-warn(the incognito memory chip) andglass-hover:hovereach swap--glass-tintfor a step derived once on:root(--glass-tint-accent= 14%--accentinto the tint,--glass-tint-warn= 12%--warn,--glass-tint-hover= 8%--textinto the tint, a step toward the foreground in either polarity). The three existing glass fallbacks (reduced transparency, more contrast, nobackdrop-filter) address.liquid-glassalone again; under all three the-accent/-warnhosts re-assert their mixed fill on the solid--bg-elevated(the!importantfill would otherwise outrank the tint swap), more-contrast draws a 1pxoutlinein--text(an outline, so no layout shift), with-accent/-warnoutlining in their own colour so a picked chip and an incognito chip still read apart, and.liquid-glass:focus-visiblere-asserts the 2px accent focus ring inside the same block. The layer hide addresses the primitive's owndata-liquid-glass-layerattribute (every effect layer and the filter's zero-size<svg>carry it), NOTaria-hidden: the children render directly, so a decorative icon among them —TipCard's<Lightbulb aria-hidden>,FolderSuggestionCard's<FolderInput>— is a direct child too, and anaria-hiddenselector deleted it with the layers under every fallback. It covers the frost clip wrapper, so the far-edge blur fix below solidifies with the rest. Measured on the built chip's top edge in dark (device px, 2×): the CSS copy[9, 43, 43, 78, 75, 71, 70, 67, 66, 44, 43]— a hairline, a 1px gap, a 3px flat-topped band, then a hard step; the primitive[9, 68, 61, 52, 47, 44, 43, 43, 43]— the hairline meets the lit edge and it fades inward smoothly, the same profile as the composer's[9, 66, 63, 59, 55, 51, 48, 43, 39].The recipe, re-tuned (
index.css,Glass.tsx,ui/liquid-glass.tsx). With content scrolling under the pane the #14460 values read too opaque and too flat against the reference material, so:--glass-tintdark goesrgba(30,30,34,.55)→.40; light goes white.72→ a cool light greyrgba(238,238,243,.45)— not white, because on a white page a white fill leaves the top/bottom light bands nothing to stand out from (measured: pane interior 228 vs page 254, band +11 over the interior; with the white tint the band was +6). Frost drops 24 → 6 on the composer and 18 → 4 on the chips: the text scrolling under the pane has to stay readable as text, and at 16, 12 and again at 8 it still read as mush. The light bands take their colour from a new polarity-fixed--glass-band(darkrgba(255,255,255,.22), lightrgba(255,255,255,.92)) scaled by the light setting (25 = the full token, the chip's 18 ≈ 70%): on the light grey tint the old white-alpha peak topped out at ~22% white and read grey, so the light-mode band is now near-white. The bands fade to CLEAR past the corner arc, and the sides carry a 1px--glass-edgeline (light.16→.24black; dark white.14), drawn on the bevel layer as two horizontal inset shadows: a horizontal offset paints nothing on the top and bottom edges and thins out through the corner arcs by itself, so the line never closes into the ring #14460 drew around the pane. Each light band sits against a half-pixel--glass-hairline(light black.20, dark black.50) just outside the top and bottom edges: two outer box-shadows offset ±0.5px, which show only along the edge they moved away from and taper through the arcs — a very thin dark line under each lit edge, as the reference's, one device pixel on a 2× display. Measured over white in light: page 248 → hairline row 198 → band 251 → interior 246. That is the reference material — two lit edges on thin dark hairlines, set against thin dark sides; measured on an iOS 27 capsule over white, the side line reads ~185/255 at mid-height, ~215 through the arc, interior ~248. Measured on the built dock at rest: top edge +37 over the interior in dark (65.9 vs 29.1), +8 in light (251.6 vs 243.2, on a 251 page); side line 186 vs interior 246 in light (218 at the start of the arc → 186 on the straight flank), 58 vs 25 in dark; no line on the top or bottom edge.The blur reaches the far edges (
ui/liquid-glass.tsx). Measured on the built component over 8px horizontal stripes: the bottom 17px of the 24px-blurred pane showed the stripes at a third of their contrast while the top edge was flat, and the same over vertical stripes on the right edge but not the left. A baredivwithbackdrop-filter: blur(24px)did the same, at radius 0 too, so this is Chromium's backdrop blur under-blurring the far edges of the element that carries it, not this composition. The frost layer is therefore rendered two blur radii larger than the pane on every side inside a clipping box, so the under-blurred band lies outside what is shown. After: top and bottom rows of the pane mirror each other (dark 92→80 / 80→93, the rim light), stripe swing at the bottom edge 47 → 9, the same as the top. Reduced-transparency / more-contrast / no-backdrop-filterstill hide the layer, since the clip box carriesdata-liquid-glass-layerlike the layers before it. Because every small surface is now the primitive too, the chips and cards get the same clipped overhang and no surface keeps the under-blurred band.The transcript scrolls under the dock (
ChatPage.tsx). The dock — status stack, jump-to-bottom pill,FlyingQuote, the composer with everything above it — leaves the pane's flex column and becomes oneabsolute inset-x-0 bottom-0box (composer-dock-root). The transcript scroller therefore fills the pane to its bottom edge, and pays for the covered strip withpaddingBottom: dockH + DOCK_CLEARANCE_PX(16px), wheredockHis the dock's liveoffsetHeight: a callback ref attaches aResizeObserverto the dock root — a callback ref, not a[]layout effect, because the dock sits inside the pane's conditional branch and a mount-once effect ran before it existed and never measured. The ref fires in the commit phase, so the first painted frame already carries the right padding. The welcome hero pads by the samedockHso it stays centred in the visible strip. Growth and shrink of the dock (chips appearing, an approval bar, a taller draft) change the scroller'sscrollHeightthrough its padding, which the existing follow controller already treats as content settling: at the bottom it re-pins, above the bottom it leaves the reader alone — the scroller was already observed for exactly that. The memory-chip row loses itsbg-bgbackdrop, since the content scrolling under it is now the point.The opaque bottom mask (
TRANSCRIPT_MASK_ABOVE_PX/COMPOSER_MASK_OVERSHOOT_PX, thefrom-bg from-[62%]gradient) is removed outright: it existed to feather the transcript into an opaque composer box, and over glass it would paint a solid strip across exactly the content the layout exists to show. The status bars'z-[2]layers stay (they now state the dock's paint order rather than clear a mask, and their comments say so);QueueStackstays below the composer'sz-10so its fuse still slides under the input box. The dock root has NO z-index on purpose — positioned withz-index: autoit forms no stacking context, soSubagentProgressBar'sz-[46]still clears the theme-experience overlays — and paints over the scroller because it follows it in DOM order. It ispointer-events-none; its two wrapper boxes (the status stack and the input area) aredock-inert— inert themselves, with input restored on their CHILDREN, each of which is its own 900px column — so wheel and touch in the empty width beside the column reach the transcript beneath, as the strip beside an iOS toolbar does. The status stack is also a scroll box (max-h-[50svh] overflow-y-auto), and a scrollbar belongs to the box, not to a child, so an inert stack could not be scrolled by its own thumb once it overflowed: the band's existingResizeObserver(useChatPageTranscriptController) marks itdata-overflowing— it crosses the cap only by changing height, so every crossing is a resize it already sees — and.dock-inert[data-overflowing="true"]lets the box catch input as a whole for exactly that stretch. The root is also inset on the right by the scroller's measuredscrollbar-gutter(6px in Chromium, read asoffsetWidth - clientWidthin the same ResizeObserver that measures the dock height, which also observes the scroller so an engine with overlay scrollbars keeps the inset correct), which both keeps the scrollbar thumb uncovered down to the pane's bottom edge and lines the dock's column up with the transcript's, which is centred in the content box that excludes the gutter.scripts/capture-liquid-glass.mjsgrows from four composer scenes to fifteen — the collapsed composer bar, follow-up chips at rest and picked, a pending tool approval, the sub-agent approval card LIVE (the spawn request, then a user message, so the bar is gone and the card carries Approve / Reject and the glow), both approvals pending together (asserts the card says "1 sub-agent pending", offers no Approve and does not glow while the tool bar is up), the tip card, the folder-suggestion card, the question card, incognito on an empty session (asserts the warn memory chip), the welcome state with the memory chip, the 40-message transcript both pinned to the bottom and scrolled up, and aspawn-flowscene that records the approval band's three transitions to a GIF (tool bar + withheld card → the tool decision lands and the bar shows the spawn's own request, card still withheld → the user speaks, the bar hides and the card's buttons fade in), asserting each state before pushing the next frame, trimmed to open on the settled themed band rather than the blank load — in both polarities, and asserts the floating-dock geometry on the long scene (scroller bottom == dock bottom, padding == dock height + 16, last line clears the dock, text sits under the glass once scrolled, the jump-to-bottom pill is up). Cards are raised by pushing websocket frames into the stubbed socket, 900ms apart when a scene needs several.Backwards compatibility
Compatible: no route, config key or API change; two i18n additions (
components.chatInput.spawn_pendingandspawn_awaiting, both plural, in all 13 catalogs + the pseudolocale —i18n/locales/*.json, plural shape ini18n/pluralKeys.json); theui/liquid-glassprimitive gains one optional prop,as(divdefault,span,button), and itsclassName/stylenow land on the pane's host (the element carryingliquid-glass) rather than on a wrapper, so a consumer that addressed.liquid-glass's parent for layout would now address the pane itself; no consumer outside this PR does.Glassis new;.glass-paneand its-accent/-warn/-hovervariants exist only between the first push of this PR and this head and are removed. Two polarity-fixed CSS variables change shape:--glass-bandis new, and--glass-edgeis no longer drawn around any pane — it is the SIDE line only (left and right flanks, thinning through the corners) and the in-pane divider, so every glass surface loses the top and bottom of its 1px rim and its light-mode value darkens.16→.24; the mobile Settings capsule no longer turns accent on focus (its shadow deepens, its tint and side lines step instead; under the solidifying fallbacks it takes the standard accent outline). Three things a user can see differ: the composer no longer turns solid while an approval bar is attached (that solid state existed only to hide the seam this PR removes); the last line of the transcript no longer fades into the composer — it stops 16px clear of the glass at the bottom and shows through it once scrolled; and the empty width either side of the composer column now scrolls the transcript instead of swallowing the wheel. One shadow rule is new inindex.css:.glass-shadow, the neutral offset-free rest shadow for every glass pane that is not the session composer, whose focus-within form deepens the shadow and swaps the tint for--glass-tint-focusand the side lines for--glass-edge-focus; the bands and side lines live on the primitive's own layers, so they never compete with the host's shadow for onebox-shadow. Dark themes keep the 1px accent ring under the composer's.composer-halofocus glow.Tests
ChatInput.liquidGlass.test.tsx(rewritten for the dock structure): the wrapper isbg-transparentwith nobg-bg-elevatedin the no-approval state; with a pending approval the wrapper stays on the shared pane (still transparent) and the dock carries the approval glow instead of the resting halo; exactly one dock pane is mounted around the wrapper and the dock element IS the primitive's host (carriesliquid-glass, no ring class,composer-halo, 16px glass,--glass-tintlayer); the accent focus glow exists only as.composer-halo(no.liquid-glass … .composer-halorule;.glass-shadow:focus-withinis the neutral deepen and swaps the tint);index.csscontains noglass-pane; the state steps are--glass-tintswaps derived on:root(glass-accent,glass-warn,glass-hover:hover); and every one of the three fallback rules solidifies.liquid-glass, re-asserts the-accent/-warnfills, hides the[data-liquid-glass-layer]layers (never an[aria-hidden]selector) and gives a focused.glass-shadowpane the 2px accent outline.FollowUpBar.test.tsx: a chip button carriesliquid-glass(it IS the pane) and a picked oneglass-accent, an unpicked one not; the chip tree, entrance animation and click behaviour assertions are unchanged.ChatPage.dockClearance.test.tsx(new, replacesChatPage.fadeClearance.test.tsx): the scroller's padding isdockH + DOCK_CLEARANCE_PX, never a constant; the dock root isabsolute bottom-0and is measured from a callback ref through aResizeObserver(and NOT from a[]layout effect); the clearance and tail spacer are px, never viewport units; the welcome hero pads bydockH; no fade gradient and no mask constants remain; the memory-chip row has nobg-bg.ChatPage.statusStackLayering.test.tsx(new, replacesChatPage.statusStackAboveMask.test.tsx): keeps the child-list guard, QueueStack below the composer, and the stack wrapper context-free; adds that the dock root is positioned with no z-index (so it forms no stacking context) and that the root ispointer-events-none, both wrappers aredock-inert(neverpointer-events-autothemselves) andindex.cssdefines.dock-inertas inert-with-children-live.ChatPage.scrollShell.recipe.test.tsx/.render.test.tsx/ChatPage.queueBandReanchor.test.tsx: the pinnedpaddingBottomliteral follows the new expression, and the mask recipe pin becomes a DOM-order pin (the dock root follows the scroller) plus a no-gradient assertion.ChatInput.approval.test.tsx: with a tool approval and two spawns pending together, the spawn card reads "2 sub-agents pending — answer the request below first" (and nothing says "awaiting your approval"), shows "Review in panel", offers no Approve all / per-agent Approve, carries no glow, and the dock carries the glow.LiquidGlass.test.tsx: the composer fixture follows the recipe (frost 6, light 25) —blur(6px), a 12px frost overhang; the bevel layer'sbox-shadowleads with the two--glass-edgeside insets (inset 1px 0 0,inset -1px 0 0), then the two outer--glass-hairlineshadows (0 ±0.5px 0 0), before the vertical bevel insets; the specular layer's gradient is read from its--liquid-glass-bandscustom property (jsdom drops acolor-mix()background) and starts at the full--glass-band.ChatInput.liquidGlass.test.tsxalso pins the glass tokens per polarity (tint, focus tint, band, edge, focus edge, hairline), the focus rule (.glass-shadow:focus-within:not(.glass-accent, .glass-warn)swaps the tint and the edge) and the-accent/-warnre-assertion under the solidifying fallbacks;MemoryModeChip.test.tsxexpects the chip button to carryliquid-glass+glass-warn+text-warnfor the incognito chip (wasborder-warn); es/fr/it/pt gainspawn_pending_many, which their plural rules select;LiquidGlass.test.tsxchecks every layer and only the layers carrydata-liquid-glass-layer(anaria-hiddenicon child does not);ChatPage.statusStackLayering.test.tsxpins thedata-overflowingrule and the observer write.scripts/mutation-check-scroll-shell.mjs: the bottom-mask region is re-anchored on the dock root ({/* Composer dock→<JumpToBottomButton) and the suite list namesChatPage.dockClearance.test.tsx, sonpm run mutation:scroll-shellwalks the new shell instead of exiting on a missing anchor.ChatPage.composerChromeOcclusion.test.tsxis unchanged and still passes on this head: the status-stack cap, the title-band lift and the drawer scrim ordering are untouched.LiquidGlass.test.tsxalso pins the polymorphic host:<LiquidGlass as="button" …>renders a<button>that carriesliquid-glassplus the caller'sclassName, forwardsref,type,onClick,aria-*andstyleto that button, and holds the effect layers inside it. No new test forGlass.tsxitself: it is a thin composition over the primitive (recipe table +cornerRadiusfromradius).Manual verification
node scripts/capture-liquid-glass.mjsagainst the built dist of this head, dark and light: composer at rest / focused / collapsed / chips / picked chip / tool approval / sub-agent approval / both approvals together / tip / folder suggestion / question card / incognito / welcome, the 40-message transcript at the bottom and scrolled up, the mobile Settings capsule at rest and focused, the desktop Settings rail. The harness asserts ablur()backdrop layer renders on the composer (url(#lg-…)+blur(8px) saturate(1.55)) and the capsule, that the capsule'sbox-shadowchanges on focus and stays neutral (darkrgba(0,0,0,.30)→.55, light.06→.14; no accent) and its--glass-edgesteps to the focus value (dark#ffffff24→#ffffff8c, light#0000003d→#0009), that the live spawn card offers Approve / Reject with the glow and no bar, that the withheld card says "1 sub-agent pending — see the bar below" with no Approve and no glow, that the incognito scene renders the warn memory chip, and on the spawn-flow recording each of the three states before the next frame is pushed, and on the long scene: scroller bottom == dock bottom (the transcript runs under the dock), scroller padding == dock height (143px) + 16, the last message clears the dock by 70px at the bottom, 3 text nodes sit under the glass once scrolled up 180px, the jump-to-bottom pill is present, the dock's right edge stops exactly the reserved scrollbar gutter (6px) short of the scroller's,elementFromPointin the 91px gutter left of the column is not a dock box, and a wheel delivered there scrolls the transcript 120px. Static gates run locally on this head:tsc -b --force, eslint (0 warnings), i18n:check. Tests run in CI.Screenshots / video
All frames from this head's build (
node scripts/capture-liquid-glass.mjs), dark and light.The transcript under the dock — 40 messages, scrolled up so a paragraph and a code block sit beneath the glass, jump-to-bottom pill above it:
Same transcript pinned to the bottom — the last line stops clear of the dock, nothing hides under it:
Composer at rest — no ring: light bands top and bottom, a 1px dark line down each side that thins through the corners, the shadow for depth:
Composer with follow-up chips — chips and pane are one material, same bands, same side lines:
A picked chip (
glass-accent):Composer with a pending tool approval fused above it — one pane, the approval glow on the whole dock, no seam:
The sub-agent approval card live — the user sent a message while the spawn waited, so the bar is gone and the card alone carries Approve / Reject and the glow:
Both approvals pending at once — the bar acts; the card reads "1 sub-agent pending — answer the request below first" with the panel link only, no buttons, no glow:
The approval band's transitions, recorded: tool bar + withheld card → the tool decision lands (the bar now shows the spawn's own request; the card stays withheld) → the user speaks (the bar hides; the card's Approve / Reject fade in):
Tip card, folder-suggestion card and question card on glass, over the dense transcript:
Memory-mode chip: default state on the empty-session welcome screen, then the warn chip in incognito (same glass, the warn hue mixed into the tint) above the warn-bordered composer:
The collapsed composer bar — the whole dock is the "Show the message input" button, over the transcript:
Mobile Settings capsule (390px) at rest and focused — focus deepens the shadow, lights the tint a step and darkens the side lines (neutral, no accent). Measured on these frames, interior / side line, 0–255: dark 27 → 68 / 62 → 168; light 246 → 255 / 199 → 170, page under the shadow 249 → 239. The light-mode step is deliberately quiet; a keyboard-only
:focus-visibleaccent ring is an open maintainer question, not in this PR:Related Issues
Follows #14460.
Pattern harvest
variant,radius) and never optics, and leaves per-instant STATE (which shadow, focus) to the caller'sclassNamerather than growing a boolean per consumer. A CSS copy of a component's material is a second recipe that drifts on every re-tune; when the component's DOM is the obstacle, make the component polymorphic on its host (as) rather than copying its output.[]effect only looks once.Checklist
website/docs/theming-contract.mdrecords--glass-band,--glass-edgeand--glass-hairlinebeside--glass-tintand that the pane draws no ring (lit top and bottom, a line down each side); no spec covers the composer band's layout