Skip to content

fix(website): gate hover so iOS taps land on the first try - #14807

Merged
iamwhatever merged 1 commit into
kirodotdev:mainfrom
Pearcekieser:fix/touch-gated-hover
Oct 2, 2026
Merged

iamwhatever merged 1 commit into
kirodotdev:mainfrom
Pearcekieser:fix/touch-gated-hover

Conversation

@Pearcekieser

@Pearcekieser Pearcekieser commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: One tap activates a control on an iPhone, and every hover-revealed control stays reachable on touch screens.

On iOS Safari and the home-screen PWA, many dashboard controls need two taps. The first tap only reveals the control. Examples are the sessions drawer folder menu, the history row delete button, the composer image remove button, notification dismiss buttons, tab close buttons and the widget toolbar.

Why it matters

Phone users hit this on the most common actions in the drawer and composer. It makes the dashboard feel broken on mobile, and a second tap sometimes lands on a different control after the layout shifts.

Not a goal

  • Tooltips driven by JavaScript mouseenter timers (InstantTip). A separate change handles those.
  • Modal menus and touch target sizes, which are separate changes.
  • Plain CSS :hover rules in index.css. None of them reveal a control.

What changed (motivation → approach → change)

Before After
hover: compiled to a bare :hover, so a tap fired it hover: and every group-hover: / peer-hover: apply only inside @media (hover: hover) (Tailwind's default)
A control hidden until hover appeared on tap, and iOS dropped that tap's click The control is visible at rest where hover cannot happen, via [@media(hover:none)]:opacity-*
Nothing checked that a hidden control had a touch state A guard test fails on any new hidden-until-hover control without one

iOS sends a synthetic hover before a tap's click. When that hover makes hidden content visible, Safari treats the tap as a hover and never fires the click. website/src/tailwind-theme.css had redefined hover: as &:hover so that tapping would reveal hover-only controls, which is exactly the reveal that cancels the tap.

The fix removes that override so hover styles never apply on a touch screen. Each of the 32 controls that relied on a tap to appear now carries its own (hover: none) visible state, at the same opacity its hover state used. Every notification dismiss rests at the same 0.6 opacity on touch. Where a control dims while busy (disabled: or a pending mutation), the dim state still wins on touch, including at the widths where it is otherwise hidden until hover. An overlay control that is now always shown keeps room for itself, so it covers no text. A code-review-sage run card with a delete control keeps a strip of room below its last row on touch, where that control sits. A history row reserves space for its delete button. A session row on any touch screen, a wide tablet included, shows the single ⋯ menu phones already use instead of the three-button hover cluster, so the cluster never covers the row's time and pin. That menu now carries Duplicate, the one cluster action it lacked. A non-empty sessions-drawer folder row shows its menu and new-chat buttons inline on touch, the same shape an empty folder row already uses, so the folder count stays visible. The design-tweak row cluster, which collapses to zero size at rest, is always expanded on touch. The tag manager's delete and status buttons, which rest with a transparent glyph and turn muted on hover, take the muted colour on touch. A status button that is disabled stays transparent on touch, because its reason is only in a tooltip and tapping it would do nothing. In the artifacts table view, the folder row's cell spans the whole table, which scrolls sideways on a phone, so its menu sits inline after the count on touch instead of ml-auto past the viewport edge.

website/docs/frontend-conventions.md and the theme note in website/src/index.css describe the gated hover: policy instead of the old ungated one.

Hover-only decoration, such as a pencil glyph inside a visible title button or the file-change chip tooltip, no longer shows on touch. The daily token chart tooltip is the one exception. It is the only place a day's figures appear and the bar has no click action to lose, so it keeps an explicit ungated [.group:hover_&]:block and a tap still shows it.

Inventory of every hidden-until-hover site in website/src (tests excluded)
Status Sites
Touch state added here pages/ChatSidebar.tsx board folder header cluster, list folder row cluster, history row delete; components/ui.tsx IconButtonGroup reveal (session rows on touch tablets, widget toolbar); components/chat-input/FilePreviewStrip.tsx image remove; components/notifications/NotificationCard.tsx and NotificationFeed.tsx dismiss; components/SessionTabStrip.tsx, components/EmbedTabStrip.tsx, components/BottomTerminalPanel.tsx, pages/chat/SidePanel.tsx tab close; pages/chat/SessionTitleControl.tsx regenerate title; components/library/LibraryTable.tsx, pages/ArtifactsPage.tsx folder menu; pages/ArtifactDetailPage.tsx delete; pages/AppDetailPage.tsx copy command; pages/ChannelPage.tsx reply (md:); components/RegistryManager.tsx open / refresh / remove (sm:); pages/knowledge/SourcesList.tsx rename (sm:); pages/members/MembersPage.tsx star (md:); pages/LocalStorageDebug.tsx delete; components/TagManagerList.tsx status and delete (colour reveal); website/src/apps sites: code-review-sage/components/LearningRail.tsx and RunCard.tsx delete, design-tweak/DesignTweakPage.tsx row actions and cluster, papyrus/FileTree.tsx delete, personal-shopper/PreferencesTab.tsx actions and SitesTab.tsx remove
Ungated on purpose pages/overview/TokenDailyChart.tsx daily figures tooltip
Already guarded on main utils/touchActions.ts users (message footers, code blocks, diffs, tables, Mermaid, pinned messages, file menu), RedactionCards.tsx, LaunchpadTile.tsx, MembersPage.tsx title edit, CrewAvatarButton.tsx
Decorative, not shown on touch App.tsx shortcut chord hint; pencil / pen glyphs in SpecDetail.tsx, ArtifactDetailPage.tsx, SessionTitleControl.tsx; copy glyph in CopyBranchButton.tsx; external-link glyph in SecurityPanel.tsx; resize grip bar in ChatInput.tsx; FileChangeChips.tsx tooltip; WelcomeView.tsx suggestion text unclamp (one tap sends the full text to the composer)
Visible at rest, hover only brightens About 20 opacity-40..opacity-80 → hover:opacity-100 sites; unchanged on touch apart from not brightening

Backwards compatibility

Compatible: only CSS class output changes. On a hover-capable pointer every hover style compiles to the same declarations, now inside @media (hover: hover), which matches on every mouse and trackpad device.

Tests

website/src/test/hoverVariantPolicy.test.ts:

  • Compiles tailwind-theme.css and asserts that hover:, group-hover:, named groups, peer-hover: and colour hovers are emitted only inside @media (hover: hover), and that the theme does not redefine the variant.
  • Asserts the (hover: none) override sorts after sm:opacity-0 / md:opacity-0, and that (hover: none) plus disabled: sorts after the plain touch override.
  • Scans src/ for hidden-until-hover markup, including text clamped at rest and unclamped on hover (line-clamp-N with group-hover:line-clamp-none) and a glyph that is transparent at rest and coloured on hover (text-transparent with group-hover:text-muted), and fails on any site with no (hover: none) state that is not listed as decorative. Every decorative entry must still match a live site. DisplayTab.tsx and NotificationItem.tsx are skipped as unmounted, and a test fails if any source file uses either one.
  • Pins the touch state on representative controls, including the reserved room beside always-visible overlay controls and the inline folder-row cluster and the table-view folder menu, and renders IconButtonGroup to check twMerge keeps the class.

Reverting the theme line or dropping one touch class fails the suite (checked locally).

website/src/test/SessionActionsMenu.duplicate.test.tsx checks that the row's single menu shows Duplicate and calls the handler when the row passes one, and shows no Duplicate item otherwise.

Manual verification

I booted a real gateway from this branch and from its base and captured both in Chromium. With an iPhone 13 viewport and touch emulation, (hover: none) matches. The drawer folder menu's effective opacity at rest is 0.00 on the base and 1.00 here. With a desktop viewport and a mouse hover, it is 1.00 on both.

iOS WebKit's tap handling cannot be emulated in a Linux browser, so the iOS claim rests on the mechanism above and the tests. An on-device check is welcome.

Screenshots / video

Phone (iPhone 13 viewport, touch emulation), drawer at rest, before (menu hidden) and after (menu and new-chat button inline and visible). This fork PR cannot use --attach, so the captures are committed under temp-screenshots/touch-gated-hover/:

Phone drawer before, folder menu hidden at rest

Phone drawer after, folder menu and new-chat button inline and visible at rest, count still shown

Phone, composer with an attached image: the remove badge is visible at rest, so one tap removes it.

Phone composer, attached image with its remove badge visible at rest

Phone, Older Sessions list: each history row shows its delete button at rest, and the row reserves room for it, so the title and time are not covered.

Phone older sessions list, delete buttons visible beside uncovered titles and times

Tablet (iPad Pro 11 landscape, touch): session rows show the single ⋯ menu with their times and pins uncovered, and the folder row's menu and new-chat buttons sit inline.

Tablet sessions list, each row with a single menu button and visible time, folder buttons inline

The rest of the inventory, one capture per surface. All came from a harness gateway running this branch's build, in Chromium with touch emulation, and (hover: none) matched on every page. Data the test home lacks (notifications, review runs, knowledge sources, registries, design requests, shopper preferences, a widget turn) was supplied by mocking that one API response. Folders, tags, tabs and members come from the real seeded home. In every capture, the always-visible control covers no text.

Phone, notifications page and the bell panel: each item's dismiss × shows at rest beside the time.

Phone notifications feed, dismiss buttons visible at rest

Phone bell panel, dismiss buttons visible at rest

Phone, code-review-sage reviews: failed, Clean and banded run cards. The delete button sits in the strip the card reserves under its last row, clear of the error text, "Clean" and the band counts.

Phone run cards, delete buttons in the reserved strip

Session tabs on phone and tablet: inactive tabs show their close ×. The tablet capture also shows the title control's Auto-title button at rest.

Phone session tab strip, close buttons on inactive tabs

Tablet session tab strip and title control

Phone, artifacts: the folder card menu in gallery view, the folder row in table view, and the tag remove × on an artifact's detail page.

Phone artifacts gallery, folder menu visible

Phone artifacts table, folder row and row actions

Phone artifact detail, tag remove buttons visible

Phone, an inline widget in chat: the widget toolbar (star, download, open, expand) shows at rest.

Phone chat widget, toolbar visible at rest

Tablet, the controls that were hidden only from sm: up: knowledge source rename, and registry open, refresh and remove.

Tablet knowledge sources, rename pencil visible

Tablet registry rows, actions visible

Tablet, design-tweak: the request row's chat and menu buttons stay expanded beside the queued chip. On a phone, this page's rail is wider than the viewport both before and after this change.

Tablet design-tweak request row, action cluster expanded

Phone, the table view's folder row: the ⋯ menu sits inline after the count. Before this head it rendered at x=926 on a 390-pixel viewport, off screen.

Phone, Developer storage: every key row shows its delete button at rest.

Phone developer storage, delete buttons visible

Phone, code-review-sage learning rail: non-default namespaces show their delete button beside uncovered pattern counts.

Phone learning rail, namespace delete buttons visible

Phone, a channel message: the Reply button shows at rest.

Phone channel message, reply button visible

Tablet, sidebar board view: each column's folder header keeps its menu and new-chat buttons visible beside the count.

Tablet board view, folder header cluster visible

Phone, the embedded chat's tab strip: the tab's close × shows at rest.

Phone embed tab strip, close button visible

Tablet, personal-shopper sites: each site row shows its remove button at rest.

Tablet shopper sites, remove buttons visible

Phone, Papyrus file tree: the non-main file shows its delete button at rest.

Phone papyrus file tree, delete button visible

Tablet, bottom terminal panel (cropped to the tab strip): the tab's close × shows at rest.

Tablet terminal tab strip, close button visible

Tablet, design-tweak project picker open: each project shows its remove ×, clear of the name and the dev chip.

Tablet design-tweak picker, remove buttons visible

Phone, the tag manager: each tag's status bolt and delete × show at rest.

Phone tag manager, status and delete buttons visible

Phone, personal-shopper preferences and members: row actions show at rest.

Phone shopper preference row, edit and delete visible

Phone members list, star visible

Phone and tablet, a session row's ⋯ menu open: Duplicate sits with the other session actions, since this menu replaces the hover cluster on touch screens.

Phone row menu open, Duplicate item visible

Tablet row menu open, Duplicate item visible

Phone, App detail for an app that needs a local install: the copy button sits in the room the command block reserves on its right, clear of the text. The install result is mocked, since the real flow needs a macOS client handshake.

Phone app detail, copy button beside the install command

Tablet, chat side panel: the inactive Pins tab shows its close ×.

Tablet side panel, close button on the inactive tab

pages/overview/DisplayTab.tsx and pages/chat/NotificationItem.tsx are left unchanged. No route or component uses either one (NotificationItem is only re-exported from pages/chat/index.ts, which nothing imports it from), so no user can reach their hover-only controls. The guard test skips both and fails as soon as any source file uses one.

The TokenDailyChart tooltip keeps an ungated :hover, so its touch behaviour is unchanged from main.

Desktop with the pointer over the folder row (unchanged)

Desktop, folder row hovered, menu shown

Related Issues

Fixes #14805

Pattern harvest

Rule candidate: review-prompt / test guard
Pattern: a control hidden with opacity-0 (or sm:/md:opacity-0, hidden) until a hover variant, with no (hover: none) state. The guard test in this PR is the rule.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@Pearcekieser
Pearcekieser requested a review from a team September 28, 2026 19:15
@Pearcekieser
Pearcekieser requested a review from a team as a code owner September 28, 2026 19:15
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Intent: Make hover-revealed controls activate on the first tap on iOS by keeping Tailwind's hover variant gated to hover-capable devices, while every control that relied on a tap to appear stays visible on touch screens.
Not a goal: JavaScript mouseenter tooltips (InstantTip), modal menus, touch target sizes, plain CSS :hover rules in index.css, or any change to mouse behaviour.

@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: checking Automated validation is still running labels Sep 28, 2026
@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5, fork) — 🟡 CONCERNS

UX-level review of c5bde1c496e071b4c7d3df2537c6953024fd76e8 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

No blind reader has cold-read these 30+ newly always-visible touch controls; every site is shown in the committed screenshots, so the cap is this lane's limit, not a gap.

Watch

  • Fork-lane cap only: the screenshot set is complete — all 32 inventory sites, the before/after folder row (phone-before.png/phone-after.png), the new Duplicate menu item (phone-row-menu-duplicate.png, tablet-row-menu-duplicate.png), the tablet ⋯ row menu (tablet-sessions.png), the RunCard reserved strip (phone-run-cards.png) and the inline table folder menu (phone-library-table.png) all render as the description claims, with no clipping or overlap. Comprehension of the now-permanent glyph controls (×, trash, bolt) by a first-time touch user remains unverified; a maintainer who wants the blind read can push the branch to this repository.

[UX-REVIEWED] c5bde1c

Description read

[DESCRIPTION-READ] d038b11713e37914348d8b8e65997b34c21a9557e06729d27381d4cc56d760ba

That sha256 names everything this verdict read: the PR description, plus the 37 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5, fork) — ✅ PASS

Design-level review of c5bde1c496e071b4c7d3df2537c6953024fd76e8 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Verify on a real iPhone that one tap now activates (not just reveals) a drawer/composer control — screenshots prove visibility, not the dropped-click fix.

Suggestions

  • The 32 repeated [@media(hover:none)]: arbitrary variants could be one named @custom-variant (e.g. touch:), shrinking every call site and reducing the guard test's TOUCH regex to a single token — worth it only if a follow-up adds more sites.

[DESIGN-REVIEWED] c5bde1c

Description read

[DESCRIPTION-READ] 6f1eb2a47223367a2580c5111aaf280478725c8e2afa4952dcc77917af59b6a2

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review (fork) — ✅ no blocking findings

Reviewed c5bde1c496e071b4c7d3df2537c6953024fd76e8 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] c5bde1c

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5, fork) — ✅ PASS

Premise-level review of c5bde1c496e071b4c7d3df2537c6953024fd76e8 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Verify on a physical iPhone that a first tap now clicks — the new test pins CSS emission and markup, not Safari's actual tap dispatch.

What this change ships

Inventory (10 items) — 10 justified

Intent: One tap activates a control on an iPhone and every hover-revealed control stays reachable on touch — a FIX, at cause level (the ungated hover: redefinition in tailwind-theme.css is the root cause and is deleted; the deleted pin's own rationale is openly quoted, reversed with evidence, and its "no touch surface loses a control" guarantee is re-shipped as the guard test).

  1. Hover styles no longer apply on touch screens (theme's ungated hover: override deleted) — justified
  2. 32 hidden-until-hover controls are visible at rest on touch — justified
  3. Session rows on touch tablets show the single ⋯ menu instead of the hover cluster — justified
  4. The row ⋯ menu gains Duplicate, the cluster action it lacked — justified
  5. Daily token chart tooltip still shows on tap, the sole ungated exception — justified
  6. Always-shown touch controls get reserved room or inline placement so they cover nothing — justified
  7. Busy/disabled controls keep their dim on touch; a disabled tag-status bolt stays hidden there — justified
  8. Hover-only decoration (edit pencils, chord hints, chip tooltips) no longer appears on touch — justified
  9. A guard test fails on any new hidden-until-hover control without a touch state — justified
  10. Docs and theme notes describe the gated hover policy (same-commit doc rule) — justified

Checks run: useIsTouchDevice exists on base and matches the CSS (hover: none) gate (primary-pointer, so hybrid laptops keep the cluster); temp-screenshots/ is this repo's recorded PR-evidence convention (.gitignore:117); docs/decisions/ has no hover or duplicate entry; index.css :hover rules are decoration/scrollbars with their own (pointer: coarse) branches, confirming the Not-a-goal claim; unfixed siblings = 0 by construction (the guard test scans all of src/); onDuplicate has 1 real consumer in singular form.

[FIRST-PRINCIPLES-REVIEWED] c5bde1c

Description read

[DESCRIPTION-READ] dcfb8c547242d7ce48956eca09cdc24bceaf2588fc6f367301e1cdb40379395b

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5 Review (fork) — ✅ no blocking findings

Reviewed c5bde1c496e071b4c7d3df2537c6953024fd76e8 via the fork AI-review pipeline; updated in place on each push.

Review details

The tag status bolt goes fully invisible on touch for the duration of its own save.

FINDING — website/src/components/TagManagerList.tsx:366 — the touch reveal is gated on statusDisabled, which includes statusPending (line 282), so tapping an unset bolt on a touch device drops [@media(hover:none)]:text-muted while the mutation is in flight; with group-hover/tag: now gated to (hover: hover) and no optimistic t.status update (onMutate only calls beginMutation), the only remaining colour is text-transparent → the glyph the user just tapped vanishes until the request settles (the sibling delete button at :385 got [@media(hover:none)]:text-muted unconditionally, so it stays visible at disabled:opacity-40 instead) → Fix: condition the touch colour on the persistent reasons only — ${!t.agent_provenanced || tagStoreDegraded ? '' : '[@media(hover:none)]:text-muted '} — which keeps the new TagManagerList.test.tsx assertion (t1 has it, legacy t2 does not) green.

[OPUS-REVIEWED] c5bde1c

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • issue (blocking): touch-visible delete button overlays card content (fixed)

fixed in 4ae7468: RunCard keeps [@media(hover:none)]:pr-6 beside the existing group-hover:pr-6 on the counts row, and the failure line reserves the same room, so the always-visible trash icon covers no count or error text on touch.
The same class was checked across the other absolutely placed controls this PR makes visible: the history row now reserves [@media(hover:none)]:pr-10 for its delete button, and a non-empty drawer folder row renders its cluster inline on touch (the empty-folder shape). AppDetailPage's copy button already sits in reserved pr-10.
Tests: hoverVariantPolicy.test.ts pins each reserved-room class.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • Required rendered evidence missing for a reshaped touch surface (fixed)

fixed in 4ae7468: a fork PR cannot use --attach, so the three captures are now committed under temp-screenshots/touch-gated-hover/ and the description references those paths.
phone-before.png and phone-after.png are the drawer at rest on an iPhone 13 viewport with touch emulation, base vs this head; desktop-hover.png is the same row under a mouse hover, unchanged.
On touch the non-empty folder row now shows its menu and new-chat button inline (the empty-folder shape), so the folder count and name are not covered; phone-after.png shows it.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • One-tap claim not verified on a real iOS device (needs-a-decision)

Agreed that Linux browsers cannot reproduce iOS WebKit's tap handling; the claim rests on the documented content-change behaviour plus the compiled-CSS and scan tests.
@Pearcekieser can you confirm on an iPhone that the drawer folder menu and a notification dismiss button activate on the first tap with this head? I will note the result in the PR once confirmed.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • FileChangeChips tooltip unreachable on touch (rebutted)

The minimal chip is a button (onClick opens the file's diff view), and that view is headed by the file's path, so a tap still reaches the full name in one step.
Showing the tooltip on tap would reintroduce the exact defect this PR fixes: on iOS a tap that reveals content on a clickable element drops that element's click, so the chip would need two taps to open.
The only tooltip kept on tap is the daily token chart's, because that bar has no click action to lose and the tooltip is its only data surface.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • Route the common opacity-100 touch state through one shared class (rebutted)

The shared classes in utils/touchActions.ts also grow tap targets to 40px (padding and icon size), which would change layout at every one of these sites; target sizes are handled by a separate change, so reusing them here widens this PR.
Each literal matches the opacity that control already shows when revealed (0.4 feed delete, 0.6 tab close, 0.7 regenerate; the notification card uses 0.6, its own always-visible dismiss state), so the values follow each control's existing design rather than drifting. The guard test fails any hidden-until-hover control that lacks a (hover: none) state, which covers the regression a shared constant would.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in website/src/pages/members/ and website/src/pages/overview/ since this head went green (e88e807 -> current main); CI re-running.

note: First Principles pointed at website/docs/frontend-conventions.md still describing the ungated hover:. Fixed in 4ae7468: the Styling section now states the @media (hover: hover) gate, the [@media(hover:none)]: touch state it requires, and the guard test that enforces it.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 28, 2026
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: touch-only room for the always-visible run-card delete button

  • issue (blocking): touched error surface bypasses ErrorNotice (fixed)

fixed in de3e7e1: the failure line is back to its main shape (the padding on it is removed), so this PR no longer edits that error surface.
The room for the always-visible delete button moved to the card itself: a failed card gets [@media(hover:none)]:pb-7, which keeps the icon below the error text on touch.
Moving the failure message to ErrorNotice is a separate change to how code-review-sage reports run errors and is outside this PR's goal.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • issue (blocking): touch-visible icon button lacks aria-label (fixed)

fixed in de3e7e1: the custom-theme edit button now carries aria-label={i18nT('pages.overview.displayTab.edit_theme')}, the same key it already used for title.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • Inconsistent resting weight for notification dismiss on touch (fixed)

fixed in de3e7e1: NotificationFeed and NotificationItem now rest at [@media(hover:none)]:opacity-60, matching NotificationCard, so every notification dismiss has the same touch weight. The guard test pins all three.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • MinimalChip filename tooltip is the stats-only pill's only filename display (accepted, noted)

The DECORATIVE entry in hoverVariantPolicy.test.ts now records the reason: the chip is a button, and a tap opens its diff view, which names the file.
Showing the name on tap is not an option on a clickable chip, because a tap-revealed tooltip is what makes iOS drop the click; promoting the name onto the stats-only face changes that chip's design and belongs in its own change.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note: evidence for the UX review's gaps is now in the description. phone-composer-image.png shows the image remove badge visible at rest, and phone-history.png shows history rows whose delete button sits in reserved room beside uncovered titles and times. Both are committed under temp-screenshots/touch-gated-hover/, next to the drawer before and after and the desktop hover captures. The remaining sites need data the disposable test gateway does not seed (notifications, custom themes, tab strips, app surfaces). They get the same one-class change, and the guard test checks each one.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 28, 2026
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

self-added: yes

  • suggestion: pending registry actions hidden by sm:opacity-0 on wide touch screens (fixed)

fixed in d2e7db5: both pending arms now read pointer-events-none opacity-30 [@media(hover:none)]:opacity-30; the (hover: none) utility sorts after sm:opacity-0 (asserted in hoverVariantPolicy.test.ts), so a refresh or remove in flight dims instead of vanishing on a tablet.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

self-added: yes

  • suggestion: always-visible delete covers the Clean status (fixed)

fixed in d2e7db5: the clean-run label carries [@media(hover:none)]:pr-6, matching the counts branch, so the trash icon has its own room on touch in every card-content branch (counts, Clean, failure line via the card's pb-7).

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 1, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

Read-only review note, not approving yet. The core change (dropping @custom-variant hover to restore Tailwind's (hover: hover) gate, plus [@media(hover:none)] touch states at 32 sites) reads sound: desktop hover compiles to the same declarations, focus-visible and group-focus-within are kept, busy/disabled dimming still wins, and the policy test scans src/ for hidden-until-hover markup with no touch state. Two things before merge: (1) it is 34 PNGs (~5 MB, up to 421 KB each) under temp-screenshots/touch-gated-hover/; a squash merge keeps every blob in main forever, so please drop them from the branch and attach them to the PR instead. (2) It also ships behaviour beyond the hover gate (pb-7 / pr-10 padding, static folder cluster on touch, single row menu on touch tablets, a new Duplicate menu item); disclosed, but a maintainer should confirm those belong in this PR.

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed: removing the hover custom-variant restores Tailwind v4's @media (hover: hover) gate, so mouse-first devices (including Windows touch laptops) keep hover as before, and every control hidden until hover now has a [@media(hover:none)] visible state; a grep of website/src finds no uncovered site, and hoverVariantPolicy.test.ts compiles the theme and scans for new hover-only controls. The 68-file sweep is one mechanical change. Non-blocking: touch-first tablets with a trackpad lose hover feedback (fair trade-off); the guard's +/-3-line window cannot see a reveal assembled across files; isMobile={isMobile || isTouchDevice} (ChatSidebar.tsx:3668) makes the prop name misleading; please drop temp-screenshots/ at merge.

@iamwhatever
iamwhatever merged commit 57d71bb into kirodotdev:main Oct 2, 2026
99 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 2, 2026
iamwhatever pushed a commit to Pearcekieser/KiroCrew that referenced this pull request Oct 2, 2026
…irodotdev#14807

hover-policy scan did not parse, so the site left the scan and its
DECORATIVE entry matched nothing. Accept arbitrary and stacked variant
prefixes and point the entry at the new snippet.

GitFork glyph; the session menu item kirodotdev#14807 added still used Copy and its
test looked for "Duplicate". Use GitFork and test for "Fork chat".
iamwhatever pushed a commit to Pearcekieser/KiroCrew that referenced this pull request Oct 3, 2026
…irodotdev#14807

hover-policy scan did not parse, so the site left the scan and its
DECORATIVE entry matched nothing. Accept arbitrary and stacked variant
prefixes and point the entry at the new snippet.

GitFork glyph; the session menu item kirodotdev#14807 added still used Copy and its
test looked for "Duplicate". Use GitFork and test for "Fork chat".
bolichen97 pushed a commit that referenced this pull request Oct 4, 2026
…14807 (#16223)

hover-policy scan did not parse, so the site left the scan and its
DECORATIVE entry matched nothing. Accept arbitrary and stacked variant
prefixes and point the entry at the new snippet.

GitFork glyph; the session menu item #14807 added still used Copy and its
test looked for "Duplicate". Use GitFork and test for "Fork chat".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hover-revealed controls need two taps on iPhone

2 participants