Skip to content

fix(test): key the Slack thread-import slot creator by its new module - #22433

Merged
iamwhatever merged 1 commit into
mainfrom
fix/slot-kinds-registry-path
Oct 20, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
fix/slot-kinds-registry-path

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Make main green again on the slot-creator registry tests.

test_every_creator_is_classified and test_no_stale_entry in test/test_chat_follow_default_slot_kinds.py fail on main and on every open PR. #22079 moved _import_thread_to_slot from slack/interactions.py into slack/interactions_options.py; the test registry still keys it by the old file.

Why it matters

Backend Tests is red for every PR, so no PR can reach readiness: passed.

Not a goal

  • Changing _import_thread_to_slot or its verdict.
  • Changing how the registry finds creators.

What changed (motivation → approach → change)

The registry entry for the Slack thread-import creator now names slack/interactions_options.py, where the function lives. The verdict text is unchanged.

Backwards compatibility

Compatible: test-only change; no runtime code moves.

Removes nothing: one registry key is renamed to the file that now holds the same function.

Tests

test/test_chat_follow_default_slot_kinds.py: 5 passed, 3 runs in a row, on fresh origin/main plus this change. Without it, the same 2 tests fail locally.

Manual verification

N/A — the failing tests are the verification.

Related Issues

Closes #22432

Pattern harvest

Rule candidate: review-prompt
Pattern: a refactor that moves a function between modules must also update test registries keyed by (module path, function).

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

The split of slack/interactions.py moved _import_thread_to_slot into
slack/interactions_options.py, but the slot-creator registry in
test_chat_follow_default_slot_kinds.py still keyed it by the old file,
so test_every_creator_is_classified and test_no_stale_entry fail on main.
@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 20, 2026 06:32
@iamwhatever
iamwhatever enabled auto-merge (squash) October 20, 2026 06:32
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 2a19e0435de9dd9e22646f4822665d76685f6d4c touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 2a19e0435de9dd9e22646f4822665d76685f6d4c ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 2a19e0435de9dd9e22646f4822665d76685f6d4c — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] 2a19e04

Description read

[DESCRIPTION-READ] 70c245cfc9ca5ff79e8401cb387cb4238ffefcc934e80b61c5cce9c944417888

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 2a19e0435de9dd9e22646f4822665d76685f6d4c — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 2a19e04

Verdict parsed from the review's SHA-scoped output markers for commit 2a19e0435de9dd9e22646f4822665d76685f6d4c.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 2a19e0435de9dd9e22646f4822665d76685f6d4c: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 2a19e0435de9dd9e22646f4822665d76685f6d4c and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 2a19e04

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 2a19e0435de9dd9e22646f4822665d76685f6d4c: <one-sentence reason>

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve at 2a19e04. Fixes main red on 6432cad.

Cause: #22110 (f9cdc57) keyed the Slack thread-import creator as slack/interactions.py, and #22079 (e7bd257) then moved _import_thread_to_slot to slack/interactions_options.py (L210), leaving only a re-export at interactions.py L809. TestSlotCreatorRegistry then reports the new site as unclassified and the old key as stale, on Linux and Windows.

The one-line rekey points the registry at the real definition and keeps the same person-started classification, which still holds: the thread import passes no model=. test/test_chat_follow_default_slot_kinds.py passes locally on this head (5 passed).

@iamwhatever
iamwhatever merged commit f62ab4f into main Oct 20, 2026
147 of 152 checks passed
@iamwhatever
iamwhatever deleted the fix/slot-kinds-registry-path branch October 20, 2026 08:34
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Main red: slot-creator registry still names slack/interactions.py after the split

3 participants