Repository navigation
fix(test): key the Slack thread-import slot creator by its new module - #22433
Conversation
The split of slack/interactions.py moved _import_thread_to_slot into slack/interactions_options.py, but the slot-creator registry in test_chat_follow_default_slot_kinds.py still keyed it by the old file, so test_every_creator_is_classified and test_no_stale_entry fail on main.
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] 2a19e04 Description read[DESCRIPTION-READ] 70c245cfc9ca5ff79e8401cb387cb4238ffefcc934e80b61c5cce9c944417888 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
buluoray
left a comment
There was a problem hiding this comment.
Approve at 2a19e04. Fixes main red on 6432cad.
Cause: #22110 (f9cdc57) keyed the Slack thread-import creator as slack/interactions.py, and #22079 (e7bd257) then moved _import_thread_to_slot to slack/interactions_options.py (L210), leaving only a re-export at interactions.py L809. TestSlotCreatorRegistry then reports the new site as unclassified and the old key as stale, on Linux and Windows.
The one-line rekey points the registry at the real definition and keeps the same person-started classification, which still holds: the thread import passes no model=. test/test_chat_follow_default_slot_kinds.py passes locally on this head (5 passed).
Problem / Motivation
Goal: Make
maingreen again on the slot-creator registry tests.test_every_creator_is_classifiedandtest_no_stale_entryintest/test_chat_follow_default_slot_kinds.pyfail onmainand on every open PR. #22079 moved_import_thread_to_slotfromslack/interactions.pyintoslack/interactions_options.py; the test registry still keys it by the old file.Why it matters
Backend Tests is red for every PR, so no PR can reach
readiness: passed.Not a goal
_import_thread_to_slotor its verdict.What changed (motivation → approach → change)
The registry entry for the Slack thread-import creator now names
slack/interactions_options.py, where the function lives. The verdict text is unchanged.Backwards compatibility
Compatible: test-only change; no runtime code moves.
Removes nothing: one registry key is renamed to the file that now holds the same function.
Tests
test/test_chat_follow_default_slot_kinds.py: 5 passed, 3 runs in a row, on freshorigin/mainplus this change. Without it, the same 2 tests fail locally.Manual verification
N/A — the failing tests are the verification.
Related Issues
Closes #22432
Pattern harvest
Rule candidate: review-prompt
Pattern: a refactor that moves a function between modules must also update test registries keyed by
(module path, function).Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)