Repository navigation
fix(test): expect 'none' for API-key auth in the Kiro usage parser test - #25944
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Test-only change that brings a stale assertion in line with the contract #25434 already set in Notes
[DESIGN-REVIEWED] 9cd83bc Description read[DESCRIPTION-READ] bc224e9ed0ece9db52d481df303631c712aa313fa376d0d7403464b348a0bd9e That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. This PR only changes one test file ( [UX-REVIEWED] 9cd83bc Description read[DESCRIPTION-READ] cb3155e4faf944e34d81218c003fa43d72489d16c80d802887eee9db5df2f71c That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
36bfa0e to
9cd83bc
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Approving at 9cd83bc.
The parser on main no longer has an api-key state. KiroUsageState lists only a reading, an account-only reading, none, signin-required and null, and parseKiroUsagePayload returns none for reason: api_key_auth. Both test edits match that: the parser case now expects none, and the terminal loop drops a value the type no longer has.
Gates checked at this head: readiness passed, every check green, AI lanes pass with no block, no other change request, mergeable, one test file only.
Optional follow up, not for this PR: the doc comment above kiroUsageRefetchInterval still names a terminal api-key state.
Problem / Motivation
Goal:
Frontend Tests (1)passes onmainagain.website/src/test/kiroUsageRefetchInterval.test.tsfails onmain:Why it matters
Every PR's
Frontend Tests (1)shard is red, so no PR can reachPR Readinessgreen until this lands.Not a goal
What changed (motivation → approach → change)
Two PRs crossed. #25434 removed the
'api-key'sentinel: API-key auth now resolves to a reading, and an unavailable answer withreason: 'api_key_auth'parses to'none'. #22387 merged afterwards with a test that still expected'api-key'. The test now asserts the current contract, and the terminal-cadence loop no longer lists the removed state.Backwards compatibility
Compatible: test-only change; no production code moves.
Removes nothing: the
'api-key'state was already gone fromsrc/api/kiroUsage.tson main; this drops its last mention from a test.Tests
src/test/kiroUsageRefetchInterval.test.ts:maps an explicit unavailable answer to a terminal sentinelexpects'none'forapi_key_auth; 10 of 10 pass.Proof: not provable -- test-only change
Manual verification
N/A — the failing test is the whole defect; it fails on
main(d32862446c) and passes here.Screenshots / video
Why no screenshot: test-only change; no rendered output moves.
Related Issues
Closes #25941
Sibling sweep
Sibling: website/src/test/kiroUsageRefetchInterval.test.ts:51 -- changed here
Sibling: website/src/api/kiroUsage.ts -- not affected -- #25434 already removed the state there
Pattern harvest
Not generalizable: two PRs that each passed CI alone crossed on merge; a test pinned a value the other PR removed.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)