Skip to content

fix(test): add mimocode to the compaction table every selectable harness needs - #36290

Merged
rnoack1 merged 1 commit into
mainfrom
fix/compaction-seen-mimocode
Nov 13, 2026
Merged

rnoack1 merged 1 commit into
mainfrom
fix/compaction-seen-mimocode

Conversation

@rnoack1

@rnoack1 rnoack1 commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Backend Tests pass on main again.

test/test_reply_format_once.py::TestEveryMessageWhereTheBlockCannotBeTakenOut::test_the_table_names_every_selectable_harness fails on main and on every PR based after #24732. That PR made MiMo Code (mimocode) a selectable ACP backend, but the test's hand-written COMPACTION_SEEN table has no row for it.

Why it matters

Every open PR's Backend Tests lane is red for a reason that is not its own, so nothing can reach PR Readiness.

Not a goal

  • Changing how MiMo Code compaction is handled.
  • Deriving the table from the backend sets. The test says it is written out on purpose.

What changed (motivation → approach → change)

Symptom: the set comparison reports mimocode as an extra item on the right.

Cause: BASELINE_SELECTABLE_BACKENDS gained mimocode; COMPACTION_SEEN did not.

Change: COMPACTION_SEEN gets "mimocode": False. False is the real answer: mimocode is not in ACP_BACKENDS_COMPACTION_REPORTED (src/kiro_crew/agent_sdk/backends_turns.py), so Kiro Crew does not see its compaction, and the parametrized test_each_harness now checks that for it too.

Backwards compatibility

Compatible: test-only change.

Removes nothing: one table row is added.

Tests

  • test_the_table_names_every_selectable_harness: passes; red on unpatched main.
  • test_each_harness[mimocode-*]: new parametrized cases, pass.
  • Whole file: 88 passed. test/test_flake_pattern_ratchet.py: 68 passed.

Proof: not provable -- test-only change

Manual verification

N/A — unit coverage sufficient: the change is one row of a test table.

Related Issues

Closes #36279

Sibling sweep

Swept: git grep -n "BASELINE_SELECTABLE_BACKENDS" -- test
Sibling: test/test_reply_format_once.py -- changed here

Pattern harvest

Not generalizable: the table is hand-written on purpose so a new harness forces a decision here; the test did its job.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@rnoack1
rnoack1 requested review from a team and KiroCrewCaptain as code owners November 13, 2026 01:55
@rnoack1
rnoack1 requested a review from iamwhatever November 13, 2026 01:55
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 59902ba64e89998a2bcf053b14c0104a47e09484 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 59902ba64e89998a2bcf053b14c0104a47e09484 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 59902ba64e89998a2bcf053b14c0104a47e09484 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

A one-row test-table fix that restores the pin's intent; nothing blocks.

[DESIGN-REVIEWED] 59902ba

Description read

[DESCRIPTION-READ] ebc47fb68e31905a0a9f0305cc064376fa666398f28aa22aee566d529aee377d

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 59902ba64e89998a2bcf053b14c0104a47e09484 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 59902ba

Verdict parsed from the review's SHA-scoped output markers for commit 59902ba64e89998a2bcf053b14c0104a47e09484.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 59902ba64e89998a2bcf053b14c0104a47e09484 false-positive: <reason, 20 to 500 characters>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 59902ba64e89998a2bcf053b14c0104a47e09484 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 59902ba

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 59902ba64e89998a2bcf053b14c0104a47e09484 false-positive: <reason, 20 to 500 characters>

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:

Approving. This fixes the red on main in test_reply_format_once.py::TestEveryMessageWhereTheBlockCannotBeTakenOut::test_the_table_names_every_selectable_harness, on both Linux and Windows. #24732 made MiMo Code selectable, and this test requires every selectable harness to have a row in COMPACTION_SEEN.

False is the right value. AcpProvider.reports_compaction answers from ACP_BACKENDS_COMPACTION_REPORTED (providers/acp.py:1047), and MiMo Code is not a member, so the parametrized test_each_harness row would fail on True. It sits with OpenCode, its parent, which is False too.

What I ran. With this one line applied on current main, test/test_reply_format_once.py gives 88 passed.

CI. The one red check, Analyze (javascript-typescript), failed on the GitHub API rate limit, not on this change. It does not touch any JavaScript.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 13, 2026
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention labels Nov 13, 2026
@rnoack1
rnoack1 merged commit eee70be into main Nov 13, 2026
99 of 100 checks passed
@rnoack1
rnoack1 deleted the fix/compaction-seen-mimocode branch November 13, 2026 03:19
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

main red: test_the_table_names_every_selectable_harness has no row for mimocode

2 participants