Skip to content

docs(rfc): restore the third-party agent tools grant row to the RFC index - #36504

Merged
buluoray merged 1 commit into
mainfrom
fix/rfc-index-third-party-grant
Nov 13, 2026
Merged

buluoray merged 1 commit into
mainfrom
fix/rfc-index-third-party-grant

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Put main's docs lint back to green by restoring one RFC index row that a merge dropped.

Source Gates fails on main (run 43392195449): docs not reachable from any index (1) - docs/request-for-change/rfc-app-agent-tools-third-party-grant.md. The row added by #35966 was overwritten by #36231's merge (0587a40), so every open PR's Source Gates is red.

Why it matters

Every open PR fails Source Gates until this lands.

Not a goal

  • No edit to the RFC itself or to any other row.

What changed (motivation → approach → change)

The RFC index lost one row in a merge. This puts the same row back, byte for byte from 2151db2, next to the row that replaced it.

Backwards compatibility

Compatible: docs only.

Removes nothing: it adds one index row.

Tests

./scripts/docs-lint.sh exits 0 on this branch ("All documentation checks passed"); on main it exits 1 with the finding above.

Manual verification

N/A — docs only; the linter is the check.

Related Issues

Closes #36503

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners November 13, 2026 08:34
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 18a954aea3be85e1d0f1426fb1c5dd6b85115f7a touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 18a954aea3be85e1d0f1426fb1c5dd6b85115f7a ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 18a954aea3be85e1d0f1426fb1c5dd6b85115f7a — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this puts back one RFC index row that a merge dropped, and only docs change.

[DESIGN-REVIEWED] 18a954a

Description read

[DESCRIPTION-READ] 2fdbfd1b7716bd1a48532ac1f9efdae4ea82fbb3711bb7551aad646b01db8f40

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 18a954aea3be85e1d0f1426fb1c5dd6b85115f7a — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 18a954a

Verdict parsed from the review's SHA-scoped output markers for commit 18a954aea3be85e1d0f1426fb1c5dd6b85115f7a.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 18a954aea3be85e1d0f1426fb1c5dd6b85115f7a false-positive: <reason, 20 to 500 characters>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 18a954aea3be85e1d0f1426fb1c5dd6b85115f7a and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 18a954a

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 18a954aea3be85e1d0f1426fb1c5dd6b85115f7a false-positive: <reason, 20 to 500 characters>

@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: Approve

Why: the decider estimates a 4% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes.

The PR adds back one row to the RFC index table in docs/request-for-change/README.md, and that is its only change. The linked file exists, and the row's accepted status matches the RFC's own front matter (status: accepted). The README's audit prose at line 28 already describes this row as added 2026-11-12 and accepted the same day. The row now appears exactly once in the table, so nothing is duplicated. Both files the row cites (src/kiro_crew/apps/app_agent_tools.py and point_grants.py) exist. The fact-check linter does not check whether paths cited in request-for-change docs exist, since RFCs describe things not built yet. No other rows or docs are touched, so no state, lifecycle, limit or trust boundary changes. It fixes the "docs not reachable from any index" failure the PR description reports from the main-branch Source Gates check.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 18a954aea3 · 1 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve on 18a954a. This PR adds the missing index row for rfc-app-agent-tools-third-party-grant.md to the RFC index, which is what main's docs lint asks for since #35966 added the RFC without a row. The row names the file, its status accepted (the RFC's own Status line says accepted at this head), and what is on main. It changes one line of one documentation file and no code. Decisive lines: docs/request-for-change/README.md:32

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 13, 2026
@buluoray
buluoray merged commit 6157e13 into main Nov 13, 2026
98 checks passed
@buluoray
buluoray deleted the fix/rfc-index-third-party-grant branch November 13, 2026 09:35
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

main docs-lint red: rfc-app-agent-tools-third-party-grant.md dropped from the RFC index

3 participants