Repository navigation
docs(rfc): restore the third-party agent tools grant row to the RFC index - #36504
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this puts back one RFC index row that a merge dropped, and only docs change. [DESIGN-REVIEWED] 18a954a Description read[DESCRIPTION-READ] 2fdbfd1b7716bd1a48532ac1f9efdae4ea82fbb3711bb7551aad646b01db8f40 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Code change approver recommendation: ApproveWhy: the decider estimates a 4% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. The PR adds back one row to the RFC index table in docs/request-for-change/README.md, and that is its only change. The linked file exists, and the row's An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
buluoray
left a comment
There was a problem hiding this comment.
Approve on 18a954a. This PR adds the missing index row for rfc-app-agent-tools-third-party-grant.md to the RFC index, which is what main's docs lint asks for since #35966 added the RFC without a row. The row names the file, its status accepted (the RFC's own Status line says accepted at this head), and what is on main. It changes one line of one documentation file and no code. Decisive lines: docs/request-for-change/README.md:32
Problem / Motivation
Goal: Put main's docs lint back to green by restoring one RFC index row that a merge dropped.
Source Gatesfails on main (run 43392195449):docs not reachable from any index (1) - docs/request-for-change/rfc-app-agent-tools-third-party-grant.md. The row added by #35966 was overwritten by #36231's merge (0587a40), so every open PR'sSource Gatesis red.Why it matters
Every open PR fails
Source Gatesuntil this lands.Not a goal
What changed (motivation → approach → change)
The RFC index lost one row in a merge. This puts the same row back, byte for byte from 2151db2, next to the row that replaced it.
Backwards compatibility
Compatible: docs only.
Removes nothing: it adds one index row.
Tests
./scripts/docs-lint.shexits 0 on this branch ("All documentation checks passed"); on main it exits 1 with the finding above.Manual verification
N/A — docs only; the linter is the check.
Related Issues
Closes #36503
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)