Repository navigation
fix(providers): carry Zed, Qoder, and OpenCode Gemini compatibility - #7216
Conversation
Carried from #7066. Co-authored-by: cubebox <58514883+juzijia@users.noreply.github.com>
Carried from #7155. Co-authored-by: norths7ar <guicaitiandu@gmail.com>
Follow-up to carry #7210. Co-authored-by: Andrew Wang <andrewwangmail@gmail.com>
Follow-up to the source review on #7210; preserve custom tools and shared hosted-tool policy. Co-authored-by: Andrew Wang <andrewwangmail@gmail.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Use apply_patch, the shared Responses custom-tool passthrough; arbitrary custom names are lowered before the Zed filter. Co-authored-by: Andrew Wang <andrewwangmail@gmail.com>
|
✅ Deterministic PR hygiene checks passed. |
|
Maintainer integration decision (dev, MAINTAINERS.md maintainer-integration policy): landing this PR at head 576babd as part of the 2026-10-16 PR-reduction batch. Hosted GitHub Actions are stalled (runs sit queued), and the maintainer ruled out local test runs for this round, so the evidence is remote and exact-tree:
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 576babd02f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /** Return the fixed Gemini endpoint only for the exact model and an eligible Go destination. */ | ||
| export function openCodeGoGeminiEndpoint(provider: OpenCodeGoDestination, modelId: string): string | undefined { | ||
| return Object.hasOwn(OPENCODE_GO_MODEL_WIRES, modelId) && OPENCODE_GO_MODEL_WIRES[modelId] === "google" && isOpenCodeGoGeminiDestination(provider) | ||
| ? `https://opencode.ai/inference/go/v1/models/${encodeURIComponent(modelId)}` |
There was a problem hiding this comment.
For every opencode-go/gemini-4-argon-contributor request, this constructs https://opencode.ai/inference/go/v1/models/...:generateContent, but OpenCode's Go endpoint table specifies https://opencode.ai/inference/go/google/v1beta/models/gemini-4-argon-contributor. The current URL uses the model-catalog prefix rather than the Gemini inference prefix, so the newly added Go Gemini route cannot reach its documented endpoint; use /inference/go/google/v1beta/models/ and update the mocked URL assertions.
Useful? React with 👍 / 👎.
…ns (#7238) #7216 added native wire pins for OpenCode Go Gemini and Qwen models. An existing config with a formerly valid override, such as modelAdapters["qwen3.7-plus"] = "openai-chat", then failed validation, and the whole saved config fell back to defaults. Both the runtime load path and diagnostics now normalize these overrides before validation, so the native pin wins and providers, accounts and routing survive. Strict validation still applies to new writes and malformed values. Co-authored-by: Georgiy Bukharov <souljorje@gmail.com> Co-authored-by: norths7ar <guicaitiandu@gmail.com>
5 participants
Summary
Restore provider compatibility while preserving the current dev routing and credential boundaries.
Each source PR has its own squash-carry commit with its original author. No GUI changes. Closes #7097 when the coordinator lands this bundle and reconciles the issue on dev.
Verification
Final candidate head:
576babd02fa4bbed19203b39a119c137ae4f20a7.Local tests, typechecks, builds, lint, docs builds and dependency execution were NOT RUN by explicit user rule. Hosted GitHub CI is stalled and is not claimed as passing.
Remote exact-head verification is in progress using the coordinator's
ocx-lane-ci2.shharness:L1-576babdbase-dev-4ae49360bL1-576babdbase-dev-4ae49360bEarlier
L1-aca0bd0/L1-7202ec9runs were superseded and stopped while queued; they are not final-head proof. Remote evidence will be updated before review readiness.Static inspection: all six new test files appear in both the layout registry and expected shard; existing file-size caps were not raised and no tracked cap is exceeded. Source ownership docs and provider/config reference pages were updated. No CLI capability, locale union, or preset roster changed.
git diff --check origin/devpassed.Security boundary review: Go's fixed HTTPS endpoint uses only the selected key and removes conflicting auth headers; Zen preserves only its admitted HTTPS endpoint and key header. Other hosts, URL userinfo/query/fragment, nonstandard ports, OAuth/forward auth and Vertex/CCA modes do not acquire the new gateway endpoint behavior. Existing DSH credential pins remain intact. Qoder receives only a constant region-specific usage switch in its scoped child environment. No dependency or workflow change is included. Coordinator retains explicit maintainer security/integration judgment.
Checklist
Co-authored-by: Andrew Wang andrewwangmail@gmail.com
Co-authored-by: cubebox 58514883+juzijia@users.noreply.github.com
Co-authored-by: Georgiy Bukharov souljorje@gmail.com
Co-authored-by: norths7ar guicaitiandu@gmail.com