Skip to content

fix(responses): carry incomplete reasons, terminal refusals, offline continuation tests and MiMo envelope repair (#7122, #7152, #7068, #7214) - #7218

Merged
lidge-jun merged 8 commits into
devfrom
codex/prr-l3
Oct 16, 2026
Merged

lidge-jun merged 8 commits into
devfrom
codex/prr-l3

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Oct 16, 2026 •

Copy link
Copy Markdown
Owner

Summary

Responses clients now receive canonical incomplete reasons, stop retrying explicit terminal upstream refusals, and can reconnect when idle WebSockets consume the connection limit. Offline continuation coverage pins tool-call linkage. MiMo history repair preserves usable arguments without logging tool argument content.

Carried onto dev, each in its own authored commit:

Excluded: #7095 by @YayoiNanoka (coordinator, after remote validation). On mini (Windows) its own tests/responses/ws-capacity-tool-ownership.test.ts and ws-capacity-reclamation.test.ts fail deterministically at head 641ae5d, both in the full union run and when run alone (15 pass / 3 fail: "Upstream stream ended before response terminal event" and a 5.6 s disconnect-admission timeout); lidge passes. #7095 stays open for a Windows fix. Current dev behavior is retained in conflict resolutions. All 11 new test files appear in both layout maps; capped passthrough tests are unchanged. The wire-shapes contract remains within the 600-line structure budget. No GUI, locale, CLI capability or provider preset counts change.

Verification

Final head: 641ae5d74cf1a949151128d9b1964abd01c42586.

Local tests, typechecks, builds, lint and docs builds were NOT RUN, by explicit user rule. Hosted GitHub CI is unavailable and is not claimed as passing.

Full typecheck + full suite requested on both hosts for this pushed head:

Host Label Scope Result
mini (Windows) L3-641ae5d typecheck + full suite Pending shared remote slot
lidge (Linux) L3-641ae5d typecheck + full suite Pending shared remote slot

Commands:

ssh mini 'OCX_LANE_SLOTS=3 ~/bin/ocx-lane-ci2.sh 641ae5d74cf1a949151128d9b1964abd01c42586 L3-641ae5d'
ssh lidge 'OCX_LANE_SLOTS=2 ~/bin/ocx-lane-ci2.sh 641ae5d74cf1a949151128d9b1964abd01c42586 L3-641ae5d'

Compare each host's failures with its own ~/ocx-lane/logs/base-dev-4ae49360b.summary and full log. Evidence will be updated after both runs complete. Superseded queued L3 requests were stopped before test execution.

Static inspection: file-size caps and structure document budgets checked without running repository tooling; new test registration checked in both maps; git diff --check clean. Source review comments inspected. Source #7214's raw argument logging and escaped-quote defects are corrected in credited follow-up commits. Docs builds remain unverified.

Checklist

Co-authored-by: Bortlesboat 169967362+Bortlesboat@users.noreply.github.com
Co-authored-by: AK info@atelier-sai.jp
Co-authored-by: Claude Opus 5.5 noreply@anthropic.com
Co-authored-by: Aditya Rawat adirwt852@gmail.com
Co-authored-by: shirruy shirruy@users.noreply.github.com

Bortlesboat and others added 2 commits October 16, 2026 09:58
Carried from #7122.

Co-authored-by: Bortlesboat <169967362+Bortlesboat@users.noreply.github.com>
… retryable incomplete (carry #7152)

Carried from #7152.

Co-authored-by: AK <info@atelier-sai.jp>

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

adirwt852-cloud and others added 5 commits October 16, 2026 11:04
…7068)

Carried from #7068.

Co-authored-by: Aditya Rawat <adirwt852@gmail.com>
…inite retry loops (carry #7214)

Carried from #7214; source targets main, carried onto dev.

Co-authored-by: shirruy <shirruy@users.noreply.github.com>
Cover envelope endings, opaque valid JSON, rejected shapes, replay, and content-free diagnostics.

Co-authored-by: shirruy <shirruy@users.noreply.github.com>
Covers the outstanding source review case with the bounded parse alternatives.

Co-authored-by: shirruy <shirruy@users.noreply.github.com>
Consolidate the affected retry and history repair paragraphs without dropping contract detail.

Co-authored-by: Bortlesboat <169967362+Bortlesboat@users.noreply.github.com>

Co-authored-by: shirruy <shirruy@users.noreply.github.com>
@lidge-jun lidge-jun changed the title fix(responses): carry wire normalization, terminal refusals, idle capacity and history repairs fix(responses): carry incomplete reasons, terminal refusals, offline continuation tests and MiMo envelope repair (#7122, #7152, #7068, #7214) Oct 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

# Conflicts:
#	scripts/test-layout/layout.json
#	tests/fixtures/test-layout-expected.json
@lidge-jun
lidge-jun marked this pull request as ready for review October 16, 2026 03:44
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner October 16, 2026 03:44
@lidge-jun

Copy link
Copy Markdown
Owner Author

Maintainer integration decision (dev, MAINTAINERS.md maintainer-integration policy): landing this PR at head 74f8067 as part of the 2026-10-16 PR-reduction batch.

Hosted GitHub Actions are stalled (runs sit queued), and the maintainer ruled out local test runs for this round, so the evidence is remote and exact-tree:

@lidge-jun
lidge-jun merged commit 3785915 into dev Oct 16, 2026
5 of 6 checks passed
@lidge-jun
lidge-jun deleted the codex/prr-l3 branch October 16, 2026 03:44
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T03:47:36.503791Z 74f8067 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants