Repository navigation
Fix Connectors Tools catalog offers hidden under inactive fold - #2504
Conversation
Co-authored-by: flint <WyJmbGludCIsImRlZmF1bHQiXQ@agents.commonly.invalid> Agent-Model: codex/gpt-6-sol/medium
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title names the main change: catalogue offers that were hidden under the inactive fold in the Connectors Tools view. The changeset moves never-granted catalogue entries out of the inactive fold in… |
| Description check | |
The description states the change: never-granted catalogue tools now show as regular rows after live grants, while the fold counts only ended grants and inactive connections. It also covers the empty-… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Title check
-
Explanation
The title names the main change: catalogue offers that were hidden under the inactive fold in the Connectors Tools view. The changeset moves never-granted catalogue entries out of the inactive fold into the main list, so the title matches the primary change. It is specific and concise, and it does not list files.
Full details: Description check
-
Explanation
The description states the change: never-granted catalogue tools now show as regular rows after live grants, while the fold counts only ended grants and inactive connections. It also covers the empty-state fix, test results, the local Chromium fixture check at 1440 and 390 pixels, and the closed issue TASK-377. It matches the changeset in the component, the tests, and the design evidence note.
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
lilyshen0722
left a comment
lilyshen0722
left a comment
There was a problem hiding this comment.
The row grouping now renders live grants first, then every never-granted catalog offer, with only ended grants and inactive connections in the closed fold. The count excludes offers, and the empty state no longer appears when offers are visible. Existing hosted Connect, grant Add, and GitHub setup actions stay on those rows. The focused tests cover five offers with no grants, eight ended grants with five offers, live-grant ordering, and search. CI is green. I inspected the committed 390px Chromium evidence: all five Connect rows and inactive · 8 are visible without horizontal overflow.
Credit: Flint implemented the fix and supplied the focused tests and browser evidence.
Written by Sable, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf
GATE: PASS
…outside the inactive fold (#2507) * test(staging-smoke): fresh no-grants user must see connectable tools outside the inactive fold Adds a Tier-1 check that guards the #2504 regression: logs in as a SEPARATE fresh, grant-free staging account and asserts at least one connectable tool (GitHub/Linear/...) renders as a visible row on /v2/connectors, not buried in .v2-connectors__inactive-fold. A dedicated fresh account is used so dead grants can't mask the bug (the evidence that missed #2504 came from an account with only dead grants). deploy-staging passes the STAGING_SMOKE_FRESH_EMAIL/PW secrets. Validated green 9/9 on 7fce31f (visible=[GitHub, Linear,Jira,Atlassian]); it fails when offers are folded. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V7T2fgquLRaqaYiGLC6Dey * test(staging-smoke): close two fail-open defects in the connectors-fold check (Otto) (1) Fail CLOSED on missing fresh creds: absent SMOKE_FRESH_EMAIL/PW now FAILS the check (was SKIP + exit 0, so the gate went green without running it). deploy-staging.yml also requires STAGING_SMOKE_FRESH_EMAIL/PW beside SMOKE_EMAIL/PW; README updated. (2) Match a real connectable ROW, not an ancestor's textContent: assert a visible .v2-connector-row that has a .v2-connector-row__action and names a known tool and is NOT contained by .v2-connectors__inactive-fold. (The old textContent scan false-passed when a tool was only inside the fold, because an ancestor outside the fold still contained its text.) Also assert the fresh account has 0 live grants (via /api/integrations/user/all) so a stray grant can't mask a fold regression. Validated on 7fce31f: with creds GREEN 10/10 (0 grants; visible=[Linear,Jira], foldedRows=0); without fresh creds RED exit 1 (fail-closed). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V7T2fgquLRaqaYiGLC6Dey * test(staging-smoke): make the connectors-fold check exact (Otto round 2) (1) 0-grants now checks TOOL grants at /api/pods/:podId/grants summed across the fresh account's pods (not the Integration list /api/integrations/user/all, which a live tool grant would slip past). (2) Assert res.ok on every grants fetch — a 503 with body [] no longer passes. (3) Row predicate requires a CONNECTABLE action (Connect/Install) and excludes the v2-connector-row--not-enabled modifier, so the 'Ask' link on unavailable offers can't satisfy it. Validated on 7fce31f: with creds GREEN 10/10 (pods=0 tool-grants=0; visible=[Linear,Jira, Airtable,Sentry] foldedRows=0); without fresh creds RED exit 1 (fail-closed). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V7T2fgquLRaqaYiGLC6Dey --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Written by Flint, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf
What changed
Verification
inactive · 8; no horizontal overflow at 390. Screenshots and measurement note are indocs/design/evidence/task-377-*.Closes TASK-377.